20005 2008-07-10 22:17:29 -0700 StyleRareNonInheritedData fails to initialize or compare m_maskBoxImage 2008-07-11 15:44:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino hyatt oldest_to_newest 85749 0 simon.fraser 2008-07-10 22:17:29 -0700 The copy ctor of StyleRareNonInheritedData fails to copy m_maskBoxImage, and the operator== fails to compare the m_maskBoxImage. 85750 1 22244 simon.fraser 2008-07-10 22:18:20 -0700 Created attachment 22244 Patch 85788 2 22244 hyatt 2008-07-11 12:04:50 -0700 Comment on attachment 22244 Patch r=me 85792 3 22250 simon.fraser 2008-07-11 13:17:57 -0700 Created attachment 22250 Patch with changelog Bring hyatt's review forward. 85816 4 dino 2008-07-11 15:42:01 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/style/RenderStyle.cpp Committed r35139 22244 2008-07-10 22:18:20 -0700 2008-07-11 13:17:57 -0700 Patch m_maskBoxImage_patch.txt text/plain 894 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcCBiL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCAwMjEzYTI5Li5jYmE2 MGIwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAK KysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCkBAIC04MTMsNiAr ODEzLDcgQEAgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVk RGF0YShjb25zdCBTdHlsZVJhcmVOb25Jbmhlcml0ZWQKICAgICAsIG1fYm94UmVmbGVjdChvLm1f Ym94UmVmbGVjdCkKICAgICAsIG1fdHJhbnNpdGlvbihvLm1fdHJhbnNpdGlvbiA/IG5ldyBUcmFu c2l0aW9uKCpvLm1fdHJhbnNpdGlvbikgOiAwKQogICAgICwgbV9tYXNrKG8ubV9tYXNrKQorICAg ICwgbV9tYXNrQm94SW1hZ2Uoby5tX21hc2tCb3hJbWFnZSkKICNpZiBFTkFCTEUoWEJMKQogICAg ICwgYmluZGluZ1VSSShvLmJpbmRpbmdVUkkgPyBvLmJpbmRpbmdVUkktPmNvcHkoKSA6IDApCiAj ZW5kaWYKQEAgLTg2Niw2ICs4NjcsNyBAQCBib29sIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6 Om9wZXJhdG9yPT0oY29uc3QgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSYgbykgYwogICAgICAg ICAmJiByZWZsZWN0aW9uRGF0YUVxdWl2YWxlbnQobykKICAgICAgICAgJiYgdHJhbnNpdGlvbkRh dGFFcXVpdmFsZW50KG8pCiAgICAgICAgICYmIG1fbWFzayA9PSBvLm1fbWFzaworICAgICAgICAm JiBtX21hc2tCb3hJbWFnZSA9PSBvLm1fbWFza0JveEltYWdlCiAjaWYgRU5BQkxFKFhCTCkKICAg ICAgICAgJiYgYmluZGluZ3NFcXVpdmFsZW50KG8pCiAjZW5kaWYK 22250 2008-07-11 13:17:57 -0700 2008-07-11 13:17:57 -0700 Patch with changelog mask-box-image-patch.txt text/plain 1590 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTc0MmI1MC4uODg1NzQ2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0wNy0xMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5 YXR0CisgICAgICAgIAorICAgICAgICBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhIG5lZWRzIHRv IGluaXRpYWxpemUgYW5kIGNvbXBhcmUKKyAgICAgICAgbV9tYXNrQm94SW1hZ2UuCisgICAgICAg IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDU+CisKKyAgICAg ICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSk6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09KToK KwogMjAwOC0wNy0xMSAgU2ltb24gSGF1c21hbm4gIDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAg ICAgICAgIEZpeCB0aGUgUXQvV2luZG93cyBidWlsZCwgaW5jbHVkZSB3aW5kb3dzLmggZm9yIEhX TkQgZGlyZWN0bHkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0 eWxlLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCAw MjEzYTI5Li5jYmE2MGIwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5k ZXJTdHlsZS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3Bw CkBAIC04MTMsNiArODEzLDcgQEAgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YShjb25zdCBTdHlsZVJhcmVOb25Jbmhlcml0ZWQKICAgICAsIG1fYm94 UmVmbGVjdChvLm1fYm94UmVmbGVjdCkKICAgICAsIG1fdHJhbnNpdGlvbihvLm1fdHJhbnNpdGlv biA/IG5ldyBUcmFuc2l0aW9uKCpvLm1fdHJhbnNpdGlvbikgOiAwKQogICAgICwgbV9tYXNrKG8u bV9tYXNrKQorICAgICwgbV9tYXNrQm94SW1hZ2Uoby5tX21hc2tCb3hJbWFnZSkKICNpZiBFTkFC TEUoWEJMKQogICAgICwgYmluZGluZ1VSSShvLmJpbmRpbmdVUkkgPyBvLmJpbmRpbmdVUkktPmNv cHkoKSA6IDApCiAjZW5kaWYKQEAgLTg2Niw2ICs4NjcsNyBAQCBib29sIFN0eWxlUmFyZU5vbklu aGVyaXRlZERhdGE6Om9wZXJhdG9yPT0oY29uc3QgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSYg bykgYwogICAgICAgICAmJiByZWZsZWN0aW9uRGF0YUVxdWl2YWxlbnQobykKICAgICAgICAgJiYg dHJhbnNpdGlvbkRhdGFFcXVpdmFsZW50KG8pCiAgICAgICAgICYmIG1fbWFzayA9PSBvLm1fbWFz aworICAgICAgICAmJiBtX21hc2tCb3hJbWFnZSA9PSBvLm1fbWFza0JveEltYWdlCiAjaWYgRU5B QkxFKFhCTCkKICAgICAgICAgJiYgYmluZGluZ3NFcXVpdmFsZW50KG8pCiAjZW5kaWYK