200041 2019-07-23 12:17:37 -0700 Disable Web Animations in WebKitLegacy 2019-07-23 17:44:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin graouts jonlee mjs webkit-bug-importer oldest_to_newest 1555092 0 krollin 2019-07-23 12:17:37 -0700 According to Maciej, we want this disabled in WebKitLegacy in shipping branches. 1555093 1 krollin 2019-07-23 12:18:17 -0700 Maciej, Jon, do you have any comment on the rationale for this change? 1555094 2 webkit-bug-importer 2019-07-23 12:18:30 -0700 <rdar://problem/53458020> 1555107 3 374697 krollin 2019-07-23 12:36:22 -0700 Created attachment 374697 Patch 1555108 4 374697 krollin 2019-07-23 12:36:39 -0700 Comment on attachment 374697 Patch I'm cq-'ing so that this doesn't get landed in trunk. But it still needs review. 1555246 5 jonlee 2019-07-23 17:30:29 -0700 (In reply to Keith Rollin from comment #1) > Maciej, Jon, do you have any comment on the rationale for this change? Web Animations isn't ready for prime time yet. I think this is just an oversight since it's already set as DEFAULT_EXPERIMENTAL_FEATURES_ENABLED in the .yaml. 374697 2019-07-23 12:36:22 -0700 2019-07-23 17:29:50 -0700 Patch bug-200041-20190723123621.patch text/plain 3231 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYTJkOGY3NjI1NjBlNDA1YWJiOGVlYjM0ZTdjMzMwZTgzMjNlMTYxYy4uNmQxZWQ5MDE1OGE1 MTBlOTEyZmQ0MmI5Yzg2NTQ3MjBjY2ZiYmMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTIzICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFw cGxlLmNvbT4KKworICAgICAgICBEaXNhYmxlIFdlYiBBbmltYXRpb25zIGluIFdlYktpdExlZ2Fj eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDQx CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MzQ1ODAyMD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3YW50IHRoaXMgZGlzYWJsZWQgZm9yIFdl YktpdExlZ2FjeSBpbiBzaGlwcGluZyBicmFuY2hlcy4KKworICAgICAgICAqIFdlYlZpZXcvV2Vi UHJlZmVyZW5jZXMubW06CisgICAgICAgICgrW1dlYlByZWZlcmVuY2VzIGluaXRpYWxpemVdKToK KwogMjAxOS0wNy0yMyAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRGlzYWJsZSBFTkFCTEVfTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdExlZ2FjeS93aW4vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS93 aW4vQ2hhbmdlTG9nCmluZGV4IDQzNjY0ZGM3OWQwNzUxODg3MDU3MDk5NWI3YzIxNjczYmFhMGNj ZGEuLjRkZDgzOWRkZjNiNDgxMTljZGI1MTFlYjJiNWM3ZDA3ZDQ3NmI3ODggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wNy0yMyAgS2VpdGggUm9s bGluICA8a3JvbGxpbkBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBXZWIgQW5pbWF0aW9u cyBpbiBXZWJLaXRMZWdhY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMDA0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM0NTgwMjA+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2FudCB0aGlz IGRpc2FibGVkIGZvciBXZWJLaXRMZWdhY3kgaW4gc2hpcHBpbmcgYnJhbmNoZXMuCisKKyAgICAg ICAgKiBXZWJQcmVmZXJlbmNlcy5jcHA6CisgICAgICAgIChXZWJQcmVmZXJlbmNlczo6aW5pdGlh bGl6ZURlZmF1bHRTZXR0aW5ncyk6CisKIDIwMTktMDctMTMgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBDYW5ub3QgYnJpbmcgdXAgY3VzdG9tIG1lZGlhIGNvbnRy b2xzIGF0IGFsbCBvbiB2LnlvdWt1LmNvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0KaW5kZXggMDE0YWRkZTAyMmRhMWRlNmUxZTQ0YWQw ZWVjZGI4Njg2ZjRlMTc1OC4uM2FjNWExMzYyYmMyYTUzZWRkMTc2OWU2YjViZDg5ZGMyMWY4YjI3 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJl bmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVu Y2VzLm1tCkBAIC02NDAsNyArNjQwLDcgQEAgKyAodm9pZClpbml0aWFsaXplCiAgICAgICAgIFtO U051bWJlciBudW1iZXJXaXRoQm9vbDpOT10sIFdlYktpdERvd25sb2FkQXR0cmlidXRlRW5hYmxl ZFByZWZlcmVuY2VLZXksCiAjZW5kaWYKICAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29s Ok5PXSwgV2ViS2l0RGlyZWN0b3J5VXBsb2FkRW5hYmxlZFByZWZlcmVuY2VLZXksCi0gICAgICAg IFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdLCBXZWJLaXRXZWJBbmltYXRpb25zRW5hYmxl ZFByZWZlcmVuY2VLZXksCisgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpOT10sIFdl YktpdFdlYkFuaW1hdGlvbnNFbmFibGVkUHJlZmVyZW5jZUtleSwKICAgICAgICAgW05TTnVtYmVy IG51bWJlcldpdGhCb29sOllFU10sIFdlYktpdFBvaW50ZXJFdmVudHNFbmFibGVkUHJlZmVyZW5j ZUtleSwKICAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOllFU10sIFdlYktpdFN5bnRo ZXRpY0VkaXRpbmdDb21tYW5kc0VuYWJsZWRQcmVmZXJlbmNlS2V5LAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJQcmVmZXJlbmNlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L3dpbi9XZWJQcmVmZXJlbmNlcy5jcHAKaW5kZXggMTM5NDg2ODZiY2ZhMTQwZGE5ZGU5 Mjg5YzZhYzRiNDZjNDA1ODFkYS4uMWUxOTFmOWMzY2JhMzUzYzcxOWE3NThmNjUxNjBjOWQzY2Zk MzRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViUHJlZmVyZW5jZXMu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYlByZWZlcmVuY2VzLmNwcApAQCAt MzA3LDcgKzMwNyw3IEBAIHZvaWQgV2ViUHJlZmVyZW5jZXM6OmluaXRpYWxpemVEZWZhdWx0U2V0 dGluZ3MoKQogCiAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoZGVmYXVsdHMsIENGU1RSKFdlYktp dEN1c3RvbUVsZW1lbnRzRW5hYmxlZFByZWZlcmVuY2VLZXkpLCBrQ0ZCb29sZWFuRmFsc2UpOwog Ci0gICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoZGVmYXVsdHMsIENGU1RSKFdlYktpdFdlYkFuaW1h dGlvbnNFbmFibGVkUHJlZmVyZW5jZUtleSksIGtDRkJvb2xlYW5UcnVlKTsKKyAgICBDRkRpY3Rp b25hcnlBZGRWYWx1ZShkZWZhdWx0cywgQ0ZTVFIoV2ViS2l0V2ViQW5pbWF0aW9uc0VuYWJsZWRQ cmVmZXJlbmNlS2V5KSwga0NGQm9vbGVhbkZhbHNlKTsKIAogICAgIENGRGljdGlvbmFyeUFkZFZh bHVlKGRlZmF1bHRzLCBDRlNUUihXZWJLaXRXZWJBbmltYXRpb25zQ1NTSW50ZWdyYXRpb25FbmFi bGVkUHJlZmVyZW5jZUtleSksIGtDRkJvb2xlYW5GYWxzZSk7CiAK