200040 2019-07-23 12:11:33 -0700 Enable HAVE_APP_LINKS_WITH_ISENABLED for entire iOS family 2019-07-23 16:01:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin benjamin cdumez cmarcelo commit-queue dbates eric.carlson ews-watchlist thorton webkit-bug-importer oldest_to_newest 1555089 0 krollin 2019-07-23 12:11:33 -0700 This feature was enabled for just iOS, but should be enabled for tvOS and watchOS, too. 1555090 1 webkit-bug-importer 2019-07-23 12:13:04 -0700 <rdar://problem/53457670> 1555105 2 374696 krollin 2019-07-23 12:35:26 -0700 Created attachment 374696 Patch 1555110 3 374696 thorton 2019-07-23 12:41:01 -0700 Comment on attachment 374696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374696&action=review > Source/WTF/wtf/Platform.h:1562 > #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1 Do you want this one too? 1555122 4 krollin 2019-07-23 13:18:47 -0700 Eric, HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO got swept up in this change, enabling it for tvOS and watchOS. Should it actually be kept as iOS-only? 1555125 5 krollin 2019-07-23 13:24:36 -0700 Eric is on vacation. I'll side with caution and separate the flags. 1555126 6 374703 krollin 2019-07-23 13:27:49 -0700 Created attachment 374703 Patch 1555128 7 374704 krollin 2019-07-23 13:29:26 -0700 Created attachment 374704 Patch 1555186 8 374704 commit-queue 2019-07-23 16:01:32 -0700 Comment on attachment 374704 Patch Clearing flags on attachment: 374704 Committed r247754: <https://trac.webkit.org/changeset/247754> 1555187 9 commit-queue 2019-07-23 16:01:33 -0700 All reviewed patches have been landed. Closing bug. 374696 2019-07-23 12:35:26 -0700 2019-07-23 13:27:48 -0700 Patch bug-200040-20190723123526.patch text/plain 1430 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg1YWJhMmEzZmVmZDA1YmEwNmZlZmEy NGRjZjU1NWNjMjJlNjA2YmQuLmI3NDZiYzA1MWI1OTlkMDRjMGJlYzgyNWVkZjc2NmZkMDE0YTIy NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMjMgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBIQVZFX0FQUF9MSU5LU19XSVRIX0lTRU5B QkxFRCBmb3IgZW50aXJlIGlPUyBmYW1pbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMDA0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM0NTc2 NzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBmZWF0dXJlIHdhcyBlbmFibGVkIGZvciBqdXN0IGlPUywgYnV0IHNob3VsZCBiZSBlbmFibGVk IGZvciB0dk9TCisgICAgICAgIGFuZCB3YXRjaE9TLCB0b28uCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAxOS0wNy0xNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIE5ldyBZb3JrIGZvbnQgZXJyb25lb3VzbHkgZ2V0cyBzeW50aGV0 aWMgYm9sZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggOTdlNGU2YTJmMjMwZmU1NTAzODlkOTcyY2QyODA3Y2Nm N2QwYTYxYS4uNTllMjI4NDViZmYxMWM2MWY5MjA0MDIwMjVlM2JiYTc0YTYwZTI1NSAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCkBAIC0xNTU3LDcgKzE1NTcsNyBAQAogI2RlZmluZSBIQVZFX1VJX1NDUk9MTF9WSUVX X0lORElDQVRPUl9GTEFTSElOR19TUEkgMQogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oSU9TKSAm JiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDApCisjaWYgKFBMQVRG T1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8 fCAoUExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSA2MDAwMCkgfHwgKFBMQVRGT1JNKEFQUExFVFYpICYmIF9fVFZfT1NfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPj0gMTMwMDAwKQogI2RlZmluZSBIQVZFX0FQUF9MSU5LU19XSVRIX0lTRU5BQkxFRCAx CiAjZGVmaW5lIEhBVkVfUk9VVEVfU0hBUklOR19QT0xJQ1lfTE9OR19GT1JNX1ZJREVPIDEKICNl bmRpZgo= 374703 2019-07-23 13:27:49 -0700 2019-07-23 13:29:25 -0700 Patch bug-200040-20190723132748.patch text/plain 1510 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg1YWJhMmEzZmVmZDA1YmEwNmZlZmEy NGRjZjU1NWNjMjJlNjA2YmQuLmI3NDZiYzA1MWI1OTlkMDRjMGJlYzgyNWVkZjc2NmZkMDE0YTIy NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMjMgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBIQVZFX0FQUF9MSU5LU19XSVRIX0lTRU5B QkxFRCBmb3IgZW50aXJlIGlPUyBmYW1pbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMDA0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM0NTc2 NzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBmZWF0dXJlIHdhcyBlbmFibGVkIGZvciBqdXN0IGlPUywgYnV0IHNob3VsZCBiZSBlbmFibGVk IGZvciB0dk9TCisgICAgICAgIGFuZCB3YXRjaE9TLCB0b28uCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAxOS0wNy0xNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIE5ldyBZb3JrIGZvbnQgZXJyb25lb3VzbHkgZ2V0cyBzeW50aGV0 aWMgYm9sZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggOTdlNGU2YTJmMjMwZmU1NTAzODlkOTcyY2QyODA3Y2Nm N2QwYTYxYS4uN2JjOGM3ZjM5M2ZmZDc5ZDZjMGViYzIxZDljYTRlZDMwYjY1ODQwYyAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCkBAIC0xNTU3LDggKzE1NTcsMTEgQEAKICNkZWZpbmUgSEFWRV9VSV9TQ1JPTExfVklF V19JTkRJQ0FUT1JfRkxBU0hJTkdfU1BJIDEKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKElPUykg JiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKQorI2lmIChQTEFU Rk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDAwMCkg fHwgKFBMQVRGT1JNKFdBVENIT1MpICYmIF9fV0FUQ0hfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQg Pj0gNjAwMDApIHx8IChQTEFURk9STShBUFBMRVRWKSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEzMDAwMCkKICNkZWZpbmUgSEFWRV9BUFBfTElOS1NfV0lUSF9JU0VOQUJMRUQg MQorI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMzAwMDApCiAjZGVmaW5lIEhBVkVfUk9VVEVfU0hBUklOR19QT0xJQ1lf TE9OR19GT1JNX1ZJREVPIDEKICNlbmRpZgogCg== 374704 2019-07-23 13:29:26 -0700 2019-07-23 16:01:32 -0700 Patch bug-200040-20190723132925.patch text/plain 1506 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg1YWJhMmEzZmVmZDA1YmEwNmZlZmEy NGRjZjU1NWNjMjJlNjA2YmQuLmIxZGU4YTQyZGRjMWVjYzA4NzEwZTQ0NmY0MmY5YWY2YzJjZTQ2 MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMjMgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBIQVZFX0FQUF9MSU5LU19XSVRIX0lTRU5B QkxFRCBmb3IgZW50aXJlIGlPUyBmYW1pbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMDA0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM0NTc2 NzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBUaGlzIGZl YXR1cmUgd2FzIGVuYWJsZWQgZm9yIGp1c3QgaU9TLCBidXQgc2hvdWxkIGJlIGVuYWJsZWQgZm9y IHR2T1MKKyAgICAgICAgYW5kIHdhdGNoT1MsIHRvby4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9y bS5oOgorCiAyMDE5LTA3LTE2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5j b20+CiAKICAgICAgICAgTmV3IFlvcmsgZm9udCBlcnJvbmVvdXNseSBnZXRzIHN5bnRoZXRpYyBi b2xkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaAppbmRleCA5N2U0ZTZhMmYyMzBmZTU1MDM4OWQ5NzJjZDI4MDdjY2Y3ZDBh NjFhLi43YmM4YzdmMzkzZmZkNzlkNmMwZWJjMjFkOWNhNGVkMzBiNjU4NDBjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKQEAgLTE1NTcsOCArMTU1NywxMSBAQAogI2RlZmluZSBIQVZFX1VJX1NDUk9MTF9WSUVXX0lO RElDQVRPUl9GTEFTSElOR19TUEkgMQogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oSU9TKSAmJiBf X0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDApCisjaWYgKFBMQVRGT1JN KElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8fCAo UExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA2 MDAwMCkgfHwgKFBMQVRGT1JNKEFQUExFVFYpICYmIF9fVFZfT1NfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTMwMDAwKQogI2RlZmluZSBIQVZFX0FQUF9MSU5LU19XSVRIX0lTRU5BQkxFRCAxCisj ZW5kaWYKKworI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEzMDAwMCkKICNkZWZpbmUgSEFWRV9ST1VURV9TSEFSSU5HX1BPTElDWV9MT05H X0ZPUk1fVklERU8gMQogI2VuZGlmCiAK