200018 2019-07-22 15:54:51 -0700 Sometimes we miss removable CheckInBounds 2019-07-23 10:25:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_michaud justin_michaud commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1554897 0 justin_michaud 2019-07-22 15:54:51 -0700 In the following loop: +function doTest(arr1) { + let sum = 0 + for (let i=0; i<arr1.length; ++i) { + sum += arr1[i] + } + return sum +} +noInline(doTest); + +let arr1 = new Int32Array(1000) +//let arr1 = new Array(1000) + +for (let i=0; i<1000; ++i) doTest(arr1) we should not need to emit a checkInBounds, but we do. 1554900 1 374647 justin_michaud 2019-07-22 16:00:23 -0700 Created attachment 374647 Patch 1554918 2 374652 justin_michaud 2019-07-22 16:40:07 -0700 Created attachment 374652 Patch 1554921 3 374652 saam 2019-07-22 16:47:51 -0700 Comment on attachment 374652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374652&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + We failed to remove the CheckInBounds bounds because we did not see that the index was nonnegative. This is because we do not see the relationship between the two > + separate zero constants that appear in the IR for the given test case. This patch re-adds the hack to de-duplicate m_zero that was removed in > + <https://trac.webkit.org/changeset/241228/webkit>. nit: should go below "Reviewed by ..." Might be worth also opening a bug on not being reliant on the exact node pointer. Or at least understanding why it's ok to rely on the actual node pointer value. 1554923 4 374652 saam 2019-07-22 16:48:24 -0700 Comment on attachment 374652 Patch Can you also add a microbenchmark if one doesn't already exist 1554928 5 374654 justin_michaud 2019-07-22 16:56:51 -0700 Created attachment 374654 Patch 1555063 6 374654 commit-queue 2019-07-23 10:24:20 -0700 Comment on attachment 374654 Patch Clearing flags on attachment: 374654 Committed r247724: <https://trac.webkit.org/changeset/247724> 1555064 7 commit-queue 2019-07-23 10:24:21 -0700 All reviewed patches have been landed. Closing bug. 1555066 8 webkit-bug-importer 2019-07-23 10:25:18 -0700 <rdar://problem/53452180> 374647 2019-07-22 16:00:23 -0700 2019-07-22 16:40:05 -0700 Patch bug-200018-20190722160022.patch text/plain 2293 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YTMzZTJjMmM3YzY3MWI1ODkxNDE0MWU5OTBlYmI2NTFhNTJkZTAxLi45NTVjODI4ZjAzNDZiZTU0 NGFjZGI1YmYwMzZiNjdjNjI5NjJmNTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNy0yMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBh cHBsZS5jb20+CisKKyAgICAgICAgU29tZXRpbWVzIHdlIG1pc3MgcmVtb3ZhYmxlIENoZWNrSW5C b3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDAxOAorCisgICAgICAgIFdlIGZhaWxlZCB0byByZW1vdmUgdGhlIENoZWNrSW5Cb3VuZHMgYm91 bmRzIGJlY2F1c2Ugd2UgZGlkIG5vdCBzZWUgdGhhdCB0aGUgaW5kZXggd2FzIG5vbm5lZ2F0aXZl LiBUaGlzIGlzIGJlY2F1c2Ugd2UgZG8gbm90IHNlZSB0aGUgcmVsYXRpb25zaGlwIGJldHdlZW4g dGhlIHR3bworICAgICAgICBzZXBhcmF0ZSB6ZXJvIGNvbnN0YW50cyB0aGF0IGFwcGVhciBpbiB0 aGUgSVIgZm9yIHRoZSBnaXZlbiB0ZXN0IGNhc2UuIFRoaXMgcGF0Y2ggcmUtYWRkcyB0aGUgaGFj ayB0byBkZS1kdXBsaWNhdGUgbV96ZXJvIHRoYXQgd2FzIHJlbW92ZWQgaW4gCisgICAgICAgIDxo dHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjQxMjI4L3dlYmtpdD4uCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHSW50ZWdl clJhbmdlT3B0aW1pemF0aW9uUGhhc2UuY3BwOgorCiAyMDE5LTA3LTIyICBaaGlmZWkgRmFuZyAg PHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBOZWVkIHRvIHNraXAgdGVzdCBjYWNo ZSBkaXJlY3RvcnkgZGF0YSB2YXVsdCBmb3Igbm9uIGludGVybmFsIGJ1aWxkCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ludGVnZXJSYW5nZU9wdGltaXphdGlvblBo YXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1p emF0aW9uUGhhc2UuY3BwCmluZGV4IDY1N2UzMDMxOGZlYzgxY2RjMTdhODdjOTM5ZmYwMWY5NGY1 MWMxY2YuLjE5MzE0OWM4ODdmMjY4N2ZlYmFkYjFmY2NjNjdlNDhlYTU1ZDA1YzcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9u UGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdl T3B0aW1pemF0aW9uUGhhc2UuY3BwCkBAIC0xMDEwLDggKzEwMTAsMTYgQEAgcHVibGljOgogICAg ICAgICBBU1NFUlQobV9ncmFwaC5tX2Zvcm0gPT0gU1NBKTsKICAgICAgICAgCiAgICAgICAgIC8v IEJlZm9yZSB3ZSBkbyBhbnl0aGluZywgbWFrZSBzdXJlIHRoYXQgd2UgaGF2ZSBhIHplcm8gY29u c3RhbnQgYXQgdGhlIHRvcC4KLSAgICAgICAgbV96ZXJvID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0 Q29uc3RhbnQoMCwgbV9ncmFwaC5ibG9jaygwKS0+YXQoMCktPm9yaWdpbiwganNOdW1iZXIoMCkp OwotICAgICAgICBtX2luc2VydGlvblNldC5leGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAg ICAgICBmb3IgKE5vZGUqIG5vZGUgOiAqbV9ncmFwaC5ibG9jaygwKSkgeworICAgICAgICAgICAg aWYgKG5vZGUtPmlzSW50MzJDb25zdGFudCgpICYmICFub2RlLT5hc0ludDMyKCkpIHsKKyAgICAg ICAgICAgICAgICBtX3plcm8gPSBub2RlOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgfQorICAgICAgICB9CisgICAgICAgIGlmICghbV96ZXJvKSB7CisgICAgICAgICAgICBt X3plcm8gPSBtX2luc2VydGlvblNldC5pbnNlcnRDb25zdGFudCgwLCBtX2dyYXBoLmJsb2NrKDAp LT5hdCgwKS0+b3JpZ2luLCBqc051bWJlcigwKSk7CisgICAgICAgICAgICBtX2luc2VydGlvblNl dC5leGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAgICAgICB9CiAgICAgICAgIAogICAgICAg ICBpZiAoREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhhc2VJbnRlcm5hbDo6dmVyYm9zZSkg ewogICAgICAgICAgICAgZGF0YUxvZygiR3JhcGggYmVmb3JlIGludGVnZXIgcmFuZ2Ugb3B0aW1p emF0aW9uOlxuIik7Cg== 374652 2019-07-22 16:40:07 -0700 2019-07-22 16:56:50 -0700 Patch bug-200018-20190722164006.patch text/plain 2772 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YTMzZTJjMmM3YzY3MWI1ODkxNDE0MWU5OTBlYmI2NTFhNTJkZTAxLi4yMTZiNDA0MTk1NjQ1YzFi MGMxZjMzMjU4NzVhM2NhOGU0OGQ5YmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNy0yMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBh cHBsZS5jb20+CisKKyAgICAgICAgU29tZXRpbWVzIHdlIG1pc3MgcmVtb3ZhYmxlIENoZWNrSW5C b3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDAxOAorCisgICAgICAgIFdlIGZhaWxlZCB0byByZW1vdmUgdGhlIENoZWNrSW5Cb3VuZHMgYm91 bmRzIGJlY2F1c2Ugd2UgZGlkIG5vdCBzZWUgdGhhdCB0aGUgaW5kZXggd2FzIG5vbm5lZ2F0aXZl LiBUaGlzIGlzIGJlY2F1c2Ugd2UgZG8gbm90IHNlZSB0aGUgcmVsYXRpb25zaGlwIGJldHdlZW4g dGhlIHR3bworICAgICAgICBzZXBhcmF0ZSB6ZXJvIGNvbnN0YW50cyB0aGF0IGFwcGVhciBpbiB0 aGUgSVIgZm9yIHRoZSBnaXZlbiB0ZXN0IGNhc2UuIFRoaXMgcGF0Y2ggcmUtYWRkcyB0aGUgaGFj ayB0byBkZS1kdXBsaWNhdGUgbV96ZXJvIHRoYXQgd2FzIHJlbW92ZWQgaW4gCisgICAgICAgIDxo dHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjQxMjI4L3dlYmtpdD4uCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBkZmcvREZHSW50ZWdlclJh bmdlT3B0aW1pemF0aW9uUGhhc2UuY3BwOgorCiAyMDE5LTA3LTIyICBaaGlmZWkgRmFuZyAgPHpo aWZlaV9mYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBOZWVkIHRvIHNraXAgdGVzdCBjYWNoZSBk aXJlY3RvcnkgZGF0YSB2YXVsdCBmb3Igbm9uIGludGVybmFsIGJ1aWxkCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ludGVnZXJSYW5nZU9wdGltaXphdGlvblBoYXNl LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0 aW9uUGhhc2UuY3BwCmluZGV4IDY1N2UzMDMxOGZlYzgxY2RjMTdhODdjOTM5ZmYwMWY5NGY1MWMx Y2YuLjQ3ZDU3NWNlYmU3YjExNWVkOGI0N2FkNmM3ODUxZjZkNGU4ZTg0M2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhh c2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0 aW1pemF0aW9uUGhhc2UuY3BwCkBAIC0xMDEwLDggKzEwMTAsMTYgQEAgcHVibGljOgogICAgICAg ICBBU1NFUlQobV9ncmFwaC5tX2Zvcm0gPT0gU1NBKTsKICAgICAgICAgCiAgICAgICAgIC8vIEJl Zm9yZSB3ZSBkbyBhbnl0aGluZywgbWFrZSBzdXJlIHRoYXQgd2UgaGF2ZSBhIHplcm8gY29uc3Rh bnQgYXQgdGhlIHRvcC4KLSAgICAgICAgbV96ZXJvID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Q29u c3RhbnQoMCwgbV9ncmFwaC5ibG9jaygwKS0+YXQoMCktPm9yaWdpbiwganNOdW1iZXIoMCkpOwot ICAgICAgICBtX2luc2VydGlvblNldC5leGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAgICAg ICBmb3IgKE5vZGUqIG5vZGUgOiAqbV9ncmFwaC5ibG9jaygwKSkgeworICAgICAgICAgICAgaWYg KG5vZGUtPmlzSW50MzJDb25zdGFudCgpICYmICFub2RlLT5hc0ludDMyKCkpIHsKKyAgICAgICAg ICAgICAgICBtX3plcm8gPSBub2RlOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAg ICAgfQorICAgICAgICB9CisgICAgICAgIGlmICghbV96ZXJvKSB7CisgICAgICAgICAgICBtX3pl cm8gPSBtX2luc2VydGlvblNldC5pbnNlcnRDb25zdGFudCgwLCBtX2dyYXBoLmJsb2NrKDApLT5h dCgwKS0+b3JpZ2luLCBqc051bWJlcigwKSk7CisgICAgICAgICAgICBtX2luc2VydGlvblNldC5l eGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBp ZiAoREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhhc2VJbnRlcm5hbDo6dmVyYm9zZSkgewog ICAgICAgICAgICAgZGF0YUxvZygiR3JhcGggYmVmb3JlIGludGVnZXIgcmFuZ2Ugb3B0aW1pemF0 aW9uOlxuIik7CkBAIC0xMzIxLDcgKzEzMjksOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgICAgICBpZiAobm9uTmVnYXRpdmUgJiYgbGVzc1RoYW5MZW5n dGgpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGV4ZWN1dGVOb2RlKGJsb2NrLT5hdChub2Rl SW5kZXgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb0lkZW50aXR5 T24obV96ZXJvKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIFdlIGp1c3QgbmVlZCB0byBt YWtlIHN1cmUgd2UgYXJlIGEgdmFsdWUtcHJvZHVjaW5nIG5vZGUuCisgICAgICAgICAgICAgICAg ICAgICAgICBub2RlLT5jb252ZXJ0VG9JZGVudGl0eU9uKG5vZGUtPmNoaWxkMSgpLm5vZGUoKSk7 CiAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VkID0gdHJ1ZTsKICAgICAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsK 374654 2019-07-22 16:56:51 -0700 2019-07-23 10:24:20 -0700 Patch bug-200018-20190722165650.patch text/plain 3930 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YTMzZTJjMmM3YzY3MWI1ODkxNDE0MWU5OTBlYmI2NTFhNTJkZTAxLi42OWNhYjY5MjAyNTk3YWRi NWM0MWJhYjc0Y2I1NDRhZDM3NWQxZDVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNy0yMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBh cHBsZS5jb20+CisKKyAgICAgICAgU29tZXRpbWVzIHdlIG1pc3MgcmVtb3ZhYmxlIENoZWNrSW5C b3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFyYXRpLgorCisgICAgICAgIFdlIGZh aWxlZCB0byByZW1vdmUgdGhlIENoZWNrSW5Cb3VuZHMgYm91bmRzIGJlY2F1c2Ugd2UgZGlkIG5v dCBzZWUgdGhhdCB0aGUgaW5kZXggd2FzIG5vbm5lZ2F0aXZlLiBUaGlzIGlzIGJlY2F1c2Ugd2Ug ZG8gbm90IHNlZSB0aGUgcmVsYXRpb25zaGlwIGJldHdlZW4gdGhlIHR3bworICAgICAgICBzZXBh cmF0ZSB6ZXJvIGNvbnN0YW50cyB0aGF0IGFwcGVhciBpbiB0aGUgSVIgZm9yIHRoZSBnaXZlbiB0 ZXN0IGNhc2UuIFRoaXMgcGF0Y2ggcmUtYWRkcyB0aGUgaGFjayB0byBkZS1kdXBsaWNhdGUgbV96 ZXJvIHRoYXQgd2FzIHJlbW92ZWQgaW4gCisgICAgICAgIDxodHRwczovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvMjQxMjI4L3dlYmtpdD4uCisKKyAgICAgICAgKiBkZmcvREZHSW50ZWdlclJh bmdlT3B0aW1pemF0aW9uUGhhc2UuY3BwOgorCiAyMDE5LTA3LTIyICBaaGlmZWkgRmFuZyAgPHpo aWZlaV9mYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBOZWVkIHRvIHNraXAgdGVzdCBjYWNoZSBk aXJlY3RvcnkgZGF0YSB2YXVsdCBmb3Igbm9uIGludGVybmFsIGJ1aWxkCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ludGVnZXJSYW5nZU9wdGltaXphdGlvblBoYXNl LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0 aW9uUGhhc2UuY3BwCmluZGV4IDY1N2UzMDMxOGZlYzgxY2RjMTdhODdjOTM5ZmYwMWY5NGY1MWMx Y2YuLjQ3ZDU3NWNlYmU3YjExNWVkOGI0N2FkNmM3ODUxZjZkNGU4ZTg0M2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhh c2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0 aW1pemF0aW9uUGhhc2UuY3BwCkBAIC0xMDEwLDggKzEwMTAsMTYgQEAgcHVibGljOgogICAgICAg ICBBU1NFUlQobV9ncmFwaC5tX2Zvcm0gPT0gU1NBKTsKICAgICAgICAgCiAgICAgICAgIC8vIEJl Zm9yZSB3ZSBkbyBhbnl0aGluZywgbWFrZSBzdXJlIHRoYXQgd2UgaGF2ZSBhIHplcm8gY29uc3Rh bnQgYXQgdGhlIHRvcC4KLSAgICAgICAgbV96ZXJvID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Q29u c3RhbnQoMCwgbV9ncmFwaC5ibG9jaygwKS0+YXQoMCktPm9yaWdpbiwganNOdW1iZXIoMCkpOwot ICAgICAgICBtX2luc2VydGlvblNldC5leGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAgICAg ICBmb3IgKE5vZGUqIG5vZGUgOiAqbV9ncmFwaC5ibG9jaygwKSkgeworICAgICAgICAgICAgaWYg KG5vZGUtPmlzSW50MzJDb25zdGFudCgpICYmICFub2RlLT5hc0ludDMyKCkpIHsKKyAgICAgICAg ICAgICAgICBtX3plcm8gPSBub2RlOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAg ICAgfQorICAgICAgICB9CisgICAgICAgIGlmICghbV96ZXJvKSB7CisgICAgICAgICAgICBtX3pl cm8gPSBtX2luc2VydGlvblNldC5pbnNlcnRDb25zdGFudCgwLCBtX2dyYXBoLmJsb2NrKDApLT5h dCgwKS0+b3JpZ2luLCBqc051bWJlcigwKSk7CisgICAgICAgICAgICBtX2luc2VydGlvblNldC5l eGVjdXRlKG1fZ3JhcGguYmxvY2soMCkpOworICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBp ZiAoREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhhc2VJbnRlcm5hbDo6dmVyYm9zZSkgewog ICAgICAgICAgICAgZGF0YUxvZygiR3JhcGggYmVmb3JlIGludGVnZXIgcmFuZ2Ugb3B0aW1pemF0 aW9uOlxuIik7CkBAIC0xMzIxLDcgKzEzMjksOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgICAgICBpZiAobm9uTmVnYXRpdmUgJiYgbGVzc1RoYW5MZW5n dGgpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGV4ZWN1dGVOb2RlKGJsb2NrLT5hdChub2Rl SW5kZXgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb0lkZW50aXR5 T24obV96ZXJvKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIFdlIGp1c3QgbmVlZCB0byBt YWtlIHN1cmUgd2UgYXJlIGEgdmFsdWUtcHJvZHVjaW5nIG5vZGUuCisgICAgICAgICAgICAgICAg ICAgICAgICBub2RlLT5jb252ZXJ0VG9JZGVudGl0eU9uKG5vZGUtPmNoaWxkMSgpLm5vZGUoKSk7 CiAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VkID0gdHJ1ZTsKICAgICAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL0pTVGVzdHMv Q2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmYzZGU5YzAwODU2ZTJjN2JkODQ0 YTNmMTQyNjE0MmQ3MmM3YzBlNC4uNDliNTY4NGYxODRmMjZlYTlmOTgxYzY5NzgyMjFhODRjMWNm NjA3NCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wNy0yMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5f bWljaGF1ZEBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZXRpbWVzIHdlIG1pc3MgcmVtb3ZhYmxl IENoZWNrSW5Cb3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMDAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFyYXRpLgorCisgICAg ICAgICogbWljcm9iZW5jaG1hcmtzL3R5cGVkLWFycmF5LXN1bS5qczogQWRkZWQuCisgICAgICAg IChkb1Rlc3QpOgorCiAyMDE5LTA3LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBBcmd1bWVudHNFbGltaW5hdGlvblBoYXNlIHNob3VsZCBpbnNlcnQgS2lsbFN0 YWNrIG5vZGVzIGJlZm9yZSBQdXRTdGFjayBub2RlcyB0aGF0IGl0IGFkZHMuCmRpZmYgLS1naXQg YS9KU1Rlc3RzL21pY3JvYmVuY2htYXJrcy90eXBlZC1hcnJheS1zdW0uanMgYi9KU1Rlc3RzL21p Y3JvYmVuY2htYXJrcy90eXBlZC1hcnJheS1zdW0uanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2FiNmYyMGRjMjY4 MTFhNDI4NzQ2NGI5NjQxOTQ2ZWVhMjUyNzBlZgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMv bWljcm9iZW5jaG1hcmtzL3R5cGVkLWFycmF5LXN1bS5qcwpAQCAtMCwwICsxLDEyIEBACitmdW5j dGlvbiBkb1Rlc3QoYXJyMSkgeworICAgIGxldCBzdW0gPSAwCisgICAgZm9yIChsZXQgaT0wOyBp PGFycjEubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgc3VtICs9IGFycjFbaV0KKyAgICB9CisgICAg cmV0dXJuIHN1bQorfQorbm9JbmxpbmUoZG9UZXN0KTsKKworbGV0IGFycjEgPSBuZXcgSW50MzJB cnJheSgxMDAwKQorCitmb3IgKGxldCBpPTA7IGk8MTAwMDsgKytpKSBkb1Rlc3QoYXJyMSkK