<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200017</bug_id>
          
          <creation_ts>2019-07-22 15:26:57 -0700</creation_ts>
          <short_desc>Fix inspector override conversion in InspectorPageAgent::overrideSetting</short_desc>
          <delta_ts>2019-07-22 17:01:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=199924</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hi</cc>
    
    <cc>joepeck</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1554890</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-07-22 15:26:57 -0700</bug_when>
    <thetext>Fix inspector override conversion in InspectorPageAgent::overrideSetting</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554892</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-22 15:30:48 -0700</bug_when>
    <thetext>&lt;rdar://problem/53419693&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554893</commentid>
    <comment_count>2</comment_count>
      <attachid>374643</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-07-22 15:31:17 -0700</bug_when>
    <thetext>Created attachment 374643
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554901</commentid>
    <comment_count>3</comment_count>
      <attachid>374643</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2019-07-22 16:00:59 -0700</bug_when>
    <thetext>Comment on attachment 374643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374643&amp;action=review

r=me, nice catch!

&gt; Source/WebCore/ChangeLog:15
&gt; +         Previously, the conversion for the mock capture value was implicit from a bool pointer to an optional.
&gt; +         Make an explicit conversion as done for regular settings.

Style: there seems to be an extra space before each of these lines.

&gt; Source/WebCore/inspector/agents/InspectorPageAgent.cpp:429
&gt; +    return *value;

Style: I prefer using `.value()` with `WTF::Optional` so it&apos;s a bit clearer that it&apos;s not a pointer.

&gt; Source/WebCore/inspector/agents/InspectorPageAgent.cpp:445
&gt; +    auto overrideValue = toOptionalBool(value);

NIT: Web Inspector typically uses `as*` instead of `to*` for it&apos;s type conversions (see `asBool` in InspectorRuntimeAgent.cpp).

&gt; Source/WebCore/inspector/agents/InspectorPageAgent.cpp:448
&gt; +    case Inspector::Protocol::Page::Setting::name: {                            \

NIT: we can remove the `{` and `}` and make this slightly simpler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554907</commentid>
    <comment_count>4</comment_count>
      <attachid>374649</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-07-22 16:14:21 -0700</bug_when>
    <thetext>Created attachment 374649
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554911</commentid>
    <comment_count>5</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-07-22 16:23:32 -0700</bug_when>
    <thetext>Done.

&gt; Style: I prefer using `.value()` with `WTF::Optional` so it&apos;s a bit clearer
&gt; that it&apos;s not a pointer.

I like using pointer-like code, for instance &quot;if(value) value-&gt;doSomething()&quot; or &quot;if(value) doSomething(*value)&quot;.
The one case I am sometimes using .value() is when moving the value.
&quot;if (value) doSomething(WTFMove(*value))&quot; seems a bit strange.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554930</commentid>
    <comment_count>6</comment_count>
      <attachid>374649</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-22 17:01:11 -0700</bug_when>
    <thetext>Comment on attachment 374649
Patch for landing

Clearing flags on attachment: 374649

Committed r247707: &lt;https://trac.webkit.org/changeset/247707&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554931</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-22 17:01:12 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374643</attachid>
            <date>2019-07-22 15:31:17 -0700</date>
            <delta_ts>2019-07-22 16:14:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200017-20190722153117.patch</filename>
            <type>text/plain</type>
            <size>3695</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJiMjgzMWU0ODIyMTAx
YjJiZjE3ZWQyY2NmM2YxNzliMTA2NjM2OC4uZjkwZGIxNWZlOGUyNzliM2JiMmYwMTUxZGM5ZDc5
NGFmMGU5NjlmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA3LTIyICBZb3Vl
bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW5zcGVjdG9yIG92
ZXJyaWRlIGNvbnZlcnNpb24gaW4gSW5zcGVjdG9yUGFnZUFnZW50OjpvdmVycmlkZVNldHRpbmcK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDAxNwor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQg
YnkgaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLU1vY2tDYXB0dXJlRGV2aWNlc0VuYWJs
ZWQuaHRtbAorICAgICAgICB3aGljaCBzaG91bGQgbm90IGZhaWwgb24gYm90cyBub3QgaGF2aW5n
IGNhbWVyYXMKKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUGFnZUFnZW50
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvT3B0aW9uYWxCb29sKToKKyAgICAgICAgKFdlYkNv
cmU6Okluc3BlY3RvclBhZ2VBZ2VudDo6b3ZlcnJpZGVTZXR0aW5nKToKKyAgICAgICAgIFByZXZp
b3VzbHksIHRoZSBjb252ZXJzaW9uIGZvciB0aGUgbW9jayBjYXB0dXJlIHZhbHVlIHdhcyBpbXBs
aWNpdCBmcm9tIGEgYm9vbCBwb2ludGVyIHRvIGFuIG9wdGlvbmFsLgorICAgICAgICAgTWFrZSBh
biBleHBsaWNpdCBjb252ZXJzaW9uIGFzIGRvbmUgZm9yIHJlZ3VsYXIgc2V0dGluZ3MuCisKIDIw
MTktMDctMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl
bW90ZSBXZWJJbnNwZWN0b3Igc2hvdWxkIGVuYWJsZSBtb2NrIGNhcHR1cmUgZGV2aWNlcyBpbiBV
SVByb2Nlc3MgaWYgZG9pbmcgaXQgaW4gV2ViUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwIGIvU291cmNlL1dl
YkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCmluZGV4IGNjZDcx
NTk0MTEzNzAyMjQ0MDc4M2M2MDE3YzI4ZjM1MzBkZWZiNTMuLmJmYTEzY2I2MjUwZDU4MTI1YzM2
ZjA3MTQ5NjM3OGRkYzliMzYxNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv
ci9hZ2VudHMvSW5zcGVjdG9yUGFnZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw
ZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAKQEAgLTQyMiw2ICs0MjIsMTMgQEAg
dm9pZCBJbnNwZWN0b3JQYWdlQWdlbnQ6Om92ZXJyaWRlVXNlckFnZW50KEVycm9yU3RyaW5nJiwg
Y29uc3QgU3RyaW5nKiB2YWx1ZSkKICAgICBtX3VzZXJBZ2VudE92ZXJyaWRlID0gdmFsdWUgPyAq
dmFsdWUgOiBTdHJpbmcoKTsKIH0KIAorc3RhdGljIGlubGluZSBPcHRpb25hbDxib29sPiB0b09w
dGlvbmFsQm9vbChjb25zdCBib29sKiB2YWx1ZSkKK3sKKyAgICBpZiAoIXZhbHVlKQorICAgICAg
ICByZXR1cm4gV1RGOjpudWxsb3B0OworICAgIHJldHVybiAqdmFsdWU7Cit9CisKIHZvaWQgSW5z
cGVjdG9yUGFnZUFnZW50OjpvdmVycmlkZVNldHRpbmcoRXJyb3JTdHJpbmcmIGVycm9yU3RyaW5n
LCBjb25zdCBTdHJpbmcmIHNldHRpbmdTdHJpbmcsIGNvbnN0IGJvb2wqIHZhbHVlKQogewogICAg
IGlmIChzZXR0aW5nU3RyaW5nLmlzRW1wdHkoKSkgewpAQCAtNDM1LDE1ICs0NDIsMTMgQEAgdm9p
ZCBJbnNwZWN0b3JQYWdlQWdlbnQ6Om92ZXJyaWRlU2V0dGluZyhFcnJvclN0cmluZyYgZXJyb3JT
dHJpbmcsIGNvbnN0IFN0cmluZyYKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGF1dG8g
b3ZlcnJpZGVWYWx1ZSA9IHRvT3B0aW9uYWxCb29sKHZhbHVlKTsKICAgICBzd2l0Y2ggKHNldHRp
bmcudmFsdWUoKSkgewogI2RlZmluZSBDQVNFX0lOU1BFQ1RPUl9PVkVSUklERV9TRVRUSU5HKG5h
bWUpIFwKLSAgICBjYXNlIEluc3BlY3Rvcjo6UHJvdG9jb2w6OlBhZ2U6OlNldHRpbmc6Om5hbWU6
IHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICBpZiAodmFsdWUpICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBcCi0gICAgICAgICAgICBtX2luc3BlY3RlZFBhZ2Uuc2V0dGluZ3MoKS5zZXQjI25hbWUj
I0luc3BlY3Rvck92ZXJyaWRlKCp2YWx1ZSk7ICAgICAgIFwKLSAgICAgICAgZWxzZSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgXAotICAgICAgICAgICAgbV9pbnNwZWN0ZWRQYWdlLnNldHRpbmdzKCkuc2V0IyNuYW1l
IyNJbnNwZWN0b3JPdmVycmlkZShXVEY6Om51bGxvcHQpOyBcCi0gICAgICAgIGJyZWFrOyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIFwKLSAgICB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgIGNhc2UgSW5zcGVjdG9y
OjpQcm90b2NvbDo6UGFnZTo6U2V0dGluZzo6bmFtZTogeyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBcCisgICAgICAgIG1faW5zcGVjdGVkUGFnZS5zZXR0aW5ncygpLnNldCMjbmFtZSMjSW5z
cGVjdG9yT3ZlcnJpZGUob3ZlcnJpZGVWYWx1ZSk7IFwKKyAgICAgICAgYnJlYWs7ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
XAorICAgIH0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAKICAgICBGT1JfRUFDSF9JTlNQRUNUT1JfT1ZF
UlJJREVfU0VUVElORyhDQVNFX0lOU1BFQ1RPUl9PVkVSUklERV9TRVRUSU5HKQogCkBAIC00NTIs
NyArNDU3LDcgQEAgdm9pZCBJbnNwZWN0b3JQYWdlQWdlbnQ6Om92ZXJyaWRlU2V0dGluZyhFcnJv
clN0cmluZyYgZXJyb3JTdHJpbmcsIGNvbnN0IFN0cmluZyYKIAogICAgIC8vIFVwZGF0ZSB0aGUg
VUlQcm9jZXNzIC8gY2xpZW50IGZvciBwYXJ0aWN1bGFyIG92ZXJyaWRlcy4KICAgICBpZiAoc2V0
dGluZy52YWx1ZSgpID09IEluc3BlY3Rvcjo6UHJvdG9jb2w6OlBhZ2U6OlNldHRpbmc6Ok1vY2tD
YXB0dXJlRGV2aWNlc0VuYWJsZWQpCi0gICAgICAgIG1fY2xpZW50LT5zZXRNb2NrQ2FwdHVyZURl
dmljZXNFbmFibGVkT3ZlcnJpZGUodmFsdWUpOworICAgICAgICBtX2NsaWVudC0+c2V0TW9ja0Nh
cHR1cmVEZXZpY2VzRW5hYmxlZE92ZXJyaWRlKG92ZXJyaWRlVmFsdWUpOwogfQogCiBzdGF0aWMg
SW5zcGVjdG9yOjpQcm90b2NvbDo6UGFnZTo6Q29va2llU2FtZVNpdGVQb2xpY3kgY29va2llU2Ft
ZVNpdGVQb2xpY3lKU09OKENvb2tpZTo6U2FtZVNpdGVQb2xpY3kgcG9saWN5KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374649</attachid>
            <date>2019-07-22 16:14:21 -0700</date>
            <delta_ts>2019-07-22 17:01:11 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-200017-20190722161420.patch</filename>
            <type>text/plain</type>
            <size>3608</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJiMjgzMWU0ODIyMTAx
YjJiZjE3ZWQyY2NmM2YxNzliMTA2NjM2OC4uOWUyYzFkYmRkNjE0MDNkZDBlZjg4NjM3YzQwNmY0
Y2RmM2JlNzIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA3LTIyICBZb3Vl
bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW5zcGVjdG9yIG92
ZXJyaWRlIGNvbnZlcnNpb24gaW4gSW5zcGVjdG9yUGFnZUFnZW50OjpvdmVycmlkZVNldHRpbmcK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDAxNwor
CisgICAgICAgIFJldmlld2VkIGJ5IERldmluIFJvdXNzby4KKworICAgICAgICBDb3ZlcmVkIGJ5
IGluc3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0dGluZy1Nb2NrQ2FwdHVyZURldmljZXNFbmFibGVk
Lmh0bWwKKyAgICAgICAgd2hpY2ggc2hvdWxkIG5vdCBmYWlsIG9uIGJvdHMgbm90IGhhdmluZyBj
YW1lcmFzCisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjp0b09wdGlvbmFsQm9vbCk6CisgICAgICAgIChXZWJDb3Jl
OjpJbnNwZWN0b3JQYWdlQWdlbnQ6Om92ZXJyaWRlU2V0dGluZyk6CisgICAgICAgIFByZXZpb3Vz
bHksIHRoZSBjb252ZXJzaW9uIGZvciB0aGUgbW9jayBjYXB0dXJlIHZhbHVlIHdhcyBpbXBsaWNp
dCBmcm9tIGEgYm9vbCBwb2ludGVyIHRvIGFuIG9wdGlvbmFsLgorICAgICAgICBNYWtlIGFuIGV4
cGxpY2l0IGNvbnZlcnNpb24gYXMgZG9uZSBmb3IgcmVndWxhciBzZXR0aW5ncy4KKwogMjAxOS0w
Ny0yMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Rl
IFdlYkluc3BlY3RvciBzaG91bGQgZW5hYmxlIG1vY2sgY2FwdHVyZSBkZXZpY2VzIGluIFVJUHJv
Y2VzcyBpZiBkb2luZyBpdCBpbiBXZWJQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAKaW5kZXggY2NkNzE1OTQx
MTM3MDIyNDQwNzgzYzYwMTdjMjhmMzUzMGRlZmI1My4uNjI0NmRiZjY1MjBkZTc0YjYxNzA5YTU0
MzA3NGQ3NDI0ZjY5NjllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Fn
ZW50cy9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv
ci9hZ2VudHMvSW5zcGVjdG9yUGFnZUFnZW50LmNwcApAQCAtNDIyLDYgKzQyMiwxMyBAQCB2b2lk
IEluc3BlY3RvclBhZ2VBZ2VudDo6b3ZlcnJpZGVVc2VyQWdlbnQoRXJyb3JTdHJpbmcmLCBjb25z
dCBTdHJpbmcqIHZhbHVlKQogICAgIG1fdXNlckFnZW50T3ZlcnJpZGUgPSB2YWx1ZSA/ICp2YWx1
ZSA6IFN0cmluZygpOwogfQogCitzdGF0aWMgaW5saW5lIE9wdGlvbmFsPGJvb2w+IGFzT3B0aW9u
YWxCb29sKGNvbnN0IGJvb2wqIHZhbHVlKQoreworICAgIGlmICghdmFsdWUpCisgICAgICAgIHJl
dHVybiBXVEY6Om51bGxvcHQ7CisgICAgcmV0dXJuICp2YWx1ZTsKK30KKwogdm9pZCBJbnNwZWN0
b3JQYWdlQWdlbnQ6Om92ZXJyaWRlU2V0dGluZyhFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNv
bnN0IFN0cmluZyYgc2V0dGluZ1N0cmluZywgY29uc3QgYm9vbCogdmFsdWUpCiB7CiAgICAgaWYg
KHNldHRpbmdTdHJpbmcuaXNFbXB0eSgpKSB7CkBAIC00MzUsMTUgKzQ0MiwxMiBAQCB2b2lkIElu
c3BlY3RvclBhZ2VBZ2VudDo6b3ZlcnJpZGVTZXR0aW5nKEVycm9yU3RyaW5nJiBlcnJvclN0cmlu
ZywgY29uc3QgU3RyaW5nJgogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgYXV0byBvdmVy
cmlkZVZhbHVlID0gYXNPcHRpb25hbEJvb2wodmFsdWUpOwogICAgIHN3aXRjaCAoc2V0dGluZy52
YWx1ZSgpKSB7CiAjZGVmaW5lIENBU0VfSU5TUEVDVE9SX09WRVJSSURFX1NFVFRJTkcobmFtZSkg
XAotICAgIGNhc2UgSW5zcGVjdG9yOjpQcm90b2NvbDo6UGFnZTo6U2V0dGluZzo6bmFtZTogeyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgIGlmICh2YWx1ZSkgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IFwKLSAgICAgICAgICAgIG1faW5zcGVjdGVkUGFnZS5zZXR0aW5ncygpLnNldCMjbmFtZSMjSW5z
cGVjdG9yT3ZlcnJpZGUoKnZhbHVlKTsgICAgICAgXAotICAgICAgICBlbHNlICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBcCi0gICAgICAgICAgICBtX2luc3BlY3RlZFBhZ2Uuc2V0dGluZ3MoKS5zZXQjI25hbWUjI0lu
c3BlY3Rvck92ZXJyaWRlKFdURjo6bnVsbG9wdCk7IFwKLSAgICAgICAgYnJlYWs7ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgXAotICAgIH0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgY2FzZSBJbnNwZWN0b3I6OlBy
b3RvY29sOjpQYWdlOjpTZXR0aW5nOjpuYW1lOiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IFwKKyAgICAgICAgbV9pbnNwZWN0ZWRQYWdlLnNldHRpbmdzKCkuc2V0IyNuYW1lIyNJbnNwZWN0
b3JPdmVycmlkZShvdmVycmlkZVZhbHVlKTsgXAorICAgICAgICBicmVhazsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAK
ICAgICBGT1JfRUFDSF9JTlNQRUNUT1JfT1ZFUlJJREVfU0VUVElORyhDQVNFX0lOU1BFQ1RPUl9P
VkVSUklERV9TRVRUSU5HKQogCkBAIC00NTIsNyArNDU2LDcgQEAgdm9pZCBJbnNwZWN0b3JQYWdl
QWdlbnQ6Om92ZXJyaWRlU2V0dGluZyhFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNvbnN0IFN0
cmluZyYKIAogICAgIC8vIFVwZGF0ZSB0aGUgVUlQcm9jZXNzIC8gY2xpZW50IGZvciBwYXJ0aWN1
bGFyIG92ZXJyaWRlcy4KICAgICBpZiAoc2V0dGluZy52YWx1ZSgpID09IEluc3BlY3Rvcjo6UHJv
dG9jb2w6OlBhZ2U6OlNldHRpbmc6Ok1vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQpCi0gICAgICAg
IG1fY2xpZW50LT5zZXRNb2NrQ2FwdHVyZURldmljZXNFbmFibGVkT3ZlcnJpZGUodmFsdWUpOwor
ICAgICAgICBtX2NsaWVudC0+c2V0TW9ja0NhcHR1cmVEZXZpY2VzRW5hYmxlZE92ZXJyaWRlKG92
ZXJyaWRlVmFsdWUpOwogfQogCiBzdGF0aWMgSW5zcGVjdG9yOjpQcm90b2NvbDo6UGFnZTo6Q29v
a2llU2FtZVNpdGVQb2xpY3kgY29va2llU2FtZVNpdGVQb2xpY3lKU09OKENvb2tpZTo6U2FtZVNp
dGVQb2xpY3kgcG9saWN5KQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>