200015 2019-07-22 14:42:15 -0700 resultsdbpy: Handle case where the previous commit doesn't have the changelog 2019-07-22 16:48:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue kocsen_chung webkit-bug-importer oldest_to_newest 1554870 0 jbedard 2019-07-22 14:42:15 -0700 Discovered this in a certain testing configuration. In practice, it's not actually a problem for real instances (at least right now) because we have to declare where all the changelogs are. 1554872 1 374639 jbedard 2019-07-22 14:50:00 -0700 Created attachment 374639 Patch 1554894 2 374639 aakash_jain 2019-07-22 15:37:42 -0700 Comment on attachment 374639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374639&action=review What happens if current commit doesn't have ChangeLog? > Tools/resultsdbpy/resultsdbpy/model/repository.py:323 > if len(current_response.text) == (len(previous_response.text) if previous_response else 0): can we simplify this if-else, this is super confusing. Especially if someone doesn't pay very close attention to the order of parenthesis, this doesn't make sense. > Tools/resultsdbpy/resultsdbpy/model/repository.py:326 > + if not previous_response or len(current_response.text) < len(previous_response.text): Maybe just add another variable previous_response_length and evaluate it beforehand, so as to simplify both the if-else. something like: previous_response_length = 0 if previous_response: previous_response_length = len(previous_response.text) 1554898 3 374645 jbedard 2019-07-22 15:56:50 -0700 Created attachment 374645 Patch 1554919 4 374645 commit-queue 2019-07-22 16:47:22 -0700 Comment on attachment 374645 Patch Clearing flags on attachment: 374645 Committed r247706: <https://trac.webkit.org/changeset/247706> 1554920 5 commit-queue 2019-07-22 16:47:24 -0700 All reviewed patches have been landed. Closing bug. 1554922 6 webkit-bug-importer 2019-07-22 16:48:16 -0700 <rdar://problem/53423137> 374639 2019-07-22 14:50:00 -0700 2019-07-22 15:56:49 -0700 Patch bug-200015-20190722144959.patch text/plain 1599 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzcwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA3LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzZGJweTogSGFuZGxlIGNhc2Ugd2hlcmUgdGhlIHByZXZpb3Vz IGNvbW1pdCBkb2Vzbid0IGhhdmUgdGhlIGNoYW5nZWxvZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2Rl bC9yZXBvc2l0b3J5LnB5OgorICAgICAgICAoV2ViS2l0UmVwb3NpdG9yeS5jb21taXRfZm9yX2lk LmRpZmZfY2hhbmdlbG9ncyk6IEFsbG93IHRoZSBwcmV2aW91c19yZXNwb25zZSB0byBiZSBOb25l LgorCiAyMDE5LTA3LTIyICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04oclVua25vd24pOiBZb3VUdWJlIHBsYXliYWNrIHBhdXNlcyB3aGVuIHN3 aXRjaGluZyB0byBhIG5ldyB0YWIKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L21vZGVsL3JlcG9zaXRvcnkucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVz dWx0c2RicHkvbW9kZWwvcmVwb3NpdG9yeS5weQkocmV2aXNpb24gMjQ3NjgyKQorKysgVG9vbHMv cmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvcmVwb3NpdG9yeS5weQkod29ya2luZyBjb3B5 KQpAQCAtMzIzLDcgKzMyMyw3IEBAIGNsYXNzIFdlYktpdFJlcG9zaXRvcnkoU1ZOUmVwb3NpdG9y eSk6CiAgICAgICAgICAgICAgICAgICAgIGlmIGxlbihjdXJyZW50X3Jlc3BvbnNlLnRleHQpID09 IChsZW4ocHJldmlvdXNfcmVzcG9uc2UudGV4dCkgaWYgcHJldmlvdXNfcmVzcG9uc2UgZWxzZSAw KToKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKLSAgICAgICAgICAgICAgICAg ICAgaWYgbGVuKGN1cnJlbnRfcmVzcG9uc2UudGV4dCkgPCAobGVuKHByZXZpb3VzX3Jlc3BvbnNl LnRleHQpIGlmIHByZXZpb3VzX3Jlc3BvbnNlIGVsc2UgMCk6CisgICAgICAgICAgICAgICAgICAg IGlmIG5vdCBwcmV2aW91c19yZXNwb25zZSBvciBsZW4oY3VycmVudF9yZXNwb25zZS50ZXh0KSA8 IGxlbihwcmV2aW91c19yZXNwb25zZS50ZXh0KToKICAgICAgICAgICAgICAgICAgICAgICAgIGNo YW5nZWxvZ3NbY2hhbmdlbG9nXSA9IGN1cnJlbnRfcmVzcG9uc2UudGV4dAogICAgICAgICAgICAg ICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICAgICAgY2hhbmdlbG9nc1tjaGFuZ2Vs b2ddID0gY3VycmVudF9yZXNwb25zZS50ZXh0WzA6LWxlbihwcmV2aW91c19yZXNwb25zZS50ZXh0 KV0K 374645 2019-07-22 15:56:50 -0700 2019-07-22 16:47:22 -0700 Patch bug-200015-20190722155649.patch text/plain 2133 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzcwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA3LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzZGJweTogSGFuZGxlIGNhc2Ugd2hlcmUgdGhlIHByZXZpb3Vz IGNvbW1pdCBkb2Vzbid0IGhhdmUgdGhlIGNoYW5nZWxvZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2Rl bC9yZXBvc2l0b3J5LnB5OgorICAgICAgICAoV2ViS2l0UmVwb3NpdG9yeS5jb21taXRfZm9yX2lk LmRpZmZfY2hhbmdlbG9ncyk6IEFsbG93IHRoZSBwcmV2aW91c19yZXNwb25zZSB0byBiZSBOb25l LgorCiAyMDE5LTA3LTIyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgog CiAgICAgICAgIFtpT1NdIFtXSzFdIFVJV2ViVmlldyBhbHdheXMganVtcHMgdG8gdGhlIHRvcCBs ZWZ0IGNvcm5lciB3aGVuIHNjcm9sbGluZyB0byByZXZlYWwgdGhlIHNlbGVjdGlvbgpJbmRleDog VG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvcmVwb3NpdG9yeS5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9yZXBvc2l0b3J5LnB5 CShyZXZpc2lvbiAyNDc3MDIpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2Rl bC9yZXBvc2l0b3J5LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMjAsMTAgKzMyMCwxMyBAQCBjbGFz cyBXZWJLaXRSZXBvc2l0b3J5KFNWTlJlcG9zaXRvcnkpOgogICAgICAgICAgICAgICAgICAgICBw cmV2aW91c19yZXNwb25zZSA9IHNlbGYucmVxdWVzdChwcmV2aW91c191cmwpIGlmIHByZXZpb3Vz X3VybCBlbHNlIE5vbmUKICAgICAgICAgICAgICAgICAgICAgaWYgcHJldmlvdXNfcmVzcG9uc2Ug YW5kIHByZXZpb3VzX3Jlc3BvbnNlLnN0YXR1c19jb2RlICE9IDIwMDoKICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnRpbnVlCi0gICAgICAgICAgICAgICAgICAgIGlmIGxlbihjdXJyZW50X3Jl c3BvbnNlLnRleHQpID09IChsZW4ocHJldmlvdXNfcmVzcG9uc2UudGV4dCkgaWYgcHJldmlvdXNf cmVzcG9uc2UgZWxzZSAwKToKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKLSAg ICAgICAgICAgICAgICAgICAgaWYgbGVuKGN1cnJlbnRfcmVzcG9uc2UudGV4dCkgPCAobGVuKHBy ZXZpb3VzX3Jlc3BvbnNlLnRleHQpIGlmIHByZXZpb3VzX3Jlc3BvbnNlIGVsc2UgMCk6CisgICAg ICAgICAgICAgICAgICAgIHByZXZpb3VzX3Jlc3BvbnNlX2xlbmd0aCA9IDAKKyAgICAgICAgICAg ICAgICAgICAgaWYgcHJldmlvdXNfcmVzcG9uc2U6CisgICAgICAgICAgICAgICAgICAgICAgICBw cmV2aW91c19yZXNwb25zZV9sZW5ndGggPSBsZW4ocHJldmlvdXNfcmVzcG9uc2UudGV4dCkKKyAg ICAgICAgICAgICAgICAgICAgaWYgbGVuKGN1cnJlbnRfcmVzcG9uc2UudGV4dCkgPT0gcHJldmlv dXNfcmVzcG9uc2VfbGVuZ3RoOgorICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWUKKyAg ICAgICAgICAgICAgICAgICAgaWYgbm90IHByZXZpb3VzX3Jlc3BvbnNlX2xlbmd0aCBvciBsZW4o Y3VycmVudF9yZXNwb25zZS50ZXh0KSA8IHByZXZpb3VzX3Jlc3BvbnNlX2xlbmd0aDoKICAgICAg ICAgICAgICAgICAgICAgICAgIGNoYW5nZWxvZ3NbY2hhbmdlbG9nXSA9IGN1cnJlbnRfcmVzcG9u c2UudGV4dAogICAgICAgICAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICAg ICAgY2hhbmdlbG9nc1tjaGFuZ2Vsb2ddID0gY3VycmVudF9yZXNwb25zZS50ZXh0WzA6LWxlbihw cmV2aW91c19yZXNwb25zZS50ZXh0KV0K