<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199999</bug_id>
          
          <creation_ts>2019-07-22 07:42:53 -0700</creation_ts>
          <short_desc>Multiple context menu actions broken for YouTube videos</short_desc>
          <delta_ts>2019-07-29 02:07:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>darin</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ggaren</cc>
    
    <cc>jer.noble</cc>
    
    <cc>jonlee</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pnormand</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1554689</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-22 07:42:53 -0700</bug_when>
    <thetext>The following context menu actions are broken on youtube.com videos:

WEBKIT_CONTEXT_MENU_ACTION_OPEN_VIDEO_IN_NEW_WINDOW
WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK

The former tries to load a blob: URI in a new tab (impossible) and the later just does nothing (probably because of MSE). I&apos;m really not sure what to do about either of these, other than that leaving them broken isn&apos;t OK. My only idea is to change WebKitHitTestResult to report that these videos are not videos, but that&apos;s... meh.

Not tested, but also suspect:

WEBKIT_CONTEXT_MENU_ACTION_OPEN_AUDIO_IN_NEW_WINDOW
WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554693</commentid>
    <comment_count>1</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-07-22 08:02:57 -0700</bug_when>
    <thetext>Broken how?
How is this related with GStreamer?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554694</commentid>
    <comment_count>2</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-07-22 08:06:01 -0700</bug_when>
    <thetext>MediaPlayerPrivateGStreamer::canSaveMediaData() returns false on Youtube/MSE videos.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555032</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-23 03:51:03 -0700</bug_when>
    <thetext>WPE doesn&apos;t support context menus</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555034</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-23 06:03:15 -0700</bug_when>
    <thetext>I&apos;m getting a custom context menu from youtube when right clicking a video in youtube.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555038</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-23 06:42:12 -0700</bug_when>
    <thetext>(In reply to Carlos Garcia Campos from comment #4)
&gt; I&apos;m getting a custom context menu from youtube when right clicking a video
&gt; in youtube.

First right-click brings up the website&apos;s custom context menu. Then right-click a second time to get Epiphany&apos;s.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555744</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-25 00:34:03 -0700</bug_when>
    <thetext>Those actions are disabled in ff and chromium context menus.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555745</commentid>
    <comment_count>7</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-25 00:39:58 -0700</bug_when>
    <thetext>Safari shows options to copy video url and open video in new window, but both options are broken too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555754</commentid>
    <comment_count>8</comment_count>
      <attachid>374884</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-25 02:41:51 -0700</bug_when>
    <thetext>Created attachment 374884
Patch

Michael, we can fix ephy without having to depend on this patach, since download option was already excluded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555762</commentid>
    <comment_count>9</comment_count>
      <attachid>374884</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-25 06:26:38 -0700</bug_when>
    <thetext>Comment on attachment 374884
Patch

Nice, but I wonder if it&apos;s semantically right. E.g. a video with a blob: URI should actually be downloadable if it&apos;s not using MSE, but copy media link would result in a meaningless URI and open in new window wouldn&apos;t work. Right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555764</commentid>
    <comment_count>10</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-25 06:29:56 -0700</bug_when>
    <thetext>This is not disabled because it&apos;s a blob uri, but because it&apos;s a live stream. MediaPlayer::canSaveMediaData() returns False.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555769</commentid>
    <comment_count>11</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-25 06:41:26 -0700</bug_when>
    <thetext>(In reply to Carlos Garcia Campos from comment #10)
&gt; This is not disabled because it&apos;s a blob uri, but because it&apos;s a live
&gt; stream. MediaPlayer::canSaveMediaData() returns False.

OK, but that just proves my point: this will fail if you have a normal video as a blob URI, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555770</commentid>
    <comment_count>12</comment_count>
      <attachid>374884</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-25 06:57:05 -0700</bug_when>
    <thetext>Comment on attachment 374884
Patch

I guess this is necessary regardless, though, because if the media is not downloadable then surely it doesn&apos;t have a usable link... is that always true?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555772</commentid>
    <comment_count>13</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-07-25 07:11:46 -0700</bug_when>
    <thetext>You could make canSaveMediaData() return false for &quot;mediasourceblob&quot; URIs and true for &quot;blob&quot; URIs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555774</commentid>
    <comment_count>14</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-25 07:30:42 -0700</bug_when>
    <thetext>If the media is not downloadable the url is useless I think, and it can&apos;t be opened in a new tab/window either. This is what ff and chromium does. In the case of chromium, it allows to copy the link url, but I&apos;m not sure if that&apos;s on purpose or just a bug. Firefox has all the options disabled. In chromium the have this:

    case IDC_CONTENT_CONTEXT_OPENAVNEWTAB:
      // Currently, a media element can be opened in a new tab iff it can                                                                                                                     
      // be saved. So rather than duplicating the MediaCanSave flag, we rely                                                                                                                  
      // on that here.                                                                                                                                                                        
      return !!(params_.media_flags &amp; WebContextMenuData::kMediaCanSave);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555812</commentid>
    <comment_count>15</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-25 09:37:25 -0700</bug_when>
    <thetext>OK from me then, but it needs an owner.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1556050</commentid>
    <comment_count>16</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-26 00:48:31 -0700</bug_when>
    <thetext>This doesn&apos;t require an owner because it&apos;s a change in WebCore, not WebKit2. But still, I want to make sure Apple is also ok with this change before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1556092</commentid>
    <comment_count>17</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-26 07:04:33 -0700</bug_when>
    <thetext>&lt;rdar://problem/53585686&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1556526</commentid>
    <comment_count>18</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-07-29 02:07:33 -0700</bug_when>
    <thetext>Committed r247901: &lt;https://trac.webkit.org/changeset/247901&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374884</attachid>
            <date>2019-07-25 02:41:51 -0700</date>
            <delta_ts>2019-07-26 07:04:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk-context-menu-non-downloadable-media.diff</filename>
            <type>text/plain</type>
            <size>8514</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBiMTM3ZmEwMjBjYi4uZTM0ODQ3MDc0MDIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOS0wNy0yNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln
YWxpYS5jb20+CisKKyAgICAgICAgTXVsdGlwbGUgY29udGV4dCBtZW51IGFjdGlvbnMgYnJva2Vu
IGZvciBZb3VUdWJlIHZpZGVvcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTk5OTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgRG8gbm90IGluY2x1ZGUgQ29weU1lZGlhTGlua0l0ZW0gYW5kIE9wZW5NZWRp
YUluTmV3V2luZG93SXRlbSB0byB0aGUgY29udGV4dCBtZW51IHdoZW4gbWVkaWEgVVJMIGlzIG5v
dAorICAgICAgICBkb3dubG9hZGFibGUgb3IgdGhlIHJlcXVlc3QgY2FuJ3QgYmUgaGFuZGxlZC4K
KworICAgICAgICAqIHBhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxlcjo6cG9wdWxhdGUpOgorCiAyMDE5LTA3LTI0ICBZ
dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW2JtYWxsb2NdIEFk
ZCBJc29IZWFwIHRlc3QgdG8gZW5zdXJlIHRoYXQgSXNvSGVhcCBwYWdlcyBhcmUgbm90IGFsbG9j
YXRpbmcgdG9vIGxhcmdlIFZBCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRl
eHRNZW51Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29u
dHJvbGxlci5jcHAKaW5kZXggNWFiOGJmNjZiOWQuLmM0NzljYTFmOWNiIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNl
L1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCkBAIC04ODYsMTEgKzg4Niwx
MiBAQCB2b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6cG9wdWxhdGUoKQogI2lmIFBMQVRGT1JN
KE1BQykgJiYgRU5BQkxFKFZJREVPX1BSRVNFTlRBVElPTl9NT0RFKQogICAgICAgICAgICAgYXBw
ZW5kSXRlbShUb2dnbGVWaWRlb0VuaGFuY2VkRnVsbHNjcmVlbiwgbV9jb250ZXh0TWVudS5nZXQo
KSk7CiAjZW5kaWYKLSAgICAgICAgICAgIGFwcGVuZEl0ZW0oKnNlcGFyYXRvckl0ZW0oKSwgbV9j
b250ZXh0TWVudS5nZXQoKSk7Ci0gICAgICAgICAgICBhcHBlbmRJdGVtKENvcHlNZWRpYUxpbmtJ
dGVtLCBtX2NvbnRleHRNZW51LmdldCgpKTsKLSAgICAgICAgICAgIGFwcGVuZEl0ZW0oT3Blbk1l
ZGlhSW5OZXdXaW5kb3dJdGVtLCBtX2NvbnRleHRNZW51LmdldCgpKTsKLSAgICAgICAgICAgIGlm
IChtX2NvbnRleHQuaGl0VGVzdFJlc3VsdCgpLmlzRG93bmxvYWRhYmxlTWVkaWEoKSAmJiBsb2Fk
ZXIuY2xpZW50KCkuY2FuSGFuZGxlUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QobWVkaWFVUkwpKSkK
KyAgICAgICAgICAgIGlmIChtX2NvbnRleHQuaGl0VGVzdFJlc3VsdCgpLmlzRG93bmxvYWRhYmxl
TWVkaWEoKSAmJiBsb2FkZXIuY2xpZW50KCkuY2FuSGFuZGxlUmVxdWVzdChSZXNvdXJjZVJlcXVl
c3QobWVkaWFVUkwpKSkgeworICAgICAgICAgICAgICAgIGFwcGVuZEl0ZW0oKnNlcGFyYXRvckl0
ZW0oKSwgbV9jb250ZXh0TWVudS5nZXQoKSk7CisgICAgICAgICAgICAgICAgYXBwZW5kSXRlbShD
b3B5TWVkaWFMaW5rSXRlbSwgbV9jb250ZXh0TWVudS5nZXQoKSk7CisgICAgICAgICAgICAgICAg
YXBwZW5kSXRlbShPcGVuTWVkaWFJbk5ld1dpbmRvd0l0ZW0sIG1fY29udGV4dE1lbnUuZ2V0KCkp
OwogICAgICAgICAgICAgICAgIGFwcGVuZEl0ZW0oRG93bmxvYWRNZWRpYUl0ZW0sIG1fY29udGV4
dE1lbnUuZ2V0KCkpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAKICAgICAgICAgaWYgKGlt
YWdlVVJMLmlzRW1wdHkoKSAmJiBsaW5rVVJMLmlzRW1wdHkoKSAmJiBtZWRpYVVSTC5pc0VtcHR5
KCkpIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl
eCAxMGZkOGM0ZGVlNS4uNjViY2E0YTUyODAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor
KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxOS0wNy0yNSAgQ2FybG9z
IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgTXVsdGlwbGUg
Y29udGV4dCBtZW51IGFjdGlvbnMgYnJva2VuIGZvciBZb3VUdWJlIHZpZGVvcworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5OTk5CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBjYXNlIHRv
IGNoZWNrIGNvcHkgbGluayBhZGRyZXNzLCBvcGVuIGluIG5ldyB3aW5kb3cgYW5kIGRvd25sb2Fk
IG9wdGlvbnMgYXJlIG5vdCBpbmNsdWRlZCBpbiB0aGUKKyAgICAgICAgY29udGV4dCBtZW51IGZv
ciBub24tZG93bmxvYWRhYmxlIG1lZGlhLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0
cy9XZWJLaXRHdGsvVGVzdENvbnRleHRNZW51LmNwcDoKKyAgICAgICAgKHdyaXRlTmV4dENodW5r
KToKKyAgICAgICAgKHNlcnZlckNhbGxiYWNrKToKKyAgICAgICAgKHRlc3RDb250ZXh0TWVudUxp
dmVTdHJlYW0pOgorICAgICAgICAoYmVmb3JlQWxsKToKKyAgICAgICAgKGFmdGVyQWxsKToKKwog
MjAxOS0wNy0yNCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAog
ICAgICAgICBBZGQgVGFrYXNoaSBLb21vcmkgYW5kIFRvbW9raSBJbWFpIGFzIGNvbnRyaWJ1dG9y
cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvVGVzdENv
bnRleHRNZW51LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RD
b250ZXh0TWVudS5jcHAKaW5kZXggZTg4YTM4NDFlZTQuLjBjZjRiZmUwNGM1IDEwMDY0NAotLS0g
YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay9UZXN0Q29udGV4dE1lbnUuY3Bw
CisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RDb250ZXh0TWVu
dS5jcHAKQEAgLTE4LDEwICsxOCwxNCBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKKwor
I2luY2x1ZGUgIldlYktpdFRlc3RTZXJ2ZXIuaCIKICNpbmNsdWRlICJXZWJWaWV3VGVzdC5oIgog
I2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9HUmVmUHRyLmg+CiAK
K3N0YXRpYyBXZWJLaXRUZXN0U2VydmVyKiBrU2VydmVyOworCiBjbGFzcyBDb250ZXh0TWVudVRl
c3Q6IHB1YmxpYyBXZWJWaWV3VGVzdCB7CiBwdWJsaWM6CiAgICAgZW51bSBDb250ZXh0TWVudUl0
ZW1TdGF0ZUZsYWdzIHsKQEAgLTI5NSw2ICsyOTksNyBAQCBwdWJsaWM6CiAgICAgICAgIExpbmtJ
bWFnZSwKICAgICAgICAgVmlkZW8sCiAgICAgICAgIEF1ZGlvLAorICAgICAgICBWaWRlb0xpdmUs
CiAgICAgICAgIEVkaXRhYmxlLAogICAgICAgICBTZWxlY3Rpb24KICAgICB9OwpAQCAtMzkwLDYg
KzM5NSwxOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBpdGVyID0gY2hlY2tDdXJyZW50SXRlbUlz
U3RvY2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9DT05URVhUX01FTlVfQUNUSU9OX09Q
RU5fQVVESU9fSU5fTkVXX1dJTkRPVywgVmlzaWJsZSB8IEVuYWJsZWQpOwogICAgICAgICAgICAg
aXRlciA9IGNoZWNrQ3VycmVudEl0ZW1Jc1N0b2NrQWN0aW9uQW5kR2V0TmV4dChpdGVyLCBXRUJL
SVRfQ09OVEVYVF9NRU5VX0FDVElPTl9ET1dOTE9BRF9BVURJT19UT19ESVNLLCBWaXNpYmxlIHwg
RW5hYmxlZCk7CiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBWaWRlb0xpdmU6Cisg
ICAgICAgICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRf
aXNfbGluayhoaXRUZXN0UmVzdWx0KSk7CisgICAgICAgICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJr
aXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfaW1hZ2UoaGl0VGVzdFJlc3VsdCkpOworICAg
ICAgICAgICAgZ19hc3NlcnRfdHJ1ZSh3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNf
bWVkaWEoaGl0VGVzdFJlc3VsdCkpOworICAgICAgICAgICAgZ19hc3NlcnRfZmFsc2Uod2Via2l0
X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX2VkaXRhYmxlKGhpdFRlc3RSZXN1bHQpKTsKKyAg
ICAgICAgICAgIGdfYXNzZXJ0X2ZhbHNlKHdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9p
c19zZWxlY3Rpb24oaGl0VGVzdFJlc3VsdCkpOworICAgICAgICAgICAgaXRlciA9IGNoZWNrQ3Vy
cmVudEl0ZW1Jc1N0b2NrQWN0aW9uQW5kR2V0TmV4dChpdGVyLCBXRUJLSVRfQ09OVEVYVF9NRU5V
X0FDVElPTl9NRURJQV9QTEFZLCBWaXNpYmxlIHwgRW5hYmxlZCk7CisgICAgICAgICAgICBpdGVy
ID0gY2hlY2tDdXJyZW50SXRlbUlzU3RvY2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9D
T05URVhUX01FTlVfQUNUSU9OX01FRElBX01VVEUsIFZpc2libGUgfCBFbmFibGVkKTsKKyAgICAg
ICAgICAgIGl0ZXIgPSBjaGVja0N1cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRl
ciwgV0VCS0lUX0NPTlRFWFRfTUVOVV9BQ1RJT05fVE9HR0xFX01FRElBX0NPTlRST0xTLCBWaXNp
YmxlIHwgRW5hYmxlZCk7CisgICAgICAgICAgICBpdGVyID0gY2hlY2tDdXJyZW50SXRlbUlzU3Rv
Y2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9DT05URVhUX01FTlVfQUNUSU9OX1RPR0dM
RV9NRURJQV9MT09QLCBWaXNpYmxlIHwgRW5hYmxlZCk7CisgICAgICAgICAgICBpdGVyID0gY2hl
Y2tDdXJyZW50SXRlbUlzU3RvY2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9DT05URVhU
X01FTlVfQUNUSU9OX0VOVEVSX1ZJREVPX0ZVTExTQ1JFRU4sIFZpc2libGUgfCBFbmFibGVkKTsK
KyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEVkaXRhYmxlOgogICAgICAgICAgICAg
Z19hc3NlcnRfZmFsc2Uod2Via2l0X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX2xpbmsoaGl0
VGVzdFJlc3VsdCkpOwogICAgICAgICAgICAgZ19hc3NlcnRfZmFsc2Uod2Via2l0X2hpdF90ZXN0
X3Jlc3VsdF9jb250ZXh0X2lzX2ltYWdlKGhpdFRlc3RSZXN1bHQpKTsKQEAgLTEwNjgsMTEgKzEw
ODUsNjggQEAgc3RhdGljIHZvaWQgdGVzdENvbnRleHRNZW51V2ViRXh0ZW5zaW9uTm9kZShDb250
ZXh0TWVudVdlYkV4dGVuc2lvbk5vZGVUZXN0KiB0ZXMKICAgICBnX2Fzc2VydF9jbXBzdHIodGVz
dC0+bV9ub2RlLnBhcmVudE5hbWUuZGF0YSgpLCA9PSwgIkEiKTsKIH0KIAorc3RhdGljIHZvaWQg
d3JpdGVOZXh0Q2h1bmsoU291cE1lc3NhZ2UqIG1lc3NhZ2UpCit7CisgICAgR1VuaXF1ZVB0cjxj
aGFyPiBmaWxlUGF0aChnX2J1aWxkX2ZpbGVuYW1lKFRlc3Q6OmdldFJlc291cmNlc0RpcigpLmRh
dGEoKSwgInNpbGVuY2Uud2VibSIsIG51bGxwdHIpKTsKKyAgICBjaGFyKiBjb250ZW50czsKKyAg
ICBnc2l6ZSBjb250ZW50c0xlbmd0aDsKKyAgICBpZiAoIWdfZmlsZV9nZXRfY29udGVudHMoZmls
ZVBhdGguZ2V0KCksICZjb250ZW50cywgJmNvbnRlbnRzTGVuZ3RoLCBudWxscHRyKSkgeworICAg
ICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19OT1RfRk9V
TkQpOworICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9jb21wbGV0ZShtZXNzYWdlLT5yZXNwb25z
ZV9ib2R5KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIHNvdXBfbWVzc2FnZV9ib2R5
X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9UQUtFLCBjb250ZW50
cywgY29udGVudHNMZW5ndGgpOworICAgIHNvdXBfbWVzc2FnZV9ib2R5X2NvbXBsZXRlKG1lc3Nh
Z2UtPnJlc3BvbnNlX2JvZHkpOworfQorCitzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFjayhTb3Vw
U2VydmVyKiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKiBwYXRoLCBH
SGFzaFRhYmxlKiwgU291cENsaWVudENvbnRleHQqLCBncG9pbnRlcikKK3sKKyAgICBpZiAobWVz
c2FnZS0+bWV0aG9kICE9IFNPVVBfTUVUSE9EX0dFVCkgeworCXNvdXBfbWVzc2FnZV9zZXRfc3Rh
dHVzKG1lc3NhZ2UsIFNPVVBfU1RBVFVTX05PVF9JTVBMRU1FTlRFRCk7CisgICAgICAgIHJldHVy
bjsKKyAgICB9CisKKyAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NU
QVRVU19PSyk7CisKKyAgICBpZiAoZ19zdHJfZXF1YWwocGF0aCwgIi9saXZlLXN0cmVhbSIpKSB7
CisgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyKiBodG1sID0KKyAgICAgICAgICAgICI8aHRtbD48
Ym9keT4iCisgICAgICAgICAgICAiIDx2aWRlbyBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxl
ZnQ6MTsgdG9wOjEnIHdpZHRoPSczMDAnIGhlaWdodD0nMzAwJz4iCisgICAgICAgICAgICAiICA8
c291cmNlIHNyYz0nL2xpdmUtc3RyZWFtLndlYm0nIHR5cGU9J3ZpZGVvL3dlYm0nIC8+IgorICAg
ICAgICAgICAgIiA8L3ZpZGVvPiIKKyAgICAgICAgICAgICI8L2JvZHk+PC9odG1sPiI7CisgICAg
ICAgIHNvdXBfbWVzc2FnZV9ib2R5X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQ
X01FTU9SWV9TVEFUSUMsIGh0bWwsIHN0cmxlbihodG1sKSk7CisgICAgfSBlbHNlIGlmIChnX3N0
cl9lcXVhbChwYXRoLCAiL2xpdmUtc3RyZWFtLndlYm0iKSkgeworICAgICAgICBzb3VwX21lc3Nh
Z2VfaGVhZGVyc19zZXRfZW5jb2RpbmcobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycywgU09VUF9F
TkNPRElOR19DSFVOS0VEKTsKKyAgICAgICAgZ19zaWduYWxfY29ubmVjdChtZXNzYWdlLCAid3Jv
dGVfaGVhZGVycyIsIEdfQ0FMTEJBQ0sod3JpdGVOZXh0Q2h1bmspLCBudWxscHRyKTsKKyAgICAg
ICAgZ19zaWduYWxfY29ubmVjdChtZXNzYWdlLCAid3JvdGVfY2h1bmsiLCBHX0NBTExCQUNLKHdy
aXRlTmV4dENodW5rKSwgbnVsbHB0cik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBz
b3VwX21lc3NhZ2VfYm9keV9jb21wbGV0ZShtZXNzYWdlLT5yZXNwb25zZV9ib2R5KTsKK30KKwor
c3RhdGljIHZvaWQgdGVzdENvbnRleHRNZW51TGl2ZVN0cmVhbShDb250ZXh0TWVudURlZmF1bHRU
ZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQoreworICAgIHRlc3QtPnNob3dJbldpbmRvd0FuZFdh
aXRVbnRpbE1hcHBlZCgpOworCisgICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQ
YXRoKCIvbGl2ZS1zdHJlYW0iKS5kYXRhKCkpOworICAgIHRlc3QtPndhaXRVbnRpbExvYWRGaW5p
c2hlZCgpOworCisgICAgdGVzdC0+bV9leHBlY3RlZE1lbnVUeXBlID0gQ29udGV4dE1lbnVEZWZh
dWx0VGVzdDo6VmlkZW9MaXZlOworICAgIHRlc3QtPnNob3dDb250ZXh0TWVudUF0UG9zaXRpb25B
bmRXYWl0VW50aWxGaW5pc2hlZCgxLCAxKTsKK30KKwogdm9pZCBiZWZvcmVBbGwoKQogeworICAg
IGtTZXJ2ZXIgPSBuZXcgV2ViS2l0VGVzdFNlcnZlcigpOworICAgIGtTZXJ2ZXItPnJ1bihzZXJ2
ZXJDYWxsYmFjayk7CisKICAgICBDb250ZXh0TWVudURlZmF1bHRUZXN0OjphZGQoIldlYktpdFdl
YlZpZXciLCAiZGVmYXVsdC1tZW51IiwgdGVzdENvbnRleHRNZW51RGVmYXVsdE1lbnUpOwogICAg
IENvbnRleHRNZW51RGVmYXVsdFRlc3Q6OmFkZCgiV2ViS2l0V2ViVmlldyIsICJjb250ZXh0LW1l
bnUta2V5IiwgdGVzdENvbnRleHRNZW51S2V5KTsKICAgICBDb250ZXh0TWVudURlZmF1bHRUZXN0
OjphZGQoIldlYktpdFdlYlZpZXciLCAicG9wdXAtZXZlbnQtc2lnbmFsIiwgdGVzdFBvcHVwRXZl
bnRTaWduYWwpOworICAgIENvbnRleHRNZW51RGVmYXVsdFRlc3Q6OmFkZCgiV2ViS2l0V2ViVmll
dyIsICJsaXZlLXN0cmVhbSIsIHRlc3RDb250ZXh0TWVudUxpdmVTdHJlYW0pOwogICAgIENvbnRl
eHRNZW51Q3VzdG9tVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInBvcHVsYXRlLW1lbnUiLCB0
ZXN0Q29udGV4dE1lbnVQb3B1bGF0ZU1lbnUpOwogICAgIENvbnRleHRNZW51Q3VzdG9tRnVsbFRl
c3Q6OmFkZCgiV2ViS2l0V2ViVmlldyIsICJjdXN0b20tbWVudSIsIHRlc3RDb250ZXh0TWVudUN1
c3RvbU1lbnUpOwogICAgIENvbnRleHRNZW51RGlzYWJsZWRUZXN0OjphZGQoIldlYktpdFdlYlZp
ZXciLCAiZGlzYWJsZS1tZW51IiwgdGVzdENvbnRleHRNZW51RGlzYWJsZU1lbnUpOwpAQCAtMTA4
NCw0ICsxMTU4LDUgQEAgdm9pZCBiZWZvcmVBbGwoKQogCiB2b2lkIGFmdGVyQWxsKCkKIHsKKyAg
ICBkZWxldGUga1NlcnZlcjsKIH0K
</data>
<flag name="review"
          id="390661"
          type_id="1"
          status="+"
          setter="eric.carlson"
    />
          </attachment>
      

    </bug>

</bugzilla>