<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199978</bug_id>
          
          <creation_ts>2019-07-20 07:17:08 -0700</creation_ts>
          <short_desc>[WHLSL] Checker needs to setError() when a property access node can&apos;t commit its base type</short_desc>
          <delta_ts>2019-07-21 11:36:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>195681</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>fpizlo</cc>
    
    <cc>jonlee</cc>
    
    <cc>justin_fan</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>rmorisset</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1554504</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-07-20 07:17:08 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554510</commentid>
    <comment_count>1</comment_count>
      <attachid>374554</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-07-20 07:48:45 -0700</bug_when>
    <thetext>Created attachment 374554
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554559</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2019-07-20 20:27:30 -0700</bug_when>
    <thetext>r=me too</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554588</commentid>
    <comment_count>3</comment_count>
      <attachid>374554</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-21 11:35:56 -0700</bug_when>
    <thetext>Comment on attachment 374554
patch

Clearing flags on attachment: 374554

Committed r247676: &lt;https://trac.webkit.org/changeset/247676&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554589</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-21 11:35:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554590</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-21 11:36:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/53370790&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374554</attachid>
            <date>2019-07-20 07:48:45 -0700</date>
            <delta_ts>2019-07-21 11:35:56 -0700</delta_ts>
            <desc>patch</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>4180</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NzY2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTIwICBTYWFtIEJh
cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFtXSExTTF0gQ2hlY2tlciBuZWVk
cyB0byBzZXRFcnJvcigpIHdoZW4gYSBwcm9wZXJ0eSBhY2Nlc3Mgbm9kZSBjYW4ndCBjb21taXQg
aXRzIGJhc2UgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTk5OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgVGVzdDogd2ViZ3B1L3dobHNsL251bGwtYXJyYXktcHJvcGVydHktYWNjZXNzLmh0bWwK
KworICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQ2hlY2tlci5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpXSExTTDo6Q2hlY2tlcjo6ZmluaXNoVmlzaXRpbmcpOgorCiAyMDE5LTA3
LTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1RleHQgYXV0
b3NpemluZ10gRG8gbm90IG51a2UgdGhlIHN0eWxlIG9uIGR5bmFtaWNWaWV3cG9ydFNpemVVcGRh
dGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQ2hlY2tl
ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wv
V0hMU0xDaGVja2VyLmNwcAkocmV2aXNpb24gMjQ3NjY2KQorKysgU291cmNlL1dlYkNvcmUvTW9k
dWxlcy93ZWJncHUvV0hMU0wvV0hMU0xDaGVja2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQ5
LDggKzk0OSwxMCBAQCB2b2lkIENoZWNrZXI6OmZpbmlzaFZpc2l0aW5nKEFTVDo6UHJvcGVyCiAg
ICAgaWYgKCFiYXNlSW5mbykKICAgICAgICAgcmV0dXJuOwogICAgIGF1dG8gYmFzZVVubmFtZWRU
eXBlID0gY29tbWl0KGJhc2VJbmZvLT5yZXNvbHZpbmdUeXBlKTsKLSAgICBpZiAoIWJhc2VVbm5h
bWVkVHlwZSkKKyAgICBpZiAoIWJhc2VVbm5hbWVkVHlwZSkgeworICAgICAgICBzZXRFcnJvcigp
OwogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgQVNUOjpGdW5jdGlvbkRlY2xhcmF0aW9u
KiBnZXR0ZXJGdW5jdGlvbiA9IG51bGxwdHI7CiAgICAgQVNUOjpVbm5hbWVkVHlwZSogZ2V0dGVy
UmV0dXJuVHlwZSA9IG51bGxwdHI7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc2NjYpCisrKyBMYXlv
dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0w
Ny0yMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBbV0hMU0xd
IENoZWNrZXIgbmVlZHMgdG8gc2V0RXJyb3IoKSB3aGVuIGEgcHJvcGVydHkgYWNjZXNzIG5vZGUg
Y2FuJ3QgY29tbWl0IGl0cyBiYXNlIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTE5OTk3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogd2ViZ3B1L3dobHNsL251bGwtYXJyYXktcHJvcGVydHktYWNj
ZXNzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogd2ViZ3B1L3dobHNsL251bGwtYXJy
YXktcHJvcGVydHktYWNjZXNzLmh0bWw6IEFkZGVkLgorCiAyMDE5LTA3LTIwICBTYWFtIEJhcmF0
aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSExTTF0gTWFrZSBlbnVtcyB3b3Jr
CkluZGV4OiBMYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvbnVsbC1hcnJheS1wcm9wZXJ0eS1hY2Nl
c3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3dlYmdwdS93aGxzbC9u
dWxsLWFycmF5LXByb3BlcnR5LWFjY2Vzcy1leHBlY3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysg
TGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL251bGwtYXJyYXktcHJvcGVydHktYWNjZXNzLWV4cGVj
dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDggQEAKKworUEFTUyBzdG9yZU51bGxB
cnJheVJlZiAKK1BBU1MgbG9hZE51bGxBcnJheVJlZiAKK1BBU1MgbnVsbE5hbWVkQWNjZXNzIAor
UEFTUyBudWxsTmFtZWRBY2Nlc3MyIAorUEFTUyBudWxsTmFtZWRBY2Nlc3NTaW5rIAorUEFTUyBu
dWxsTmFtZWRBY2Nlc3NTaW5rMiAKKwpJbmRleDogTGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL251
bGwtYXJyYXktcHJvcGVydHktYWNjZXNzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv
d2ViZ3B1L3dobHNsL251bGwtYXJyYXktcHJvcGVydHktYWNjZXNzLmh0bWwJKG5vbmV4aXN0ZW50
KQorKysgTGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL251bGwtYXJyYXktcHJvcGVydHktYWNjZXNz
Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8
aHRtbD4KKzxtZXRhIGNoYXJzZXQ9dXRmLTg+Cis8bWV0YSBuYW1lPSJ0aW1lb3V0IiBjb250ZW50
PSJsb25nIj4KKzx0aXRsZT5sb2FkL3N0b3JlIHRvIG51bGwuPC90aXRsZT4KKzxzY3JpcHQgc3Jj
PSJqcy90ZXN0LWhhcm5lc3MuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3dlYmdw
dS1mdW5jdGlvbnMuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy90
ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL3Rl
c3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+Citjb25zdCB3aGxzbFRlc3Rz
ID0ge307CisKK3dobHNsVGVzdHMuc3RvcmVOdWxsQXJyYXlSZWYgPSBhc3luYyAoKSA9PiB7Cisg
ICAgYXdhaXQgY2hlY2tGYWlsKAorICAgICAgICBgCisgICAgICAgICAgICB2b2lkIGZvbygpIHsg
bnVsbFswXSA9IDQyOyB9CisgICAgICAgIGApOworfQorCit3aGxzbFRlc3RzLmxvYWROdWxsQXJy
YXlSZWYgPSBhc3luYyAoKSA9PiB7CisgICAgYXdhaXQgY2hlY2tGYWlsKAorICAgICAgICBgCisg
ICAgICAgICAgICB2b2lkIHNpbmsodGhyZWFkIGludCogeCkgeyB9CisgICAgICAgICAgICB2b2lk
IGZvbygpIHsgc2luayhudWxsWzBdKTsgfQorICAgICAgICBgKTsKK30KKword2hsc2xUZXN0cy5u
dWxsTmFtZWRBY2Nlc3MgPSBhc3luYyAoKSA9PiB7CisgICAgYXdhaXQgY2hlY2tGYWlsKAorICAg
ICAgICBgCisgICAgICAgICAgICB2b2lkIGZvbygpIHsgbnVsbC0+eDsgfQorICAgICAgICBgKTsK
K30KKword2hsc2xUZXN0cy5udWxsTmFtZWRBY2Nlc3MyID0gYXN5bmMgKCkgPT4geworICAgIGF3
YWl0IGNoZWNrRmFpbCgKKyAgICAgICAgYAorICAgICAgICAgICAgdm9pZCBmb28oKSB7IG51bGwu
eDsgfQorICAgICAgICBgKTsKK30KKword2hsc2xUZXN0cy5udWxsTmFtZWRBY2Nlc3NTaW5rID0g
YXN5bmMgKCkgPT4geworICAgIGF3YWl0IGNoZWNrRmFpbCgKKyAgICAgICAgYAorICAgICAgICAg
ICAgdm9pZCBzaW5rKGludCB4KSB7IH0KKyAgICAgICAgICAgIHZvaWQgZm9vKCkgeyBzaW5rKG51
bGwtPngpOyB9CisgICAgICAgIGApOworfQorCit3aGxzbFRlc3RzLm51bGxOYW1lZEFjY2Vzc1Np
bmsyID0gYXN5bmMgKCkgPT4geworICAgIGF3YWl0IGNoZWNrRmFpbCgKKyAgICAgICAgYAorICAg
ICAgICAgICAgdm9pZCBzaW5rKGludCB4KSB7IH0KKyAgICAgICAgICAgIHZvaWQgZm9vKCkgeyBz
aW5rKG51bGwueCk7IH0KKyAgICAgICAgYCk7Cit9CisKK3J1blRlc3RzKHdobHNsVGVzdHMpOwor
PC9zY3JpcHQ+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>