199966 2019-07-19 15:29:24 -0700 Provide correct names for UIContextMenuInteraction API replacements 2019-07-19 15:51:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 1554358 0 dino 2019-07-19 15:29:24 -0700 Provide correct names for UIContextMenuInteraction API replacements 1554363 1 374509 dino 2019-07-19 15:31:38 -0700 Created attachment 374509 Patch 1554365 2 374509 thorton 2019-07-19 15:33:12 -0700 Comment on attachment 374509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374509&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h:195 > +- (void)webView:(WKWebView *)webView contextMenuForElement:(WKContextMenuElementInfo *)elementInfo willCommitWithAnimator:(id<UIContextMenuInteractionCommitAnimating>)animator WK_API_AVAILABLE(ios(WK_IOS_TBA)); There should be a space between id and < 1554380 3 dino 2019-07-19 15:50:37 -0700 Committed r247657: <https://trac.webkit.org/changeset/247657> 1554381 4 webkit-bug-importer 2019-07-19 15:51:12 -0700 <rdar://problem/53327932> 374509 2019-07-19 15:31:38 -0700 2019-07-19 15:33:12 -0700 Patch bug-199966-20190720083136.patch text/plain 6361 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzZmI0YWRkOTIzYTcwNmI1 ODJiODZhNDMwOWQ0ZmIzNjJhMzQwNTIuLmY0ZGIwOTdmZjZmNzZmYmMwM2M1ZmY0NTQ4NWJjYjkx ZjlmNDdjYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMTkgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgY29ycmVjdCBuYW1lcyBm b3IgVUlDb250ZXh0TWVudUludGVyYWN0aW9uIEFQSSByZXBsYWNlbWVudHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTk2NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhhZCBzb21lIG9sZCBpbmNv cnJlY3QgbmFtZXMgZm9yIHJlcGxhY2VtZW50cyB0byBTUEkuIFdoaWxlCisgICAgICAgIGhlcmUs IEkgcmVvcmRlcmVkIGFuZCBleHBhbmRlZCB0aGUgZG9jdW1lbnRhdGlvbiBmb3IgdGhlIG5ldyBB UEkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oOgorCiAyMDE5 LTA3LTE5ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBt ZW51IGl0ZW0gdG8gdG9nZ2xlIGJldHdlZW4gc2hvd2luZyBhbmQgaGlkaW5nIGxpbmsgcHJldmll d3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVs ZWdhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUu aAppbmRleCA5ZDk3ZWQ3MTNhNjIzZmYyMDA4MGRlNzE4NzZiMmYyM2NiYzAzOTg0Li42NmY0ZDE0 YzU2ZTU3YTE5MTdjYzE2MTViMTFkODRlOGViYTExZDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlLmgKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCkBAIC0xNzQsMjcgKzE3NCwyOCBA QCBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3 ZWJWaWV3IGNvbnRleHRNZW51Q29uZmlndXJhdGlvbkZvckVsZW1lbnQ6KFdLQ29udGV4dE1lbnVF bGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShVSUNv bnRleHRNZW51Q29uZmlndXJhdGlvbiAqIF9OdWxsYWJsZSBjb25maWd1cmF0aW9uKSljb21wbGV0 aW9uSGFuZGxlciBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CiAKIC8qKgotICog QGFic3RyYWN0IENhbGxlZCB3aGVuIHRoZSBjb250ZXh0IG1lbnUgY29uZmlndXJlZCBieSB0aGUg VUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gZnJvbQotICogd2ViVmlldzpjb250ZXh0TWVudUNv bmZpZ3VyYXRpb25Gb3JFbGVtZW50OmNvbXBsZXRpb25IYW5kbGVyOiBpcyBjb21taXR0ZWQuCisg KiBAYWJzdHJhY3QgQ2FsbGVkIHdoZW4gdGhlIGNvbnRleHQgbWVudSB3aWxsIGJlIHByZXNlbnRl ZC4KICAqCiAgKiBAcGFyYW0gd2ViVmlldyBUaGUgd2ViIHZpZXcgaW52b2tpbmcgdGhlIGRlbGVn YXRlIG1ldGhvZC4KICAqIEBwYXJhbSBlbGVtZW50SW5mbyBUaGUgZWxlbWVudEluZm8gZm9yIHRo ZSBlbGVtZW50IHRoZSB1c2VyIGlzIHRvdWNoaW5nLgotICogQHBhcmFtIGFuaW1hdG9yIFRoZSBh bmltYXRvciB0byB1c2UgZm9yIHRoZSBjb21taXQgYW5pbWF0aW9uLgogICovCiAKLS0gKHZvaWQp d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb250ZXh0TWVudUZvckVsZW1lbnQ6KFdLQ29u dGV4dE1lbnVFbGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvIHdpbGxDb21taXRXaXRoQW5pbWF0b3I6 KGlkPFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkNvbW1pdEFuaW1hdGluZz4pYW5pbWF0b3IgV0tf QVBJX0FWQUlMQUJMRShpb3MoV0tfSU9TX1RCQSkpOworLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3IGNvbnRleHRNZW51V2lsbFByZXNlbnRGb3JFbGVtZW50OihXS0NvbnRleHRN ZW51RWxlbWVudEluZm8gKillbGVtZW50SW5mbyBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1Nf VEJBKSk7CiAKIC8qKgotICogQGFic3RyYWN0IENhbGxlZCB3aGVuIHRoZSBjb250ZXh0IG1lbnUg d2lsbCBiZSBwcmVzZW50ZWQuCisgKiBAYWJzdHJhY3QgQ2FsbGVkIHdoZW4gdGhlIGNvbnRleHQg bWVudSBjb25maWd1cmVkIGJ5IHRoZSBVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiBmcm9tCisg KiB3ZWJWaWV3OmNvbnRleHRNZW51Q29uZmlndXJhdGlvbkZvckVsZW1lbnQ6Y29tcGxldGlvbkhh bmRsZXI6IGlzIGNvbW1pdHRlZC4gVGhhdCBpcywgd2hlbgorICogdGhlIHVzZXIgaGFzIHNlbGVj dGVkIHRoZSB2aWV3IHByb3ZpZGVkIGluIHRoZSBVSUNvbnRleHRNZW51Q29udGVudFByZXZpZXdQ cm92aWRlci4KICAqCiAgKiBAcGFyYW0gd2ViVmlldyBUaGUgd2ViIHZpZXcgaW52b2tpbmcgdGhl IGRlbGVnYXRlIG1ldGhvZC4KICAqIEBwYXJhbSBlbGVtZW50SW5mbyBUaGUgZWxlbWVudEluZm8g Zm9yIHRoZSBlbGVtZW50IHRoZSB1c2VyIGlzIHRvdWNoaW5nLgorICogQHBhcmFtIGFuaW1hdG9y IFRoZSBhbmltYXRvciB0byB1c2UgZm9yIHRoZSBjb21taXQgYW5pbWF0aW9uLgogICovCiAKLS0g KHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb250ZXh0TWVudVdpbGxQcmVzZW50 Rm9yRWxlbWVudDooV0tDb250ZXh0TWVudUVsZW1lbnRJbmZvICopZWxlbWVudEluZm8gV0tfQVBJ X0FWQUlMQUJMRShpb3MoV0tfSU9TX1RCQSkpOworLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcg Kil3ZWJWaWV3IGNvbnRleHRNZW51Rm9yRWxlbWVudDooV0tDb250ZXh0TWVudUVsZW1lbnRJbmZv ICopZWxlbWVudEluZm8gd2lsbENvbW1pdFdpdGhBbmltYXRvcjooaWQ8VUlDb250ZXh0TWVudUlu dGVyYWN0aW9uQ29tbWl0QW5pbWF0aW5nPilhbmltYXRvciBXS19BUElfQVZBSUxBQkxFKGlvcyhX S19JT1NfVEJBKSk7CiAKIC8qKgotICogQGFic3RyYWN0IENhbGxlZCB3aGVuIHRoZSBjb250ZXh0 IG1lbnUgZW5kcy4KKyAqIEBhYnN0cmFjdCBDYWxsZWQgd2hlbiB0aGUgY29udGV4dCBtZW51IGVu ZHMsIGVpdGhlciBieSBiZWluZyBkaXNtaXNzZWQgb3Igd2hlbiBhIG1lbnUgYWN0aW9uIGlzIHRh a2VuLgogICoKICAqIEBwYXJhbSB3ZWJWaWV3IFRoZSB3ZWIgdmlldyBpbnZva2luZyB0aGUgZGVs ZWdhdGUgbWV0aG9kLgogICogQHBhcmFtIGVsZW1lbnRJbmZvIFRoZSBlbGVtZW50SW5mbyBmb3Ig dGhlIGVsZW1lbnQgdGhlIHVzZXIgaXMgdG91Y2hpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZhdGUuaAppbmRleCBmNWQ3 ZTA5MThlZmEwYTNkYWNmOTAwNDhhMmFlNDY4NzIzNTQ2YTA0Li44ZTY0N2M5NDhjMWRjNDE4MzUy OGM0ZTQxNWY5YTAzN2Y0NmJkYTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGVQcml2YXRlLmgKQEAgLTE0NCwxMSArMTQ0LDEx IEBAIHN0cnVjdCBVSUVkZ2VJbnNldHM7CiAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3 ZWJWaWV3IHJlcXVlc3RHZW9sb2NhdGlvbkF1dGhvcml6YXRpb25Gb3JVUkw6KE5TVVJMICopdXJs IGZyYW1lOihXS0ZyYW1lSW5mbyAqKWZyYW1lIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAoXikoQk9P TCBhdXRob3JpemVkKSlkZWNpc2lvbkhhbmRsZXIgV0tfQVBJX0FWQUlMQUJMRShpb3MoMTEuMCkp OwogCiAtIChVSVZpZXdDb250cm9sbGVyICopX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcg cHJldmlld1ZpZXdDb250cm9sbGVyRm9yVVJMOihOU1VSTCAqKXVybCBXS19BUElfREVQUkVDQVRF RF9XSVRIX1JFUExBQ0VNRU5UKCJ3ZWJWaWV3OmNvbnRleHRNZW51Q29uZmlndXJhdGlvbkZvckVs ZW1lbnQ6Y29tcGxldGlvbkhhbmRsZXI6IiwgaW9zKDkuMCwgV0tfSU9TX1RCQSkpOwotLSAodm9p ZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb21taXRQcmV2aWV3ZWRWaWV3Q29udHJv bGxlcjooVUlWaWV3Q29udHJvbGxlciAqKXByZXZpZXdlZFZpZXdDb250cm9sbGVyIFdLX0FQSV9E RVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoIndlYlZpZXc6Y29tbWl0Q29udGV4dE1lbnU6Iiwg aW9zKDkuMCwgV0tfSU9TX1RCQSkpOworLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2Vi VmlldyBjb21taXRQcmV2aWV3ZWRWaWV3Q29udHJvbGxlcjooVUlWaWV3Q29udHJvbGxlciAqKXBy ZXZpZXdlZFZpZXdDb250cm9sbGVyIFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQo IndlYlZpZXc6Y29udGV4dE1lbnVGb3JFbGVtZW50OndpbGxDb21taXRXaXRoQW5pbWF0b3I6Iiwg aW9zKDkuMCwgV0tfSU9TX1RCQSkpOwogLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2Vi VmlldyB3aWxsUHJldmlld0ltYWdlV2l0aFVSTDooTlNVUkwgKilpbWFnZVVSTCBXS19BUElfREVQ UkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJ3ZWJWaWV3OmNvbnRleHRNZW51Q29uZmlndXJhdGlv bkZvckVsZW1lbnQ6Y29tcGxldGlvbkhhbmRsZXI6IiwgaW9zKDkuMCwgV0tfSU9TX1RCQSkpOwot LSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb21taXRQcmV2aWV3ZWRJbWFn ZVdpdGhVUkw6KE5TVVJMICopaW1hZ2VVUkwgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNF TUVOVCgid2ViVmlldzpjb21taXRDb250ZXh0TWVudToiLCBpb3MoOS4wLCBXS19JT1NfVEJBKSk7 Ci0tICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZERpc21pc3NQcmV2aWV3 Vmlld0NvbnRyb2xsZXI6KFVJVmlld0NvbnRyb2xsZXIgKilwcmV2aWV3ZWRWaWV3Q29udHJvbGxl ciBjb21taXR0aW5nOihCT09MKWNvbW1pdHRpbmcgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBM QUNFTUVOVCgid2ViVmlldzpkaXNtaXNzQ29udGV4dE1lbnU6IiwgaW9zKDkuMCwgV0tfSU9TX1RC QSkpOwotLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWREaXNtaXNzUHJl dmlld1ZpZXdDb250cm9sbGVyOihVSVZpZXdDb250cm9sbGVyICopcHJldmlld2VkVmlld0NvbnRy b2xsZXIgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgid2ViVmlldzpkaXNtaXNz Q29udGV4dE1lbnU6IiwgaW9zKDkuMCwgV0tfSU9TX1RCQSkpOworLSAodm9pZClfd2ViVmlldzoo V0tXZWJWaWV3ICopd2ViVmlldyBjb21taXRQcmV2aWV3ZWRJbWFnZVdpdGhVUkw6KE5TVVJMICop aW1hZ2VVUkwgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgid2ViVmlldzpjb250 ZXh0TWVudUZvckVsZW1lbnQ6d2lsbENvbW1pdFdpdGhBbmltYXRvcjoiLCBpb3MoOS4wLCBXS19J T1NfVEJBKSk7CistICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZERpc21p c3NQcmV2aWV3Vmlld0NvbnRyb2xsZXI6KFVJVmlld0NvbnRyb2xsZXIgKilwcmV2aWV3ZWRWaWV3 Q29udHJvbGxlciBjb21taXR0aW5nOihCT09MKWNvbW1pdHRpbmcgV0tfQVBJX0RFUFJFQ0FURURf V0lUSF9SRVBMQUNFTUVOVCgid2ViVmlldzpjb250ZXh0TWVudURpZEVuZEZvckVsZW1lbnQ6Iiwg aW9zKDkuMCwgV0tfSU9TX1RCQSkpOworLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2Vi VmlldyBkaWREaXNtaXNzUHJldmlld1ZpZXdDb250cm9sbGVyOihVSVZpZXdDb250cm9sbGVyICop cHJldmlld2VkVmlld0NvbnRyb2xsZXIgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVO VCgid2ViVmlldzpjb250ZXh0TWVudURpZEVuZEZvckVsZW1lbnQ6IiwgaW9zKDkuMCwgV0tfSU9T X1RCQSkpOwogCiAjaWYgVEFSR0VUX09TX0lPUwogLy8gVGhpcyBuZWVkcyB0byBiZSByZW1vdmVk IG9uY2UgdGhlcmUgaXMgYW4gQVBJIHZlcnNpb24gdG8gY29udGludWUgdG8gZG8gY2FsbGJhY2tz IGZvciBpbWFnZSBlbGVtZW50IGNvbnRleHQgbWVudXMuCg==