199964 2019-07-19 15:17:16 -0700 DateConversion::formatDateTime incorrectly formats negative years 2019-08-15 12:32:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Minor --- 1 ashvayka webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1554351 0 ashvayka 2019-07-19 15:17:16 -0700 Test case: d = new Date; d.setFullYear(-12); d.toUTCString().split(" ")[3] Expected: "-0012" Math.abs(year) should be padded to length of 4 and preceded with "-" if year < 0. Actual: "-012" JSC always pads year to length of 4, including minus sign "-". Other browsers engines comply with the spec. ECMA262: https://tc39.es/ecma262/#sec-datestring (steps 6-10) Test262: https://test262.report/browse/built-ins/Date/prototype/toDateString/negative-year.js https://test262.report/browse/built-ins/Date/prototype/toString/negative-year.js https://test262.report/browse/built-ins/Date/prototype/toUTCString/invalid-date.js 1554364 1 374510 ashvayka 2019-07-19 15:33:02 -0700 Created attachment 374510 Patch 1561688 2 374510 commit-queue 2019-08-15 12:31:20 -0700 Comment on attachment 374510 Patch Clearing flags on attachment: 374510 Committed r248738: <https://trac.webkit.org/changeset/248738> 1561689 3 commit-queue 2019-08-15 12:31:21 -0700 All reviewed patches have been landed. Closing bug. 1561690 4 webkit-bug-importer 2019-08-15 12:32:16 -0700 <rdar://problem/54358160> 374510 2019-07-19 15:33:02 -0700 2019-08-15 12:31:20 -0700 Patch bug-199964-20190720013301.patch text/plain 4540 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDc2NTQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE5LTA3LTE5ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBEYXRlQ29udmVyc2lvbjo6Zm9ybWF0RGF0ZVRpbWUgaW5j b3JyZWN0bHkgZm9ybWF0cyBuZWdhdGl2ZSB5ZWFycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5OTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOiBNYXJr IDYgdGVzdCBjYXNlcyBhcyBwYXNzaW5nLgorCiAyMDE5LTA3LTE2ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBcmd1bWVudHNFbGltaW5hdGlvblBoYXNlIHNob3Vs ZCBpbnNlcnQgS2lsbFN0YWNrIG5vZGVzIGJlZm9yZSBQdXRTdGFjayBub2RlcyB0aGF0IGl0IGFk ZHMuCkluZGV4OiBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCShyZXZpc2lvbiAyNDc2MzQpCisr KyBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTg1 OCw5ICs4NTgsNiBAQCB0ZXN0L2J1aWx0LWlucy9EYXRlL3Byb3RvLWZyb20tY3Rvci1yZWFsCiB0 ZXN0L2J1aWx0LWlucy9EYXRlL3Byb3RvLWZyb20tY3Rvci1yZWFsbS16ZXJvLmpzOgogICBkZWZh dWx0OiAnVHlwZUVycm9yOiBUeXBlIGVycm9yJwogICBzdHJpY3QgbW9kZTogJ1R5cGVFcnJvcjog VHlwZSBlcnJvcicKLXRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBlL3RvRGF0ZVN0cmluZy9u ZWdhdGl2ZS15ZWFyLmpzOgotICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBEYXRlLnByb3RvdHlw ZS50b0RhdGVTdHJpbmcgc2VyaWFsaXplcyB5ZWFyIC0xIHRvICItMDAwMSIgRXhwZWN0ZWQgU2Ft ZVZhbHVlKMOCwqstMDAxw4LCuywgw4LCqy0wMDAxw4LCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0 IG1vZGU6ICdUZXN0MjYyRXJyb3I6IERhdGUucHJvdG90eXBlLnRvRGF0ZVN0cmluZyBzZXJpYWxp emVzIHllYXIgLTEgdG8gIi0wMDAxIiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqy0wMDHDgsK7LCDD gsKrLTAwMDHDgsK7KSB0byBiZSB0cnVlJwogdGVzdC9idWlsdC1pbnMvRGF0ZS9wcm90b3R5cGUv dG9KU09OL2ludm9rZS1yZXN1bHQuanM6CiAgIGRlZmF1bHQ6ICdUeXBlRXJyb3I6IHRvSVNPU3Ry aW5nIGRpZCBub3QgcmV0dXJuIGEgcHJpbWl0aXZlIHZhbHVlJwogICBzdHJpY3QgbW9kZTogJ1R5 cGVFcnJvcjogdG9JU09TdHJpbmcgZGlkIG5vdCByZXR1cm4gYSBwcmltaXRpdmUgdmFsdWUnCkBA IC04NzMsMTIgKzg3MCw2IEBAIHRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBlL3RvSlNPTi90 by0KIHRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBlL3RvSlNPTi90by1wcmltaXRpdmUtdmFs dWUtb2YuanM6CiAgIGRlZmF1bHQ6ICdUeXBlRXJyb3I6IHRvSVNPU3RyaW5nIGRpZCBub3QgcmV0 dXJuIGEgcHJpbWl0aXZlIHZhbHVlJwogICBzdHJpY3QgbW9kZTogJ1R5cGVFcnJvcjogdG9JU09T dHJpbmcgZGlkIG5vdCByZXR1cm4gYSBwcmltaXRpdmUgdmFsdWUnCi10ZXN0L2J1aWx0LWlucy9E YXRlL3Byb3RvdHlwZS90b1N0cmluZy9uZWdhdGl2ZS15ZWFyLmpzOgotICBkZWZhdWx0OiAnVGVz dDI2MkVycm9yOiBEYXRlLnByb3RvdHlwZS50b1N0cmluZyBzZXJpYWxpemVzIHllYXIgLTEgdG8g Ii0wMDAxIiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqy0wMDHDgsK7LCDDgsKrLTAwMDHDgsK7KSB0 byBiZSB0cnVlJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRGF0ZS5wcm90b3R5cGUu dG9TdHJpbmcgc2VyaWFsaXplcyB5ZWFyIC0xIHRvICItMDAwMSIgRXhwZWN0ZWQgU2FtZVZhbHVl KMOCwqstMDAxw4LCuywgw4LCqy0wMDAxw4LCuykgdG8gYmUgdHJ1ZScKLXRlc3QvYnVpbHQtaW5z L0RhdGUvcHJvdG90eXBlL3RvVVRDU3RyaW5nL25lZ2F0aXZlLXllYXIuanM6Ci0gIGRlZmF1bHQ6 ICdUZXN0MjYyRXJyb3I6IERhdGUucHJvdG90eXBlLnRvVVRDU3RyaW5nIHNlcmlhbGl6ZXMgeWVh ciAtMSB0byAiLTAwMDEiIEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrLTAwMcOCwrssIMOCwqstMDAw McOCwrspIHRvIGJlIHRydWUnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBEYXRlLnBy b3RvdHlwZS50b1VUQ1N0cmluZyBzZXJpYWxpemVzIHllYXIgLTEgdG8gIi0wMDAxIiBFeHBlY3Rl ZCBTYW1lVmFsdWUow4LCqy0wMDHDgsK7LCDDgsKrLTAwMDHDgsK7KSB0byBiZSB0cnVlJwogdGVz dC9idWlsdC1pbnMvRXJyb3IvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgogICBkZWZhdWx0OiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCq0Vycm9yw4LCuywgw4LCq0Vycm9y w4LCuykgdG8gYmUgdHJ1ZScKICAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVk IFNhbWVWYWx1ZSjDgsKrRXJyb3LDgsK7LCDDgsKrRXJyb3LDgsK7KSB0byBiZSB0cnVlJwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc2MzQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIw MTktMDctMTkgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisgICAg ICAgIERhdGVDb252ZXJzaW9uOjpmb3JtYXREYXRlVGltZSBpbmNvcnJlY3RseSBmb3JtYXRzIG5l Z2F0aXZlIHllYXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTk5NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDdXJyZW50bHksIHllYXIgaXMgYWx3YXlzIHBhZGRlZCB0byBtYXggbGVuZ3RoIG9mIDQs IGluY2x1ZGluZyB0aGUgbWludXMgc2lnbiAiLSIuCisgICAgICAgIFdpdGggdGhpcyBjaGFuZ2Us IG9ubHkgYWJzb2x1dGUgdmFsdWUgb2YgeWVhciBpcyBwYWRkZWQgdG8gbWF4IGxlbmd0aCBvZiA0 IGFuZAorICAgICAgICBwcmVjZWRlZCBieSBtaW51cyBzaWduICItIiBpZiB0aGUgeWVhciBpcyBu ZWdhdGl2ZS4KKyAgICAgICAgKHN0ZXBzIDYtMTAgb2YgaHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIv I3NlYy1kYXRlc3RyaW5nKQorCisgICAgICAgICogcnVudGltZS9EYXRlQ29udmVyc2lvbi5jcHA6 CisgICAgICAgIChKU0M6OmFwcGVuZE51bWJlcik6CisKIDIwMTktMDctMTcgIEFudG9pbmUgUXVp bnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIFBvaW50ZXIgRXZlbnRz IHByaW9yIHRvIHdhdGNoT1MgNgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv RGF0ZUNvbnZlcnNpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0RhdGVDb252ZXJzaW9uLmNwcAkocmV2aXNpb24gMjQ3NjM0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUNvbnZlcnNpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00MSwxNCArNDEsMTIgQEAgdXNpbmcgbmFtZXNwYWNlIFdURjsKIHRlbXBsYXRlPGludCB3aWR0 aD4KIHN0YXRpYyBpbmxpbmUgdm9pZCBhcHBlbmROdW1iZXIoU3RyaW5nQnVpbGRlciYgYnVpbGRl ciwgaW50IHZhbHVlKQogewotICAgIGludCBmaWxsaW5nWmVyb3NDb3VudCA9IHdpZHRoOwogICAg IGlmICh2YWx1ZSA8IDApIHsKICAgICAgICAgYnVpbGRlci5hcHBlbmQoJy0nKTsKICAgICAgICAg dmFsdWUgPSAtdmFsdWU7Ci0gICAgICAgIC0tZmlsbGluZ1plcm9zQ291bnQ7CiAgICAgfQogICAg IFN0cmluZyB2YWx1ZVN0cmluZyA9IFN0cmluZzo6bnVtYmVyKHZhbHVlKTsKLSAgICBmaWxsaW5n WmVyb3NDb3VudCAtPSB2YWx1ZVN0cmluZy5sZW5ndGgoKTsKKyAgICBpbnQgZmlsbGluZ1plcm9z Q291bnQgPSB3aWR0aCAtIHZhbHVlU3RyaW5nLmxlbmd0aCgpOwogICAgIGZvciAoaW50IGkgPSAw OyBpIDwgZmlsbGluZ1plcm9zQ291bnQ7ICsraSkKICAgICAgICAgYnVpbGRlci5hcHBlbmQoJzAn KTsKICAgICBidWlsZGVyLmFwcGVuZCh2YWx1ZVN0cmluZyk7Cg==