199936 2019-07-19 02:35:04 -0700 [SOUP] WebSockets: use new api to send text messages 2019-07-22 01:47:08 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply csaavedra mcatanzaro oldest_to_newest 1554171 0 cgarcia 2019-07-19 02:35:04 -0700 New API allows to include null character in text messages. 1554172 1 374453 cgarcia 2019-07-19 02:37:53 -0700 Created attachment 374453 Patch 1554660 2 cgarcia 2019-07-22 01:47:08 -0700 Committed r247680: <https://trac.webkit.org/changeset/247680> 374453 2019-07-19 02:37:53 -0700 2019-07-19 08:12:15 -0700 Patch wk2-soup-ws-message.diff text/plain 3293 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDNlZTZjNzNkZmUuLjZlMThmMWQzY2QxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE5LTA3LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbU09VUF0gV2ViU29ja2V0czogdXNlIG5ldyBhcGkgdG8gc2VuZCB0 ZXh0IG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTk5MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOZXcgQVBJIGFsbG93cyB0byBpbmNsdWRlIG51bGwgY2hhcmFjdGVyIGluIHRleHQgbWVz c2FnZXMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3Vw LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU29ja2V0VGFzazo6ZGlkUmVjZWl2ZU1lc3NhZ2VD YWxsYmFjayk6IFBhc3MgZGF0YSBzaXplIHRvIFN0cmluZzo6ZnJvbVVURjgoKS4KKyAgICAgICAg KFdlYktpdDo6V2ViU29ja2V0VGFzazo6c2VuZFN0cmluZyk6IFVzZSBzb3VwX3dlYnNvY2tldF9j b25uZWN0aW9uX3NlbmRfbWVzc2FnZSgpIGluc3RlYWQgb2YKKyAgICAgICAgc291cF93ZWJzb2Nr ZXRfY29ubmVjdGlvbl9zZW5kX3RleHQoKSB3aGVuIGF2YWlsYWJsZS4gQWxzbyB1c2UKKyAgICAg ICAgU3RyaWN0Q29udmVyc2lvblJlcGxhY2luZ1VucGFpcmVkU3Vycm9nYXRlc1dpdGhGRkZEIG9w dGlvbnMgd2hlbiBjb252ZXJ0aW5nIHRvIFVURi04LgorCiAyMDE5LTA3LTE4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHdhcm5pbmcg d2hlbiBpbXBvcnRpbmcgV2ViS2l0IGluIFN3aWZ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvV2ViU29ja2V0VGFza1NvdXAuY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcAppbmRleCAwNDY5ZTIy NTU5Ny4uZWRlNDQzZmYxNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcApAQCAtODYsMTcgKzg2LDE3IEBAIHZv aWQgV2ViU29ja2V0VGFzazo6ZGlkUmVjZWl2ZU1lc3NhZ2VDYWxsYmFjayhXZWJTb2NrZXRUYXNr KiB0YXNrLCBTb3VwV2Vic29ja2V0CiAgICAgaWYgKGdfY2FuY2VsbGFibGVfaXNfY2FuY2VsbGVk KHRhc2stPm1fY2FuY2VsbGFibGUuZ2V0KCkpKQogICAgICAgICByZXR1cm47CiAKKyAgICBnc2l6 ZSBkYXRhU2l6ZTsKKyAgICBjb25zdCBhdXRvKiBkYXRhID0gZ19ieXRlc19nZXRfZGF0YShtZXNz YWdlLCAmZGF0YVNpemUpOworCiAgICAgc3dpdGNoIChkYXRhVHlwZSkgewogICAgIGNhc2UgU09V UF9XRUJTT0NLRVRfREFUQV9URVhUOgotICAgICAgICB0YXNrLT5tX2NoYW5uZWwuZGlkUmVjZWl2 ZVRleHQoU3RyaW5nOjpmcm9tVVRGOChzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oZ19ieXRlc19n ZXRfZGF0YShtZXNzYWdlLCBudWxscHRyKSkpKTsKKyAgICAgICAgdGFzay0+bV9jaGFubmVsLmRp ZFJlY2VpdmVUZXh0KFN0cmluZzo6ZnJvbVVURjgoc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KGRh dGEpLCBkYXRhU2l6ZSkpOwogICAgICAgICBicmVhazsKLSAgICBjYXNlIFNPVVBfV0VCU09DS0VU X0RBVEFfQklOQVJZOiB7Ci0gICAgICAgIGdzaXplIGRhdGFTaXplOwotICAgICAgICBhdXRvIGRh dGEgPSBnX2J5dGVzX2dldF9kYXRhKG1lc3NhZ2UsICZkYXRhU2l6ZSk7CisgICAgY2FzZSBTT1VQ X1dFQlNPQ0tFVF9EQVRBX0JJTkFSWToKICAgICAgICAgdGFzay0+bV9jaGFubmVsLmRpZFJlY2Vp dmVCaW5hcnlEYXRhKHN0YXRpY19jYXN0PGNvbnN0IHVpbnQ4X3QqPihkYXRhKSwgZGF0YVNpemUp OwogICAgICAgICBicmVhazsKICAgICB9Ci0gICAgfQogfQogCiB2b2lkIFdlYlNvY2tldFRhc2s6 OmRpZFJlY2VpdmVFcnJvckNhbGxiYWNrKFdlYlNvY2tldFRhc2sqIHRhc2ssIEdFcnJvciogZXJy b3IpCkBAIC0xMzksOCArMTM5LDE2IEBAIHZvaWQgV2ViU29ja2V0VGFzazo6ZGlkQ2xvc2UodW5z aWduZWQgc2hvcnQgY29kZSwgY29uc3QgU3RyaW5nJiByZWFzb24pCiAKIHZvaWQgV2ViU29ja2V0 VGFzazo6c2VuZFN0cmluZyhjb25zdCBTdHJpbmcmIHRleHQsIENvbXBsZXRpb25IYW5kbGVyPHZv aWQoKT4mJiBjYWxsYmFjaykKIHsKLSAgICBpZiAobV9jb25uZWN0aW9uICYmIHNvdXBfd2Vic29j a2V0X2Nvbm5lY3Rpb25fZ2V0X3N0YXRlKG1fY29ubmVjdGlvbi5nZXQoKSkgPT0gU09VUF9XRUJT T0NLRVRfU1RBVEVfT1BFTikKLSAgICAgICAgc291cF93ZWJzb2NrZXRfY29ubmVjdGlvbl9zZW5k X3RleHQobV9jb25uZWN0aW9uLmdldCgpLCB0ZXh0LnV0ZjgoKS5kYXRhKCkpOworICAgIGlmICht X2Nvbm5lY3Rpb24gJiYgc291cF93ZWJzb2NrZXRfY29ubmVjdGlvbl9nZXRfc3RhdGUobV9jb25u ZWN0aW9uLmdldCgpKSA9PSBTT1VQX1dFQlNPQ0tFVF9TVEFURV9PUEVOKSB7CisgICAgICAgIENT dHJpbmcgdXRmOCA9IHRleHQudXRmOChTdHJpY3RDb252ZXJzaW9uUmVwbGFjaW5nVW5wYWlyZWRT dXJyb2dhdGVzV2l0aEZGRkQpOworI2lmIFNPVVBfQ0hFQ0tfVkVSU0lPTigyLCA2NywgMykKKyAg ICAgICAgLy8gU291cCBpcyBnb2luZyB0byBjb3B5IHRoZSBkYXRhIGltbWVkaWF0ZWx5LCBzbyB3 ZSBjYW4gdXNlIGdfYnl0ZXNfbmV3X3N0YXRpYygpIGhlcmUgdG8gYXZvaWQgbW9yZSBkYXRhIGNv cGllcy4KKyAgICAgICAgR1JlZlB0cjxHQnl0ZXM+IGJ5dGVzID0gYWRvcHRHUmVmKGdfYnl0ZXNf bmV3X3N0YXRpYyh1dGY4LmRhdGEoKSwgdXRmOC5sZW5ndGgoKSkpOworICAgICAgICBzb3VwX3dl YnNvY2tldF9jb25uZWN0aW9uX3NlbmRfbWVzc2FnZShtX2Nvbm5lY3Rpb24uZ2V0KCksIFNPVVBf V0VCU09DS0VUX0RBVEFfVEVYVCwgYnl0ZXMuZ2V0KCkpOworI2Vsc2UKKyAgICAgICAgc291cF93 ZWJzb2NrZXRfY29ubmVjdGlvbl9zZW5kX3RleHQobV9jb25uZWN0aW9uLmdldCgpLCB1dGY4LmRh dGEoKSk7CisjZW5kaWYKKyAgICB9CiAgICAgY2FsbGJhY2soKTsKIH0KIAo=