199934 2019-07-18 23:18:18 -0700 [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource 2019-07-19 04:44:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner calvaris commit-queue webkit-bug-importer oldest_to_newest 1554135 0 cturner 2019-07-18 23:18:18 -0700 [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource 1554136 1 374444 cturner 2019-07-18 23:20:57 -0700 Created attachment 374444 Patch 1554149 2 374444 calvaris 2019-07-19 00:07:04 -0700 Comment on attachment 374444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374444&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:780 > + { This should go to the line above. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:785 > + locker.unlockEarly(); This shouldn't be needed. 1554159 3 374449 cturner 2019-07-19 01:38:55 -0700 Created attachment 374449 Patch for landing 1554160 4 374450 cturner 2019-07-19 01:39:30 -0700 Created attachment 374450 Patch for landing 1554180 5 374450 commit-queue 2019-07-19 04:43:41 -0700 Comment on attachment 374450 Patch for landing Clearing flags on attachment: 374450 Committed r247643: <https://trac.webkit.org/changeset/247643> 1554181 6 commit-queue 2019-07-19 04:43:42 -0700 All reviewed patches have been landed. Closing bug. 374444 2019-07-18 23:20:57 -0700 2019-07-19 01:38:52 -0700 Patch bug-199934-20190719072056.patch text/plain 1932 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE4OTYyYjdlZjFjYTg1 ZjExZmVkMTUxY2JhZTc2MGMzMDJhMjgwOS4uMGJmYTY3MWY1NTM2YWE4ODRhMjBhYWU3NzZjZWE4 OTMzNjMzY2ZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTE4ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBG bHVzaCBnZXRfcmFuZ2UgY2FsbHMgZHVyaW5nIFBBVVNFRC0+UkVBRFkgaW4gV2ViS2l0V2ViU291 cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk5 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbml0 IHRlc3Rpbmcgbm90IGFwcGxpY2FibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdl YlNyY0NoYW5nZVN0YXRlKTogQSB3ZWxsLWJlaGF2ZWQgZWxlbWVudCBzaG91bGQgdW5ibG9jayBz dHJlYW1pbmcgdGhyZWFkcworICAgICAgICBkdXJpbmcgYSBQQVVTRUQtPlJFQURZIHRyYW5zaXRp b24sIHNvIGRvIHRoYXQgaGVyZS4KKwogMjAxOS0wNy0xNyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIEFkZCByZWZlcnJlcnBvbGljeSBhdHRyaWJ1dGUgc3VwcG9ydCBm b3IgPHNjcmlwdD4gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKaW5kZXggMTJiMjFhZTNiZmQzYzY3NjkxYTVjNWJhNTY3ZjliMDZjMWEyZjM3Mi4u MzJmNjlmMjY1NmZhZjM3Njg1NDgzNzBhMzBjMWU3YWE4NWY0YTU4YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdT dHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTc3NCw4ICs3NzQsMTcgQEAgc3Rh dGljIEdzdFN0YXRlQ2hhbmdlUmV0dXJuIHdlYktpdFdlYlNyY0NoYW5nZVN0YXRlKEdzdEVsZW1l bnQqIGVsZW1lbnQsIEdzdFN0YXQKICNlbmRpZgogICAgIHN3aXRjaCAodHJhbnNpdGlvbikgewog ICAgIGNhc2UgR1NUX1NUQVRFX0NIQU5HRV9SRUFEWV9UT19OVUxMOgotICAgICAgICB3ZWJLaXRX ZWJTcmNDbG9zZVNlc3Npb24oc3JjKTsKKyAgICAgICAgd2Via2l0V2ViU3JjQ2xvc2VTZXNzaW9u KHNyYyk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgR1NUX1NUQVRFX0NIQU5HRV9QQVVTRURf VE9fUkVBRFk6CisgICAgICAgIHsKKyAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIoc3JjLT5wcml2 LT5yZXNwb25zZUxvY2spOworICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHNyYywgIlBBVVNFRC0+ UkVBRFkgY2FuY2VsbGluZyBuZXR3b3JrIHJlcXVlc3RzIik7CisgICAgICAgIHNyYy0+cHJpdi0+ aXNGbHVzaGluZyA9IHRydWU7CisgICAgICAgIHNyYy0+cHJpdi0+cmVzcG9uc2VDb25kaXRpb24u bm90aWZ5T25lKCk7CisgICAgICAgIGxvY2tlci51bmxvY2tFYXJseSgpOwogICAgICAgICBicmVh azsKKyAgICAgICAgfQogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJyZWFrOwogICAgIH0K 374449 2019-07-19 01:38:55 -0700 2019-07-19 01:39:27 -0700 Patch for landing bug-199934-20190719093854.patch text/plain 1824 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE4OTYyYjdlZjFjYTg1 ZjExZmVkMTUxY2JhZTc2MGMzMDJhMjgwOS4uMGJmYTY3MWY1NTM2YWE4ODRhMjBhYWU3NzZjZWE4 OTMzNjMzY2ZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTE4ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBG bHVzaCBnZXRfcmFuZ2UgY2FsbHMgZHVyaW5nIFBBVVNFRC0+UkVBRFkgaW4gV2ViS2l0V2ViU291 cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk5 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbml0 IHRlc3Rpbmcgbm90IGFwcGxpY2FibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdl YlNyY0NoYW5nZVN0YXRlKTogQSB3ZWxsLWJlaGF2ZWQgZWxlbWVudCBzaG91bGQgdW5ibG9jayBz dHJlYW1pbmcgdGhyZWFkcworICAgICAgICBkdXJpbmcgYSBQQVVTRUQtPlJFQURZIHRyYW5zaXRp b24sIHNvIGRvIHRoYXQgaGVyZS4KKwogMjAxOS0wNy0xNyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIEFkZCByZWZlcnJlcnBvbGljeSBhdHRyaWJ1dGUgc3VwcG9ydCBm b3IgPHNjcmlwdD4gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKaW5kZXggMTJiMjFhZTNiZmQzYzY3NjkxYTVjNWJhNTY3ZjliMDZjMWEyZjM3Mi4u NWY0YzZmYmZjMWY5ZGMzZjg2NzRhNWRiZTIwZDQyNGQ1OGZkMzkzZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdT dHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTc3Niw3ICs3NzYsMTMgQEAgc3Rh dGljIEdzdFN0YXRlQ2hhbmdlUmV0dXJuIHdlYktpdFdlYlNyY0NoYW5nZVN0YXRlKEdzdEVsZW1l bnQqIGVsZW1lbnQsIEdzdFN0YXQKICAgICBjYXNlIEdTVF9TVEFURV9DSEFOR0VfUkVBRFlfVE9f TlVMTDoKICAgICAgICAgd2ViS2l0V2ViU3JjQ2xvc2VTZXNzaW9uKHNyYyk7CiAgICAgICAgIGJy ZWFrOwotICAgIGRlZmF1bHQ6CisgICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BBVVNFRF9UT19S RUFEWTogeworICAgICAgICBMb2NrSG9sZGVyIGxvY2tlcihzcmMtPnByaXYtPnJlc3BvbnNlTG9j ayk7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUEFVU0VELT5SRUFEWSBjYW5jZWxs aW5nIG5ldHdvcmsgcmVxdWVzdHMiKTsKKyAgICAgICAgc3JjLT5wcml2LT5pc0ZsdXNoaW5nID0g dHJ1ZTsKKyAgICAgICAgc3JjLT5wcml2LT5yZXNwb25zZUNvbmRpdGlvbi5ub3RpZnlPbmUoKTsK KyAgICAgICAgYnJlYWs7CisgICAgfSBkZWZhdWx0OgogICAgICAgICBicmVhazsKICAgICB9CiAK 374450 2019-07-19 01:39:30 -0700 2019-07-19 04:43:41 -0700 Patch for landing bug-199934-20190719093929.patch text/plain 1833 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE4OTYyYjdlZjFjYTg1 ZjExZmVkMTUxY2JhZTc2MGMzMDJhMjgwOS4uYWUwMTEzMTcwNWY0MWMyOTNmMTQyOTZhNmIxMjUx Y2Q5OTYxZWUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTE4ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBG bHVzaCBnZXRfcmFuZ2UgY2FsbHMgZHVyaW5nIFBBVVNFRC0+UkVBRFkgaW4gV2ViS2l0V2ViU291 cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk5 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBYYWJpZXIgUm9kcmlndWV6LUNhbHZhci4KKworICAg ICAgICBVbml0IHRlc3Rpbmcgbm90IGFwcGxpY2FibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg KHdlYktpdFdlYlNyY0NoYW5nZVN0YXRlKTogQSB3ZWxsLWJlaGF2ZWQgZWxlbWVudCBzaG91bGQg dW5ibG9jayBzdHJlYW1pbmcgdGhyZWFkcworICAgICAgICBkdXJpbmcgYSBQQVVTRUQtPlJFQURZ IHRyYW5zaXRpb24sIHNvIGRvIHRoYXQgaGVyZS4KKwogMjAxOS0wNy0xNyAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFkZCByZWZlcnJlcnBvbGljeSBhdHRyaWJ1dGUg c3VwcG9ydCBmb3IgPHNjcmlwdD4gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHAKaW5kZXggMTJiMjFhZTNiZmQzYzY3NjkxYTVjNWJhNTY3ZjliMDZj MWEyZjM3Mi4uNWY0YzZmYmZjMWY5ZGMzZjg2NzRhNWRiZTIwZDQyNGQ1OGZkMzkzZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdl YlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTc3Niw3ICs3NzYs MTMgQEAgc3RhdGljIEdzdFN0YXRlQ2hhbmdlUmV0dXJuIHdlYktpdFdlYlNyY0NoYW5nZVN0YXRl KEdzdEVsZW1lbnQqIGVsZW1lbnQsIEdzdFN0YXQKICAgICBjYXNlIEdTVF9TVEFURV9DSEFOR0Vf UkVBRFlfVE9fTlVMTDoKICAgICAgICAgd2ViS2l0V2ViU3JjQ2xvc2VTZXNzaW9uKHNyYyk7CiAg ICAgICAgIGJyZWFrOwotICAgIGRlZmF1bHQ6CisgICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BB VVNFRF9UT19SRUFEWTogeworICAgICAgICBMb2NrSG9sZGVyIGxvY2tlcihzcmMtPnByaXYtPnJl c3BvbnNlTG9jayk7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUEFVU0VELT5SRUFE WSBjYW5jZWxsaW5nIG5ldHdvcmsgcmVxdWVzdHMiKTsKKyAgICAgICAgc3JjLT5wcml2LT5pc0Zs dXNoaW5nID0gdHJ1ZTsKKyAgICAgICAgc3JjLT5wcml2LT5yZXNwb25zZUNvbmRpdGlvbi5ub3Rp ZnlPbmUoKTsKKyAgICAgICAgYnJlYWs7CisgICAgfSBkZWZhdWx0OgogICAgICAgICBicmVhazsK ICAgICB9CiAK