<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199932</bug_id>
          
          <creation_ts>2019-07-18 22:10:06 -0700</creation_ts>
          <short_desc>[WHLSL] Global struct has too many unused members in it</short_desc>
          <delta_ts>2020-05-05 00:42:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>200463</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1554127</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2019-07-18 22:10:06 -0700</bug_when>
    <thetext>There are hundreds of members, almost none of which are used.

We should gather items in the global struct per entry point, and only in functions which are reachable from that entry point, rather than gathering them across the whole program.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554477</commentid>
    <comment_count>1</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-07-20 01:49:14 -0700</bug_when>
    <thetext>(In reply to Myles C. Maxfield from comment #0)
&gt; There are hundreds of members, almost none of which are used.
&gt; 
&gt; We should gather items in the global struct per entry point, and only in
&gt; functions which are reachable from that entry point, rather than gathering
&gt; them across the whole program.

We’d also greatly reduce the number if we marked the various take the address of nodes we generate internally with a special bit that they don’t need to be in the struct. same if we skipped stdlib functions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1649051</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-05-05 00:42:36 -0700</bug_when>
    <thetext>WHLSL is no longer relevant.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>