199918 2019-07-18 15:35:01 -0700 Web Inspector: Issues toggling multiple breakpoints on one line 2019-07-19 00:40:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://devinrousso.com/demo/WebKit/199918.html P2 Normal --- 1 joepeck hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1554045 0 joepeck 2019-07-18 15:35:01 -0700 Issues toggling multiple breakpoints on one line Steps to Reproduce: 1. Inspect https://devinrousso.com/demo/WebKit/breakpoint-collapse.html 2. Pretty print the js file 3. Set a breakpoint on line 2 4. Set a breakpoint on line 7 5. Unpretty print the js file 6. Right click the breakpoint and select "Disable Breakpoints" => Show as unresolved instead of disabled 1554129 1 374443 hi 2019-07-18 22:58:10 -0700 Created attachment 374443 Patch 1554134 2 374443 joepeck 2019-07-18 23:16:17 -0700 Comment on attachment 374443 Patch rs=me 1554150 3 hi 2019-07-19 00:30:42 -0700 (In reply to Joseph Pecoraro from comment #0) > 1. Inspect https://devinrousso.com/demo/WebKit/breakpoint-collapse.html This has been moved to <https://devinrousso.com/demo/WebKit/199918.html>. 1554151 4 374443 commit-queue 2019-07-19 00:39:18 -0700 Comment on attachment 374443 Patch Clearing flags on attachment: 374443 Committed r247639: <https://trac.webkit.org/changeset/247639> 1554152 5 commit-queue 2019-07-19 00:39:20 -0700 All reviewed patches have been landed. Closing bug. 374443 2019-07-18 22:58:10 -0700 2019-07-19 00:39:18 -0700 Patch bug-199918-20190718225809.patch text/plain 7399 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFmZTZhZTcwOGViYmQ1MWQyODQzMWQ3OTBmZDc2 MjJlYTgyYTJhZTUuLjM3YTYzYWEwMWI0YjUwMmJhN2MzNGQ0ODNlOWYzMDQwNmVkMTljMzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA3LTE4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJ c3N1ZXMgdG9nZ2xpbmcgbXVsdGlwbGUgYnJlYWtwb2ludHMgb24gb25lIGxpbmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTkxOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdJLlNvdXJjZUNvZGVUZXh0 RWRpdG9yKToKKyAgICAgICAgKFdJLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnByb3RvdHlwZS5jbG9z ZSk6CisgICAgICAgIChXSS5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUudGV4dEVkaXRv ckd1dHRlckNvbnRleHRNZW51KToKKyAgICAgICAgKFdJLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnBy b3RvdHlwZS50ZXh0RWRpdG9yVXBkYXRlZEZvcm1hdHRpbmcpOgorICAgICAgICAoV0kuU291cmNl Q29kZVRleHRFZGl0b3IucHJvdG90eXBlLl9oYW5kbGVGb3JtYXR0ZXJEaWRDaGFuZ2UpOiBBZGRl ZC4KKyAgICAgICAgTGlzdGVuIGZvciBgV0kuU291cmNlQ29kZS5FdmVudC5Gb3JtYXR0ZXJEaWRD aGFuZ2VgIGV2ZW50cyBhcyB0aGVyZSBtYXkgYmUgbXVsdGlwbGUgY29udGVudAorICAgICAgICB2 aWV3cyBmb3IgdGhlIHNhbWUgYFdJLlNvdXJjZUNvZGVgLiBQcmV2aW91c2x5LCBpZiB0aGVyZSB3 ZXJlLCBvbmx5IHRoZSBhY3RpdmUgb25lIHdvdWxkCisgICAgICAgIHByb3Blcmx5IHVwZGF0ZSBp dCdzICJsaW5lIC0+IGNvbHVtbiAtPiBicmVha3BvaW50IiBtYXBwaW5nLCBjYXVzaW5nIGFuIGVy cm9yIHRvIGJlIHRocm93bgorICAgICAgICB3aGVuIHRoZSBub24tYWN0aXZlIGNvbnRlbnQgdmll d3MgdHJpZWQgdG8gcmV0cmlldmUgdGhlIGJyZWFrcG9pbnQgZm9yIHRoZSBuZXcgbGluZS9jb2x1 bW4uCisKIDIwMTktMDctMTcgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21l LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhcHBsaWNhdGlvbi94bWwgY29udGVudCBu b3Qgc2hvd24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKaW5kZXggMmUzMzk4OTg4 ZDEyYjZhNjQ3YzY3MTg0NzEwOThhYWM3NjhmMTBiYS4uNmFjNDZiYTFiYjlhMzJjMWE5NjE1ZTc3 NzQ2Y2NiMzNlYzFmZWJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAg LTkwLDYgKzkwLDcgQEAgV0kuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2Rl VGV4dEVkaXRvciBleHRlbmRzIFdJLlRleHRFZGl0b3IKIAogICAgICAgICBXSS5jb25zb2xlTWFu YWdlci5hZGRFdmVudExpc3RlbmVyKFdJLkNvbnNvbGVNYW5hZ2VyLkV2ZW50Lklzc3VlQWRkZWQs IHRoaXMuX2lzc3VlV2FzQWRkZWQsIHRoaXMpOwogCisgICAgICAgIHRoaXMuX3NvdXJjZUNvZGUu YWRkRXZlbnRMaXN0ZW5lcihXSS5Tb3VyY2VDb2RlLkV2ZW50LkZvcm1hdHRlckRpZENoYW5nZSwg dGhpcy5faGFuZGxlRm9ybWF0dGVyRGlkQ2hhbmdlLCB0aGlzKTsKICAgICAgICAgaWYgKHRoaXMu X3NvdXJjZUNvZGUgaW5zdGFuY2VvZiBXSS5Tb3VyY2VNYXBSZXNvdXJjZSB8fCB0aGlzLl9zb3Vy Y2VDb2RlLnNvdXJjZU1hcHMubGVuZ3RoID4gMCkKICAgICAgICAgICAgIFdJLm5vdGlmaWNhdGlv bnMuYWRkRXZlbnRMaXN0ZW5lcihXSS5Ob3RpZmljYXRpb24uR2xvYmFsTW9kaWZpZXJLZXlzRGlk Q2hhbmdlLCB0aGlzLl91cGRhdGVUb2tlblRyYWNraW5nQ29udHJvbGxlclN0YXRlLCB0aGlzKTsK ICAgICAgICAgZWxzZQpAQCAtMTc2LDEyICsxNzcsOSBAQCBXSS5Tb3VyY2VDb2RlVGV4dEVkaXRv ciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVGV4dEVkaXRvcgogICAg ICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgV0kuY29uc29sZU1hbmFnZXIucmVtb3Zl RXZlbnRMaXN0ZW5lcihXSS5Db25zb2xlTWFuYWdlci5FdmVudC5Jc3N1ZUFkZGVkLCB0aGlzLl9p c3N1ZVdhc0FkZGVkLCB0aGlzKTsKLQotICAgICAgICBpZiAodGhpcy5fc291cmNlQ29kZSBpbnN0 YW5jZW9mIFdJLlNvdXJjZU1hcFJlc291cmNlIHx8IHRoaXMuX3NvdXJjZUNvZGUuc291cmNlTWFw cy5sZW5ndGggPiAwKQotICAgICAgICAgICAgV0kubm90aWZpY2F0aW9ucy5yZW1vdmVFdmVudExp c3RlbmVyKFdJLk5vdGlmaWNhdGlvbi5HbG9iYWxNb2RpZmllcktleXNEaWRDaGFuZ2UsIHRoaXMu X3VwZGF0ZVRva2VuVHJhY2tpbmdDb250cm9sbGVyU3RhdGUsIHRoaXMpOwotICAgICAgICBlbHNl Ci0gICAgICAgICAgICB0aGlzLl9zb3VyY2VDb2RlLnJlbW92ZUV2ZW50TGlzdGVuZXIoV0kuU291 cmNlQ29kZS5FdmVudC5Tb3VyY2VNYXBBZGRlZCwgdGhpcy5fc291cmNlQ29kZVNvdXJjZU1hcEFk ZGVkLCB0aGlzKTsKKyAgICAgICAgV0kuY29uc29sZU1hbmFnZXIucmVtb3ZlRXZlbnRMaXN0ZW5l cihudWxsLCBudWxsLCB0aGlzKTsKKyAgICAgICAgV0kubm90aWZpY2F0aW9ucy5yZW1vdmVFdmVu dExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOworICAgICAgICB0aGlzLl9zb3VyY2VDb2RlLnJl bW92ZUV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7CiAgICAgfQogCiAgICAgY2FuQmVG b3JtYXR0ZWQoKQpAQCAtMTI2MiwyNSArMTI2MCwxNiBAQCBXSS5Tb3VyY2VDb2RlVGV4dEVkaXRv ciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVGV4dEVkaXRvcgogICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgLy8gTXVsdGlwbGUgYnJlYWtw b2ludHMuCi0gICAgICAgIGxldCByZW1vdmVCcmVha3BvaW50cyA9ICgpID0+IHsKLSAgICAgICAg ICAgIGZvciAobGV0IGJyZWFrcG9pbnQgb2YgYnJlYWtwb2ludHMpIHsKLSAgICAgICAgICAgICAg ICBpZiAoV0kuZGVidWdnZXJNYW5hZ2VyLmlzQnJlYWtwb2ludFJlbW92YWJsZShicmVha3BvaW50 KSkKLSAgICAgICAgICAgICAgICAgICAgV0kuZGVidWdnZXJNYW5hZ2VyLnJlbW92ZUJyZWFrcG9p bnQoYnJlYWtwb2ludCk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH07Ci0KICAgICAgICAgbGV0 IHNob3VsZERpc2FibGUgPSBicmVha3BvaW50cy5zb21lKChicmVha3BvaW50KSA9PiAhYnJlYWtw b2ludC5kaXNhYmxlZCk7Ci0gICAgICAgIGxldCB0b2dnbGVCcmVha3BvaW50cyA9IChzaG91bGRE aXNhYmxlKSA9PiB7CisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oc2hvdWxkRGlzYWJs ZSA/IFdJLlVJU3RyaW5nKCJEaXNhYmxlIEJyZWFrcG9pbnRzIikgOiBXSS5VSVN0cmluZygiRW5h YmxlIEJyZWFrcG9pbnRzIiksICgpID0+IHsKICAgICAgICAgICAgIGZvciAobGV0IGJyZWFrcG9p bnQgb2YgYnJlYWtwb2ludHMpCiAgICAgICAgICAgICAgICAgYnJlYWtwb2ludC5kaXNhYmxlZCA9 IHNob3VsZERpc2FibGU7Ci0gICAgICAgIH07CisgICAgICAgIH0pOwogCi0gICAgICAgIGlmIChz aG91bGREaXNhYmxlKQotICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0 cmluZygiRGlzYWJsZSBCcmVha3BvaW50cyIpLCB0b2dnbGVCcmVha3BvaW50cyk7Ci0gICAgICAg IGVsc2UKLSAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkVu YWJsZSBCcmVha3BvaW50cyIpLCB0b2dnbGVCcmVha3BvaW50cyk7Ci0gICAgICAgIGNvbnRleHRN ZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkRlbGV0ZSBCcmVha3BvaW50cyIpLCByZW1vdmVC cmVha3BvaW50cyk7CisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmco IkRlbGV0ZSBCcmVha3BvaW50cyIpLCAoKSA9PiB7CisgICAgICAgICAgICBmb3IgKGxldCBicmVh a3BvaW50IG9mIGJyZWFrcG9pbnRzKQorICAgICAgICAgICAgICAgIFdJLmRlYnVnZ2VyTWFuYWdl ci5yZW1vdmVCcmVha3BvaW50KGJyZWFrcG9pbnQpOworICAgICAgICB9KTsKICAgICB9CiAKICAg ICB0ZXh0RWRpdG9yQnJlYWtwb2ludEFkZGVkKHRleHRFZGl0b3IsIGxpbmVOdW1iZXIsIGNvbHVt bk51bWJlcikKQEAgLTEzODcsMjQgKzEzNzYsNyBAQCBXSS5Tb3VyY2VDb2RlVGV4dEVkaXRvciA9 IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVGV4dEVkaXRvcgogICAgICAg ICAgICAgICAgIHRoaXMuX3NvdXJjZUNvZGUucmVzb3VyY2UuZm9ybWF0dGVyU291cmNlTWFwID0g dGhpcy5mb3JtYXR0ZXJTb3VyY2VNYXA7CiAgICAgICAgIH0KIAotICAgICAgICAvLyBTb21lIGJy ZWFrcG9pbnRzIC8gaXNzdWVzIG1heSBoYXZlIG1vdmVkLCBzb21lIG1pZ2h0IG5vdCBoYXZlLiBK dXN0IGdvIHRocm91Z2gKLSAgICAgICAgLy8gYW5kIHJlbW92ZSBhbmQgcmVpbnNlcnQgYWxsIHRo ZSBicmVha3BvaW50cyAvIGlzc3Vlcy4KLQotICAgICAgICB2YXIgb2xkQnJlYWtwb2ludE1hcCA9 IHRoaXMuX2JyZWFrcG9pbnRNYXA7Ci0gICAgICAgIHRoaXMuX2JyZWFrcG9pbnRNYXAgPSB7fTsK LQotICAgICAgICBmb3IgKHZhciBsaW5lTnVtYmVyIGluIG9sZEJyZWFrcG9pbnRNYXApIHsKLSAg ICAgICAgICAgIGZvciAodmFyIGNvbHVtbk51bWJlciBpbiBvbGRCcmVha3BvaW50TWFwW2xpbmVO dW1iZXJdKSB7Ci0gICAgICAgICAgICAgICAgdmFyIGJyZWFrcG9pbnQgPSBvbGRCcmVha3BvaW50 TWFwW2xpbmVOdW1iZXJdW2NvbHVtbk51bWJlcl07Ci0gICAgICAgICAgICAgICAgdmFyIG5ld0xp bmVJbmZvID0gdGhpcy5fZWRpdG9yTGluZUluZm9Gb3JTb3VyY2VDb2RlTG9jYXRpb24oYnJlYWtw b2ludC5zb3VyY2VDb2RlTG9jYXRpb24pOwotICAgICAgICAgICAgICAgIHRoaXMuX2FkZEJyZWFr cG9pbnRXaXRoRWRpdG9yTGluZUluZm8oYnJlYWtwb2ludCwgbmV3TGluZUluZm8pOwotICAgICAg ICAgICAgICAgIHRoaXMuc2V0QnJlYWtwb2ludEluZm9Gb3JMaW5lQW5kQ29sdW1uKGxpbmVOdW1i ZXIsIGNvbHVtbk51bWJlciwgbnVsbCk7Ci0gICAgICAgICAgICAgICAgdGhpcy5zZXRCcmVha3Bv aW50SW5mb0ZvckxpbmVBbmRDb2x1bW4obmV3TGluZUluZm8ubGluZU51bWJlciwgbmV3TGluZUlu Zm8uY29sdW1uTnVtYmVyLCB0aGlzLl9icmVha3BvaW50SW5mb0ZvckJyZWFrcG9pbnQoYnJlYWtw b2ludCkpOwotICAgICAgICAgICAgfQotICAgICAgICB9Ci0KLSAgICAgICAgdGhpcy5fcmVpbnNl cnRBbGxJc3N1ZXMoKTsKLSAgICAgICAgdGhpcy5fcmVpbnNlcnRBbGxUaHJlYWRJbmRpY2F0b3Jz KCk7CisgICAgICAgIHRoaXMuX2hhbmRsZUZvcm1hdHRlckRpZENoYW5nZSgpOwogICAgIH0KIAog ICAgIHRleHRFZGl0b3JFeGVjdXRpb25IaWdobGlnaHRSYW5nZShjdXJyZW50UG9zaXRpb24sIGNh bGxiYWNrKQpAQCAtMTYwNyw2ICsxNTc5LDMxIEBAIFdJLlNvdXJjZUNvZGVUZXh0RWRpdG9yID0g Y2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXSS5UZXh0RWRpdG9yCiAgICAgICAg ICAgICB0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yLnJlZnJlc2goKTsKICAgICB9CiAKKyAgICBf aGFuZGxlRm9ybWF0dGVyRGlkQ2hhbmdlKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMu X2lnbm9yZUFsbEJyZWFrcG9pbnRMb2NhdGlvblVwZGF0ZXMpCisgICAgICAgICAgICByZXR1cm47 CisKKyAgICAgICAgLy8gU29tZSBicmVha3BvaW50cyAvIGlzc3VlcyBtYXkgaGF2ZSBtb3ZlZCwg c29tZSBtaWdodCBub3QgaGF2ZS4gSnVzdCBnbyB0aHJvdWdoCisgICAgICAgIC8vIGFuZCByZW1v dmUgYW5kIHJlaW5zZXJ0IGFsbCB0aGUgYnJlYWtwb2ludHMgLyBpc3N1ZXMuCisKKyAgICAgICAg dmFyIG9sZEJyZWFrcG9pbnRNYXAgPSB0aGlzLl9icmVha3BvaW50TWFwOworICAgICAgICB0aGlz Ll9icmVha3BvaW50TWFwID0ge307CisKKyAgICAgICAgZm9yICh2YXIgbGluZU51bWJlciBpbiBv bGRCcmVha3BvaW50TWFwKSB7CisgICAgICAgICAgICBmb3IgKHZhciBjb2x1bW5OdW1iZXIgaW4g b2xkQnJlYWtwb2ludE1hcFtsaW5lTnVtYmVyXSkgeworICAgICAgICAgICAgICAgIHZhciBicmVh a3BvaW50ID0gb2xkQnJlYWtwb2ludE1hcFtsaW5lTnVtYmVyXVtjb2x1bW5OdW1iZXJdOworICAg ICAgICAgICAgICAgIHZhciBuZXdMaW5lSW5mbyA9IHRoaXMuX2VkaXRvckxpbmVJbmZvRm9yU291 cmNlQ29kZUxvY2F0aW9uKGJyZWFrcG9pbnQuc291cmNlQ29kZUxvY2F0aW9uKTsKKyAgICAgICAg ICAgICAgICB0aGlzLl9hZGRCcmVha3BvaW50V2l0aEVkaXRvckxpbmVJbmZvKGJyZWFrcG9pbnQs IG5ld0xpbmVJbmZvKTsKKyAgICAgICAgICAgICAgICB0aGlzLnNldEJyZWFrcG9pbnRJbmZvRm9y TGluZUFuZENvbHVtbihsaW5lTnVtYmVyLCBjb2x1bW5OdW1iZXIsIG51bGwpOworICAgICAgICAg ICAgICAgIHRoaXMuc2V0QnJlYWtwb2ludEluZm9Gb3JMaW5lQW5kQ29sdW1uKG5ld0xpbmVJbmZv LmxpbmVOdW1iZXIsIG5ld0xpbmVJbmZvLmNvbHVtbk51bWJlciwgdGhpcy5fYnJlYWtwb2ludElu Zm9Gb3JCcmVha3BvaW50KGJyZWFrcG9pbnQpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQor CisgICAgICAgIHRoaXMuX3JlaW5zZXJ0QWxsSXNzdWVzKCk7CisgICAgICAgIHRoaXMuX3JlaW5z ZXJ0QWxsVGhyZWFkSW5kaWNhdG9ycygpOworICAgIH0KKwogICAgIF9zb3VyY2VDb2RlU291cmNl TWFwQWRkZWQoZXZlbnQpCiAgICAgewogICAgICAgICBXSS5ub3RpZmljYXRpb25zLmFkZEV2ZW50 TGlzdGVuZXIoV0kuTm90aWZpY2F0aW9uLkdsb2JhbE1vZGlmaWVyS2V5c0RpZENoYW5nZSwgdGhp cy5fdXBkYXRlVG9rZW5UcmFja2luZ0NvbnRyb2xsZXJTdGF0ZSwgdGhpcyk7Cg==