199887 2019-07-17 15:34:01 -0700 Provide a NSURL cateogry to tell AppSSO Kerberos URLs 2019-07-17 17:15:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham commit-queue conrad_shultz jiewen_tan webkit-bug-importer oldest_to_newest 1553717 0 jiewen_tan 2019-07-17 15:34:01 -0700 Provide a NSURL cateogry to tell AppSSO Kerberos URLs. 1553718 1 jiewen_tan 2019-07-17 15:34:31 -0700 <rdar://problem/52323161> 1553723 2 374344 jiewen_tan 2019-07-17 15:42:49 -0700 Created attachment 374344 Patch 1553728 3 374344 bfulgham 2019-07-17 15:54:32 -0700 Comment on attachment 374344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 > ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something. 1553748 4 374344 jiewen_tan 2019-07-17 16:40:43 -0700 Comment on attachment 374344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review >> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 >> ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url > > Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? > > That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something. Thanks, Brent. I made it + (BOOL)_web_willPerformSOKerberosAuthorizationWithURL:(NSURL *)url. 1553751 5 374351 jiewen_tan 2019-07-17 16:52:49 -0700 Created attachment 374351 Patch 1553752 6 374351 bfulgham 2019-07-17 16:53:28 -0700 Comment on attachment 374351 Patch Thanks for changing the naming. 1553753 7 jiewen_tan 2019-07-17 16:54:39 -0700 (In reply to Brent Fulgham from comment #6) > Comment on attachment 374351 [details] > Patch > > Thanks for changing the naming. Thanks for r+ it. 1553762 8 374351 commit-queue 2019-07-17 17:15:07 -0700 Comment on attachment 374351 Patch Clearing flags on attachment: 374351 Committed r247547: <https://trac.webkit.org/changeset/247547> 1553763 9 commit-queue 2019-07-17 17:15:08 -0700 All reviewed patches have been landed. Closing bug. 374344 2019-07-17 15:42:49 -0700 2019-07-17 16:52:48 -0700 Patch bug-199887-20190717154248.patch text/plain 2481 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyNzM2NWIzZTc4YjQyMDI1 M2Y1MDhjYjQ4MTViZDAyNzJmNTQ2MzcuLmQyMTVkNThhYjIxNTYyYTQyYWM2NGU3YmFhZTcwMTVl MTRiNDNkY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDctMTcgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQcm92aWRlIGEgTlNVUkwgY2F0 ZW9ncnkgdG8gdGVsbCBBcHBTU08gS2VyYmVyb3MgVVJMcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81MjMyMzE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNV UkxFeHRyYXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NP QXV0aG9yaXphdGlvbk5TVVJMRXh0cmFzLm1tOgorICAgICAgICAoK1tOU1VSTCBfd2ViX2NhblBl cmZvcm1LZXJiZXJvc0F1dGhvcml6YXRpb25XaXRoVVJMOl0pOgorCiAyMDE5LTA3LTE3ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBpbmcgaW50byBhIGNl bGwgaW4gYSBHb29nbGUgU2hlZXQgbGFncyBiZWhpbmQgYnkgb25lIGNoYXJhY3RlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0 aG9yaXphdGlvbk5TVVJMRXh0cmFzLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9T T0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNVUkxFeHRyYXMuaAppbmRleCAxMDNkMDU3 OTI0YTVjODhiYTMxOWU0ZDc2NTk0OWFkOTk4MzE0MTIyLi43OGM2OWUyY2JkMTFkYWY4OWZhMDQy NDBlZWE0ZjMwZGQzYjAzMGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNVUkxFeHRyYXMuaAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0 aW9uTlNVUkxFeHRyYXMuaApAQCAtMjUsOSArMjUsMTIgQEAKIAogI3ByYWdtYSBvbmNlCiAKLS8v IEZJWE1FIHJkYXI6Ly9wcm9ibGVtLzUwMDI4MjQ2IFJlbW92ZSB0aGUgZm9sbG93aW5nIG9uY2Ug dGhlIHJhZGFyIGlzIGZpeGVkLgogQGludGVyZmFjZSBOU1VSTCAoU09BdXRob3JpemF0aW9uRXh0 cmFzKQogCisvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzUwMDI4MjQ2PiBSZW1vdmUgdGhlIGZv bGxvd2luZyBvbmNlIHRoZSByYWRhciBpcyBmaXhlZC4KICsgKEJPT0wpX3dlYl9jYW5QZXJmb3Jt QXV0aG9yaXphdGlvbldpdGhVUkw6KE5TVVJMICopdXJsOwogCisvLyBGSVhNRTogPHJkYXI6Ly9w cm9ibGVtLzUzMjI0NDg1PiBSZW1vdmUgdGhlIGZvbGxvd2luZyBvbmNlIHRoZSByYWRhciBpcyBm aXhlZC4KKysgKEJPT0wpX3dlYl9jYW5QZXJmb3JtS2VyYmVyb3NBdXRob3JpemF0aW9uV2l0aFVS TDooTlNVUkwgKil1cmw7CisKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1dGhvcml6YXRpb25OU1VSTEV4dHJhcy5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1dGhvcml6 YXRpb25OU1VSTEV4dHJhcy5tbQppbmRleCBhNTU0N2FkMjc3M2NlM2I3OTg0OTc0MzdkMTNkYjNm NzcyOWM3ZmQwLi45OTc2NmQ0ODBlZmRmYTVjNmEzMDFlNTM0NTQ0NWY5Y2FhYzA1MmRjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09B dXRob3JpemF0aW9uTlNVUkxFeHRyYXMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Q29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0aG9yaXphdGlvbk5TVVJMRXh0cmFzLm1tCkBAIC0z OSw0ICszOSwxMyBAQCArIChCT09MKV93ZWJfY2FuUGVyZm9ybUF1dGhvcml6YXRpb25XaXRoVVJM OihOU1VSTCAqKXVybAogI2VuZGlmCiB9CiAKKysgKEJPT0wpX3dlYl9jYW5QZXJmb3JtS2VyYmVy b3NBdXRob3JpemF0aW9uV2l0aFVSTDooTlNVUkwgKil1cmwKK3sKKyNpZiBIQVZFKEFQUF9TU08p CisgICAgcmV0dXJuIFtQQUw6OmdldFNPQXV0aG9yaXphdGlvbkNsYXNzKCkgY2FuUGVyZm9ybUF1 dGhvcml6YXRpb25XaXRoVVJMOnVybCByZXNwb25zZUNvZGU6NDAxXTsKKyNlbHNlCisgICAgcmV0 dXJuIGZhbHNlOworI2VuZGlmCit9CisKIEBlbmQK 374351 2019-07-17 16:52:49 -0700 2019-07-17 17:15:07 -0700 Patch bug-199887-20190717165248.patch text/plain 2490 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyNzM2NWIzZTc4YjQyMDI1 M2Y1MDhjYjQ4MTViZDAyNzJmNTQ2MzcuLjE4NTU0ZmZjNmU3NmJjODVhNTVlN2FjMWViMDgwODI0 NTkyNTY3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDctMTcgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQcm92aWRlIGEgTlNVUkwgY2F0 ZW9ncnkgdG8gdGVsbCBBcHBTU08gS2VyYmVyb3MgVVJMcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81MjMyMzE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNV UkxFeHRyYXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NP QXV0aG9yaXphdGlvbk5TVVJMRXh0cmFzLm1tOgorICAgICAgICAoK1tOU1VSTCBfd2ViX3dpbGxQ ZXJmb3JtU09LZXJiZXJvc0F1dGhvcml6YXRpb25XaXRoVVJMOl0pOgorCiAyMDE5LTA3LTE3ICBE YW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBpbmcgaW50byBh IGNlbGwgaW4gYSBHb29nbGUgU2hlZXQgbGFncyBiZWhpbmQgYnkgb25lIGNoYXJhY3RlcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NP QXV0aG9yaXphdGlvbk5TVVJMRXh0cmFzLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNVUkxFeHRyYXMuaAppbmRleCAxMDNk MDU3OTI0YTVjODhiYTMxOWU0ZDc2NTk0OWFkOTk4MzE0MTIyLi44NzI3NzY2MzljMzc1NDRjMDky ZWQxYzU5YjY4NmU4ODRlOWI0N2Q3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uTlNVUkxFeHRyYXMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU09BdXRob3Jp emF0aW9uTlNVUkxFeHRyYXMuaApAQCAtMjUsOSArMjUsMTIgQEAKIAogI3ByYWdtYSBvbmNlCiAK LS8vIEZJWE1FIHJkYXI6Ly9wcm9ibGVtLzUwMDI4MjQ2IFJlbW92ZSB0aGUgZm9sbG93aW5nIG9u Y2UgdGhlIHJhZGFyIGlzIGZpeGVkLgogQGludGVyZmFjZSBOU1VSTCAoU09BdXRob3JpemF0aW9u RXh0cmFzKQogCisvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzUwMDI4MjQ2PiBSZW1vdmUgdGhl IGZvbGxvd2luZyBvbmNlIHRoZSByYWRhciBpcyBmaXhlZC4KICsgKEJPT0wpX3dlYl9jYW5QZXJm b3JtQXV0aG9yaXphdGlvbldpdGhVUkw6KE5TVVJMICopdXJsOwogCisvLyBGSVhNRTogPHJkYXI6 Ly9wcm9ibGVtLzUzMjI0NDg1PiBSZW1vdmUgdGhlIGZvbGxvd2luZyBvbmNlIHRoZSByYWRhciBp cyBmaXhlZC4KKysgKEJPT0wpX3dlYl93aWxsUGVyZm9ybVNPS2VyYmVyb3NBdXRob3JpemF0aW9u V2l0aFVSTDooTlNVUkwgKil1cmw7CisKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1dGhvcml6YXRpb25OU1VSTEV4dHJh cy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1 dGhvcml6YXRpb25OU1VSTEV4dHJhcy5tbQppbmRleCBhNTU0N2FkMjc3M2NlM2I3OTg0OTc0Mzdk MTNkYjNmNzcyOWM3ZmQwLi42NWM5Y2RlZjQ2MGYxYTQ0NzY2NjRjY2VjYTkwYmFiM2QzZDU4ZDJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRp b24vU09BdXRob3JpemF0aW9uTlNVUkxFeHRyYXMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0aG9yaXphdGlvbk5TVVJMRXh0cmFzLm1t CkBAIC0zOSw0ICszOSwxMyBAQCArIChCT09MKV93ZWJfY2FuUGVyZm9ybUF1dGhvcml6YXRpb25X aXRoVVJMOihOU1VSTCAqKXVybAogI2VuZGlmCiB9CiAKKysgKEJPT0wpX3dlYl93aWxsUGVyZm9y bVNPS2VyYmVyb3NBdXRob3JpemF0aW9uV2l0aFVSTDooTlNVUkwgKil1cmwKK3sKKyNpZiBIQVZF KEFQUF9TU08pCisgICAgcmV0dXJuIFtQQUw6OmdldFNPQXV0aG9yaXphdGlvbkNsYXNzKCkgY2Fu UGVyZm9ybUF1dGhvcml6YXRpb25XaXRoVVJMOnVybCByZXNwb25zZUNvZGU6NDAxXTsKKyNlbHNl CisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIEBlbmQK