199882 2019-07-17 14:23:26 -0700 Force useLLInt to true on arm64_32 2019-07-17 16:12:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff ryanhaddad saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1553684 0 keith_miller 2019-07-17 14:23:26 -0700 Force useLLInt to true on arm64_32 1553686 1 374331 keith_miller 2019-07-17 14:26:35 -0700 Created attachment 374331 Patch 1553687 2 keith_miller 2019-07-17 14:27:15 -0700 rdar://problem/53207586 1553690 3 374331 ysuzuki 2019-07-17 14:35:05 -0700 Comment on attachment 374331 Patch r=me 1553691 4 374331 mark.lam 2019-07-17 14:39:47 -0700 Comment on attachment 374331 Patch The reason we went with an assertion failure before instead of auto-forcing the LLInt on is so that we don’t end up silently running misconfigured tests, and thinking everything is dandy when we didn’t actually run with the intended config. The better fix is to skip those tests if the JIT is not available for a certain target. I’m ok with landing this patch as a workaround until we can implement the better fix. If you want to do that, please #if the change on arm64_32, and add a FiXME so that it can be properly fixed later. r=me conditional on the above. 1553701 5 keith_miller 2019-07-17 14:46:55 -0700 (In reply to Mark Lam from comment #4) > Comment on attachment 374331 [details] > Patch > > The reason we went with an assertion failure before instead of auto-forcing > the LLInt on is so that we don’t end up silently running misconfigured > tests, and thinking everything is dandy when we didn’t actually run with the > intended config. The better fix is to skip those tests if the JIT is not > available for a certain target. I’m ok with landing this patch as a > workaround until we can implement the better fix. If you want to do that, > please #if the change on arm64_32, and add a FiXME so that it can be > properly fixed later. We already do similar things for !ENABLE(JIT) where we force the JIT flag to false. The upside of this change is that if we enable JIT on arm64_32 the "fix" will stop working. > > r=me conditional on the above. 1553738 6 374331 commit-queue 2019-07-17 16:12:08 -0700 Comment on attachment 374331 Patch Clearing flags on attachment: 374331 Committed r247543: <https://trac.webkit.org/changeset/247543> 1553739 7 commit-queue 2019-07-17 16:12:10 -0700 All reviewed patches have been landed. Closing bug. 374331 2019-07-17 14:26:35 -0700 2019-07-17 16:12:08 -0700 Patch bug-199882-20190717142633.patch text/plain 1567 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YWNlYmJkYWNjMjA5ZTcwZWQ5MzlhZGJlYTIwNDkxMDdjZTcwYjFiLi41ZjhiMjNjMGZiZTYzYWJh NGU4MmQwNmEwMDdjOTg5MTlmYjUzOWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNy0xNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGb3JjZSB1c2VMTEludCB0byB0cnVlIG9uIGFybTY0XzMyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk4ODIKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUzMjA3NTg2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNvbWUganNjIHRlc3RzIHNldCB1c2VMTEludD1mYWxzZSBi dXQgb24gYXJtNjRfMzIgd2UgZG9uJ3Qgc3VwcG9ydCB0aGUgSklULgorICAgICAgICBUaGlzIGNh dXNlcyB0aGUgb3B0aW9uIGNvaGVyZW5jeSBjaGVja2VyIHRvIGdldCBhbmdyeS4gV2Ugc2hvdWxk IGZvcmNlCisgICAgICAgIHVzZUxMSW50PXRydWUgb24gYXJtNjRfMzIgdW5sZXNzIHVzZUpJVD10 cnVlLgorCisgICAgICAgICogcnVudGltZS9PcHRpb25zLmNwcDoKKyAgICAgICAgKEpTQzo6cmVj b21wdXRlRGVwZW5kZW50T3B0aW9ucyk6CisKIDIwMTktMDctMTUgIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgSlNHbG9iYWxPYmplY3QgdHlwZSBtYWNy b3Mgc2hvdWxkIHN1cHBvcnQgZmVhdHVyZSBmbGFncyBhbmQgV2Vha1JlZiBzaG91bGQgaGF2ZSBv bmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKaW5kZXggYzY1YzZk YmQzNTkyMDAwYjYxN2ZiZGNmODM1OTJmZjFiNWM3MDE1YS4uOGNiODhmMjU2NDAxNTg5ODg5OWRi NDM1YmE5ZTVhNjNlM2FhMWQ4OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvT3B0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0 aW9ucy5jcHAKQEAgLTQyMSw2ICs0MjEsOSBAQCBzdGF0aWMgdm9pZCByZWNvbXB1dGVEZXBlbmRl bnRPcHRpb25zKCkKICAgICAgICAgT3B0aW9uczo6dXNlV2ViQXNzZW1ibHkoKSA9IGZhbHNlOwog ICAgIH0KIAorICAgIGlmICghaml0RW5hYmxlZEJ5RGVmYXVsdCgpICYmICFPcHRpb25zOjp1c2VK SVQoKSkKKyAgICAgICAgT3B0aW9uczo6dXNlTExJbnQoKSA9IHRydWU7CisKICAgICBpZiAoIU9w dGlvbnM6OnVzZVdlYkFzc2VtYmx5KCkpCiAgICAgICAgIE9wdGlvbnM6OnVzZUZhc3RUTFNGb3JX YXNtQ29udGV4dCgpID0gZmFsc2U7CiAgICAgCg==