199865 2019-07-17 09:03:10 -0700 Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa 2019-07-17 11:32:31 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue darin eric.carlson jer.noble webkit-bug-importer youennf oldest_to_newest 1553527 0 youennf 2019-07-17 09:03:10 -0700 Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa 1553532 1 374298 youennf 2019-07-17 09:06:43 -0700 Created attachment 374298 Patch 1553533 2 webkit-bug-importer 2019-07-17 09:06:55 -0700 <rdar://problem/53205430> 1553541 3 374298 darin 2019-07-17 09:23:33 -0700 Comment on attachment 374298 Patch This looks like a fine way to fix this case. Any ideas on how to notice in the future when we accidentally log on non-main threads? 1553542 4 darin 2019-07-17 09:23:55 -0700 Also, is there an easy way to make Logger itself handle this so we don’t push the responsibility onto all the callers? 1553586 5 youennf 2019-07-17 11:11:21 -0700 Yes, I think some refactoring in LoggerHelper is probably needed to make it stronger/easier to use. 1553601 6 374298 commit-queue 2019-07-17 11:32:30 -0700 Comment on attachment 374298 Patch Clearing flags on attachment: 374298 Committed r247525: <https://trac.webkit.org/changeset/247525> 1553602 7 commit-queue 2019-07-17 11:32:31 -0700 All reviewed patches have been landed. Closing bug. 374298 2019-07-17 09:06:43 -0700 2019-07-17 11:32:30 -0700 Patch bug-199865-20190717090642.patch text/plain 3857 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmEyNmFmMWU4OWExYmY3 YjBlODVlMDhiNGYyMGUwZTMwZDhlZTYzNC4uYjdiYTU5OWE1ZDlmNGM5ZjE2ZDU1MDhjZjYwZWE2 NzRjYmMwMWQxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTE3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBIb3AgdG8gdGhlIG1haW4g dGhyZWFkIHdoZW4gZG9pbmcgbG9nZ2luZyBpbiBSZWFsdGltZUluY29taW5nVmlkZW9Tb3VyY2VD b2NvYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5 ODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9n Z2VySGVscGVyIHJvdXRpbmVzIGFsbG93IGxvZ2dpbmcgbWVzc2FnZXMgaW4gc3lzdGVtIGNvbnNv bGUgYW5kIGluc3BlY3RvciBjb25zb2xlLgorICAgICAgICBUaGVzZSByb3V0aW5lcyBpdGVyYXRl IHRocm91Z2ggYSBWZWN0b3Igb2YgbG9nIG9ic2VydmVycyB3aGljaCBpcyBub3QgdGhyZWFkIHNh ZmUuCisgICAgICAgIERvY3VtZW50LCB0aGUgbWFpbiBsb2cgb2JzZXJ2ZXIsIGFsc28gZXhwZWN0 cyB0byBiZSBjYWxsZWQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBNYW51YWxseSB0ZXN0 ZWQgKHdyaXRpbmcgYSBsYXlvdXQgdGVzdCBmb3IgdGhpcyB3b3VsZCByZXF1aXJlIG1vcmUgdGhh biAyIHNlY29uZHMpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0 aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRp bWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2E6Ok9uRnJhbWUpOgorCiAyMDE5LTA3LTE3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcmVsZWFzZSBsb2dn aW5nIHRvIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29h Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5j b21pbmdWaWRlb1NvdXJjZUNvY29hLm1tCmluZGV4IGU0NmQwNzUyNzlkOTgwYjhkMjFmMGRhM2Jh NmFkZjU1MjYzZGY3MzAuLjE3ZWJkNjZkOGViNTUwNzI4OGVhMGQ1YWM3OTc3NmJlMmUxZmMyZTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFs dGltZUluY29taW5nVmlkZW9Tb3VyY2VDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2EubW0K QEAgLTE1OCwxMyArMTU4LDE4IEBAIHZvaWQgUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29j b2E6Ok9uRnJhbWUoY29uc3Qgd2VicnRjOjpWaWRlb0ZyYW1lJiBmcmFtZSkKICAgICAgICAgcmV0 dXJuOwogCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECi0gICAgaWYgKCEoKyttX251bWJlck9m RnJhbWVzICUgNjApKQotICAgICAgICBBTFdBWVNfTE9HX0lGKGxvZ2dlclB0cigpLCBMT0dJREVO VElGSUVSLCAiZnJhbWUgIiwgbV9udW1iZXJPZkZyYW1lcyk7CisgICAgaWYgKCEoKyttX251bWJl ck9mRnJhbWVzICUgNjApKSB7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3Rl Y3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgbnVtYmVyT2ZGcmFtZXMgPSBtX251bWJlck9mRnJh bWVzXSB7CisgICAgICAgICAgICBBTFdBWVNfTE9HX0lGKGxvZ2dlclB0cigpLCBMT0dJREVOVElG SUVSLCAiZnJhbWUgIiwgbnVtYmVyT2ZGcmFtZXMpOworICAgICAgICB9KTsKKyAgICB9CiAjZW5k aWYKIAogICAgIGF1dG8gcGl4ZWxCdWZmZXIgPSBwaXhlbEJ1ZmZlckZyb21WaWRlb0ZyYW1lKGZy YW1lKTsKICAgICBpZiAoIXBpeGVsQnVmZmVyKSB7Ci0gICAgICAgIEVSUk9SX0xPR19JRihsb2dn ZXJQdHIoKSwgTE9HSURFTlRJRklFUiwgIkZhaWxlZCB0byBnZXQgYSBwaXhlbCBidWZmZXIgZnJv bSBhIGZyYW1lIik7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3RlY3RlZFRo aXMgPSBtYWtlUmVmKCp0aGlzKV0geworICAgICAgICAgICAgRVJST1JfTE9HX0lGKGxvZ2dlclB0 cigpLCBMT0dJREVOVElGSUVSLCAiRmFpbGVkIHRvIGdldCBhIHBpeGVsIGJ1ZmZlciBmcm9tIGEg ZnJhbWUiKTsKKyAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTE3OCw3 ICsxODMsOSBAQCB2b2lkIFJlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29hOjpPbkZyYW1l KGNvbnN0IHdlYnJ0Yzo6VmlkZW9GcmFtZSYgZnJhbWUpCiAgICAgQ01WaWRlb0Zvcm1hdERlc2Ny aXB0aW9uUmVmIGZvcm1hdERlc2NyaXB0aW9uOwogICAgIE9TU3RhdHVzIG9zdGF0dXMgPSBDTVZp ZGVvRm9ybWF0RGVzY3JpcHRpb25DcmVhdGVGb3JJbWFnZUJ1ZmZlcihrQ0ZBbGxvY2F0b3JEZWZh dWx0LCAoQ1ZJbWFnZUJ1ZmZlclJlZilwaXhlbEJ1ZmZlciwgJmZvcm1hdERlc2NyaXB0aW9uKTsK ICAgICBpZiAob3N0YXR1cyAhPSBub0VycikgewotICAgICAgICBFUlJPUl9MT0dfSUYobG9nZ2Vy UHRyKCksIExPR0lERU5USUZJRVIsICJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBDTVZpZGVvRm9ybWF0 RGVzY3JpcHRpb24gd2l0aCBlcnJvciAiLCBzdGF0aWNfY2FzdDxpbnQ+KG9zdGF0dXMpKTsKKyAg ICAgICAgY2FsbE9uTWFpblRocmVhZChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRo aXMpLCBvc3RhdHVzXSB7CisgICAgICAgICAgICBFUlJPUl9MT0dfSUYobG9nZ2VyUHRyKCksIExP R0lERU5USUZJRVIsICJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBDTVZpZGVvRm9ybWF0RGVzY3JpcHRp b24gd2l0aCBlcnJvciAiLCBzdGF0aWNfY2FzdDxpbnQ+KG9zdGF0dXMpKTsKKyAgICAgICAgfSk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTE4Niw3ICsxOTMsOSBAQCB2b2lkIFJlYWx0 aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29hOjpPbkZyYW1lKGNvbnN0IHdlYnJ0Yzo6VmlkZW9G cmFtZSYgZnJhbWUpCiAgICAgb3N0YXR1cyA9IENNU2FtcGxlQnVmZmVyQ3JlYXRlUmVhZHlXaXRo SW1hZ2VCdWZmZXIoa0NGQWxsb2NhdG9yRGVmYXVsdCwgKENWSW1hZ2VCdWZmZXJSZWYpcGl4ZWxC dWZmZXIsIGZvcm1hdERlc2NyaXB0aW9uLCAmdGltaW5nSW5mbywgJnNhbXBsZUJ1ZmZlcik7CiAg ICAgQ0ZSZWxlYXNlKGZvcm1hdERlc2NyaXB0aW9uKTsKICAgICBpZiAob3N0YXR1cyAhPSBub0Vy cikgewotICAgICAgICBFUlJPUl9MT0dfSUYobG9nZ2VyUHRyKCksIExPR0lERU5USUZJRVIsICJG YWlsZWQgdG8gY3JlYXRlIHRoZSBzYW1wbGUgYnVmZmVyIHdpdGggZXJyb3IgIiwgc3RhdGljX2Nh c3Q8aW50Pihvc3RhdHVzKSk7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3Rl Y3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgb3N0YXR1c10geworICAgICAgICAgICAgRVJST1Jf TE9HX0lGKGxvZ2dlclB0cigpLCBMT0dJREVOVElGSUVSLCAiRmFpbGVkIHRvIGNyZWF0ZSB0aGUg c2FtcGxlIGJ1ZmZlciB3aXRoIGVycm9yICIsIHN0YXRpY19jYXN0PGludD4ob3N0YXR1cykpOwor ICAgICAgICB9KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo=