199845 2019-07-16 18:34:58 -0700 Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine. 2019-07-17 10:06:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1553408 0 andresg_22 2019-07-16 18:34:58 -0700 Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine. 1553411 1 374270 andresg_22 2019-07-16 18:48:51 -0700 Created attachment 374270 Patch 1553417 2 andresg_22 2019-07-16 19:29:42 -0700 <rdar://problem/53121017> 1553425 3 374270 cfleizach 2019-07-16 19:57:38 -0700 Comment on attachment 374270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374270&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970 > - if (!lineCount || !m_renderer) NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. also probably sufficient to check if it’s equals to nsnotfound. I think it’s already uint max so it won’t matter checking higher > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983 > + || visiblePos.equals(savedVisiblePos)) surprised the == operator doesn’t call .equals directly 1553446 4 374279 andresg_22 2019-07-16 21:21:20 -0700 Created attachment 374279 Patch 1553448 5 andresg_22 2019-07-16 21:29:10 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 374270 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374270&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970 > > - if (!lineCount || !m_renderer) > > NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. > also probably sufficient to check if it’s equals to nsnotfound. I think it’s > already uint max so it won’t matter checking higher > Done. > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983 > > + || visiblePos.equals(savedVisiblePos)) > > surprised the == operator doesn’t call .equals directly The equals method has a FIXME comment in the header file: // FIXME: Combine this function with operator== and looking at the implementation, it does a lot more than operator==. 1553551 6 374279 commit-queue 2019-07-17 10:06:02 -0700 Comment on attachment 374279 Patch Clearing flags on attachment: 374279 Committed r247519: <https://trac.webkit.org/changeset/247519> 1553552 7 commit-queue 2019-07-17 10:06:04 -0700 All reviewed patches have been landed. Closing bug. 374270 2019-07-16 18:48:51 -0700 2019-07-16 21:21:17 -0700 Patch bug-199845-20190716214850.patch text/plain 3193 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTAyYWQ1OWNmYWNhNGNj N2VjZDIzYzVhY2ViNmViOTk0NGFmOTRmMi4uNTAxYWMwZmM2MjEwN2ZkOTliMmI1YzA4MDU0Y2M0 ZGQyZDMxMWE2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA3LTE2ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5nIGluIFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlRm9y TGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 OTg0NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTMxMjEwMTc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBBZGRlZCBjaGVjayBmb3IgdXBwZXIg Ym91bmQgTlNOb3RGb3VuZCBmb3IgcGFyYW1ldGVyIHRvIHZpc2libGVQb3NpdGlvblJhbmdlRm9y TGluZS4KKyAgICAgICAgLSBGaXhlZCBzaWduZWQvdW5zaWduZWQgaXNzdWUgZm9yIEFYVGV4dE1h cmtlclJhbmdlRm9yTGluZSBhdHRyaWJ1dGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdDo6dmlzaWJsZVBvc2l0aW9uUmFuZ2VGb3JMaW5lIGNvbnN0KToKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1h Yy5tbToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJp bGl0eUF0dHJpYnV0ZVZhbHVlOmZvclBhcmFtZXRlcjpdKToKKwogMjAxOS0wNy0xNiAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSG9wIHRvIG1haW4gdGhyZWFk IGZvciByZWxlYXNlIGxvZ2dpbmcgaW4gUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcAppbmRleCA5ZTRlYTNhYjQyODE5NDEzYTc1YzRjOGM3MDlmNDE3OThkNzUz NDZlLi5hZWMxODIyNzllYzBhZDFjNjRmZDg4MTViYjVjMDZhZjVhNDBkOWExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdC5jcHAKQEAgLTE5NjcsNyArMTk2Nyw3IEBAIFZpc2libGVQb3NpdGlvblJhbmdlIEFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlKCkgY29uc3QKIAog VmlzaWJsZVBvc2l0aW9uUmFuZ2UgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dmlzaWJsZVBv c2l0aW9uUmFuZ2VGb3JMaW5lKHVuc2lnbmVkIGxpbmVDb3VudCkgY29uc3QKIHsKLSAgICBpZiAo IWxpbmVDb3VudCB8fCAhbV9yZW5kZXJlcikKKyAgICBpZiAoIWxpbmVDb3VudCB8fCBsaW5lQ291 bnQgPj0gTlNOb3RGb3VuZCB8fCAhbV9yZW5kZXJlcikKICAgICAgICAgcmV0dXJuIFZpc2libGVQ b3NpdGlvblJhbmdlKCk7CiAgICAgCiAgICAgLy8gaXRlcmF0ZSBvdmVyIHRoZSBsaW5lcwpAQCAt MTk3OCw3ICsxOTc4LDkgQEAgVmlzaWJsZVBvc2l0aW9uUmFuZ2UgQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdDo6dmlzaWJsZVBvc2l0aW9uUmFuZ2VGb3JMaW5lKHVuc2kKICAgICB3aGlsZSAoLS1s aW5lQ291bnQpIHsKICAgICAgICAgc2F2ZWRWaXNpYmxlUG9zID0gdmlzaWJsZVBvczsKICAgICAg ICAgdmlzaWJsZVBvcyA9IG5leHRMaW5lUG9zaXRpb24odmlzaWJsZVBvcywgMCk7Ci0gICAgICAg IGlmICh2aXNpYmxlUG9zLmlzTnVsbCgpIHx8IHZpc2libGVQb3MgPT0gc2F2ZWRWaXNpYmxlUG9z KQorICAgICAgICBpZiAodmlzaWJsZVBvcy5pc051bGwoKQorICAgICAgICAgICAgfHwgdmlzaWJs ZVBvcyA9PSBzYXZlZFZpc2libGVQb3MKKyAgICAgICAgICAgIHx8IHZpc2libGVQb3MuZXF1YWxz KHNhdmVkVmlzaWJsZVBvcykpCiAgICAgICAgICAgICByZXR1cm4gVmlzaWJsZVBvc2l0aW9uUmFu Z2UoKTsKICAgICB9CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbSBiL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1t CmluZGV4IDI5ZmY0ZDAyOTY3NTYzZmM3N2NiMmFhNzg1YWQyMzFlNzUxMTI2YTMuLjk0MDcwZWVj NzlmM2E2ZjM1MWIzYjBkYWY5NmJjNDdlODVjODU1NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyTWFjLm1tCkBAIC00MjQ3LDcgKzQyNDcsNyBAQCBJR05PUkVfV0FSTklOR1Nf RU5ECiAgICAgfQogICAgIAogICAgIGlmIChbYXR0cmlidXRlIGlzRXF1YWxUb1N0cmluZzpAIkFY VGV4dE1hcmtlclJhbmdlRm9yTGluZSJdKSB7Ci0gICAgICAgIFZpc2libGVQb3NpdGlvblJhbmdl IHZwUmFuZ2UgPSBtX29iamVjdC0+dmlzaWJsZVBvc2l0aW9uUmFuZ2VGb3JMaW5lKFtudW1iZXIg aW50VmFsdWVdKTsKKyAgICAgICAgVmlzaWJsZVBvc2l0aW9uUmFuZ2UgdnBSYW5nZSA9IG1fb2Jq ZWN0LT52aXNpYmxlUG9zaXRpb25SYW5nZUZvckxpbmUoW251bWJlciB1bnNpZ25lZEludFZhbHVl XSk7CiAgICAgICAgIHJldHVybiBbc2VsZiB0ZXh0TWFya2VyUmFuZ2VGcm9tVmlzaWJsZVBvc2l0 aW9uczp2cFJhbmdlLnN0YXJ0IGVuZFBvc2l0aW9uOnZwUmFuZ2UuZW5kXTsKICAgICB9CiAgICAg Cg== 374279 2019-07-16 21:21:20 -0700 2019-07-17 10:06:02 -0700 Patch bug-199845-20190717002119.patch text/plain 2890 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTAyYWQ1OWNmYWNhNGNj N2VjZDIzYzVhY2ViNmViOTk0NGFmOTRmMi4uNTAxYWMwZmM2MjEwN2ZkOTliMmI1YzA4MDU0Y2M0 ZGQyZDMxMWE2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA3LTE2ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5nIGluIFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlRm9y TGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 OTg0NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTMxMjEwMTc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBBZGRlZCBjaGVjayBmb3IgdXBwZXIg Ym91bmQgTlNOb3RGb3VuZCBmb3IgcGFyYW1ldGVyIHRvIHZpc2libGVQb3NpdGlvblJhbmdlRm9y TGluZS4KKyAgICAgICAgLSBGaXhlZCBzaWduZWQvdW5zaWduZWQgaXNzdWUgZm9yIEFYVGV4dE1h cmtlclJhbmdlRm9yTGluZSBhdHRyaWJ1dGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdDo6dmlzaWJsZVBvc2l0aW9uUmFuZ2VGb3JMaW5lIGNvbnN0KToKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1h Yy5tbToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJp bGl0eUF0dHJpYnV0ZVZhbHVlOmZvclBhcmFtZXRlcjpdKToKKwogMjAxOS0wNy0xNiAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSG9wIHRvIG1haW4gdGhyZWFk IGZvciByZWxlYXNlIGxvZ2dpbmcgaW4gUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcAppbmRleCA5ZTRlYTNhYjQyODE5NDEzYTc1YzRjOGM3MDlmNDE3OThkNzUz NDZlLi5lOTUyMjhlNmMyYjM2YjA0MTI5ODg1NThlODRmODVlYzE2YTRmZmIwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdC5jcHAKQEAgLTE5NzgsNyArMTk3OCw5IEBAIFZpc2libGVQb3NpdGlvblJhbmdlIEFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlRm9yTGluZSh1bnNp CiAgICAgd2hpbGUgKC0tbGluZUNvdW50KSB7CiAgICAgICAgIHNhdmVkVmlzaWJsZVBvcyA9IHZp c2libGVQb3M7CiAgICAgICAgIHZpc2libGVQb3MgPSBuZXh0TGluZVBvc2l0aW9uKHZpc2libGVQ b3MsIDApOwotICAgICAgICBpZiAodmlzaWJsZVBvcy5pc051bGwoKSB8fCB2aXNpYmxlUG9zID09 IHNhdmVkVmlzaWJsZVBvcykKKyAgICAgICAgaWYgKHZpc2libGVQb3MuaXNOdWxsKCkKKyAgICAg ICAgICAgIHx8IHZpc2libGVQb3MgPT0gc2F2ZWRWaXNpYmxlUG9zCisgICAgICAgICAgICB8fCB2 aXNpYmxlUG9zLmVxdWFscyhzYXZlZFZpc2libGVQb3MpKQogICAgICAgICAgICAgcmV0dXJuIFZp c2libGVQb3NpdGlvblJhbmdlKCk7CiAgICAgfQogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMu bW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlck1hYy5tbQppbmRleCAyOWZmNGQwMjk2NzU2M2ZjNzdjYjJhYTc4NWFkMjMxZTc1 MTEyNmEzLi45NzI3YWM2ZTc0ZDVkNDg2MGVmODVmMDhkOTE1ZThlM2YxM2Q5MDlmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAtNDI0Nyw3ICs0MjQ3LDkgQEAg SUdOT1JFX1dBUk5JTkdTX0VORAogICAgIH0KICAgICAKICAgICBpZiAoW2F0dHJpYnV0ZSBpc0Vx dWFsVG9TdHJpbmc6QCJBWFRleHRNYXJrZXJSYW5nZUZvckxpbmUiXSkgewotICAgICAgICBWaXNp YmxlUG9zaXRpb25SYW5nZSB2cFJhbmdlID0gbV9vYmplY3QtPnZpc2libGVQb3NpdGlvblJhbmdl Rm9yTGluZShbbnVtYmVyIGludFZhbHVlXSk7CisgICAgICAgIFZpc2libGVQb3NpdGlvblJhbmdl IHZwUmFuZ2U7CisgICAgICAgIGlmIChbbnVtYmVyIHVuc2lnbmVkSW50ZWdlclZhbHVlXSAhPSBO U05vdEZvdW5kKQorICAgICAgICAgICAgdnBSYW5nZSA9IG1fb2JqZWN0LT52aXNpYmxlUG9zaXRp b25SYW5nZUZvckxpbmUoW251bWJlciB1bnNpZ25lZEludFZhbHVlXSk7CiAgICAgICAgIHJldHVy biBbc2VsZiB0ZXh0TWFya2VyUmFuZ2VGcm9tVmlzaWJsZVBvc2l0aW9uczp2cFJhbmdlLnN0YXJ0 IGVuZFBvc2l0aW9uOnZwUmFuZ2UuZW5kXTsKICAgICB9CiAgICAgCg==