19983 2008-07-10 15:23:17 -0700 DOM event handler onfocus not fired 2009-06-30 20:38:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED WONTFIX P2 Normal --- 1 anderson.calvin1 webkit-unassigned jberlin oldest_to_newest 85674 0 anderson.calvin1 2008-07-10 15:23:17 -0700 I. Steps: ----------- 1. Launch Safari 2. Launch the attached testcase 3. Try focussing the button (or) clicking on the button II. Issue: ----------------- Alert box should show up when onfocus fires. But it doesn't happen in Safari. III. Other browsers: ----------------------- IE7 : ok FF3 : ok Opera 9.50: ok IV. Safari nightly tested: version 3.1.1(525.17 )- r34603. Not working properly on Safari. V. Safari screenshot : Not Avalible 85675 1 22215 anderson.calvin1 2008-07-10 15:23:19 -0700 Created attachment 22215 reduction.zip 122535 2 swetha.shadow 2009-05-21 21:53:37 -0700 Hi, I have been analysing this bug, these are the observation made: In webkit\webcore\dom\eventtargetnode.cpp file, under EventTargetNode::handleLocalEvents(Event* event, bool useCapture) method if (r.eventType() == event->type().....) condition fails since the r.eventType() is "focus" and event->type() is "click". so the condition fails hence we wont get the alert message. I added event->type()==eventNames().clickEvent ORed with the r.eventType() == event->type()in the if statement. This would solve the problem. 128899 3 32021 jberlin 2009-06-29 14:52:44 -0700 Created attachment 32021 Tests the onfocus handler for a div It looks like the problem has moved to Node::handleLocalEvents as EventTargetNode no longer exists (http://trac.webkit.org/changeset/40675). 129246 4 32108 jberlin 2009-06-30 20:37:53 -0700 Created attachment 32108 Shows how the onfocus handler does get called if the tabindex is set to -1 In accordance with the HTML5 spec, the onfocus handler of a div will only be called if that div has a tabIndex set: http://dev.w3.org/html5/spec/Overview.html#focus 22215 2008-07-10 15:23:19 -0700 2008-07-10 15:23:19 -0700 reduction.zip reductions.zip application/octet-stream 534 anderson.calvin1 UEsDBAoAAAAAANqC0TgAAAAAAAAAAAAAAAALAAAAcmVkdWN0aW9ucy9QSwMEFAAAAAgAImLROBWF X9kkAQAA4QEAABcAAAByZWR1Y3Rpb25zL29uZm9jdXMuaHRtbH2RT0/DMAzF75P4Dl4ug0MJGpwg rQTtBIgxdihCHLPUqGFpUhpno9+e/kEIdkA5xf75PflZTLOnNH9dL+Auf1zC+vlmeZ8Cizh/OU85 z/JsbFycnkHeSOs1aWel4XyxYslElFSZRJQoi+RoIiokCSVRHeFH0LuYKWcJLUXU1sjg+xczwk/i /egVqFI2HikOPpJeac06nf4J0mQwgRXuIXMqVN0gCD5Uf6ysrDBmt2ixkeSaXw6LQtPaBM8O2OtA 5R/wEHjAdu+awv+DZOhVo+s+iEOKD0mIjSvaZNhC2zoQ7KQJ3WBqtNpChVMGUin0fottzOYMnH3r VvQxe5c7OYpfSoMNHc/mMEr0CcImEDkLA+yxmJ2wvt4pjw02evLBXvDhNl9QSwECFAAKAAAAAADa gtE4AAAAAAAAAAAAAAAACwAAAAAAAAAAABAAAAAAAAAAcmVkdWN0aW9ucy9QSwECFAAUAAAACAAi YtE4FYVf2SQBAADhAQAAFwAAAAAAAAAAACAAAAApAAAAcmVkdWN0aW9ucy9vbmZvY3VzLmh0bWxQ SwUGAAAAAAIAAgB+AAAAggEAAAAA 32021 2009-06-29 14:52:44 -0700 2009-06-29 14:52:44 -0700 Tests the onfocus handler for a div TestDivOnFocus.htm text/html 1334 jberlin PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiID4NCjxo ZWFkPg0KICAgIDx0aXRsZT5UZXN0IG9uRm9jdXMgSGFuZGxpbmcgZm9yIGEgZGl2PC90aXRsZT4N Cg0KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4NCiAgICAudGVzdCB7DQogICAgICAgIGJhY2tncm91 bmQtY29sb3I6ICNjY2M7DQogICAgICAgIGJvcmRlcjogMXB4IHNvbGlkICMzMzM7DQogICAgICAg IHdpZHRoOiAyMDBweDsNCiAgICAgICAgdGV4dC1hbGlnbjogY2VudGVyOw0KICAgICAgICBtYXJn aW46IDEwcHg7DQogICAgfQ0KPC9zdHlsZT4NCg0KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPg0KICAgIGZ1bmN0aW9uIHJlcG9ydEZvY3VzKCkgew0KICAgICAgICB2YXIgcmVzdWx0ID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7DQogICAgICAgIHJlc3VsdC5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiVGhlIG9uZm9jdXMgd29ya2VkIGFuZCB0aGUgaGFu ZGxlciB3YXMgY2FsbGVkISIpKTsNCiAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChy ZXN1bHQpOw0KICAgIH0NCiAgICANCiAgICBmdW5jdGlvbiByZXBvcnRDbGljaygpIHsNCiAgICAg ICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOw0KICAgICAgICBy ZXN1bHQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIlRoZSBvbmNsaWNrIHdv cmtlZCBhbmQgdGhlIGhhbmRsZXIgd2FzIGNhbGxlZCEiKSk7DQogICAgICAgIGRvY3VtZW50LmJv ZHkuYXBwZW5kQ2hpbGQocmVzdWx0KTsNCiAgICB9DQo8L3NjcmlwdD4NCg0KPC9oZWFkPg0KPGJv ZHk+DQogICA8ZGl2IG9uZm9jdXM9InJlcG9ydEZvY3VzKCkiIGNsYXNzPSJ0ZXN0Ij4NCiAgIElm IHlvdSBjbGljayBvbiBtZSwgeW91IHNob3VsZCBzZWUgYSBsaW5lIGFwcGVuZGVkIHRoYXQgc2F5 cyB0aGF0IHRoZSBPTkZPQ1VTIGhhbmRsZXIgd2FzIGNhbGxlZC4NCiAgIDwvZGl2Pg0KICAgPGJy IC8+DQogICA8ZGl2IG9uY2xpY2s9InJlcG9ydENsaWNrKCkiIGNsYXNzPSJ0ZXN0Ij4NCiAgIElm IHlvdSBjbGljayBvbiBtZSwgeW91IHNob3VsZCBzZWUgYSBsaW5lIGFwcGVuZGVkIHRoYXQgc2F5 cyB0aGF0IHRoZSBPTkNMSUNLIGhhbmRsZXIgd2FzIGNhbGxlZC4NCiAgIDwvZGl2Pg0KICAgPGJy IC8+DQo8L2JvZHk+DQo8L2h0bWw+DQo= 32108 2009-06-30 20:37:53 -0700 2009-06-30 20:37:53 -0700 Shows how the onfocus handler does get called if the tabindex is set to -1 TestDivOnFocusWithTabIndex.htm text/html 1392 jberlin PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiID4NCjxo ZWFkPg0KICAgIDx0aXRsZT5UZXN0IG9uRm9jdXMgSGFuZGxpbmcgZm9yIGEgZGl2IHdpdGggdGFi SW5kZXg8L3RpdGxlPg0KDQo8c3R5bGUgdHlwZT0idGV4dC9jc3MiPg0KICAgIC50ZXN0IHsNCiAg ICAgICAgYmFja2dyb3VuZC1jb2xvcjogI2NjYzsNCiAgICAgICAgYm9yZGVyOiAxcHggc29saWQg IzMzMzsNCiAgICAgICAgd2lkdGg6IDIwMHB4Ow0KICAgICAgICB0ZXh0LWFsaWduOiBjZW50ZXI7 DQogICAgICAgIG1hcmdpbjogMTBweDsNCiAgICB9DQo8L3N0eWxlPg0KDQo8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCI+DQogICAgZnVuY3Rpb24gcmVwb3J0Rm9jdXMoKSB7DQogICAgICAg IHZhciByZXN1bHQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsNCiAgICAgICAgcmVz dWx0LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJUaGUgb25mb2N1cyB3b3Jr ZWQgYW5kIHRoZSBoYW5kbGVyIHdhcyBjYWxsZWQhIikpOw0KICAgICAgICBkb2N1bWVudC5ib2R5 LmFwcGVuZENoaWxkKHJlc3VsdCk7DQogICAgfQ0KICAgIA0KICAgIGZ1bmN0aW9uIHJlcG9ydENs aWNrKCkgew0KICAgICAgICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2 Iik7DQogICAgICAgIHJlc3VsdC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgi VGhlIG9uY2xpY2sgd29ya2VkIGFuZCB0aGUgaGFuZGxlciB3YXMgY2FsbGVkISIpKTsNCiAgICAg ICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChyZXN1bHQpOw0KICAgIH0NCjwvc2NyaXB0Pg0K DQo8L2hlYWQ+DQo8Ym9keT4NCiAgIDxkaXYgb25mb2N1cz0icmVwb3J0Rm9jdXMoKSIgY2xhc3M9 InRlc3QiIHRhYmluZGV4PS0xPg0KICAgSWYgeW91IGNsaWNrIG9uIG1lLCB5b3Ugc2hvdWxkIHNl ZSBhIGxpbmUgYXBwZW5kZWQgdGhhdCBzYXlzIHRoYXQgdGhlIE9ORk9DVVMgaGFuZGxlciB3YXMg Y2FsbGVkIGJlY2F1c2UgSSBoYXZlIGEgdGFiSW5kZXggb2YgLTEuDQogICA8L2Rpdj4NCiAgIDxi ciAvPg0KICAgPGRpdiBvbmNsaWNrPSJyZXBvcnRDbGljaygpIiBjbGFzcz0idGVzdCI+DQogICBJ ZiB5b3UgY2xpY2sgb24gbWUsIHlvdSBzaG91bGQgc2VlIGEgbGluZSBhcHBlbmRlZCB0aGF0IHNh eXMgdGhhdCB0aGUgT05DTElDSyBoYW5kbGVyIHdhcyBjYWxsZWQuDQogICA8L2Rpdj4NCiAgIDxi ciAvPg0KPC9ib2R5Pg0KPC9odG1sPg0K