199825 2019-07-16 03:43:29 -0700 Fix build warning because of missing super_class initializer 2019-07-16 13:09:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fred.wang fred.wang commit-queue jbedard thorton webkit-bug-importer oldest_to_newest 1553159 0 fred.wang 2019-07-16 03:43:29 -0700 This happens in WebKit/UIProcess/ios/WKContentView.mm when building iOS 13 with XCode beta and public SDK. 1553160 1 374203 fred.wang 2019-07-16 03:48:20 -0700 Created attachment 374203 Patch 1553236 2 374203 jbedard 2019-07-16 11:09:57 -0700 Comment on attachment 374203 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374203&action=review > Source/WebKit/UIProcess/ios/WKContentView.mm:152 > + struct objc_super super { self, class_getSuperclass(object_getClass(self)) }; Looking through other code which set's struct values, seems that we prefer: struct objc_super super = { self, class_getSuperclass(object_getClass(self)) }; 1553262 3 374229 fred.wang 2019-07-16 12:07:50 -0700 Created attachment 374229 Patch 1553281 4 374229 commit-queue 2019-07-16 13:08:32 -0700 Comment on attachment 374229 Patch Clearing flags on attachment: 374229 Committed r247491: <https://trac.webkit.org/changeset/247491> 1553282 5 commit-queue 2019-07-16 13:08:34 -0700 All reviewed patches have been landed. Closing bug. 1553283 6 webkit-bug-importer 2019-07-16 13:09:15 -0700 <rdar://problem/53167674> 374203 2019-07-16 03:48:20 -0700 2019-07-16 12:07:46 -0700 Patch bug-199825-20190716124818.patch text/plain 1571 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0ZjgwOTgwYWMzZDkyNmQw MTJiNjg4YmY1NDBkYThjODg1ZTgyZmMuLjNiNzUwNjdiYzlhODFjZTVhYzg3MjA0YmFlODY3NzY0 ODFlZDg4NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDctMTYgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJl Y2F1c2Ugb2YgbWlzc2luZyBzdXBlcl9jbGFzcyBpbml0aWFsaXplcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODI1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXcubW06CisgICAgICAgIChrZXlDb21tYW5kc1BsYWNlaG9sZGVySGFja0ZvckV2ZXJub3Rl KToKKwogMjAxOS0wNy0xNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJlbW92ZSByZWR1bmRhbnQgV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3Vy YXRpb24gbWVtYmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 Lm1tCmluZGV4IDI2ZmY5NDc1YWJhNzU3NDBlYmUwMmEyNDQyMDQ0MTQyMDdjYmFlZjQuLmRjZDRi MmMwMGRlZmY1ZmY0MmIwYWJjNTNkNDQwN2JlM2U4YmJhODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCkBAIC0xNDksMTAgKzE0OSw3IEBACiAvLyBh cyBzb29uIGFzIHJlYXNvbmFibHkgcG9zc2libGUuIFNlZSA8cmRhcjovL3Byb2JsZW0vNTE3NTky NDc+Lgogc3RhdGljIE5TQXJyYXkgKmtleUNvbW1hbmRzUGxhY2Vob2xkZXJIYWNrRm9yRXZlcm5v dGUoaWQgc2VsZiwgU0VMIF9jbWQpCiB7Ci0gICAgc3RydWN0IG9iamNfc3VwZXIgc3VwZXIgeyAw IH07Ci0gICAgc3VwZXIucmVjZWl2ZXIgPSBzZWxmOwotICAgIHN1cGVyLnN1cGVyX2NsYXNzID0g Y2xhc3NfZ2V0U3VwZXJjbGFzcyhvYmplY3RfZ2V0Q2xhc3Moc2VsZikpOwotCisgICAgc3RydWN0 IG9iamNfc3VwZXIgc3VwZXIgeyBzZWxmLCBjbGFzc19nZXRTdXBlcmNsYXNzKG9iamVjdF9nZXRD bGFzcyhzZWxmKSkgfTsKICAgICB1c2luZyBTdXBlcktleUNvbW1hbmRzRnVuY3Rpb24gPSBOU0Fy cmF5ICooKikoc3RydWN0IG9iamNfc3VwZXIqLCBTRUwpOwogICAgIHJldHVybiByZWludGVycHJl dF9jYXN0PFN1cGVyS2V5Q29tbWFuZHNGdW5jdGlvbj4oJm9iamNfbXNnU2VuZFN1cGVyKSgmc3Vw ZXIsIEBzZWxlY3RvcihrZXlDb21tYW5kcykpOwogfQo= 374229 2019-07-16 12:07:50 -0700 2019-07-16 13:08:32 -0700 Patch bug-199825-20190716210748.patch text/plain 1573 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0ZjgwOTgwYWMzZDkyNmQw MTJiNjg4YmY1NDBkYThjODg1ZTgyZmMuLjNiNzUwNjdiYzlhODFjZTVhYzg3MjA0YmFlODY3NzY0 ODFlZDg4NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDctMTYgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJl Y2F1c2Ugb2YgbWlzc2luZyBzdXBlcl9jbGFzcyBpbml0aWFsaXplcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODI1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXcubW06CisgICAgICAgIChrZXlDb21tYW5kc1BsYWNlaG9sZGVySGFja0ZvckV2ZXJub3Rl KToKKwogMjAxOS0wNy0xNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJlbW92ZSByZWR1bmRhbnQgV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3Vy YXRpb24gbWVtYmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 Lm1tCmluZGV4IDI2ZmY5NDc1YWJhNzU3NDBlYmUwMmEyNDQyMDQ0MTQyMDdjYmFlZjQuLjg0Zjg1 NDc4OWMzNWJiMmI1NmRmNzE1ZmMzNmQ0ZTljN2ZkMzRlOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCkBAIC0xNDksMTAgKzE0OSw3IEBACiAvLyBh cyBzb29uIGFzIHJlYXNvbmFibHkgcG9zc2libGUuIFNlZSA8cmRhcjovL3Byb2JsZW0vNTE3NTky NDc+Lgogc3RhdGljIE5TQXJyYXkgKmtleUNvbW1hbmRzUGxhY2Vob2xkZXJIYWNrRm9yRXZlcm5v dGUoaWQgc2VsZiwgU0VMIF9jbWQpCiB7Ci0gICAgc3RydWN0IG9iamNfc3VwZXIgc3VwZXIgeyAw IH07Ci0gICAgc3VwZXIucmVjZWl2ZXIgPSBzZWxmOwotICAgIHN1cGVyLnN1cGVyX2NsYXNzID0g Y2xhc3NfZ2V0U3VwZXJjbGFzcyhvYmplY3RfZ2V0Q2xhc3Moc2VsZikpOwotCisgICAgc3RydWN0 IG9iamNfc3VwZXIgc3VwZXIgPSB7IHNlbGYsIGNsYXNzX2dldFN1cGVyY2xhc3Mob2JqZWN0X2dl dENsYXNzKHNlbGYpKSB9OwogICAgIHVzaW5nIFN1cGVyS2V5Q29tbWFuZHNGdW5jdGlvbiA9IE5T QXJyYXkgKigqKShzdHJ1Y3Qgb2JqY19zdXBlciosIFNFTCk7CiAgICAgcmV0dXJuIHJlaW50ZXJw cmV0X2Nhc3Q8U3VwZXJLZXlDb21tYW5kc0Z1bmN0aW9uPigmb2JqY19tc2dTZW5kU3VwZXIpKCZz dXBlciwgQHNlbGVjdG9yKGtleUNvbW1hbmRzKSk7CiB9Cg==