199824 2019-07-15 23:57:33 -0700 [GTK] Fix a build warning in JavaScriptCore/API/tests/testapi.c 2019-07-16 11:41:52 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park achristensen bugs-noreply commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo oldest_to_newest 1553136 0 jh718.park 2019-07-15 23:57:33 -0700 Fix the build warning message below. ../../Source/JavaScriptCore/API/tests/testapi.c: In function ‘main’: ../../Source/JavaScriptCore/API/tests/testapi.c:1392:5: warning: ignoring return value of ‘realpath’, declared with attribute warn_unused_result [-Wunused-result] realpath(argv[0], resolvedPath); 1553137 1 374197 jh718.park 2019-07-16 00:00:22 -0700 Created attachment 374197 Patch 1553138 2 374198 jh718.park 2019-07-16 00:01:13 -0700 Created attachment 374198 Patch 1553150 3 374198 ews-watchlist 2019-07-16 01:54:25 -0700 Comment on attachment 374198 Patch Attachment 374198 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12748861 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-baseline apiTests 1553151 4 jh718.park 2019-07-16 02:08:10 -0700 Could you please review this change? I think the jsc ews test failure result is nothing to do with this patch. 1553252 5 374198 commit-queue 2019-07-16 11:41:50 -0700 Comment on attachment 374198 Patch Clearing flags on attachment: 374198 Committed r247488: <https://trac.webkit.org/changeset/247488> 1553253 6 commit-queue 2019-07-16 11:41:52 -0700 All reviewed patches have been landed. Closing bug. 374197 2019-07-16 00:00:22 -0700 2019-07-16 00:01:09 -0700 Patch bug-199824-20190716155929.patch text/plain 1410 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YWNlYmJkYWNjMjA5ZTcwZWQ5MzlhZGJlYTIwNDkxMDdjZTcwYjFiLi4zODdjMzhlNDM5OTE0NDAy MDZmMTM4N2YwZWI3MDg0YWEzMWQ4NWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNy0xNSAgSm9vbmdodW4gUGFyayAgPHBqaDA3MThAZ21haWwuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBhIGJ1aWxkIHdhcm5pbmcgaW4gIEphdmFTY3JpcHRDb3Jl L0FQSS90ZXN0cy90ZXN0YXBpLmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5OTgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAgKG1haW4pOgorCiAy MDE5LTA3LTE1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEpTR2xvYmFsT2JqZWN0IHR5cGUgbWFjcm9zIHNob3VsZCBzdXBwb3J0IGZlYXR1cmUgZmxh Z3MgYW5kIFdlYWtSZWYgc2hvdWxkIGhhdmUgb25lCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv dGVzdHMvdGVzdGFwaS5jCmluZGV4IGZhMjQ1MzQ0YjUyOTA2NzA2YmI2MGU0NThlMzAxZGIzMWEw ZmI2NmQuLjMxNTBmZGIzYWViOTBiOTdmYWMxZWUyN2ZkYmMwZGRiOTNmODc2NTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCkBAIC0xMzg5LDcgKzEzODksOCBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogCiAjaWYgIU9TKFdJTkRPV1MpCiAg ICAgY2hhciByZXNvbHZlZFBhdGhbUEFUSF9NQVhdOwotICAgIHJlYWxwYXRoKGFyZ3ZbMF0sIHJl c29sdmVkUGF0aCk7IAorICAgIGlmICghcmVhbHBhdGgoYXJndlswXSwgcmVzb2x2ZWRQYXRoKSkK KyAgICAgICAgZnByaW50ZihzdGRvdXQsICJDb3VsZCBub3QgZ2V0IHRoZSBhYnNvbHV0ZSBwYXRo bmFtZSBmb3I6ICVzXG4iLCBhcmd2WzBdKTsKICAgICBjaGFyKiBuZXdDV0QgPSBkaXJuYW1lKHJl c29sdmVkUGF0aCk7CiAgICAgaWYgKGNoZGlyKG5ld0NXRCkpCiAgICAgICAgIGZwcmludGYoc3Rk b3V0LCAiQ291bGQgbm90IGNoZGlyIHRvOiAlc1xuIiwgbmV3Q1dEKTsK 374198 2019-07-16 00:01:13 -0700 2019-07-16 11:41:50 -0700 Patch bug-199824-20190716160020.patch text/plain 1409 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YWNlYmJkYWNjMjA5ZTcwZWQ5MzlhZGJlYTIwNDkxMDdjZTcwYjFiLi4yMjgxYmQ1ZjljYmZhZmI0 ODYwMjc5ZTYxMjE5YjkxMjMwNmRkNDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNy0xNSAgSm9vbmdodW4gUGFyayAgPHBqaDA3MThAZ21haWwuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBhIGJ1aWxkIHdhcm5pbmcgaW4gSmF2YVNjcmlwdENvcmUv QVBJL3Rlc3RzL3Rlc3RhcGkuYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk5ODI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBBUEkvdGVzdHMvdGVzdGFwaS5jOgorICAgICAgICAobWFpbik6CisKIDIw MTktMDctMTUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAg ICAgSlNHbG9iYWxPYmplY3QgdHlwZSBtYWNyb3Mgc2hvdWxkIHN1cHBvcnQgZmVhdHVyZSBmbGFn cyBhbmQgV2Vha1JlZiBzaG91bGQgaGF2ZSBvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90 ZXN0cy90ZXN0YXBpLmMKaW5kZXggZmEyNDUzNDRiNTI5MDY3MDZiYjYwZTQ1OGUzMDFkYjMxYTBm YjY2ZC4uMzE1MGZkYjNhZWI5MGI5N2ZhYzFlZTI3ZmRiYzBkZGI5M2Y4NzY1NiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKQEAgLTEzODksNyArMTM4OSw4IEBA IGludCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAKICNpZiAhT1MoV0lORE9XUykKICAg ICBjaGFyIHJlc29sdmVkUGF0aFtQQVRIX01BWF07Ci0gICAgcmVhbHBhdGgoYXJndlswXSwgcmVz b2x2ZWRQYXRoKTsgCisgICAgaWYgKCFyZWFscGF0aChhcmd2WzBdLCByZXNvbHZlZFBhdGgpKQor ICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIkNvdWxkIG5vdCBnZXQgdGhlIGFic29sdXRlIHBhdGhu YW1lIGZvcjogJXNcbiIsIGFyZ3ZbMF0pOwogICAgIGNoYXIqIG5ld0NXRCA9IGRpcm5hbWUocmVz b2x2ZWRQYXRoKTsKICAgICBpZiAoY2hkaXIobmV3Q1dEKSkKICAgICAgICAgZnByaW50ZihzdGRv dXQsICJDb3VsZCBub3QgY2hkaXIgdG86ICVzXG4iLCBuZXdDV0QpOwo=