199813 2019-07-15 16:20:49 -0700 Hop to main thread for release logging in RealtimeIncomingAudioSource 2019-07-16 08:09:49 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue eric.carlson jer.noble krollin webkit-bug-importer youennf oldest_to_newest 1553020 0 youennf 2019-07-15 16:20:49 -0700 Hop to main thread for release logging in RealtimeIncomingAudioSource 1553021 1 webkit-bug-importer 2019-07-15 16:23:17 -0700 <rdar://problem/53127693> 1553023 2 374163 youennf 2019-07-15 16:28:19 -0700 Created attachment 374163 patch 1553024 3 374163 cdumez 2019-07-15 16:32:02 -0700 Comment on attachment 374163 patch View in context: https://bugs.webkit.org/attachment.cgi?id=374163&action=review > Source/WebCore/ChangeLog:3 > + Hop to main thread for release logging in RealtimeIncomingAudioSource Could you please explain why in the change loge? Isn't it safe to call RELEASE_LOG() from another thread? 1553033 4 374166 youennf 2019-07-15 16:46:34 -0700 Created attachment 374166 patch 1553035 5 youennf 2019-07-15 16:49:46 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 374163 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374163&action=review > > > Source/WebCore/ChangeLog:3 > > + Hop to main thread for release logging in RealtimeIncomingAudioSource > > Could you please explain why in the change loge? Isn't it safe to call > RELEASE_LOG() from another thread? It is not thread safe, see Logger::log in Logger.h. I updated the change log. 1553182 6 374166 commit-queue 2019-07-16 08:09:47 -0700 Comment on attachment 374166 patch Clearing flags on attachment: 374166 Committed r247480: <https://trac.webkit.org/changeset/247480> 1553183 7 commit-queue 2019-07-16 08:09:49 -0700 All reviewed patches have been landed. Closing bug. 374163 2019-07-15 16:28:19 -0700 2019-07-15 16:46:34 -0700 patch patch text/plain 1810 youennf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YWQ4OWRlYWVlYy4uODMyNTFiYTM3NWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wNy0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CisKKyAgICAgICAgSG9wIHRvIG1haW4gdGhyZWFkIGZvciByZWxlYXNlIGxvZ2dpbmcgaW4gUmVh bHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTk4MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYW51YWxseSB0ZXN0ZWQgKHdyaXRpbmcgYSBsYXlvdXQgdGVzdCBm b3IgdGhpcyB3b3VsZCByZXF1aXJlIG1vcmUgdGhhbiAyIHNlY29uZHMpLgorCisgICAgICAgICog cGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29h LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29h OjpPbkRhdGEpOgorCiAyMDE5LTA3LTE1ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDczOTcsIHIyNDczNzgs IHIyNDczNjYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9tYWMvUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNv Y29hLmNwcAppbmRleCBhZjE1MjM0OGQ2My4uMmRmOWM0ODJjMjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZUluY29taW5nQXVkaW9T b3VyY2VDb2NvYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v bWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hLmNwcApAQCAtODcsOCArODcsMTEg QEAgdm9pZCBSZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYTo6T25EYXRhKGNvbnN0IHZv aWQqIGF1ZGlvRGF0YSwgaW50IGJpdHNQZXIKICAgICAgICAgbWVtY3B5KGF1ZGlvQnVmZmVyTGlz dC5idWZmZXIoMCktPm1EYXRhLCBhdWRpb0RhdGEsIGF1ZGlvQnVmZmVyTGlzdC5idWZmZXIoMCkt Pm1EYXRhQnl0ZVNpemUpOwogCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECi0gICAgaWYgKCEo KyttX2NodW5rc1JlY2VpdmVkICUgMjAwKSkKLSAgICAgICAgQUxXQVlTX0xPR19JRihsb2dnZXJQ dHIoKSwgTE9HSURFTlRJRklFUiwgImNodW5rICIsIG1fY2h1bmtzUmVjZWl2ZWQpOworICAgIGlm ICghKCsrbV9jaHVua3NSZWNlaXZlZCAlIDIwMCkpIHsKKyAgICAgICAgY2FsbE9uTWFpblRocmVh ZChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpXSB7CisgICAgICAgICAgICBB TFdBWVNfTE9HX0lGKGxvZ2dlclB0cigpLCBMT0dJREVOVElGSUVSLCAiY2h1bmsgIiwgbV9jaHVu a3NSZWNlaXZlZCk7CisgICAgICAgIH0pOworICAgIH0KICNlbmRpZgogCiAgICAgYXVkaW9TYW1w bGVzQXZhaWxhYmxlKG1lZGlhVGltZSwgYXVkaW9CdWZmZXJMaXN0LCBDQUF1ZGlvU3RyZWFtRGVz Y3JpcHRpb24obmV3RGVzY3JpcHRpb24pLCBudW1iZXJPZkZyYW1lcyk7Cg== 374166 2019-07-15 16:46:34 -0700 2019-07-16 08:09:47 -0700 patch patch text/plain 2085 youennf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YWQ4OWRlYWVlYy4uZDMwMDU2MmYzMGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNy0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CisKKyAgICAgICAgSG9wIHRvIG1haW4gdGhyZWFkIGZvciByZWxlYXNlIGxvZ2dpbmcgaW4gUmVh bHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTk4MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBMb2dnZXJIZWxwZXIgcm91dGluZXMgYWxsb3cgbG9nZ2luZyBtZXNz YWdlcyBpbiBzeXN0ZW0gY29uc29sZSBhbmQgaW5zcGVjdG9yIGNvbnNvbGUuCisgICAgICAgIFRo ZXNlIHJvdXRpbmVzIGl0ZXJhdGUgdGhyb3VnaCBhIFZlY3RvciBvZiBsb2cgb2JzZXJ2ZXJzIHdo aWNoIGlzIG5vdCB0aHJlYWQgc2FmZS4KKyAgICAgICAgRG9jdW1lbnQsIHRoZSBtYWluIGxvZyBv YnNlcnZlciwgYWxzbyBleHBlY3RzIHRvIGJlIGNhbGxlZCBvbiB0aGUgbWFpbiB0aHJlYWQuCisg ICAgICAgIE1hbnVhbGx5IHRlc3RlZCAod3JpdGluZyBhIGxheW91dCB0ZXN0IGZvciB0aGlzIHdv dWxkIHJlcXVpcmUgbW9yZSB0aGFuIDIgc2Vjb25kcykuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2E6Ok9uRGF0YSk6 CisKIDIwMTktMDctMTUgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0NzM5NywgcjI0NzM3OCwgcjI0NzM2Ni4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFs dGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwCmlu ZGV4IGFmMTUyMzQ4ZDYzLi4yZGY5YzQ4MmMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29h LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRp bWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwCkBAIC04Nyw4ICs4NywxMSBAQCB2b2lkIFJl YWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpPbkRhdGEoY29uc3Qgdm9pZCogYXVkaW9E YXRhLCBpbnQgYml0c1BlcgogICAgICAgICBtZW1jcHkoYXVkaW9CdWZmZXJMaXN0LmJ1ZmZlcigw KS0+bURhdGEsIGF1ZGlvRGF0YSwgYXVkaW9CdWZmZXJMaXN0LmJ1ZmZlcigwKS0+bURhdGFCeXRl U2l6ZSk7CiAKICNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQKLSAgICBpZiAoISgrK21fY2h1bmtz UmVjZWl2ZWQgJSAyMDApKQotICAgICAgICBBTFdBWVNfTE9HX0lGKGxvZ2dlclB0cigpLCBMT0dJ REVOVElGSUVSLCAiY2h1bmsgIiwgbV9jaHVua3NSZWNlaXZlZCk7CisgICAgaWYgKCEoKyttX2No dW5rc1JlY2VpdmVkICUgMjAwKSkgeworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCBw cm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldIHsKKyAgICAgICAgICAgIEFMV0FZU19MT0df SUYobG9nZ2VyUHRyKCksIExPR0lERU5USUZJRVIsICJjaHVuayAiLCBtX2NodW5rc1JlY2VpdmVk KTsKKyAgICAgICAgfSk7CisgICAgfQogI2VuZGlmCiAKICAgICBhdWRpb1NhbXBsZXNBdmFpbGFi bGUobWVkaWFUaW1lLCBhdWRpb0J1ZmZlckxpc3QsIENBQXVkaW9TdHJlYW1EZXNjcmlwdGlvbihu ZXdEZXNjcmlwdGlvbiksIG51bWJlck9mRnJhbWVzKTsK