199808 2019-07-15 14:22:24 -0700 Crash under DisplayRefreshMonitorManager::displayWasUpdated() 2019-07-16 19:51:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 199847 1 cdumez cdumez achristensen commit-queue ggaren pvollan rniwa sabouhallawa webkit-bug-importer oldest_to_newest 1552968 0 cdumez 2019-07-15 14:22:24 -0700 50 WebCore: WebCore::DisplayRefreshMonitorManager::displayWasUpdated(unsigned int) <== 50 WebKit: IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 50 WebKit: WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call() 50 JavaScriptCore: WTF::RunLoop::performWork() 50 JavaScriptCore: WTF::RunLoop::performWork(void*) 50 CoreFoundation: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 50 CoreFoundation: __CFRunLoopDoSource0 50 CoreFoundation: __CFRunLoopDoSources0 50 CoreFoundation: __CFRunLoopRun 50 CoreFoundation: CFRunLoopRunSpecific 50 Foundation: -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 50 Foundation: -[NSRunLoop(NSRunLoop) run] 50 libxpc.dylib: _xpc_objc_main.cold.4 50 libxpc.dylib: _xpc_objc_main 50 libxpc.dylib: xpc_main 50 WebKit: WebKit::XPCServiceMain(int, char const**) 50 libdyld.dylib: start 1552969 1 cdumez 2019-07-15 14:22:38 -0700 <rdar://problem/53070144> 1552978 2 374151 cdumez 2019-07-15 14:31:24 -0700 Created attachment 374151 Patch 1552982 3 374151 ggaren 2019-07-15 14:41:27 -0700 Comment on attachment 374151 Patch r=me 1553012 4 374151 commit-queue 2019-07-15 16:07:03 -0700 Comment on attachment 374151 Patch Clearing flags on attachment: 374151 Committed r247459: <https://trac.webkit.org/changeset/247459> 1553013 5 commit-queue 2019-07-15 16:07:05 -0700 All reviewed patches have been landed. Closing bug. 1553407 6 374151 sabouhallawa 2019-07-16 18:27:26 -0700 Comment on attachment 374151 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374151&action=review > Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:134 > - for (const auto& monitorWrapper : m_monitors) { > - auto& monitor = monitorWrapper.monitor; > + Vector<RefPtr<DisplayRefreshMonitor>> monitors = WTF::map(m_monitors, [](auto& monitorWrapper) { > + return monitorWrapper.monitor; > + }); > + for (auto& monitor : monitors) { Isn't PlatformDisplayID unique for every monitor? If so, why do we need to loop through all the monitors if we find one whose displayID matches the argument displayID? Can't we just break/return when we find the first one: if (displayID == monitor->displayID()) { if (monitor->hasRequestedRefreshCallback()) monitor->displayLinkFired(); break; } DisplayRefreshMonitorManager::unregisterClient() has similar logic like the proposed one so it does not need to copy the monitors before looping through them. 374151 2019-07-15 14:31:24 -0700 2019-07-15 16:07:03 -0700 Patch bug-199808-20190715143122.patch text/plain 2036 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYwZDFjNDI3NTJmYTcy ZTM3NmE2OTMwMjVjOWI4M2YzNGYxMGQzZi4uZjBhNDBiM2Y4MzYyMmVjMGY4MWY0ZmY2N2RiOTJi NTkxZmVmNTkzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgRGlzcGxh eVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6ZGlzcGxheVdhc1VwZGF0ZWQoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODA4CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MzA3MDE0ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb3B5IG1fbW9uaXRvcnMgYmVmb3JlIGl0ZXJhdGluZyBvdmVyIGl0IGJl Y2F1c2UgdGhlIGNhbGxpbmcgZGlzcGxheUxpbmtGaXJlZCgpIG9uIHRoZQorICAgICAgICBtb25p dG9yIG1heSBlbmQgdXAgY2FsbGluZyBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpkaXNw bGF5RGlkUmVmcmVzaCgpIHN5bmNocm9ub3VzbHksCisgICAgICAgIHdoaWNoIHJlbW92ZXMgdGhl IG1vbml0b3IgZnJvbSBtX21vbml0b3JzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEaXNw bGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpkaXNwbGF5V2FzVXBkYXRlZCk6CisKIDIwMTktMDct MTUgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBJ bXByb3ZlIHdhc20gd3B0IHRlc3QgcmVzdWx0cyBieSBmaXhpbmcgbWlzY2VsbGFuZW91cyBpc3N1 ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlS ZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAKaW5kZXggNGQzY2Q2OTU1ZDNhYjc5 NTk0MDlkMWNjZTFmYjlkYjU4Y2NjOThkNS4uNjk5Zjg1ZDExYTgyNmVjMTY3NDYyM2FlY2I3ZDI3 YTA2YTNkNGFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAKQEAgLTEyOCw4 ICsxMjgsMTAgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjp3aW5kb3dTY3Jl ZW5EaWRDaGFuZ2UoUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGwKIAogdm9pZCBEaXNwbGF5UmVmcmVz aE1vbml0b3JNYW5hZ2VyOjpkaXNwbGF5V2FzVXBkYXRlZChQbGF0Zm9ybURpc3BsYXlJRCBkaXNw bGF5SUQpCiB7Ci0gICAgZm9yIChjb25zdCBhdXRvJiBtb25pdG9yV3JhcHBlciA6IG1fbW9uaXRv cnMpIHsKLSAgICAgICAgYXV0byYgbW9uaXRvciA9IG1vbml0b3JXcmFwcGVyLm1vbml0b3I7Cisg ICAgVmVjdG9yPFJlZlB0cjxEaXNwbGF5UmVmcmVzaE1vbml0b3I+PiBtb25pdG9ycyA9IFdURjo6 bWFwKG1fbW9uaXRvcnMsIFtdKGF1dG8mIG1vbml0b3JXcmFwcGVyKSB7CisgICAgICAgIHJldHVy biBtb25pdG9yV3JhcHBlci5tb25pdG9yOworICAgIH0pOworICAgIGZvciAoYXV0byYgbW9uaXRv ciA6IG1vbml0b3JzKSB7CiAgICAgICAgIGlmIChkaXNwbGF5SUQgPT0gbW9uaXRvci0+ZGlzcGxh eUlEKCkgJiYgbW9uaXRvci0+aGFzUmVxdWVzdGVkUmVmcmVzaENhbGxiYWNrKCkpCiAgICAgICAg ICAgICBtb25pdG9yLT5kaXNwbGF5TGlua0ZpcmVkKCk7CiAgICAgfQo=