199802 2019-07-15 13:31:27 -0700 Add missing webgpu includes 2019-07-15 14:40:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1552939 0 krollin 2019-07-15 13:31:27 -0700 WHLSLFunctionWriter.cpp fails to compile on tvOS and watchOS due to missing includes. This file likely compiles on other platforms due to the Unified Sources facility that clumps several implementation files together, exposing those implementation files to the others' includes. It fails on tvOS and watchOS due to the different ways these implementation files can get clumped together on different platforms. 1552940 1 webkit-bug-importer 2019-07-15 13:32:15 -0700 <rdar://problem/53119120> 1552941 2 374142 krollin 2019-07-15 13:34:27 -0700 Created attachment 374142 Patch 1552980 3 374142 commit-queue 2019-07-15 14:40:34 -0700 Comment on attachment 374142 Patch Clearing flags on attachment: 374142 Committed r247450: <https://trac.webkit.org/changeset/247450> 1552981 4 commit-queue 2019-07-15 14:40:36 -0700 All reviewed patches have been landed. Closing bug. 374142 2019-07-15 13:34:27 -0700 2019-07-15 14:40:34 -0700 Patch bug-199802-20190715133427.patch text/plain 1821 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYyNmU2NWMzYzlhM2Uy MTBhM2ZkMmYyNGZmYzIyZjQ5YTA3YTkzMC4uZjZiOGMxMTZkMWVkNWFjNWZiODMyZjc4NTdhMTJk Yjk0YmZmNzE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA3LTE1ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbWlzc2luZyB3ZWJn cHUgaW5jbHVkZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTgwMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTMxMTkxMjA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0hMU0xGdW5jdGlvbldyaXRl ci5jcHAgZmFpbHMgdG8gY29tcGlsZSBvbiB0dk9TIGFuZCB3YXRjaE9TIGR1ZSB0bworICAgICAg ICBtaXNzaW5nIGluY2x1ZGVzLiBUaGlzIGZpbGUgbGlrZWx5IGNvbXBpbGVzIG9uIG90aGVyIHBs YXRmb3JtcyBkdWUgdG8KKyAgICAgICAgdGhlIFVuaWZpZWQgU291cmNlcyBmYWNpbGl0eSB0aGF0 IGNsdW1wcyBzZXZlcmFsIGltcGxlbWVudGF0aW9uIGZpbGVzCisgICAgICAgIHRvZ2V0aGVyLCBl eHBvc2luZyB0aG9zZSBpbXBsZW1lbnRhdGlvbiBmaWxlcyB0byB0aGUgb3RoZXJzJyBpbmNsdWRl cy4KKyAgICAgICAgSXQgZmFpbHMgb24gdHZPUyBhbmQgd2F0Y2hPUyBkdWUgdG8gdGhlIGRpZmZl cmVudCB3YXlzIHRoZXNlCisgICAgICAgIGltcGxlbWVudGF0aW9uIGZpbGVzIGNhbiBnZXQgY2x1 bXBlZCB0b2dldGhlciBvbiBkaWZmZXJlbnQgcGxhdGZvcm1zLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBhcyB0aGVyZSBpcyBubyBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVs ZXMvd2ViZ3B1L1dITFNML01ldGFsL1dITFNMRnVuY3Rpb25Xcml0ZXIuY3BwOgorCiAyMDE5LTA3 LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgbmF2ZXIuY29t OiBWaWRlbyBzdG9wcyB3aGVuIHRhcHBpbmcgb24gdGhlIHZpZGVvIHRvIHVzZSBidXR0b25zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9NZXRhbC9XSExT TEZ1bmN0aW9uV3JpdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNM L01ldGFsL1dITFNMRnVuY3Rpb25Xcml0ZXIuY3BwCmluZGV4IDBiNTk4MGY2MjBhOTFlM2Q2MTY1 YmNhNjkzNzIxNmU3ZjBmOTAxMTUuLjJiNTc5MzM1NDI3OGZkYzY4N2U5ZGJmZWQ2NzVkOWEwYmZh MzU5OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML01l dGFsL1dITFNMRnVuY3Rpb25Xcml0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViZ3B1L1dITFNML01ldGFsL1dITFNMRnVuY3Rpb25Xcml0ZXIuY3BwCkBAIC0zMCw2ICszMCw4 IEBACiAKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIldITFNMQVNULmgi CisjaW5jbHVkZSAiV0hMU0xFbnRyeVBvaW50U2NhZmZvbGRpbmcuaCIKKyNpbmNsdWRlICJXSExT TEluZmVyVHlwZXMuaCIKICNpbmNsdWRlICJXSExTTE5hdGl2ZUZ1bmN0aW9uV3JpdGVyLmgiCiAj aW5jbHVkZSAiV0hMU0xQcm9ncmFtLmgiCiAjaW5jbHVkZSAiV0hMU0xUeXBlTmFtZXIuaCIK