199777 2019-07-12 20:04:16 -0700 Fix non thread-safe usage of makeWeakPtr() in MediaPlayerPrivateAVFoundation 2019-07-13 04:08:17 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199700 InRadar P2 Normal --- 199639 1 cdumez cdumez achristensen commit-queue eric.carlson ggaren jer.noble webkit-bug-importer oldest_to_newest 1552666 0 cdumez 2019-07-12 20:04:16 -0700 Fix non thread-safe usage of makeWeakPtr() in MediaPlayerPrivateAVFoundation. 1552667 1 374073 cdumez 2019-07-12 20:06:24 -0700 Created attachment 374073 Patch 1552689 2 374073 commit-queue 2019-07-13 04:07:47 -0700 Comment on attachment 374073 Patch Clearing flags on attachment: 374073 Committed r247415: <https://trac.webkit.org/changeset/247415> 1552690 3 commit-queue 2019-07-13 04:07:48 -0700 All reviewed patches have been landed. Closing bug. 1552691 4 webkit-bug-importer 2019-07-13 04:08:17 -0700 <rdar://problem/53048354> 374073 2019-07-12 20:06:24 -0700 2019-07-13 04:07:47 -0700 Patch bug-199777-20190712200622.patch text/plain 3442 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTVkNjkzY2YxNGIxZmRh MWMzNjc0NTI1YjA5Y2U0NWVmMzkyNzI2Ni4uZWYyYTIwMWNmMWNhZWY1YWExMjE3OWY2YmQzMDNk YmI3NjczZjlkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA3LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IG5vbiB0aHJlYWQtc2Fm ZSB1c2FnZSBvZiBtYWtlV2Vha1B0cigpIGluIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5Nzc3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNv ZGUgd2FzIGNhbGxpbmcgbWFrZVdlYWtQdHIoKSBvbiBhIG1haW4tdGhyZWFkIG9iamVjdCwgZnJv bSBhIGJhY2tncm91bmQgdGhyZWFkLgorICAgICAgICBUaGlzIGlzIG5vdCB0aHJlYWQgc2FmZS4g VG8gYWRkcmVzcyB0aGUgaXNzdWUsIHRoaXMgcGF0Y2hlcyBjcmVhdGVzIHRoZSBXZWFrUHRyIGFo ZWFkCisgICAgICAgIG9mIHRpbWUsIG9uIHRoZSBtYWluIHRocmVhZC4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u OjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpzY2hlZHVsZU1haW5UaHJlYWROb3RpZmljYXRp b24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpk aXNwYXRjaE5vdGlmaWNhdGlvbik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5oOgorCiAyMDE5LTA3LTEyICBU aGliYXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVh bWVyXSBNb2NrIEdTdHJlYW1lciByZWFsdGltZSBzb3VyY2VzIHNob3VsZCBrZWVwIGEgUmVmIG9m IHRoZWlyIG1vY2sgcmVhbHRpbWUgbWVkaWEgc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAppbmRleCAyODk4ZGY4NGFj MjJmYTNjOTQ5YmE3ZDNhMzNhYWI1MmMxMGI4ODNlLi44NTdmMzFmMjc3MmY0MDgxZmJhNjM4Zjgx MGMxMTQ5NDI4NThiOTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcApAQCAtNTUsNyArNTUsOCBAQAogbmFtZXNwYWNlIFdl YkNvcmUgewogCiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246Ok1lZGlhUGxheWVyUHJp dmF0ZUFWRm91bmRhdGlvbihNZWRpYVBsYXllciogcGxheWVyKQotICAgIDogbV9wbGF5ZXIocGxh eWVyKQorICAgIDogbV93ZWFrVGhpcyhtYWtlV2Vha1B0cigqdGhpcykpCisgICAgLCBtX3BsYXll cihwbGF5ZXIpCiAgICAgLCBtX3F1ZXVlZE5vdGlmaWNhdGlvbnMoKQogICAgICwgbV9xdWV1ZU11 dGV4KCkKICAgICAsIG1fbmV0d29ya1N0YXRlKE1lZGlhUGxheWVyOjpFbXB0eSkKQEAgLTc3NCw3 ICs3NzUsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6c2NoZWR1bGVN YWluVGhyZWFkTm90aWZpY2F0aW9uKE5vdGlmaWNhdGlvbgogICAgIGlmIChkZWxheURpc3BhdGNo ICYmICFtX21haW5UaHJlYWRDYWxsUGVuZGluZykgewogICAgICAgICBtX21haW5UaHJlYWRDYWxs UGVuZGluZyA9IHRydWU7CiAKLSAgICAgICAgY2FsbE9uTWFpblRocmVhZChbd2Vha1RoaXMgPSBt YWtlV2Vha1B0cigqdGhpcyldIHsKKyAgICAgICAgY2FsbE9uTWFpblRocmVhZChbd2Vha1RoaXMg PSBtX3dlYWtUaGlzXSB7CiAgICAgICAgICAgICBpZiAoIXdlYWtUaGlzKQogICAgICAgICAgICAg ICAgIHJldHVybjsKIApAQCAtODA3LDcgKzgwOCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uOjpkaXNwYXRjaE5vdGlmaWNhdGlvbigpCiAgICAgICAgIH0KICAgICAgICAg CiAgICAgICAgIGlmICghbV9xdWV1ZWROb3RpZmljYXRpb25zLmlzRW1wdHkoKSAmJiAhbV9tYWlu VGhyZWFkQ2FsbFBlbmRpbmcpIHsKLSAgICAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3dlYWtU aGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXSB7CisgICAgICAgICAgICBjYWxsT25NYWluVGhyZWFk KFt3ZWFrVGhpcyA9IG1fd2Vha1RoaXNdIHsKICAgICAgICAgICAgICAgICBpZiAoIXdlYWtUaGlz KQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uaAppbmRleCA1MWEyOWJkMThhOTQ1OTdj NDg4M2I0NDdkOTYzZThiM2UwNjI2ZmExLi5hNjFlNWI5MWExYTFkOGYxYmJkYThlZWQ4OTVjMGQ4 NWI2MjQyYmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbi5oCkBAIC0zMjcsNiArMzI3LDcgQEAgcHJvdGVjdGVkOgogICAgIGNvbnN0 IFVSTCYgcmVzb2x2ZWRVUkwoKSBjb25zdCB7IHJldHVybiBtX3Jlc29sdmVkVVJMOyB9CiAKIHBy aXZhdGU6CisgICAgV2Vha1B0cjxNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24+IG1fd2Vh a1RoaXM7CiAgICAgTWVkaWFQbGF5ZXIqIG1fcGxheWVyOwogCiAgICAgV1RGOjpGdW5jdGlvbjx2 b2lkKCk+IG1fcGVuZGluZ1NlZWs7Cg==