199775 2019-07-12 19:48:28 -0700 Drop non thread-safe usage of WeakPtr in VideoFullscreenInterfaceAVKit 2019-07-13 08:29:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199698 InRadar P2 Normal --- 199639 1 cdumez cdumez achristensen commit-queue eric.carlson ggaren jer.noble webkit-bug-importer oldest_to_newest 1552660 0 cdumez 2019-07-12 19:48:28 -0700 Drop non thread-safe usage of WeakPtr in VideoFullscreenInterfaceAVKit. 1552663 1 374072 cdumez 2019-07-12 19:53:19 -0700 Created attachment 374072 Patch 1552696 2 374072 commit-queue 2019-07-13 08:28:57 -0700 Comment on attachment 374072 Patch Clearing flags on attachment: 374072 Committed r247417: <https://trac.webkit.org/changeset/247417> 1552697 3 commit-queue 2019-07-13 08:28:58 -0700 All reviewed patches have been landed. Closing bug. 1552698 4 webkit-bug-importer 2019-07-13 08:29:20 -0700 <rdar://problem/53052575> 374072 2019-07-12 19:53:19 -0700 2019-07-13 08:28:57 -0700 Patch bug-199775-20190712195316.patch text/plain 6981 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTVkNjkzY2YxNGIxZmRh MWMzNjc0NTI1YjA5Y2U0NWVmMzkyNzI2Ni4uMmQzNjk3OWVlNGQ4OGFhZGU4MzA1NmQ0N2IxZjU2 MmMxODNkYmI0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE5LTA3LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBub24gdGhyZWFkLXNh ZmUgdXNhZ2Ugb2YgV2Vha1B0ciBpbiBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5Nzc1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFZpZGVvRnVs bHNjcmVlbkludGVyZmFjZUFWS2l0IGNvbnN0cnVjdG9yIHdhcyBtYWtpbmcgYSB3ZWFrUHRyIG9u IHRoZSBVSSBUaHJlYWQKKyAgICAgICAgb2YgYW4gV2ViVGhyZWFkIG9iamVjdC4gVGhlIFdlYWtQ dHIgd291bGQgdGhlbiBiZSB1c2VkIGFzIGEgZGF0YSBtZW1iZXIgdGhyb3VnaG91dAorICAgICAg ICB0aGUgY2xhc3Mgb24gdGhlIFVJVGhyZWFkLiBUaGlzIGlzIG5vdCB0aHJlYWQtc2FmZS4KKwor ICAgICAgICBUaGlzIHBhdGNoIHN3aXRjaGVzIHRvIHVzaW5nIGEgcmF3IHBvaW50ZXIgaW5zdGVh ZCBvZiBhIFdlYWtQdHIuIFRoaXMgaXMgYSBwYXJ0aWFsCisgICAgICAgIHJvbGxvdXQgb2YgcjI0 MzI5OCwgd2hpY2ggdHVybmVkIHRoZSByYXcgcG9pbnRlciBpbnRvIGEgV2Vha1B0ciBmb3IgaGFy ZGVuaW5nCisgICAgICAgIHB1cnBvc2VzLiBGb3IgZXh0cmEgc2FmZXR5LCB0aGlzIHBhdGNoIHVw ZGF0ZXMgdGhlIFZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXJDb250ZXh0CisgICAgICAgIHNvIHRo YXQgaXQgbm90aWZpZXMgaXRzIGNsaWVudHMgKGkuZS4gUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNl QVZLaXQpIHRoYXQgaXQgaXMKKyAgICAgICAgZ2V0dGluZyBkZXN0cm95ZWQsIHNvIHRoYXQgdGhl eSBjYW4gbnVsbC1vdXQgdGhlaXIgbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbCAmCisgICAgICAgIG1f ZnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyIGRhdGEgbWVtYmVycy4gVGhpcyBnaXZlcyB0aGUgc2Ft ZXMgZ3VhcmFudGVlcyBhcyBXZWFrUHRyCisgICAgICAgIGJ1dCBpbiBhIHRocmVhZC1zYWZlIHdh eS4KKworICAgICAgICBUaGlzIGlzIHZlcnkgc2ltaWxhciB0byB0aGUgZml4IHRoYXQgd2FzIGRv bmUgZm9yIFBsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFWS2l0IGluCisgICAgICAgIHIyNDczODAu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9WaWRlb0Z1bGxzY3JlZW5Nb2RlbC5oOgorICAg ICAgICAoV2ViQ29yZTo6VmlkZW9GdWxsc2NyZWVuTW9kZWxDbGllbnQ6Om1vZGVsRGVzdHJveWVk KToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQu bW06CisgICAgICAgIChWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6c2V0VmlkZW9GdWxs c2NyZWVuTW9kZWwpOgorICAgICAgICAoVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnNl dFZpZGVvRnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyKToKKyAgICAgICAgKFZpZGVvRnVsbHNjcmVl bkludGVyZmFjZUFWS2l0Ojptb2RlbERlc3Ryb3llZCk6CisgICAgICAgICogcGxhdGZvcm0vaW9z L1dlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXJBVktpdC5tbToKKyAgICAgICAgKFZpZGVvRnVs bHNjcmVlbkNvbnRyb2xsZXJDb250ZXh0Ojp+VmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckNvbnRl eHQpOgorCiAyMDE5LTA3LTEyICBUaGliYXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBNb2NrIEdTdHJlYW1lciByZWFsdGltZSBzb3VyY2Vz IHNob3VsZCBrZWVwIGEgUmVmIG9mIHRoZWlyIG1vY2sgcmVhbHRpbWUgbWVkaWEgc291cmNlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvVmlkZW9GdWxsc2NyZWVu TW9kZWwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1v ZGVsLmgKaW5kZXggN2IyYmZhNmNmNjg1NmY0NjI2ODE2N2NjNTMwNjgwNTU3MjljMDc5Yy4uM2Y0 NTdkMzhiZWY0MTYyOWZmZTQ0ZmI4ODFjZWYxMWNlOGIyYzFlMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvVmlkZW9GdWxsc2NyZWVuTW9kZWwuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9WaWRlb0Z1bGxzY3JlZW5Nb2RlbC5oCkBAIC04Myw2 ICs4Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZmFpbGVkVG9FbnRlclBpY3R1cmVJ blBpY3R1cmUoKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgd2lsbEV4aXRQaWN0dXJlSW5QaWN0dXJl KCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZEV4aXRQaWN0dXJlSW5QaWN0dXJlKCkgeyB9Cisg ICAgdmlydHVhbCB2b2lkIG1vZGVsRGVzdHJveWVkKCkgeyB9CiB9OwogCiBXRUJDT1JFX0VYUE9S VCBib29sIHN1cHBvcnRzUGljdHVyZUluUGljdHVyZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQuaApp bmRleCA1ZDQ5NGY4NjI5MmQ3NDg3YTgyYjUyZmMzOWI4NDEwYjM2NjAyZmNlLi5lNzQ4NWNiZjIz YTRiNjhmZjM5MGVhYzY2Y2FkY2Y4YTdiZDQ2M2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQuaApA QCAtNzQsNiArNzQsNyBAQCBwdWJsaWM6CiAgICAgLy8gVmlkZW9GdWxsc2NyZWVuTW9kZWxDbGll bnQKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGhhc1ZpZGVvQ2hhbmdlZChib29sKSBmaW5hbDsK ICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHZpZGVvRGltZW5zaW9uc0NoYW5nZWQoY29uc3QgRmxv YXRTaXplJikgZmluYWw7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBtb2RlbERlc3Ryb3llZCgp IGZpbmFsOwogCiAgICAgLy8gUGxheWJhY2tTZXNzaW9uTW9kZWxDbGllbnQKICAgICBXRUJDT1JF X0VYUE9SVCB2b2lkIGV4dGVybmFsUGxheWJhY2tDaGFuZ2VkKGJvb2wgZW5hYmxlZCwgUGxheWJh Y2tTZXNzaW9uTW9kZWw6OkV4dGVybmFsUGxheWJhY2tUYXJnZXRUeXBlLCBjb25zdCBTdHJpbmcm IGxvY2FsaXplZERldmljZU5hbWUpIGZpbmFsOwpAQCAtMTI3LDcgKzEyOCw3IEBAIHB1YmxpYzoK ICAgICBNb2RlIG1fY3VycmVudE1vZGU7CiAgICAgTW9kZSBtX3RhcmdldE1vZGU7CiAKLSAgICBW aWRlb0Z1bGxzY3JlZW5Nb2RlbCogdmlkZW9GdWxsc2NyZWVuTW9kZWwoKSBjb25zdCB7IHJldHVy biBtX3ZpZGVvRnVsbHNjcmVlbk1vZGVsLmdldCgpOyB9CisgICAgVmlkZW9GdWxsc2NyZWVuTW9k ZWwqIHZpZGVvRnVsbHNjcmVlbk1vZGVsKCkgY29uc3QgeyByZXR1cm4gbV92aWRlb0Z1bGxzY3Jl ZW5Nb2RlbDsgfQogICAgIGJvb2wgc2hvdWxkRXhpdEZ1bGxzY3JlZW5XaXRoUmVhc29uKEV4aXRG dWxsU2NyZWVuUmVhc29uKTsKICAgICBIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNj cmVlbk1vZGUgbW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fY3VycmVudE1vZGUubW9kZSgpOyB9CiAg ICAgYm9vbCBhbGxvd3NQaWN0dXJlSW5QaWN0dXJlUGxheWJhY2soKSBjb25zdCB7IHJldHVybiBt X2FsbG93c1BpY3R1cmVJblBpY3R1cmVQbGF5YmFjazsgfQpAQCAtMTcxLDggKzE3Miw4IEBAIHBy b3RlY3RlZDoKICAgICBSZWY8UGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQ+IG1fcGxheWJh Y2tTZXNzaW9uSW50ZXJmYWNlOwogICAgIFJldGFpblB0cjxXZWJBVlBsYXllclZpZXdDb250cm9s bGVyRGVsZWdhdGU+IG1fcGxheWVyVmlld0NvbnRyb2xsZXJEZWxlZ2F0ZTsKICAgICBSZXRhaW5Q dHI8V2ViQVZQbGF5ZXJWaWV3Q29udHJvbGxlcj4gbV9wbGF5ZXJWaWV3Q29udHJvbGxlcjsKLSAg ICBXZWFrUHRyPFZpZGVvRnVsbHNjcmVlbk1vZGVsPiBtX3ZpZGVvRnVsbHNjcmVlbk1vZGVsOwot ICAgIFdlYWtQdHI8VmlkZW9GdWxsc2NyZWVuQ2hhbmdlT2JzZXJ2ZXI+IG1fZnVsbHNjcmVlbkNo YW5nZU9ic2VydmVyOworICAgIFZpZGVvRnVsbHNjcmVlbk1vZGVsKiBtX3ZpZGVvRnVsbHNjcmVl bk1vZGVsIHsgbnVsbHB0ciB9OworICAgIFZpZGVvRnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyKiBt X2Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciB7IG51bGxwdHIgfTsKIAogICAgIC8vIFRoZXNlIGFy ZSBvbmx5IHVzZWQgd2hlbiBmdWxsc2NyZWVuIGlzIHByZXNlbnRlZCBpbiBhIHNlcGFyYXRlIHdp bmRvdy4KICAgICBSZXRhaW5QdHI8VUlXaW5kb3c+IG1fd2luZG93OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1t IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0Lm1tCmluZGV4IDU3Mzk1NjE5MmYwMjViNzIyM2JjN2E4MWExNTliYzJkZmFlNzU4OGIuLjVh NzQ2NWQ3ZWQwNGZjYzFjZDZkODdlNDBlMzY1ZTcwYTA0ZmE2OGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQubW0KQEAgLTc2MCw3ICs3NjAsNyBAQCB2b2lkIFZpZGVvRnVsbHNjcmVlbkludGVyZmFj ZUFWS2l0OjpzZXRWaWRlb0Z1bGxzY3JlZW5Nb2RlbChWaWRlb0Z1bGxzY3JlZW5Nb2RlbAogICAg IGlmIChtX3ZpZGVvRnVsbHNjcmVlbk1vZGVsKQogICAgICAgICBtX3ZpZGVvRnVsbHNjcmVlbk1v ZGVsLT5yZW1vdmVDbGllbnQoKnRoaXMpOwogCi0gICAgbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbCA9 IG1ha2VXZWFrUHRyKG1vZGVsKTsKKyAgICBtX3ZpZGVvRnVsbHNjcmVlbk1vZGVsID0gbW9kZWw7 CiAKICAgICBpZiAobV92aWRlb0Z1bGxzY3JlZW5Nb2RlbCkgewogICAgICAgICBtX3ZpZGVvRnVs bHNjcmVlbk1vZGVsLT5hZGRDbGllbnQoKnRoaXMpOwpAQCAtNzc5LDcgKzc3OSw3IEBAIHZvaWQg VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnNldFZpZGVvRnVsbHNjcmVlbk1vZGVsKFZp ZGVvRnVsbHNjcmVlbk1vZGVsCiAKIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OnNldFZpZGVvRnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyKFZpZGVvRnVsbHNjcmVlbkNoYW5nZU9i c2VydmVyKiBvYnNlcnZlcikKIHsKLSAgICBtX2Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciA9IG1h a2VXZWFrUHRyKG9ic2VydmVyKTsKKyAgICBtX2Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciA9IG9i c2VydmVyOwogfQogCiB2b2lkIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpoYXNWaWRl b0NoYW5nZWQoYm9vbCBoYXNWaWRlbykKQEAgLTkzMCw2ICs5MzAsMTIgQEAgdm9pZCBWaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6aW52YWxpZGF0ZSgpCiAgICAgY2xlYW51cEZ1bGxzY3Jl ZW4oKTsKIH0KIAordm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6bW9kZWxEZXN0 cm95ZWQoKQoreworICAgIEFTU0VSVChpc1VJVGhyZWFkKCkpOworICAgIGludmFsaWRhdGUoKTsK K30KKwogdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6cmVxdWVzdEhpZGVBbmRF eGl0RnVsbHNjcmVlbigpCiB7CiAgICAgaWYgKG1fY3VycmVudE1vZGUuaGFzUGljdHVyZUluUGlj dHVyZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVv RnVsbHNjcmVlbkNvbnRyb2xsZXJBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyQVZLaXQubW0KaW5kZXggZDg5NGM5NDk3ZjQw MjA0NDQzYjc4OTc1NTIwNzQ5YTQxZjNkZmY2OC4uNDM2YTk3MDU5MmU4YTU4NTU4NGQ1YWY1NzQ3 ZjRhYjY4MjQ2NDE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dl YlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXJBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0Lm1tCkBAIC0yMjMs NiArMjIzLDggQEAgVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckNvbnRleHQ6On5WaWRlb0Z1bGxz Y3JlZW5Db250cm9sbGVyQ29udGV4dCgpCiAgICAgYXV0byBub3RpZnlDbGllbnRzTW9kZWxXYXNE ZXN0cm95ZWQgPSBbdGhpc10gewogICAgICAgICB3aGlsZSAoIW1fcGxheWJhY2tDbGllbnRzLmlz RW1wdHkoKSkKICAgICAgICAgICAgICgqbV9wbGF5YmFja0NsaWVudHMuYmVnaW4oKSktPm1vZGVs RGVzdHJveWVkKCk7CisgICAgICAgIHdoaWxlICghbV9mdWxsc2NyZWVuQ2xpZW50cy5pc0VtcHR5 KCkpCisgICAgICAgICAgICAoKm1fZnVsbHNjcmVlbkNsaWVudHMuYmVnaW4oKSktPm1vZGVsRGVz dHJveWVkKCk7CiAgICAgfTsKICAgICBpZiAoaXNVSVRocmVhZCgpKQogICAgICAgICBub3RpZnlD bGllbnRzTW9kZWxXYXNEZXN0cm95ZWQoKTsK