199765 2019-07-12 16:02:22 -0700 Increase JSValue cage size on iOS and reduce the max slide 2019-07-12 17:23:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller saam webkit-bug-importer oldest_to_newest 1552584 0 keith_miller 2019-07-12 16:02:22 -0700 Increase JSValue cage size on iOS and reduce the max slide 1552588 1 374048 keith_miller 2019-07-12 16:09:59 -0700 Created attachment 374048 Patch 1552591 2 keith_miller 2019-07-12 16:11:05 -0700 rdar://problem/52589569 1552596 3 374048 saam 2019-07-12 16:21:29 -0700 Comment on attachment 374048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review > Source/bmalloc/bmalloc/Gigacage.h:71 > constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB; > -constexpr size_t jsValueGigacageSize = 1 * bmalloc::Sizes::GB; > +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB; should we bump to 4gb/4gb? 1552600 4 374048 saam 2019-07-12 16:21:57 -0700 Comment on attachment 374048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review > Source/bmalloc/ChangeLog:12 > + might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation 1552625 5 374048 keith_miller 2019-07-12 17:22:32 -0700 Comment on attachment 374048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review >> Source/bmalloc/ChangeLog:12 >> + > > might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation Done. >> Source/bmalloc/bmalloc/Gigacage.h:71 >> +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB; > > should we bump to 4gb/4gb? I'm not sure that's necessary. If we still have a problem we can consider it later. 1552626 6 keith_miller 2019-07-12 17:23:16 -0700 Committed r247409: <https://trac.webkit.org/changeset/247409> 374048 2019-07-12 16:09:59 -0700 2019-07-12 16:19:23 -0700 Patch bug-199765-20190712160959.patch text/plain 1798 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMGZhYzFhYWEzM2VkNzA0 ZWI0YWFiOTU1ZGZhNmE2YTJjMDAzOWMwZC4uNmJkOGE5ZmQzYmE5Y2JlNjQxOWI1Zjg5ZmUxMjQ1 YmU1ZGNhMDVlYyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTEyICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIEluY3JlYXNlIEpT VmFsdWUgY2FnZSBzaXplIG9uIGlPUyBhbmQgcmVkdWNlIHRoZSBtYXggc2xpZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTc2NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRoZSBXZWJDb250 ZW50IGpldHNhbSBsaW1pdCBoYXMgY2hhbmdlZCB3ZSBzb21ldGltZXMgcnVuIG91dAorICAgICAg ICBvZiBKU1ZhbHVlIGNhZ2UgVkEgc3BhY2UgY2F1c2luZyB1cyB0byBydW4gb3V0IG9mIG1lbW9y eSBmb3IKKyAgICAgICAgYXJyYXlzLiBUaGlzIGNoYW5nZSBtYWtlcyB0aGUgSlNWYWx1ZSBjYWdl IGEgbW9yZSByZWFzb25hYmxlIHVwcGVyCisgICAgICAgIGxpbWl0IGZvciB3aGF0IHNob3VsZCBi ZSBwb3NzaWJsZSB3aXRob3V0IGpldHNhbW1pbmcuCisKKyAgICAgICAgKiBibWFsbG9jL0dpZ2Fj YWdlLmg6CisKIDIwMTktMDctMDMgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5j b20+CiAKICAgICAgICAgUEFDQ2FnZSBzaG91bGQgZmlyc3QgY2FnZSBsZWF2aW5nIFBBQyBiaXRz IGludGFjdCB0aGVuIGF1dGhlbnRpY2F0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9HaWdhY2FnZS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9HaWdhY2FnZS5oCmluZGV4 IGEzN2QwYmFmOTk3OWRlZWNjMmU5ZTI1NDJhOGMyOTU4ZGRmODZiNTcuLmM3MzA0OTM2OWMxN2Uw OTAwMDgxMTAyOGJmMDY0NDE4YzFhNTBmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvR2lnYWNhZ2UuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmgK QEAgLTY4LDkgKzY4LDkgQEAgQklOTElORSBjb25zdCBjaGFyKiBuYW1lKEtpbmQga2luZCkKIAog I2lmIEJDUFUoQVJNNjQpCiBjb25zdGV4cHIgc2l6ZV90IHByaW1pdGl2ZUdpZ2FjYWdlU2l6ZSA9 IDIgKiBibWFsbG9jOjpTaXplczo6R0I7Ci1jb25zdGV4cHIgc2l6ZV90IGpzVmFsdWVHaWdhY2Fn ZVNpemUgPSAxICogYm1hbGxvYzo6U2l6ZXM6OkdCOworY29uc3RleHByIHNpemVfdCBqc1ZhbHVl R2lnYWNhZ2VTaXplID0gMiAqIGJtYWxsb2M6OlNpemVzOjpHQjsKIGNvbnN0ZXhwciBzaXplX3Qg Z2lnYWNhZ2VCYXNlUHRyc1NpemUgPSAxNiAqIGJtYWxsb2M6OlNpemVzOjprQjsKLWNvbnN0ZXhw ciBzaXplX3QgbWF4aW11bUNhZ2VTaXplUmVkdWN0aW9uRm9yU2xpZGUgPSBibWFsbG9jOjpTaXpl czo6R0IgLyAyOworY29uc3RleHByIHNpemVfdCBtYXhpbXVtQ2FnZVNpemVSZWR1Y3Rpb25Gb3JT bGlkZSA9IGJtYWxsb2M6OlNpemVzOjpHQiAvIDQ7CiAjZGVmaW5lIEdJR0FDQUdFX0FMTE9DQVRJ T05fQ0FOX0ZBSUwgMQogI2Vsc2UKIGNvbnN0ZXhwciBzaXplX3QgcHJpbWl0aXZlR2lnYWNhZ2VT aXplID0gMzIgKiBibWFsbG9jOjpTaXplczo6R0I7Cg==