199754 2019-07-12 13:11:25 -0700 Regression(macOS Catalina): Cannot quick look html documents in Mail 2019-09-19 16:10:35 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202012 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson bfulgham commit-queue ggaren mitz webkit-bug-importer youennf oldest_to_newest 1552494 0 cdumez 2019-07-12 13:11:25 -0700 Cannot quick look html documents in Mail due to sandboxing errors. 1552495 1 cdumez 2019-07-12 13:11:41 -0700 <rdar://problem/51304961> 1552498 2 374029 cdumez 2019-07-12 13:14:22 -0700 Created attachment 374029 Patch 1552499 3 374029 ggaren 2019-07-12 13:15:56 -0700 Comment on attachment 374029 Patch Can we test this with an API test? 1552500 4 cdumez 2019-07-12 13:20:57 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 374029 [details] > Patch > > Can we test this with an API test? No, as far as I know, we cannot API test sandboxing since TestWebKitAPI is not sandboxed. 1552505 5 374029 cdumez 2019-07-12 13:51:43 -0700 Comment on attachment 374029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:1061 > // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508. Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this. 1552514 6 374029 cdumez 2019-07-12 14:04:35 -0700 Comment on attachment 374029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:1061 >> // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508. > > Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this. Ok, I have confirmed that rdar://problem/52357508 is also fixed with my patch. I'll drop the FIXME comment before landing. 1552515 7 374034 cdumez 2019-07-12 14:06:00 -0700 Created attachment 374034 Patch 1552549 8 374034 commit-queue 2019-07-12 15:03:33 -0700 Comment on attachment 374034 Patch Clearing flags on attachment: 374034 Committed r247400: <https://trac.webkit.org/changeset/247400> 1552550 9 commit-queue 2019-07-12 15:03:35 -0700 All reviewed patches have been landed. Closing bug. 374029 2019-07-12 13:14:22 -0700 2019-07-12 14:05:58 -0700 Patch bug-199754-20190712131421.patch text/plain 2590 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY1ZGE4NmNiMDJiMDA3ZWI3 NDVhNWQyZjEwOGI2NjUzMzUzYzBiZDUuLjg5ZDhkYTgzYWQ0MGFhZmM4ZDE1ZWU3YzRhZDZiYjhi YTllMThiODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDctMTIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKG1hY09TIENhdGFs aW5hKTogQ2Fubm90IHF1aWNrIGxvb2sgaHRtbCBkb2N1bWVudHMgaW4gTWFpbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NzU0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTMwNDk2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJZiB0aGUgY2xpZW50IGFza3MgdXMgdG8gbG9hZCBhIGZpbGUgVVJM IGJ1dCBkb2VzIG5vdCBwcm92aWRlIGEgcmVzb3VyY2UgcGF0aCwgV2ViS2l0CisgICAgICAgIHdv dWxkIGZhbGxiYWNrIHRvIGlzc3VpbmcgYSBzYW5kYm94IGV4dGVuc2lvbiBmb3IgLy4gVGhpcyBu byBsb25nZXIgd29ya3Mgb24gbWFjIE9TCisgICAgICAgIENhdGFsaW5hIGFuZCBpdCB3b3VsZCB0 aHVzIGZhaWwgdG8gbG9hZCB0aGUgZmlsZS4KKworICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1 ZSwgaWYgdGhlIGF0dGVtcHQgdG8gY3JlYXRlIGEgc2FuZGJveCBleHRlbnNpb24gZm9yIC8gZmFp bHMsIHdlIG5vdworICAgICAgICBmYWxsIGJhY2sgdG8gaXNzdWluZyBvbmUgZm9yIHRoZSBmaWxl J3MgYmFzZVVSTCAocGF0aCBvZiBjb250YWluaW5nIGZvbGRlcikuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpt YXliZUluaXRpYWxpemVTYW5kYm94RXh0ZW5zaW9uSGFuZGxlKToKKwogMjAxOS0wNy0xMiAgVGlt b3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgRHJvcCBEYXJrTW9k ZUNTU0VuYWJsZWQgYXMgYW4gZXhwZXJpbWVudGFsIGZlYXR1cmUgYW5kIGFsd2F5cyBlbmFibGUg aXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA2OGQ4ODFj ODNhZWY2MGE5NzBiYjk3NWE2M2RlODk4OTQ2ODg3NWFhLi44NjRhNmU0YzM3NjA0NTU4MTk2ZWFk ZGNkNDlmNzI2ZTQ0NjExMTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAKQEAgLTEwNTksOCArMTA1OSwxNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6bWF5YmVJbml0 aWFsaXplU2FuZGJveEV4dGVuc2lvbkhhbmRsZShXZWJQcm9jZXNzUHJveHkmIHByb2NlcwogICAg IEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCFXZWJLaXQ6OmlzSW5zcGVjdG9yUGFn ZSgqdGhpcykpOwogCiAgICAgLy8gRklYTUU6IHVuaXZlcnNhbCBmaWxlIHJlYWQgYWNjZXNzIHNo b3VsZCBiZSBzZXQgaWYgdGhlIHNhbmRib3ggZXh0ZW5zaW9uIGlzIHN1Y2Nlc3NmdWxseSBjcmVh dGVkOiByZGFyOi8vcHJvYmxlbS81MjM1NzUwOC4KLSAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGVIYW5kbGUoIi8iLCBTYW5kYm94RXh0ZW5zaW9uOjpUeXBlOjpSZWFkT25seSwgc2FuZGJveEV4 dGVuc2lvbkhhbmRsZSk7Ci0gICAgd2lsbEFjcXVpcmVVbml2ZXJzYWxGaWxlUmVhZFNhbmRib3hF eHRlbnNpb24ocHJvY2Vzcyk7CisgICAgaWYgKFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRs ZSgiLyIsIFNhbmRib3hFeHRlbnNpb246OlR5cGU6OlJlYWRPbmx5LCBzYW5kYm94RXh0ZW5zaW9u SGFuZGxlKSkgeworICAgICAgICB3aWxsQWNxdWlyZVVuaXZlcnNhbEZpbGVSZWFkU2FuZGJveEV4 dGVuc2lvbihwcm9jZXNzKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIFdlIGZh aWxlZCB0byBpc3N1ZSBhbiB1bml2ZXJzYWwgZmlsZSByZWFkIGFjY2VzcyBzYW5kYm94LCBmYWxs IGJhY2sgdG8gaXNzdWluZyBvbmUgZm9yIHRoZSBiYXNlIFVSTCBpbnN0ZWFkLgorICAgIGF1dG8g YmFzZVVSTCA9IFVSTChVUkwoKSwgdXJsLmJhc2VBc1N0cmluZygpKTsKKyAgICBhdXRvIGJhc2VQ YXRoID0gYmFzZVVSTC5maWxlU3lzdGVtUGF0aCgpOworICAgIGlmICghYmFzZVBhdGguaXNOdWxs KCkgJiYgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGJhc2VQYXRoLCBTYW5kYm94RXh0 ZW5zaW9uOjpUeXBlOjpSZWFkT25seSwgc2FuZGJveEV4dGVuc2lvbkhhbmRsZSkpCisgICAgICAg IG1fcHJvY2Vzcy0+YXNzdW1lUmVhZEFjY2Vzc1RvQmFzZVVSTCgqdGhpcywgYmFzZVVSTCk7CiB9 CiAKICNpZiAhUExBVEZPUk0oQ09DT0EpCg== 374034 2019-07-12 14:06:00 -0700 2019-07-12 15:03:33 -0700 Patch bug-199754-20190712140559.patch text/plain 2655 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY1ZGE4NmNiMDJiMDA3ZWI3 NDVhNWQyZjEwOGI2NjUzMzUzYzBiZDUuLjA1ODY0OTZiM2U0MmIyYTBhNzMwYWVhYmQzMDUzMWZk NGZkMzMxNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDctMTIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKG1hY09TIENhdGFs aW5hKTogQ2Fubm90IHF1aWNrIGxvb2sgaHRtbCBkb2N1bWVudHMgaW4gTWFpbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NzU0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTMwNDk2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBHZW9mZiBHYXJl bi4KKworICAgICAgICBJZiB0aGUgY2xpZW50IGFza3MgdXMgdG8gbG9hZCBhIGZpbGUgVVJMIGJ1 dCBkb2VzIG5vdCBwcm92aWRlIGEgcmVzb3VyY2UgcGF0aCwgV2ViS2l0CisgICAgICAgIHdvdWxk IGZhbGxiYWNrIHRvIGlzc3VpbmcgYSBzYW5kYm94IGV4dGVuc2lvbiBmb3IgLy4gVGhpcyBubyBs b25nZXIgd29ya3Mgb24gbWFjIE9TCisgICAgICAgIENhdGFsaW5hIGFuZCBpdCB3b3VsZCB0aHVz IGZhaWwgdG8gbG9hZCB0aGUgZmlsZS4KKworICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwg aWYgdGhlIGF0dGVtcHQgdG8gY3JlYXRlIGEgc2FuZGJveCBleHRlbnNpb24gZm9yIC8gZmFpbHMs IHdlIG5vdworICAgICAgICBmYWxsIGJhY2sgdG8gaXNzdWluZyBvbmUgZm9yIHRoZSBmaWxlJ3Mg YmFzZVVSTCAocGF0aCBvZiBjb250YWluaW5nIGZvbGRlcikuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjptYXli ZUluaXRpYWxpemVTYW5kYm94RXh0ZW5zaW9uSGFuZGxlKToKKwogMjAxOS0wNy0xMiAgVGltb3Ro eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgRHJvcCBEYXJrTW9kZUNT U0VuYWJsZWQgYXMgYW4gZXhwZXJpbWVudGFsIGZlYXR1cmUgYW5kIGFsd2F5cyBlbmFibGUgaXQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA2OGQ4ODFjODNh ZWY2MGE5NzBiYjk3NWE2M2RlODk4OTQ2ODg3NWFhLi5kNDEzZmVjODUyMzkwODg2NDA3MDM0N2Mx OTgzODY0N2RjYjVmY2ZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKQEAgLTEwNTgsOSArMTA1OCwxNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6bWF5YmVJbml0aWFs aXplU2FuZGJveEV4dGVuc2lvbkhhbmRsZShXZWJQcm9jZXNzUHJveHkmIHByb2NlcwogICAgIC8v IEluc3BlY3RvciByZXNvdXJjZXMgYXJlIGluIGEgZGlyZWN0b3J5IHdpdGggYXNzdW1lZCBhY2Nl c3MuCiAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIVdlYktpdDo6aXNJbnNw ZWN0b3JQYWdlKCp0aGlzKSk7CiAKLSAgICAvLyBGSVhNRTogdW5pdmVyc2FsIGZpbGUgcmVhZCBh Y2Nlc3Mgc2hvdWxkIGJlIHNldCBpZiB0aGUgc2FuZGJveCBleHRlbnNpb24gaXMgc3VjY2Vzc2Z1 bGx5IGNyZWF0ZWQ6IHJkYXI6Ly9wcm9ibGVtLzUyMzU3NTA4LgotICAgIFNhbmRib3hFeHRlbnNp b246OmNyZWF0ZUhhbmRsZSgiLyIsIFNhbmRib3hFeHRlbnNpb246OlR5cGU6OlJlYWRPbmx5LCBz YW5kYm94RXh0ZW5zaW9uSGFuZGxlKTsKLSAgICB3aWxsQWNxdWlyZVVuaXZlcnNhbEZpbGVSZWFk U2FuZGJveEV4dGVuc2lvbihwcm9jZXNzKTsKKyAgICBpZiAoU2FuZGJveEV4dGVuc2lvbjo6Y3Jl YXRlSGFuZGxlKCIvIiwgU2FuZGJveEV4dGVuc2lvbjo6VHlwZTo6UmVhZE9ubHksIHNhbmRib3hF eHRlbnNpb25IYW5kbGUpKSB7CisgICAgICAgIHdpbGxBY3F1aXJlVW5pdmVyc2FsRmlsZVJlYWRT YW5kYm94RXh0ZW5zaW9uKHByb2Nlc3MpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAg Ly8gV2UgZmFpbGVkIHRvIGlzc3VlIGFuIHVuaXZlcnNhbCBmaWxlIHJlYWQgYWNjZXNzIHNhbmRi b3gsIGZhbGwgYmFjayB0byBpc3N1aW5nIG9uZSBmb3IgdGhlIGJhc2UgVVJMIGluc3RlYWQuCisg ICAgYXV0byBiYXNlVVJMID0gVVJMKFVSTCgpLCB1cmwuYmFzZUFzU3RyaW5nKCkpOworICAgIGF1 dG8gYmFzZVBhdGggPSBiYXNlVVJMLmZpbGVTeXN0ZW1QYXRoKCk7CisgICAgaWYgKCFiYXNlUGF0 aC5pc051bGwoKSAmJiBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUoYmFzZVBhdGgsIFNh bmRib3hFeHRlbnNpb246OlR5cGU6OlJlYWRPbmx5LCBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKSkK KyAgICAgICAgbV9wcm9jZXNzLT5hc3N1bWVSZWFkQWNjZXNzVG9CYXNlVVJMKCp0aGlzLCBiYXNl VVJMKTsKIH0KIAogI2lmICFQTEFURk9STShDT0NPQSkK