199722 2019-07-11 13:19:31 -0700 [ews-build] Add build step to clean up .git/index.lock file 2019-07-11 16:20:07 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1552176 0 aakash_jain 2019-07-11 13:19:31 -0700 Sometimes some bots gets into a state when git operations fail with an error: "fatal: Unable to create 'build/.git/index.lock': File exists." , e.g.: https://ews-build.webkit-uat.org/#/builders/40/builds/177 This usually happens when a git operation is interrupted (e.g.: by buildbot restart while git operation was running). Once that happens bot can't recover themself, and they burn through all the build-requests very quickly. This is pretty bad. To make EWS robust against such issues, we should add build step to delete .git/index.lock file. 1552178 1 373945 aakash_jain 2019-07-11 13:23:06 -0700 Created attachment 373945 Patch 1552179 2 aakash_jain 2019-07-11 13:23:48 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/40/builds/193 1552180 3 ews-watchlist 2019-07-11 13:25:39 -0700 Attachment 373945 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:105: [CheckOutSource.getResultSummary] Instance of 'CheckOutSource' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:119: [CleanUpGitIndexLock.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:122: [CleanUpGitIndexLock.evaluateCommand] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:499: [TestCleanUpGitIndexLock.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:499: [TestCleanUpGitIndexLock.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:513: [TestCleanUpGitIndexLock.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:513: [TestCleanUpGitIndexLock.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1552206 4 373945 commit-queue 2019-07-11 14:12:46 -0700 Comment on attachment 373945 Patch Clearing flags on attachment: 373945 Committed r247364: <https://trac.webkit.org/changeset/247364> 1552208 5 commit-queue 2019-07-11 14:12:48 -0700 All reviewed patches have been landed. Closing bug. 1552209 6 webkit-bug-importer 2019-07-11 14:13:15 -0700 <rdar://problem/52971180> 1552276 7 aakash_jain 2019-07-11 16:20:07 -0700 Small follow-up fix: https://trac.webkit.org/changeset/247372/webkit Missed this while creating the patch previously. 373945 2019-07-11 13:23:06 -0700 2019-07-11 14:12:46 -0700 Patch bug-199722-20190711162305.patch text/plain 4883 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzM2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA3LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCB0byBjbGVhbiB1cCAuZ2l0 L2luZGV4LmxvY2sgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5NzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChDaGVja091dFNvdXJjZS5nZXRSZXN1bHRTdW1tYXJ5KTogUnVuIENsZWFuVXBHaXRJbmRleExv Y2sgc3RlcCB3aGVuIENoZWNrT3V0U291cmNlIGZhaWxzLgorICAgICAgICAoQ2xlYW5VcEdpdElu ZGV4TG9jay5fX2luaXRfXyk6IENvbmZpZ3VyZSB0aW1lb3V0IGFuZCBsb2dFbnZpcm9uLgorICAg ICAgICAoQ2xlYW5VcEdpdEluZGV4TG9jay5ldmFsdWF0ZUNvbW1hbmQpOiBBbHdheXMgUkVUUlkg dGhlIGJ1aWxkIGFmdGVyIHRoaXMgc3RlcCBpcyBydW4uCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBBZGRlZCB1bml0LXRlc3RzLgorCiAy MDE5LTA3LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TIDEzXSBFbmFibGUgV2ViS2l0IGJ1aWxkCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNDczNTkpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwMiwx MiArMTAyLDI4IEBAIGNsYXNzIENoZWNrT3V0U291cmNlKGdpdC5HaXQpOgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKiprd2FyZ3MpCiAKICAgICBkZWYg Z2V0UmVzdWx0U3VtbWFyeShzZWxmKToKKyAgICAgICAgaWYgc2VsZi5yZXN1bHRzID09IEZBSUxV UkU6CisgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChbQ2xl YW5VcEdpdEluZGV4TG9jaygpXSkKKwogICAgICAgICBpZiBzZWxmLnJlc3VsdHMgIT0gU1VDQ0VT UzoKICAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWlsZWQgdG8gdXBkYXRlZCB3b3Jr aW5nIGRpcmVjdG9yeSd9CiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICByZXR1cm4ge3Unc3Rl cCc6IHUnQ2xlYW5lZCBhbmQgdXBkYXRlZCB3b3JraW5nIGRpcmVjdG9yeSd9CiAKIAorY2xhc3Mg Q2xlYW5VcEdpdEluZGV4TG9jayhzaGVsbC5TaGVsbENvbW1hbmQpOgorICAgIG5hbWUgPSAnY2xl YW4tZ2l0LWluZGV4LWxvY2snCisgICAgY29tbWFuZCA9IFsncm0nLCAnLWYnLCAnLmdpdC9pbmRl eC5sb2NrJ10KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0RlbGV0ZWQgLmdpdC9pbmRleC5sb2Nr J10KKworICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CisgICAgICAgIHN1cGVyKENs ZWFuVXBHaXRJbmRleExvY2ssIHNlbGYpLl9faW5pdF9fKHRpbWVvdXQ9MiAqIDYwLCBsb2dFbnZp cm9uPUZhbHNlLCAqKmt3YXJncykKKworICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21k KToKKyAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFsnR2l0IGlzc3VlLCByZXRyeWlu ZyBidWlsZCddLCBSRVRSWSkKKyAgICAgICAgcmV0dXJuIHN1cGVyKENsZWFuVXBHaXRJbmRleExv Y2ssIHNlbGYpLmV2YWx1YXRlQ29tbWFuZChjbWQpCisKKwogY2xhc3MgQ2hlY2tPdXRTcGVjaWZp Y1JldmlzaW9uKHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgbmFtZSA9ICdjaGVja291dC1zcGVj aWZpYy1yZXZpc2lvbicKICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0NoZWNrZWQgb3V0IHJlcXVp cmVkIHJldmlzaW9uJ10KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0NzM1OSkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMzUsNyArMzUsNyBAQCBmcm9tIHR3aXN0ZWQucHl0aG9uIGltcG9ydCBmYWlsdXJlLCBs b2cKIGZyb20gdHdpc3RlZC50cmlhbCBpbXBvcnQgdW5pdHRlc3QKIAogZnJvbSBzdGVwcyBpbXBv cnQgKEFuYWx5emVBUElUZXN0c1Jlc3VsdHMsIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cywg QXBwbHlQYXRjaCwgQXJjaGl2ZUJ1aWx0UHJvZHVjdCwgQXJjaGl2ZVRlc3RSZXN1bHRzLAotICAg ICAgICAgICAgICAgICAgIENoZWNrT3V0U291cmNlLCBDaGVja091dFNwZWNpZmljUmV2aXNpb24s IENoZWNrUGF0Y2hSZWxldmFuY2UsIENoZWNrU3R5bGUsIENsZWFuQnVpbGQsIENsZWFuV29ya2lu Z0RpcmVjdG9yeSwKKyAgICAgICAgICAgICAgICAgICBDaGVja091dFNvdXJjZSwgQ2hlY2tPdXRT cGVjaWZpY1JldmlzaW9uLCBDaGVja1BhdGNoUmVsZXZhbmNlLCBDaGVja1N0eWxlLCBDbGVhbkJ1 aWxkLCBDbGVhblVwR2l0SW5kZXhMb2NrLCBDbGVhbldvcmtpbmdEaXJlY3RvcnksCiAgICAgICAg ICAgICAgICAgICAgQ29tcGlsZUpTQ09ubHksIENvbXBpbGVKU0NPbmx5VG9ULCBDb21waWxlV2Vi S2l0LCBDb21waWxlV2ViS2l0VG9ULCBDb25maWd1cmVCdWlsZCwKICAgICAgICAgICAgICAgICAg ICBEb3dubG9hZEJ1aWx0UHJvZHVjdCwgRXh0cmFjdEJ1aWx0UHJvZHVjdCwgRXh0cmFjdFRlc3RS ZXN1bHRzLCBJbnN0YWxsR3RrRGVwZW5kZW5jaWVzLCBJbnN0YWxsV3BlRGVwZW5kZW5jaWVzLCBL aWxsT2xkUHJvY2Vzc2VzLAogICAgICAgICAgICAgICAgICAgIFByaW50Q29uZmlndXJhdGlvbiwg UmVSdW5BUElUZXN0cywgUmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSdW5BUElUZXN0cywgUnVu QVBJVGVzdHNXaXRob3V0UGF0Y2gsCkBAIC00NzgsNiArNDc4LDQyIEBAIGNsYXNzIFRlc3RDbGVh bkJ1aWxkKEJ1aWxkU3RlcE1peGluQWRkaXQKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgp CiAKIAorY2xhc3MgVGVzdENsZWFuVXBHaXRJbmRleExvY2soQnVpbGRTdGVwTWl4aW5BZGRpdGlv bnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNl bGYubG9uZ01lc3NhZ2UgPSBUcnVlCisgICAgICAgIHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVw KCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYudGVhckRv d25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToKKyAgICAgICAgc2Vs Zi5zZXR1cFN0ZXAoQ2xlYW5VcEdpdEluZGV4TG9jaygpKQorICAgICAgICBzZWxmLmV4cGVjdFJl bW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAor ICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91dD0xMjAsCisgICAgICAgICAgICAgICAgICAg ICAgICBsb2dFbnZpcm9uPUZhbHNlLAorICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1b J3JtJywgJy1mJywgJy5naXQvaW5kZXgubG9jayddLAorICAgICAgICAgICAgICAgICAgICAgICAg KQorICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29t ZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdEZWxldGVkIC5naXQvaW5kZXgubG9jaycp CisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisgICAgZGVmIHRlc3RfZmFpbHVyZShz ZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoQ2xlYW5VcEdpdEluZGV4TG9jaygpKQorICAg ICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwo d29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91dD0xMjAsCisg ICAgICAgICAgICAgICAgICAgICAgICBsb2dFbnZpcm9uPUZhbHNlLAorICAgICAgICAgICAgICAg ICAgICAgICAgY29tbWFuZD1bJ3JtJywgJy1mJywgJy5naXQvaW5kZXgubG9jayddLAorICAgICAg ICAgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlv Jywgc3Rkb3V0PSdVbmV4cGVjdGVkIGVycm9yLicpCisgICAgICAgICAgICArIDEsCisgICAgICAg ICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJp bmc9J0RlbGV0ZWQgLmdpdC9pbmRleC5sb2NrIChmYWlsdXJlKScpCisgICAgICAgIHJldHVybiBz ZWxmLnJ1blN0ZXAoKQorCisKIGNsYXNzIFRlc3RJbnN0YWxsR3RrRGVwZW5kZW5jaWVzKEJ1aWxk U3RlcE1peGluQWRkaXRpb25zLCB1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHNldFVwKHNl bGYpOgogICAgICAgICBzZWxmLmxvbmdNZXNzYWdlID0gVHJ1ZQo=