199702 2019-07-10 21:40:44 -0700 [LFC][IFC] Cleanup InlineFormattingContext::LineLayout class. 2019-07-11 07:10:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1551981 0 zalan 2019-07-10 21:40:44 -0700 Move inner structs to .cpp 1551982 1 webkit-bug-importer 2019-07-10 21:41:09 -0700 <rdar://problem/52931733> 1551984 2 373905 zalan 2019-07-10 21:45:05 -0700 Created attachment 373905 Patch 1552050 3 373905 commit-queue 2019-07-11 07:10:01 -0700 Comment on attachment 373905 Patch Clearing flags on attachment: 373905 Committed r247350: <https://trac.webkit.org/changeset/247350> 1552051 4 commit-queue 2019-07-11 07:10:03 -0700 All reviewed patches have been landed. Closing bug. 373905 2019-07-10 21:45:05 -0700 2019-07-11 07:10:01 -0700 Patch bug-199702-20190710214504.patch text/plain 6946 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkzYmRmMjEzYjhmNTdk MDM0NmQzZjYzNDA5OWY2NWE1YWYwMjZjYi4uMTVlNjU2ZDMyYjMzOTNlYmYzMGZkY2Y5ZDBmNjcz MWZhNDg1ZWMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA3LTEwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBDbGVhbnVw IElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpMaW5lTGF5b3V0IGNsYXNzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NzAyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MjkzMTczMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNb3ZlIHNvbWUgc3RydWN0cyB0byAuY3BwLiBUaGV5IGRvbid0IG5lZWQg dG8gcG9sbHV0ZSB0aGUgY2xhc3MgZGVjbGFyYXRpb24uIAorCisgICAgICAgICogbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlvdXQ6OmxheW91dFN0 YXRlIGNvbnN0KToKKyAgICAgICAgKCk6IERlbGV0ZWQuCisgICAgICAgICogbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUlucHV0OjpIb3Jpem9udGFsQ29uc3RyYWludDo6SG9y aXpvbnRhbENvbnN0cmFpbnQpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lSW5wdXQ6 OkxpbmVJbnB1dCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdD b250ZXh0OjpMaW5lTGF5b3V0OjpwbGFjZUlubGluZUl0ZW1zIGNvbnN0KToKKyAgICAgICAgKFdl YkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlvdXQ6OkxpbmVJ bnB1dDo6SG9yaXpvbnRhbENvbnN0cmFpbnQ6Okhvcml6b250YWxDb25zdHJhaW50KTogRGVsZXRl ZC4KKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6Okxp bmVMYXlvdXQ6OkxpbmVJbnB1dDo6TGluZUlucHV0KTogRGVsZXRlZC4KKwogMjAxOS0wNy0xMCAg Um9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSExTTF0g T3B0aW9uYWw8VW5pcXVlUmVmPFQ+PiAtPiBzdGQ6OnVuaXF1ZV9wdHIgaW4gUmV0dXJuL0lmU3Rh dGVtZW50L0Zvckxvb3AKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5oCmluZGV4IDI0MmQ1 YWUyMmVmMzJlNDY1ZGM0ZmJlZTgwMDQ1ZjFmYWUwZWE0NTYuLmQ0NDc3YjA0ZTA0ODg5NDlmYmQ3 ZjQ5ZGMxODgzOTUzZDg5MzJmNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuaApA QCAtMzgsNiArMzgsOCBAQCBuYW1lc3BhY2UgTGF5b3V0IHsKIAogY2xhc3MgRmxvYXRpbmdTdGF0 ZTsKIGNsYXNzIElubGluZUNvbnRhaW5lcjsKK3N0cnVjdCBMaW5lQ29udGVudDsKK3N0cnVjdCBM aW5lSW5wdXQ7CiAKIC8vIFRoaXMgY2xhc3MgaW1wbGVtZW50cyB0aGUgbGF5b3V0IGxvZ2ljIGZv ciBpbmxpbmUgZm9ybWF0dGluZyBjb250ZXh0cy4KIC8vIGh0dHBzOi8vd3d3LnczLm9yZy9UUi9D U1MyMi92aXN1cmVuLmh0bWwjaW5saW5lLWZvcm1hdHRpbmcKQEAgLTU4LDMzICs2MCw2IEBAIHBy aXZhdGU6CiAKICAgICBwcml2YXRlOgogICAgICAgICBMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUo KSBjb25zdCB7IHJldHVybiBtX2xheW91dFN0YXRlOyB9Ci0KLSAgICAgICAgc3RydWN0IElubGlu ZUluZGV4QW5kU3BsaXRQb3NpdGlvbiB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBpbmRleCB7IDAg fTsKLSAgICAgICAgICAgIE9wdGlvbmFsPHVuc2lnbmVkPiBzcGxpdFBvc2l0aW9uOwotICAgICAg ICB9OwotCi0gICAgICAgIHN0cnVjdCBMaW5lSW5wdXQgewotICAgICAgICAgICAgTGluZUlucHV0 KExheW91dFBvaW50IGxvZ2ljYWxUb3BMZWZ0LCBMYXlvdXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxX aWR0aCwgTGluZTo6U2tpcFZlcnRpY2FsQWxpZ21lbnQsIElubGluZUluZGV4QW5kU3BsaXRQb3Np dGlvbiBmaXJzdFRvUHJvY2VzcywgY29uc3QgSW5saW5lSXRlbXMmKTsKLSAgICAgICAgICAgIHN0 cnVjdCBIb3Jpem9udGFsQ29uc3RyYWludCB7Ci0gICAgICAgICAgICAgICAgSG9yaXpvbnRhbENv bnN0cmFpbnQoTGF5b3V0UG9pbnQgbG9naWNhbFRvcExlZnQsIExheW91dFVuaXQgYXZhaWxhYmxl TG9naWNhbFdpZHRoKTsKLQotICAgICAgICAgICAgICAgIExheW91dFBvaW50IGxvZ2ljYWxUb3BM ZWZ0OwotICAgICAgICAgICAgICAgIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNhbFdpZHRoOwot ICAgICAgICAgICAgfTsKLSAgICAgICAgICAgIEhvcml6b250YWxDb25zdHJhaW50IGhvcml6b250 YWxDb25zdHJhaW50OwotICAgICAgICAgICAgLy8gRklYTUUgQWx0ZXJuYXRpdmVseSB3ZSBjb3Vs ZCBqdXN0IGhhdmUgYSBzZWNvbmQgcGFzcyB3aXRoIHZlcnRpY2FsIHBvc2l0aW9uaW5nIChwcmVm ZXJyZWQgd2lkdGggY29tcHV0YXRpb24gb3B0cyBvdXQpIAotICAgICAgICAgICAgTGluZTo6U2tp cFZlcnRpY2FsQWxpZ21lbnQgc2tpcFZlcnRpY2FsQWxpZ21lbnQ7Ci0gICAgICAgICAgICBJbmxp bmVJbmRleEFuZFNwbGl0UG9zaXRpb24gZmlyc3RJbmxpbmVJdGVtOwotICAgICAgICAgICAgY29u c3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zOwotICAgICAgICAgICAgT3B0aW9uYWw8TGF5b3V0 VW5pdD4gZmxvYXRNaW5pbXVtTG9naWNhbEJvdHRvbTsKLSAgICAgICAgfTsKLQotICAgICAgICBz dHJ1Y3QgTGluZUNvbnRlbnQgewotICAgICAgICAgICAgT3B0aW9uYWw8SW5saW5lSW5kZXhBbmRT cGxpdFBvc2l0aW9uPiBsYXN0Q29tbWl0dGVkOwotICAgICAgICAgICAgVmVjdG9yPFdlYWtQdHI8 SW5saW5lSXRlbT4+IGZsb2F0czsKLSAgICAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxMaW5lOjpD b250ZW50PiBydW5zOwotICAgICAgICB9OwogICAgICAgICBMaW5lQ29udGVudCBwbGFjZUlubGlu ZUl0ZW1zKGNvbnN0IExpbmVJbnB1dCYpIGNvbnN0OwogICAgICAgICB2b2lkIGNyZWF0ZURpc3Bs YXlSdW5zKGNvbnN0IExpbmU6OkNvbnRlbnQmLCBjb25zdCBWZWN0b3I8V2Vha1B0cjxJbmxpbmVJ dGVtPj4mIGZsb2F0cywgTGF5b3V0VW5pdCB3aWR0aENvbnN0cmFpbnQpIGNvbnN0OwogICAgICAg ICB2b2lkIGFsaWduUnVucyhUZXh0QWxpZ25Nb2RlLCBJbmxpbmVSdW5zJiwgdW5zaWduZWQgZmly c3RSdW5JbmRleCwgTGF5b3V0VW5pdCBhdmFpbGFibGVXaWR0aCkgY29uc3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5n Q29udGV4dExpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNwcAppbmRleCAzMzM3ZWJm ZTQzMjE0NTNmM2JjODg2Yjk2YWQ3ZGUyODQyYjA2ZGZmLi44ZTI1MDU3N2I0NGJlMjIyODI4NDll NWUyMDY1MGRkZTY4NjMxMzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdD b250ZXh0TGluZUxheW91dC5jcHAKQEAgLTQxLDYgKzQxLDMzIEBACiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBuYW1lc3BhY2UgTGF5b3V0IHsKIAorc3RydWN0IElubGluZUluZGV4QW5kU3BsaXRQb3Np dGlvbiB7CisgICAgdW5zaWduZWQgaW5kZXggeyAwIH07CisgICAgT3B0aW9uYWw8dW5zaWduZWQ+ IHNwbGl0UG9zaXRpb247Cit9OworCitzdHJ1Y3QgTGluZUlucHV0IHsKKyAgICBMaW5lSW5wdXQo TGF5b3V0UG9pbnQgbG9naWNhbFRvcExlZnQsIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNhbFdp ZHRoLCBMaW5lOjpTa2lwVmVydGljYWxBbGlnbWVudCwgSW5saW5lSW5kZXhBbmRTcGxpdFBvc2l0 aW9uIGZpcnN0VG9Qcm9jZXNzLCBjb25zdCBJbmxpbmVJdGVtcyYpOworICAgIHN0cnVjdCBIb3Jp em9udGFsQ29uc3RyYWludCB7CisgICAgICAgIEhvcml6b250YWxDb25zdHJhaW50KExheW91dFBv aW50IGxvZ2ljYWxUb3BMZWZ0LCBMYXlvdXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCk7CisK KyAgICAgICAgTGF5b3V0UG9pbnQgbG9naWNhbFRvcExlZnQ7CisgICAgICAgIExheW91dFVuaXQg YXZhaWxhYmxlTG9naWNhbFdpZHRoOworICAgIH07CisgICAgSG9yaXpvbnRhbENvbnN0cmFpbnQg aG9yaXpvbnRhbENvbnN0cmFpbnQ7CisgICAgLy8gRklYTUUgQWx0ZXJuYXRpdmVseSB3ZSBjb3Vs ZCBqdXN0IGhhdmUgYSBzZWNvbmQgcGFzcyB3aXRoIHZlcnRpY2FsIHBvc2l0aW9uaW5nIChwcmVm ZXJyZWQgd2lkdGggY29tcHV0YXRpb24gb3B0cyBvdXQpIAorICAgIExpbmU6OlNraXBWZXJ0aWNh bEFsaWdtZW50IHNraXBWZXJ0aWNhbEFsaWdtZW50OworICAgIElubGluZUluZGV4QW5kU3BsaXRQ b3NpdGlvbiBmaXJzdElubGluZUl0ZW07CisgICAgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0 ZW1zOworICAgIE9wdGlvbmFsPExheW91dFVuaXQ+IGZsb2F0TWluaW11bUxvZ2ljYWxCb3R0b207 Cit9OworCitzdHJ1Y3QgTGluZUNvbnRlbnQgeworICAgIE9wdGlvbmFsPElubGluZUluZGV4QW5k U3BsaXRQb3NpdGlvbj4gbGFzdENvbW1pdHRlZDsKKyAgICBWZWN0b3I8V2Vha1B0cjxJbmxpbmVJ dGVtPj4gZmxvYXRzOworICAgIHN0ZDo6dW5pcXVlX3B0cjxMaW5lOjpDb250ZW50PiBydW5zOwor fTsKKwogc3RydWN0IFVuY29tbWl0dGVkQ29udGVudCB7CiAgICAgc3RydWN0IFJ1biB7CiAgICAg ICAgIGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW07CkBAIC03MiwxMyArOTksMTMgQEAgdm9p ZCBVbmNvbW1pdHRlZENvbnRlbnQ6OnJlc2V0KCkKICAgICBtX3dpZHRoID0gMDsKIH0KIAotSW5s aW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlvdXQ6OkxpbmVJbnB1dDo6SG9yaXpvbnRhbENv bnN0cmFpbnQ6Okhvcml6b250YWxDb25zdHJhaW50KExheW91dFBvaW50IGxvZ2ljYWxUb3BMZWZ0 LCBMYXlvdXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCkKK0xpbmVJbnB1dDo6SG9yaXpvbnRh bENvbnN0cmFpbnQ6Okhvcml6b250YWxDb25zdHJhaW50KExheW91dFBvaW50IGxvZ2ljYWxUb3BM ZWZ0LCBMYXlvdXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCkKICAgICA6IGxvZ2ljYWxUb3BM ZWZ0KGxvZ2ljYWxUb3BMZWZ0KQogICAgICwgYXZhaWxhYmxlTG9naWNhbFdpZHRoKGF2YWlsYWJs ZUxvZ2ljYWxXaWR0aCkKIHsKIH0KIAotSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlv dXQ6OkxpbmVJbnB1dDo6TGluZUlucHV0KExheW91dFBvaW50IGxvZ2ljYWxUb3BMZWZ0LCBMYXlv dXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCwgTGluZTo6U2tpcFZlcnRpY2FsQWxpZ21lbnQg c2tpcFZlcnRpY2FsQWxpZ21lbnQsIElubGluZUluZGV4QW5kU3BsaXRQb3NpdGlvbiBmaXJzdFRv UHJvY2VzcywgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zKQorTGluZUlucHV0OjpMaW5l SW5wdXQoTGF5b3V0UG9pbnQgbG9naWNhbFRvcExlZnQsIExheW91dFVuaXQgYXZhaWxhYmxlTG9n aWNhbFdpZHRoLCBMaW5lOjpTa2lwVmVydGljYWxBbGlnbWVudCBza2lwVmVydGljYWxBbGlnbWVu dCwgSW5saW5lSW5kZXhBbmRTcGxpdFBvc2l0aW9uIGZpcnN0VG9Qcm9jZXNzLCBjb25zdCBJbmxp bmVJdGVtcyYgaW5saW5lSXRlbXMpCiAgICAgOiBob3Jpem9udGFsQ29uc3RyYWludChsb2dpY2Fs VG9wTGVmdCwgYXZhaWxhYmxlTG9naWNhbFdpZHRoKQogICAgICwgc2tpcFZlcnRpY2FsQWxpZ21l bnQoc2tpcFZlcnRpY2FsQWxpZ21lbnQpCiAgICAgLCBmaXJzdElubGluZUl0ZW0oZmlyc3RUb1By b2Nlc3MpCkBAIC0xMjMsNyArMTUwLDcgQEAgc3RhdGljIExheW91dFVuaXQgaW5saW5lSXRlbVdp ZHRoKGNvbnN0IExheW91dFN0YXRlJiBsYXlvdXRTdGF0ZSwgY29uc3QgSW5saW5lSXQKICAgICBy ZXR1cm4gZGlzcGxheUJveC53aWR0aCgpOwogfQogCi1JbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6 TGluZUxheW91dDo6TGluZUNvbnRlbnQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlv dXQ6OnBsYWNlSW5saW5lSXRlbXMoY29uc3QgTGluZUlucHV0JiBsaW5lSW5wdXQpIGNvbnN0CitM aW5lQ29udGVudCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6TGluZUxheW91dDo6cGxhY2VJbmxp bmVJdGVtcyhjb25zdCBMaW5lSW5wdXQmIGxpbmVJbnB1dCkgY29uc3QKIHsKICAgICBhdXRvIGlu aXRpYWxMaW5lQ29uc3RyYWludHMgPSBMaW5lOjpJbml0aWFsQ29uc3RyYWludHMgewogICAgICAg ICBsaW5lSW5wdXQuaG9yaXpvbnRhbENvbnN0cmFpbnQubG9naWNhbFRvcExlZnQsCg==