19970 2008-07-10 03:50:53 -0700 PluginView/Win32 does not compile with MinGW 2008-07-14 02:27:29 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ariya.hidayat webkit-unassigned oldest_to_newest 85604 0 ariya.hidayat 2008-07-10 03:50:53 -0700 The following line causes problem: friend static LRESULT CALLBACK PluginViewWndProc(HWND, UINT, WPARAM, LPARAM); since gcc 3.4.5 (on latest stable MinGW) chokes on that. 85605 1 22198 ariya.hidayat 2008-07-10 04:02:32 -0700 Created attachment 22198 patch to fix the problem (as discussed with aroben and andersca) 85607 2 22198 aroben 2008-07-10 08:04:43 -0700 Comment on attachment 22198 patch to fix the problem (as discussed with aroben and andersca) r=me 85879 3 ariya.hidayat 2008-07-14 02:27:29 -0700 Landed in r35124 22198 2008-07-10 04:02:32 -0700 2008-07-10 08:04:43 -0700 patch to fix the problem (as discussed with aroben and andersca) webkit-plugin-win32-mingw-fix.patch text/plain 2732 ariya.hidayat Y29tbWl0IGM0NzE4OGJiN2Q4NmQ0NDk0MjRiYWE3NjZkNWMzOWE5NDhkZDI1ZjcKQXV0aG9yOiBB cml5YSBIaWRheWF0IDxhcml5YS5oaWRheWF0QHRyb2xsdGVjaC5jb20+CkRhdGU6ICAgVGh1IEp1 bCAxMCAxMjo0NjozOCAyMDA4ICswMjAwCgogICAgRml4IGNvbXBpbGUgd2l0aCBNaW5HVyBzaW5j ZSBpdCBkb2VzIG5vdCBsaWtlIGZyaWVuZCBzdGF0aWMgZnVuY3Rpb24uCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaCBiL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmgKaW5kZXggZWRkMzQ3My4uYmM4ZDAyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuaAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCkBAIC01Niw3ICs1 Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBLZXlib2FyZEV2ZW50OwogICAg IGNsYXNzIE1vdXNlRXZlbnQ7CiAgICAgY2xhc3MgS1VSTDsKLSNpZiBQTEFURk9STShXSU4pCisj aWYgUExBVEZPUk0oV0lOX09TKQogICAgIGNsYXNzIFBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW47 CiAjZW5kaWYKICAgICBjbGFzcyBQbHVnaW5QYWNrYWdlOwpAQCAtOTEsMTAgKzkxLDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIH07CiAKICAgICBjbGFzcyBQbHVnaW5WaWV3IDogcHVibGlj IFdpZGdldCwgcHJpdmF0ZSBQbHVnaW5TdHJlYW1DbGllbnQgewotI2lmIFBMQVRGT1JNKFdJTikK LSAgICBmcmllbmQgc3RhdGljIExSRVNVTFQgQ0FMTEJBQ0sgUGx1Z2luVmlld1duZFByb2MoSFdO RCwgVUlOVCwgV1BBUkFNLCBMUEFSQU0pOwotI2VuZGlmCi0KICAgICBwdWJsaWM6CiAgICAgICAg IHN0YXRpYyBQbHVnaW5WaWV3KiBjcmVhdGUoRnJhbWUqIHBhcmVudEZyYW1lLCBjb25zdCBJbnRT aXplJiwgRWxlbWVudCosIGNvbnN0IEtVUkwmLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFyYW1O YW1lcywgY29uc3QgVmVjdG9yPFN0cmluZz4mIHBhcmFtVmFsdWVzLCBjb25zdCBTdHJpbmcmIG1p bWVUeXBlLCBib29sIGxvYWRNYW51YWxseSk7CiAgICAgICAgIHZpcnR1YWwgflBsdWdpblZpZXco KTsKQEAgLTE1Niw3ICsxNTIsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgdmly dHVhbCBib29sIGlzUGx1Z2luVmlldygpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAotI2lmIFBM QVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU5fT1MpCisgICAgICAgIHN0YXRpYyBMUkVTVUxU IENBTExCQUNLIFBsdWdpblZpZXdXbmRQcm9jKEhXTkQsIFVJTlQsIFdQQVJBTSwgTFBBUkFNKTsK ICAgICAgICAgTFJFU1VMVCB3bmRQcm9jKEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0g d1BhcmFtLCBMUEFSQU0gbFBhcmFtKTsKICAgICAgICAgV05EUFJPQyBwbHVnaW5XbmRQcm9jKCkg Y29uc3QgeyByZXR1cm4gbV9wbHVnaW5XbmRQcm9jOyB9CiAjZW5kaWYKQEAgLTIzOCw3ICsyMzUs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV9uZWVkc1hFbWJlZDsKICNl bmRpZgogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTl9PUykKICAgICAgICAg T3duUHRyPFBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW4+IG1fbWVzc2FnZVRocm90dGxlcjsKICAg ICAgICAgV05EUFJPQyBtX3BsdWdpblduZFByb2M7CiAgICAgICAgIHVuc2lnbmVkIG1fbGFzdE1l c3NhZ2U7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3Bw IGIvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAppbmRleCBkNGYzY2E2Li4y Y2E0YTk2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3Bw CisrKyBiL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTg1LDggKzg1 LDYgQEAgY29uc3QgTFBDV1NUUiBrV2ViUGx1Z2luVmlld1Byb3BlcnR5ID0gTCJXZWJQbHVnaW5W aWV3UHJvcGVydHkiOwogCiBzdGF0aWMgY29uc3QgY2hhciogTW96aWxsYVVzZXJBZ2VudCA9ICJN b3ppbGxhLzUuMCAoV2luZG93czsgVTsgV2luZG93cyBOVCA1LjE7IGVuLVVTOyBydjoxLjguMSkg R2Vja28vMjAwNjEwMTAgRmlyZWZveC8yLjAiOwogCi1zdGF0aWMgTFJFU1VMVCBDQUxMQkFDSyBQ bHVnaW5WaWV3V25kUHJvYyhIV05EIGhXbmQsIFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwg TFBBUkFNIGxQYXJhbSk7Ci0KIHN0YXRpYyBib29sIHJlZ2lzdGVyUGx1Z2luVmlldygpCiB7CiAg ICAgc3RhdGljIGJvb2wgaGF2ZVJlZ2lzdGVyZWRXaW5kb3dDbGFzcyA9IGZhbHNlOwpAQCAtMTE2 LDcgKzExNCw3IEBAIHN0YXRpYyBib29sIHJlZ2lzdGVyUGx1Z2luVmlldygpCiAgICAgcmV0dXJu ICEhUmVnaXN0ZXJDbGFzc0V4KCZ3Y2V4KTsKIH0KIAotc3RhdGljIExSRVNVTFQgQ0FMTEJBQ0sg UGx1Z2luVmlld1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0s IExQQVJBTSBsUGFyYW0pCitMUkVTVUxUIENBTExCQUNLIFBsdWdpblZpZXc6OlBsdWdpblZpZXdX bmRQcm9jKEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBh cmFtKQogewogICAgIFBsdWdpblZpZXcqIHBsdWdpblZpZXcgPSByZWludGVycHJldF9jYXN0PFBs dWdpblZpZXcqPihHZXRQcm9wKGhXbmQsIGtXZWJQbHVnaW5WaWV3UHJvcGVydHkpKTsKIAo=