199696 2019-07-10 18:47:00 -0700 Long pressing on attachments will crash the WebContent process 2019-07-10 21:09:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue dino simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1551938 0 thorton 2019-07-10 18:47:00 -0700 Long pressing on attachments will crash the WebContent process 1551939 1 373890 thorton 2019-07-10 18:47:56 -0700 Created attachment 373890 Patch 1551940 2 thorton 2019-07-10 18:47:57 -0700 <rdar://problem/52920241> 1551947 3 373890 dino 2019-07-10 18:56:17 -0700 Comment on attachment 373890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373890&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667 > + linkIndicatorPositionInformation(page, attachment, request, info); Less than perfect name for a function (there are many like this in the file). 1551974 4 thorton 2019-07-10 20:39:02 -0700 (In reply to Dean Jackson from comment #3) > Comment on attachment 373890 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373890&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667 > > + linkIndicatorPositionInformation(page, attachment, request, info); > > Less than perfect name for a function (there are many like this in the file). Said introduced them recently, it all still needs baking but at least it’s not a giant function anymore. 1551978 5 373890 commit-queue 2019-07-10 21:09:58 -0700 Comment on attachment 373890 Patch Clearing flags on attachment: 373890 Committed r247342: <https://trac.webkit.org/changeset/247342> 1551979 6 commit-queue 2019-07-10 21:09:59 -0700 All reviewed patches have been landed. Closing bug. 373890 2019-07-10 18:47:56 -0700 2019-07-10 21:09:58 -0700 Patch bug-199696-20190710184755.patch text/plain 6963 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYxOWY4NmEzZjBkZGY2NTVk MTdkOWMxMTViYjZjMzVkNmNlMTFiM2QuLjJkOTExNTkyNmFhMjE4YWQzNzEzOGQyZjZmNzViOGVk YWJmMDkwZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMDctMTAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTG9uZyBwcmVzc2luZyBv biBhdHRhY2htZW50cyB3aWxsIGNyYXNoIHRoZSBXZWJDb250ZW50IHByb2Nlc3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTY5NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTI5MjAyNDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06 CisgICAgICAgIChXZWJLaXQ6OmxpbmtJbmRpY2F0b3JQb3NpdGlvbkluZm9ybWF0aW9uKToKKyAg ICAgICAgKFdlYktpdDo6ZWxlbWVudFBvc2l0aW9uSW5mb3JtYXRpb24pOgorICAgICAgICAoV2Vi S2l0OjpzZWxlY3Rpb25Qb3NpdGlvbkluZm9ybWF0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZTo6cG9zaXRpb25JbmZvcm1hdGlvbik6CisgICAgICAgIEluc3RlYWQgb2Ygb25lLW9mZiBj cmVhdGluZyBhIG5vZGUgc25hcHNob3QgZm9yIDxhdHRhY2htZW50PiwganVzdAorICAgICAgICB1 c2UgVGV4dEluZGljYXRvci4gVGhpcyB3YXksIHdlIGdldCBhbiBlc3RpbWF0ZWQgYmFja2dyb3Vu ZCBjb2xvciwKKyAgICAgICAgcGFpbnQgYXQgdGhlIHJpZ2h0IHJlc29sdXRpb24sIGV0Yy4KKwor ICAgICAgICBBbHNvLCBoaXROb2RlIHdhcyBvZnRlbiBudWxsIHdoZXJlIHdlIHdlcmUgcHJldmlv dXNseSBjYWxsaW5nCisgICAgICAgIHNoYXJlYWJsZUJpdG1hcFNuYXBzaG90Rm9yTm9kZSwgYmVj YXVzZSBpdCBkZXBlbmRzIG9uIHRoZSBlbGVtZW50CisgICAgICAgIGhhdmluZyBjbGljayBldmVu dCBoYW5kbGVycy4gc2VsZWN0aW9uUG9zaXRpb25JbmZvcm1hdGlvbigpIHJlLWhpdC10ZXN0cwor ICAgICAgICBtb3JlIHBlcm1pc3NpdmVseSB0byBmaW5kIHRoZSA8YXR0YWNobWVudD4sIHNvIG1v dmluZyB0aGlzIGNvZGUKKyAgICAgICAgaW5zaWRlIHRoYXQgZnVuY3Rpb24gZW5zdXJlcyB0aGF0 IHdlIGRvbid0IHRyeSB0byBzbmFwc2hvdCBhIG51bGwgbm9kZS4KKwogMjAxOS0wNy0xMCAgRGVh biBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgU2hhcmUgb3IgQ29weSBpbWFn ZSBmcm9tIGNvbnRleHQgbWVudSBkb2VzIG5vdCBzaGFyZSB0aGUgY29ycmVjdCBkYXRhCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmlu ZGV4IGM3YmQ4ZDc5YmEwZDY5ZmVhMTdkYzNhNzdkZmI0Y2U2YmVmMzQ5ODUuLjUzOWZiZDFlOGEw ODBiYWRkYjAxYmU4Y2UzY2FmZjEzZGNjMzlkMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0yNTIzLDcgKzI1MjMsNyBA QCBzdGF0aWMgdm9pZCBmb2N1c2VkRWxlbWVudFBvc2l0aW9uSW5mb3JtYXRpb24oV2ViUGFnZSYg cGFnZSwgRWxlbWVudCYgZm9jdXNlZEVsZQogICAgIGluZm8uaXNOZWFyTWFya2VkVGV4dCA9ICEo ZGVsdGFYID4ga0hpdEFyZWFXaWR0aCB8fCBkZWx0YVlGcm9tVGhlVG9wID4ga0hpdEFyZWFIZWln aHQgfHwgZGVsdGFZRnJvbVRoZUJvdHRvbSA+IGtIaXRBcmVhSGVpZ2h0KTsKIH0KIAotc3RhdGlj IHZvaWQgbGlua0luZGljYXRvclBvc2l0aW9uSW5mb3JtYXRpb24oV2ViUGFnZSYgcGFnZSwgRWxl bWVudCYgZWxlbWVudCwgRWxlbWVudCYgbGlua0VsZW1lbnQsIGNvbnN0IEludGVyYWN0aW9uSW5m b3JtYXRpb25SZXF1ZXN0JiByZXF1ZXN0LCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv biYgaW5mbykKK3N0YXRpYyB2b2lkIGxpbmtJbmRpY2F0b3JQb3NpdGlvbkluZm9ybWF0aW9uKFdl YlBhZ2UmIHBhZ2UsIEVsZW1lbnQmIGxpbmtFbGVtZW50LCBjb25zdCBJbnRlcmFjdGlvbkluZm9y bWF0aW9uUmVxdWVzdCYgcmVxdWVzdCwgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24m IGluZm8pCiB7CiAgICAgaWYgKCFyZXF1ZXN0LmluY2x1ZGVMaW5rSW5kaWNhdG9yKQogICAgICAg ICByZXR1cm47CkBAIC0yNjM1LDcgKzI2MzUsNyBAQCBzdGF0aWMgdm9pZCBlbGVtZW50UG9zaXRp b25JbmZvcm1hdGlvbihXZWJQYWdlJiBwYWdlLCBFbGVtZW50JiBlbGVtZW50LCBjb25zdCBJbgog ICAgICAgICBpbmZvLmlzTGluayA9IHRydWU7CiAgICAgICAgIGluZm8udXJsID0gbGlua0VsZW1l bnQtPmRvY3VtZW50KCkuY29tcGxldGVVUkwoc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3Bh Y2VzKGxpbmtFbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikpKTsKIAot ICAgICAgICBsaW5rSW5kaWNhdG9yUG9zaXRpb25JbmZvcm1hdGlvbihwYWdlLCBlbGVtZW50LCAq bGlua0VsZW1lbnQsIHJlcXVlc3QsIGluZm8pOworICAgICAgICBsaW5rSW5kaWNhdG9yUG9zaXRp b25JbmZvcm1hdGlvbihwYWdlLCAqbGlua0VsZW1lbnQsIHJlcXVlc3QsIGluZm8pOwogI2lmIEVO QUJMRShEQVRBX0RFVEVDVElPTikKICAgICAgICAgZGF0YURldGVjdG9yTGlua1Bvc2l0aW9uSW5m b3JtYXRpb24oZWxlbWVudCwgaW5mbyk7CiAjZW5kaWYKQEAgLTI2NjIsOCArMjY2Miw5IEBAIHN0 YXRpYyB2b2lkIHNlbGVjdGlvblBvc2l0aW9uSW5mb3JtYXRpb24oV2ViUGFnZSYgcGFnZSwgY29u c3QgSW50ZXJhY3Rpb25JbmZvcm1hCiAgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBzZWxlY3QgYmxv Y2tzIHRoYXQgYXJlIGxhcmdlciB0aGFuIDk3JSBvZiB0aGUgdmlzaWJsZSBhcmVhIG9mIHRoZSBk b2N1bWVudC4KICAgICBpZiAoaXM8SFRNTEF0dGFjaG1lbnRFbGVtZW50PigqaGl0Tm9kZSkpIHsK ICAgICAgICAgaW5mby5pc0F0dGFjaG1lbnQgPSB0cnVlOwotICAgICAgICBjb25zdCBIVE1MQXR0 YWNobWVudEVsZW1lbnQmIGF0dGFjaG1lbnQgPSBkb3duY2FzdDxIVE1MQXR0YWNobWVudEVsZW1l bnQ+KCpoaXROb2RlKTsKKyAgICAgICAgSFRNTEF0dGFjaG1lbnRFbGVtZW50JiBhdHRhY2htZW50 ID0gZG93bmNhc3Q8SFRNTEF0dGFjaG1lbnRFbGVtZW50PigqaGl0Tm9kZSk7CiAgICAgICAgIGlu Zm8udGl0bGUgPSBhdHRhY2htZW50LmF0dGFjaG1lbnRUaXRsZSgpOworICAgICAgICBsaW5rSW5k aWNhdG9yUG9zaXRpb25JbmZvcm1hdGlvbihwYWdlLCBhdHRhY2htZW50LCByZXF1ZXN0LCBpbmZv KTsKICAgICAgICAgaWYgKGF0dGFjaG1lbnQuZmlsZSgpKQogICAgICAgICAgICAgaW5mby51cmwg PSBVUkw6OmZpbGVVUkxXaXRoRmlsZVN5c3RlbVBhdGgoZG93bmNhc3Q8SFRNTEF0dGFjaG1lbnRF bGVtZW50PigqaGl0Tm9kZSkuZmlsZSgpLT5wYXRoKCkpOwogICAgIH0gZWxzZSB7CkBAIC0yNzI1 LDE1ICsyNzI2LDkgQEAgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24gV2ViUGFnZTo6 cG9zaXRpb25JbmZvcm1hdGlvbihjb25zdCBJbnRlcmFjdGlvbkkKICAgICAgICAgICAgIGluZm8u aW1hZ2UgPSBzaGFyZWFibGVCaXRtYXBTbmFwc2hvdEZvck5vZGUoZWxlbWVudCk7CiAgICAgfQog Ci0gICAgaWYgKCEoaW5mby5pc0xpbmsgfHwgaW5mby5pc0ltYWdlKSkgeworICAgIGlmICghKGlu Zm8uaXNMaW5rIHx8IGluZm8uaXNJbWFnZSkpCiAgICAgICAgIHNlbGVjdGlvblBvc2l0aW9uSW5m b3JtYXRpb24oKnRoaXMsIHJlcXVlc3QsIGluZm8pOwogCi0gICAgICAgIGlmIChpbmZvLmlzQXR0 YWNobWVudCAmJiByZXF1ZXN0LmluY2x1ZGVTbmFwc2hvdCkgewotICAgICAgICAgICAgRWxlbWVu dCYgZWxlbWVudCA9IGRvd25jYXN0PEVsZW1lbnQ+KCpoaXROb2RlKTsKLSAgICAgICAgICAgIGlu Zm8uaW1hZ2UgPSBzaGFyZWFibGVCaXRtYXBTbmFwc2hvdEZvck5vZGUoZWxlbWVudCk7Ci0gICAg ICAgIH0KLSAgICB9Ci0KICAgICAvLyBQcmV2ZW50IHRoZSBjYWxsb3V0IGJhciBmcm9tIHNob3dp bmcgd2hlbiB0YXBwaW5nIG9uIHRoZSBkYXRhbGlzdCBidXR0b24uCiAjaWYgRU5BQkxFKERBVEFM SVNUX0VMRU1FTlQpCiAgICAgaWYgKGlzPEhUTUxJbnB1dEVsZW1lbnQ+KGhpdE5vZGUpKSB7CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmJhOTcx ZjJkNDM1OWY5YTdiNjgyNTQ5ZmE0ZmUwYTA0MDM1OWE3MS4uNjlhMDMwNGI0ZWIwZGNlY2U5YjM2 ZmE3YWFiMmRlNGMyMzMwY2Y3OCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTEwICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIExvbmcgcHJlc3Npbmcgb24gYXR0 YWNobWVudHMgd2lsbCBjcmFzaCB0aGUgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk2OTYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzUyOTIwMjQxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS1JlcXVlc3RB Y3RpdmF0ZWRFbGVtZW50SW5mby5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgor ICAgICAgICBBZGQgYSB0ZXN0IHRoYXQgcHJldmlvdXNseSBjcmFzaGVkLgorCiAyMDE5LTA3LTEw ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNPU10g RmlsdGVyIFZQQSBpbmZvIGxvZ2dlZCB0byBzdGRvdXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tSZXF1ZXN0QWN0aXZhdGVkRWxlbWVudEluZm8u bW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLUmVxdWVzdEFjdGl2 YXRlZEVsZW1lbnRJbmZvLm1tCmluZGV4IGY4NWRiYTFjYzdkNjY4ODZhN2Q4MGIwYzViZWFlN2U3 OThjMmQ4ZGUuLjZlNzkzZDAyM2M1Nzk1MjY4YzE5MGUzZTI1YmUzNzBiNWY0NWE5NjkgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tSZXF1ZXN0QWN0 aXZhdGVkRWxlbWVudEluZm8ubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9XS1JlcXVlc3RBY3RpdmF0ZWRFbGVtZW50SW5mby5tbQpAQCAtMzAsNiArMzAsNyBA QAogI2ltcG9ydCAiVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5oIgogI2ltcG9ydCAiVGVzdFdLV2Vi Vmlldy5oIgogI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmlldy5oPgorI2ltcG9ydCA8V2ViS2l0L1dL V2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvX1dLQWN0aXZh dGVkRWxlbWVudEluZm8uaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KIApAQCAtMTM0LDYg KzEzNSwyNSBAQCBURVNUKFdlYktpdCwgUmVxdWVzdEFjdGl2YXRlZEVsZW1lbnRJbmZvRm9yQnJv a2VuSW1hZ2UpCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZmaW5pc2hlZCk7CiB9CiAK K1RFU1QoV2ViS2l0LCBSZXF1ZXN0QWN0aXZhdGVkRWxlbWVudEluZm9Gb3JBdHRhY2htZW50KQor eworICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0 aW9uIGFsbG9jXSBpbml0XSk7CisgICAgW2NvbmZpZ3VyYXRpb24gX3NldEF0dGFjaG1lbnRFbGVt ZW50RW5hYmxlZDpZRVNdOworCisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dl YlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDUwMCkgY29u ZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7CisgICAgW3dlYlZpZXcgbG9hZEhUTUxT dHJpbmc6QCI8aHRtbD48aGVhZD48bWV0YSBuYW1lPSd2aWV3cG9ydCcgY29udGVudD0naW5pdGlh bC1zY2FsZT0xJz48L2hlYWQ+PGJvZHkgc3R5bGU9J21hcmdpbjogMHB4Oyc+PGF0dGFjaG1lbnQg IC8+PC9ib2R5PjwvaHRtbD4iIGJhc2VVUkw6bmlsXTsKKyAgICBbd2ViVmlldyBfdGVzdF93YWl0 Rm9yRGlkRmluaXNoTmF2aWdhdGlvbl07CisKKyAgICBfX2Jsb2NrIGJvb2wgZmluaXNoZWQgPSBm YWxzZTsKKyAgICBbd2ViVmlldyBfcmVxdWVzdEFjdGl2YXRlZEVsZW1lbnRBdFBvc2l0aW9uOkNH UG9pbnRNYWtlKDIwLCAyMCkgY29tcGxldGlvbkJsb2NrOl4oX1dLQWN0aXZhdGVkRWxlbWVudElu Zm8gKmVsZW1lbnRJbmZvKSB7CisgICAgICAgIEVYUEVDVF9UUlVFKGVsZW1lbnRJbmZvLnR5cGUg PT0gX1dLQWN0aXZhdGVkRWxlbWVudFR5cGVBdHRhY2htZW50KTsKKworICAgICAgICBmaW5pc2hl ZCA9IHRydWU7CisgICAgfV07CisKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmZpbmlz aGVkKTsKK30KKwogVEVTVChXZWJLaXQsIFJlcXVlc3RBY3RpdmF0ZWRFbGVtZW50SW5mb1dpdGhO ZXN0ZWRTeW5jaHJvbm91c1VwZGF0ZXMpCiB7CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhb W1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAs IDUwMCldKTsK