199678 2019-07-10 12:02:32 -0700 Context menus are not presented for WKWebViews that don't have UIDelegates 2019-07-10 13:04:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton achristensen commit-queue dino webkit-bug-importer oldest_to_newest 1551766 0 thorton 2019-07-10 12:02:32 -0700 Context menus are not presented for WKWebViews that don't have UIDelegates 1551767 1 373855 thorton 2019-07-10 12:03:34 -0700 Created attachment 373855 Patch 1551769 2 webkit-bug-importer 2019-07-10 12:06:50 -0700 <rdar://problem/52905302> 1551792 3 373855 commit-queue 2019-07-10 13:04:33 -0700 Comment on attachment 373855 Patch Clearing flags on attachment: 373855 Committed r247321: <https://trac.webkit.org/changeset/247321> 1551793 4 commit-queue 2019-07-10 13:04:34 -0700 All reviewed patches have been landed. Closing bug. 373855 2019-07-10 12:03:34 -0700 2019-07-10 13:04:33 -0700 Patch bug-199678-20190710120333.patch text/plain 6963 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1NWU0YzQwYjc0NzkyYjcz ZWM3N2I2ZDAwOWYwNjcwNzAyNWJjMDIuLjk0OWE5MDE1YmI4Njg4MzExYjZmYzJmZGU3NGQ2NDg0 MjlkOTIyZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDctMTAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ29udGV4dCBtZW51cyBh cmUgbm90IHByZXNlbnRlZCBmb3IgV0tXZWJWaWV3cyB0aGF0IGRvbid0IGhhdmUgVUlEZWxlZ2F0 ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTY3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgY29udGludWVDb250ZXh0TWVudUludGVyYWN0aW9uOl0pOgorICAgICAgICBSZW1v dmUgdGhpcyB1bm5lY2Vzc2FyeSBlYXJseS1yZXR1cm4gaWYgd2UgZG9uJ3QgaGF2ZSBhIFVJRGVs ZWdhdGUuCisgICAgICAgIFdlIGhhdmUgYSBkZWZhdWx0IGJlaGF2aW9yIHRoYXQgd2UgdG90YWxs eSB3YW50IHRvIGhhcHBlbi4KKyAgICAgICAgQWxzbywgcmVuYW1lIGNvbXBsZXRpb24oKSB0byBj b250aW51ZVdpdGhDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24oKQorICAgICAgICB0byByZWR1Y2Ug Y29uZnVzaW9uIGJldHdlZW4gY29tcGxldGlvbigpIGFuZCBjb21wbGV0aW9uQmxvY2soKSBpbgor ICAgICAgICB0aGlzIG1ldGhvZC4KKwogMjAxOS0wNy0xMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBhZnRlciBGb3VuZGF0 aW9uIGNoYW5nZXMgVUlFZGdlSW5zZXRzIGRlZmluaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDM5 OWIxYjdiMDY1MjI3N2Y5MzdjNzUwMWE0ZGU2MDE3MmVhMGU3MmIuLmM1N2U5NDBlZmFjM2U2N2Y3 ODYzNDM0Yjk3MmU0NGM3OWY1MjdjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNzgwMSwzMSArNzgw MSwyOCBAQCAtICh2b2lkKV9jb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRleHRNZW51SW50 ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBjb25maWd1cgogICAgIH0gZm9yUmVxdWVzdDpyZXF1ZXN0 XTsKIH0KIAotLSAodm9pZCljb250aW51ZUNvbnRleHRNZW51SW50ZXJhY3Rpb246KHZvaWQoXiko VUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKikpY29tcGxldGlvbgorLSAodm9pZCljb250aW51 ZUNvbnRleHRNZW51SW50ZXJhY3Rpb246KHZvaWQoXikoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRp b24gKikpY29udGludWVXaXRoQ29udGV4dE1lbnVDb25maWd1cmF0aW9uCiB7CiAgICAgaWYgKCFf cG9zaXRpb25JbmZvcm1hdGlvbi50b3VjaENhbGxvdXRFbmFibGVkKQotICAgICAgICByZXR1cm4g Y29tcGxldGlvbihuaWwpOworICAgICAgICByZXR1cm4gY29udGludWVXaXRoQ29udGV4dE1lbnVD b25maWd1cmF0aW9uKG5pbCk7CiAKICAgICBpZiAoIV9wb3NpdGlvbkluZm9ybWF0aW9uLmlzTGlu ayAmJiAhX3Bvc2l0aW9uSW5mb3JtYXRpb24uaXNJbWFnZSAmJiAhX3Bvc2l0aW9uSW5mb3JtYXRp b24uaXNBdHRhY2htZW50KQotICAgICAgICByZXR1cm4gY29tcGxldGlvbihuaWwpOworICAgICAg ICByZXR1cm4gY29udGludWVXaXRoQ29udGV4dE1lbnVDb25maWd1cmF0aW9uKG5pbCk7CiAKICAg ICBVUkwgbGlua1VSTCA9IF9wb3NpdGlvbkluZm9ybWF0aW9uLnVybDsKIAogICAgIGlmIChfcG9z aXRpb25JbmZvcm1hdGlvbi5pc0xpbmsgJiYgbGlua1VSTC5pc0VtcHR5KCkpCi0gICAgICAgIHJl dHVybiBjb21wbGV0aW9uKG5pbCk7CisgICAgICAgIHJldHVybiBjb250aW51ZVdpdGhDb250ZXh0 TWVudUNvbmZpZ3VyYXRpb24obmlsKTsKIAogICAgIGF1dG8gdWlEZWxlZ2F0ZSA9IHN0YXRpY19j YXN0PGlkPFdLVUlEZWxlZ2F0ZVByaXZhdGU+Pihfd2ViVmlldy5VSURlbGVnYXRlKTsKLSAgICBp ZiAoIXVpRGVsZWdhdGUpCi0gICAgICAgIHJldHVybiBjb21wbGV0aW9uKG5pbCk7CiAKICAgICBp ZiAobmVlZHNEZXByZWNhdGVkUHJldmlld0FQSSh1aURlbGVnYXRlKSkgewotCiAgICAgICAgIGlm IChfcG9zaXRpb25JbmZvcm1hdGlvbi5pc0xpbmspIHsKICAgICAgICAgICAgIEFMTE9XX0RFUFJF Q0FURURfREVDTEFSQVRJT05TX0JFR0lOCiAgICAgICAgICAgICBpZiAoW3VpRGVsZWdhdGUgcmVz cG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcih3ZWJWaWV3OnNob3VsZFByZXZpZXdFbGVtZW50Oild KSB7CiAgICAgICAgICAgICAgICAgYXV0byBwcmV2aWV3RWxlbWVudEluZm8gPSBhZG9wdE5TKFtb V0tQcmV2aWV3RWxlbWVudEluZm8gYWxsb2NdIF9pbml0V2l0aExpbmtVUkw6bGlua1VSTF0pOwog ICAgICAgICAgICAgICAgIGlmICghW3VpRGVsZWdhdGUgd2ViVmlldzpfd2ViVmlldyBzaG91bGRQ cmV2aWV3RWxlbWVudDpwcmV2aWV3RWxlbWVudEluZm8uZ2V0KCldKQotICAgICAgICAgICAgICAg ICAgICByZXR1cm4gY29tcGxldGlvbihuaWwpOworICAgICAgICAgICAgICAgICAgICByZXR1cm4g Y29udGludWVXaXRoQ29udGV4dE1lbnVDb25maWd1cmF0aW9uKG5pbCk7CiAgICAgICAgICAgICB9 CiAgICAgICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKIApAQCAtNzgz NCw3ICs3ODMxLDcgQEAgLSAodm9pZCljb250aW51ZUNvbnRleHRNZW51SW50ZXJhY3Rpb246KHZv aWQoXikoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKikpY28KICAgICAgICAgICAgIGlmICgh bGlua1VSTC5wcm90b2NvbElzSW5IVFRQRmFtaWx5KCkpIHsKICNpZiBFTkFCTEUoREFUQV9ERVRF Q1RJT04pCiAgICAgICAgICAgICAgICAgaWYgKCFXZWJDb3JlOjpEYXRhRGV0ZWN0aW9uOjpjYW5C ZVByZXNlbnRlZEJ5RGF0YURldGVjdG9ycyhsaW5rVVJMKSkKLSAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGNvbXBsZXRpb24obmlsKTsKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGNvbnRp bnVlV2l0aENvbnRleHRNZW51Q29uZmlndXJhdGlvbihuaWwpOwogI2VuZGlmCiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KQEAgLTc4NjUsMTggKzc4NjIsMTggQEAgLSAodm9pZCljb250aW51ZUNv bnRleHRNZW51SW50ZXJhY3Rpb246KHZvaWQoXikoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24g KikpY28KICAgICAgICAgfTsKIAogICAgICAgICAvLyBGSVhNRTogU2hvdWxkIHdlIHByb3ZpZGUg YW4gaWRlbnRpZmllciBhbmQgQVNTRVJUIGluIGRlbGVnYXRlcyBpZiB3ZSBkb24ndCBtYXRjaD8K LSAgICAgICAgcmV0dXJuIGNvbXBsZXRpb24oW1VJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uIGNv bmZpZ3VyYXRpb25XaXRoSWRlbnRpZmllcjpuaWwgcHJldmlld1Byb3ZpZGVyOmNvbnRlbnRQcmV2 aWV3UHJvdmlkZXIgYWN0aW9uUHJvdmlkZXI6YWN0aW9uTWVudVByb3ZpZGVyXSk7CisgICAgICAg IHJldHVybiBjb250aW51ZVdpdGhDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24oW1VJQ29udGV4dE1l bnVDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRpb25XaXRoSWRlbnRpZmllcjpuaWwgcHJldmlld1By b3ZpZGVyOmNvbnRlbnRQcmV2aWV3UHJvdmlkZXIgYWN0aW9uUHJvdmlkZXI6YWN0aW9uTWVudVBy b3ZpZGVyXSk7CiAgICAgfQogCi0gICAgYXV0byBjb21wbGV0aW9uQmxvY2sgPSBtYWtlQmxvY2tQ dHIoW2NvbXBsZXRpb24gPSBtYWtlQmxvY2tQdHIoY29tcGxldGlvbiksIGxpbmtVUkwgPSBXVEZN b3ZlKGxpbmtVUkwpLCB3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdLQ29udGVudFZpZXc+KHNlbGYp XSAoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKmNvbmZpZ3VyYXRpb25Gcm9tV0tVSURlbGVn YXRlKSBtdXRhYmxlIHsKKyAgICBhdXRvIGNvbXBsZXRpb25CbG9jayA9IG1ha2VCbG9ja1B0cihb Y29udGludWVXaXRoQ29udGV4dE1lbnVDb25maWd1cmF0aW9uID0gbWFrZUJsb2NrUHRyKGNvbnRp bnVlV2l0aENvbnRleHRNZW51Q29uZmlndXJhdGlvbiksIGxpbmtVUkwgPSBXVEZNb3ZlKGxpbmtV UkwpLCB3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdLQ29udGVudFZpZXc+KHNlbGYpXSAoVUlDb250 ZXh0TWVudUNvbmZpZ3VyYXRpb24gKmNvbmZpZ3VyYXRpb25Gcm9tV0tVSURlbGVnYXRlKSBtdXRh YmxlIHsKIAogICAgICAgICBhdXRvIHN0cm9uZ1NlbGYgPSB3ZWFrU2VsZi5nZXQoKTsKICAgICAg ICAgaWYgKCFzdHJvbmdTZWxmKQotICAgICAgICAgICAgcmV0dXJuIGNvbXBsZXRpb24obmlsKTsK KyAgICAgICAgICAgIHJldHVybiBjb250aW51ZVdpdGhDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24o bmlsKTsKIAogICAgICAgICBpZiAoY29uZmlndXJhdGlvbkZyb21XS1VJRGVsZWdhdGUpIHsKICAg ICAgICAgICAgIHN0cm9uZ1NlbGYtPl9jb250ZXh0TWVudUFjdGlvblByb3ZpZGVyRGVsZWdhdGVO ZWVkc092ZXJyaWRlID0gWUVTOwotICAgICAgICAgICAgY29tcGxldGlvbihjb25maWd1cmF0aW9u RnJvbVdLVUlEZWxlZ2F0ZSk7CisgICAgICAgICAgICBjb250aW51ZVdpdGhDb250ZXh0TWVudUNv bmZpZ3VyYXRpb24oY29uZmlndXJhdGlvbkZyb21XS1VJRGVsZWdhdGUpOwogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKQEAgLTc4ODksNyArNzg4Niw3IEBAIC0gKHZvaWQpY29udGlu dWVDb250ZXh0TWVudUludGVyYWN0aW9uOih2b2lkKF4pKFVJQ29udGV4dE1lbnVDb25maWd1cmF0 aW9uICopKWNvCiAgICAgICAgIC8vIEZJWE1FOiBTdXBwb3J0IEphdmFTY3JpcHQgdXJscyBoZXJl LiBCdXQgbWFrZSBzdXJlIHRoZXkgZG9uJ3Qgc2hvdyBhIHByZXZpZXcuCiAgICAgICAgIC8vIDxy ZGFyOi8vcHJvYmxlbS81MDU3MjI4Mz4KICAgICAgICAgaWYgKCFsaW5rVVJMLnByb3RvY29sSXNJ bkhUVFBGYW1pbHkoKSAmJiAhV2ViQ29yZTo6RGF0YURldGVjdGlvbjo6Y2FuQmVQcmVzZW50ZWRC eURhdGFEZXRlY3RvcnMobGlua1VSTCkpCi0gICAgICAgICAgICByZXR1cm4gY29tcGxldGlvbihu aWwpOworICAgICAgICAgICAgcmV0dXJuIGNvbnRpbnVlV2l0aENvbnRleHRNZW51Q29uZmlndXJh dGlvbihuaWwpOwogCiAgICAgICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKICAgICAg ICAgYXV0byBkZENvbnRleHRNZW51QWN0aW9uQ2xhc3MgPSBnZXRERENvbnRleHRNZW51QWN0aW9u Q2xhc3MoKTsKQEAgLTc4OTgsMTIgKzc4OTUsMTIgQEAgLSAodm9pZCljb250aW51ZUNvbnRleHRN ZW51SW50ZXJhY3Rpb246KHZvaWQoXikoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKikpY28K ICAgICAgICAgICAgIFVJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uICpjb25maWd1cmF0aW9uRnJv bUREID0gW2RkQ29udGV4dE1lbnVBY3Rpb25DbGFzcyBjb250ZXh0TWVudUNvbmZpZ3VyYXRpb25G b3JVUkw6bGlua1VSTCBpZGVudGlmaWVyOnN0cm9uZ1NlbGYtPl9wb3NpdGlvbkluZm9ybWF0aW9u LmRhdGFEZXRlY3RvcklkZW50aWZpZXIgc2VsZWN0ZWRUZXh0OltzdHJvbmdTZWxmIHNlbGVjdGVk VGV4dF0gcmVzdWx0czpzdHJvbmdTZWxmLT5fcG9zaXRpb25JbmZvcm1hdGlvbi5kYXRhRGV0ZWN0 b3JSZXN1bHRzLmdldCgpIGluVmlldzpzdHJvbmdTZWxmLmdldCgpIGNvbnRleHQ6Y29udGV4dCBt ZW51SWRlbnRpZmllcjpuaWxdOwogICAgICAgICAgICAgc3Ryb25nU2VsZi0+X2NvbnRleHRNZW51 QWN0aW9uUHJvdmlkZXJEZWxlZ2F0ZU5lZWRzT3ZlcnJpZGUgPSBZRVM7CiAgICAgICAgICAgICBp ZiAoc3Ryb25nU2VsZi0+X3Nob3dMaW5rUHJldmlld3MpCi0gICAgICAgICAgICAgICAgcmV0dXJu IGNvbXBsZXRpb24oY29uZmlndXJhdGlvbkZyb21ERCk7Ci0gICAgICAgICAgICByZXR1cm4gY29t cGxldGlvbihbVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gY29uZmlndXJhdGlvbldpdGhJZGVu dGlmaWVyOltjb25maWd1cmF0aW9uRnJvbUREIGlkZW50aWZpZXJdIHByZXZpZXdQcm92aWRlcjpu aWwgYWN0aW9uUHJvdmlkZXI6W2NvbmZpZ3VyYXRpb25Gcm9tREQgYWN0aW9uUHJvdmlkZXJdXSk7 CisgICAgICAgICAgICAgICAgcmV0dXJuIGNvbnRpbnVlV2l0aENvbnRleHRNZW51Q29uZmlndXJh dGlvbihjb25maWd1cmF0aW9uRnJvbUREKTsKKyAgICAgICAgICAgIHJldHVybiBjb250aW51ZVdp dGhDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24oW1VJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uIGNv bmZpZ3VyYXRpb25XaXRoSWRlbnRpZmllcjpbY29uZmlndXJhdGlvbkZyb21ERCBpZGVudGlmaWVy XSBwcmV2aWV3UHJvdmlkZXI6bmlsIGFjdGlvblByb3ZpZGVyOltjb25maWd1cmF0aW9uRnJvbURE IGFjdGlvblByb3ZpZGVyXV0pOwogICAgICAgICB9CiAgICAgICAgIEVORF9CTE9DS19PQkpDX0VY Q0VQVElPTlM7CiAjZW5kaWYKLSAgICAgICAgcmV0dXJuIGNvbXBsZXRpb24obmlsKTsKKyAgICAg ICAgcmV0dXJuIGNvbnRpbnVlV2l0aENvbnRleHRNZW51Q29uZmlndXJhdGlvbihuaWwpOwogICAg IH0pOwogCiAgICAgX2NvbnRleHRNZW51QWN0aW9uUHJvdmlkZXJEZWxlZ2F0ZU5lZWRzT3ZlcnJp ZGUgPSBOTzsK