199662 2019-07-09 23:47:42 -0700 [iOS] REGRESSION(r244851): Revealing caret sometimes fails when content inset is used 2019-07-11 16:30:16 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa commit-queue megan_gardner simon.fraser wenson_hsieh oldest_to_newest 1551617 0 rniwa 2019-07-09 23:47:42 -0700 When WKWebView's content inset is used, we sometimes fail to reveal the caret as the user types. <rdar://problem/52103924> 1551618 1 373825 rniwa 2019-07-09 23:53:04 -0700 Created attachment 373825 Fixes the bug 1551758 2 373825 simon.fraser 2019-07-10 11:47:15 -0700 Comment on attachment 373825 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=373825&action=review > Source/WebCore/rendering/RenderLayer.cpp:2685 > LayoutRect viewRect = frameView.visualViewportRectExpandedByContentInsets(); > > + maxScrollPosition = frameView.scrollPositionFromOffset(ScrollPosition(frameView.totalContentsSize() - flooredIntSize(viewRect.size()))); We need to clean this up so that webcore code doesn't have to get muddied with inset complexity. 1551804 3 rniwa 2019-07-10 13:29:56 -0700 Filed https://bugs.webkit.org/show_bug.cgi?id=199682 and https://bugs.webkit.org/show_bug.cgi?id=199683 Will add links as comments. 1551807 4 373861 rniwa 2019-07-10 13:30:48 -0700 Created attachment 373861 Patch for landing 1551835 5 373861 commit-queue 2019-07-10 14:12:54 -0700 Comment on attachment 373861 Patch for landing Clearing flags on attachment: 373861 Committed r247327: <https://trac.webkit.org/changeset/247327> 1551837 6 commit-queue 2019-07-10 14:14:04 -0700 All reviewed patches have been landed. Closing bug. 1552280 7 rniwa 2019-07-11 16:30:16 -0700 Fixed the test in https://trac.webkit.org/changeset/247373. 373825 2019-07-09 23:53:04 -0700 2019-07-10 13:30:47 -0700 Fixes the bug bug-199662-20190709235303.patch text/plain 5222 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcwNDUzMmY0MjI4OGJi MTAyNmNmOWE1MTVkODljODNjOWZkZWRjYS4uMjdhMDExZjUwMGVjZGQ0ZDczMjJmYThjMDFhZDQ3 NmQ1MThhMGYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA3LTA5ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtpT1NdIFJFR1JFU1NJT04o cjI0NDg1MSk6IFJldmVhbGluZyBjYXJldCBzb21ldGltZXMgZmFpbHMgd2hlbiBjb250ZW50IGlu c2V0IGlzIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTY2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSBTY3JvbGxhYmxlQXJlYTo6bWF4aW11bVNjcm9sbFBv c2l0aW9uIHVzaW5nIFNjcm9sbGFibGVBcmVhOjp2aXNpYmxlU2l6ZSwgd2hpY2ggZG9lcyBub3QK KyAgICAgICAgdGFrZSB0aGUgY29udGVudCBpbnNldHMgaW50byBhY2NvdW50IGNvcnJlY3RseSwg cmF0aGVyIHRoYW4gRnJhbWVWaWV3Ojp2aXN1YWxWaWV3cG9ydFJlY3RFeHBhbmRlZEJ5Q29udGVu dEluc2V0cywKKyAgICAgICAgd2hpY2ggZG9lcywgYW5kIGlzIHVzZWQgZm9yICJ2aWV3UmVjdCIg aW4gUmVuZGVyTGF5ZXI6OnNjcm9sbFJlY3RUb1Zpc2libGUuCisKKyAgICAgICAgT3ZlcnJpZGUg dGhlIG1heGltdW0gc2Nyb2xsIHBvc2l0aW9uIHVzaW5nIHZpc3VhbFZpZXdwb3J0UmVjdEV4cGFu ZGVkQnlDb250ZW50SW5zZXRzIGluIGlPUyB0byBmaXggdGhlIGlzc3VlLgorCisgICAgICAgIFRl c3Q6IGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9hdXRvc2Nyb2xsLXdpdGgtdG9wLWNvbnRlbnQtaW5z ZXQtMi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnNjcm9sbFJlY3RUb1Zpc2libGUpOiBGaXhlZCB0aGUg YnVnLgorCiAyMDE5LTA3LTA5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgRml4IGJ1aWxkIGFmdGVyIHIyNDcyNzkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDFkM2ViMTM1MDdlYTg4ZDkyODU1MDMzNzMx YWZjYTk5NmQ4NTNkM2UuLjE3OTYyNTM2OWI3MGEyYmY4ZmY1MjNhMWRlODhjNWE3NjQ1MzIwMjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMjY4Miw2ICsy NjgyLDggQEAgdm9pZCBSZW5kZXJMYXllcjo6c2Nyb2xsUmVjdFRvVmlzaWJsZShjb25zdCBMYXlv dXRSZWN0JiBhYnNvbHV0ZVJlY3QsIGJvb2wgaW5zaWQKICAgICAgICAgICAgIC8vIFRvIGRvIHRo YXQsIGdldFJlY3RUb0V4cG9zZSBuZWVkcyB0byByZXR1cm4gdGhlIGFkZGl0aW9uYWwgc2Nyb2xs aW5nIHRvIGRvIGJleW9uZCBjb250ZW50IHJlY3QuCiAgICAgICAgICAgICBMYXlvdXRSZWN0IHZp ZXdSZWN0ID0gZnJhbWVWaWV3LnZpc3VhbFZpZXdwb3J0UmVjdEV4cGFuZGVkQnlDb250ZW50SW5z ZXRzKCk7CiAKKyAgICAgICAgICAgIG1heFNjcm9sbFBvc2l0aW9uID0gZnJhbWVWaWV3LnNjcm9s bFBvc2l0aW9uRnJvbU9mZnNldChTY3JvbGxQb3NpdGlvbihmcmFtZVZpZXcudG90YWxDb250ZW50 c1NpemUoKSAtIGZsb29yZWRJbnRTaXplKHZpZXdSZWN0LnNpemUoKSkpKTsKKwogICAgICAgICAg ICAgYXV0byBjb250ZW50SW5zZXRzID0gcGFnZSgpLmNvbnRlbnRJbnNldHMoKTsKICAgICAgICAg ICAgIG1pblNjcm9sbFBvc2l0aW9uLm1vdmUoLWNvbnRlbnRJbnNldHMubGVmdCgpLCAtY29udGVu dEluc2V0cy50b3AoKSk7CiAgICAgICAgICAgICBtYXhTY3JvbGxQb3NpdGlvbi5tb3ZlKGNvbnRl bnRJbnNldHMucmlnaHQoKSwgY29udGVudEluc2V0cy5ib3R0b20oKSk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDZjMTQx ZTJiZWI4ZWVlYjk1NjdjMDU0ZDBjNmQyYjJmZjU2MDc4Ni4uNjc5MGQ1MWY1MTY2NGI1OTliNTVl NDQyOWMyNTJkN2YwOGNlZjAxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTA5ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtpT1NdIFJFR1JFU1NJ T04ocjI0NDg1MSk6IFJldmVhbGluZyBjYXJldCBzb21ldGltZXMgZmFpbHMgd2hlbiBjb250ZW50 IGluc2V0IGlzIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5OTY2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZGVkIGEgcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAgICogZWRpdGluZy9zZWxl Y3Rpb24vaW9zL2F1dG9zY3JvbGwtd2l0aC10b3AtY29udGVudC1pbnNldC0yLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vaW9zL2F1dG9zY3JvbGwtd2l0 aC10b3AtY29udGVudC1pbnNldC0yLmh0bWw6IEFkZGVkLgorCiAyMDE5LTA3LTA5ICBSeWFuIEhh ZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBn YXJkZW5pbmcsIGFkZHJlc3MgVGVzdEV4cGVjdGF0aW9ucyBsaW50ZXIgd2FybmluZy4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9hdXRvc2Nyb2xsLXdpdGgt dG9wLWNvbnRlbnQtaW5zZXQtMi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9pb3MvYXV0b3Njcm9sbC13aXRoLXRvcC1jb250ZW50LWluc2V0LTItZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjY2YjI0ZDA0MTk2NjAwZGNkZDhkMjA3MWViMzA3NjNmZTVmYmM5NjQK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvYXV0 b3Njcm9sbC13aXRoLXRvcC1jb250ZW50LWluc2V0LTItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEg QEAKK1BBU1MgLSBjYXJldCBhcHBlYXJlZCB3aXRoaW4gdGhlIHZpc3VhbCB2aWV3cG9ydApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2F1dG9zY3JvbGwtd2l0 aC10b3AtY29udGVudC1pbnNldC0yLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9pb3MvYXV0b3Njcm9sbC13aXRoLXRvcC1jb250ZW50LWluc2V0LTIuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4yMTBiZDVmYTk0YzU4ZjdkZGYwMTEzZDE2ODZhZDZjM2EzZjEwYzgxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2F1dG9zY3JvbGwtd2l0aC10 b3AtY29udGVudC1pbnNldC0yLmh0bWwKQEAgLTAsMCArMSw0MSBAQAorPCFET0NUWVBFIGh0bWw+ IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlLCBjb250 ZW50SW5zZXQudG9wPTE1MCBdIC0tPgorPGh0bWw+Cis8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29u dGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEiPgorPGhlYWQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2Jhc2ljLWdlc3R1cmVzLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQ+CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5uZXIud2Fp dFVudGlsRG9uZSgpOworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworfQorCithc3luYyBm dW5jdGlvbiBydW4oKQoreworICAgIGF3YWl0IFVJSGVscGVyLnNldEhhcmR3YXJlS2V5Ym9hcmRB dHRhY2hlZChmYWxzZSk7CisgICAgYXdhaXQgVUlIZWxwZXIuYWN0aXZhdGVBbmRXYWl0Rm9ySW5w dXRTZXNzaW9uQXQoMTAsIDEwKTsKKworICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMTUwOyBpKysp CisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdpbnNlcnRQYXJhZ3JhcGgnKTsKKworICAg IHdpbmRvdy5zY3JvbGxUbygwLCAwKTsKKyAgICBhd2FpdCBVSUhlbHBlci5lbnN1cmVQcmVzZW50 YXRpb25VcGRhdGUoKTsKKyAgICBhd2FpdCBVSUhlbHBlci5lbnRlclRleHQoJ2hlbGxvJyk7CisK KyAgICBjb25zdCBrZXlib2FyZFJlY3QgPSBhd2FpdCBVSUhlbHBlci5pbnB1dFZpZXdCb3VuZHMo KTsKKyAgICBjb25zdCBzY3JvbGxUb3AgPSBkb2N1bWVudC5zY3JvbGxpbmdFbGVtZW50LnNjcm9s bFRvcDsKKyAgICBjb25zdCB2aWV3cG9ydEhlaWdodCA9IHZpc3VhbFZpZXdwb3J0LmhlaWdodDsK KyAgICBjb25zdCBjYXJldFJlY3QgPSBnZXRTZWxlY3Rpb24oKS5nZXRSYW5nZUF0KDApLmdldEJv dW5kaW5nQ2xpZW50UmVjdCgpOworCisgICAgZG9jdW1lbnQuYm9keS50ZXh0Q29udGVudCA9IGNh cmV0UmVjdC55ICsgY2FyZXRSZWN0LmhlaWdodCA8PSB2aXN1YWxWaWV3cG9ydC5oZWlnaHQKKyAg ICAgICAgPyAnUEFTUyAtIGNhcmV0IGFwcGVhcmVkIHdpdGhpbiB0aGUgdmlzdWFsIHZpZXdwb3J0 JworICAgICAgICA6ICdGQUlMIC0gY2FyZXQgYXBwZWFyZWQgYmVsb3cgdGhlIHZpc3VhbCB2aWV3 cG9ydCc7CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIu bm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBjb250ZW50ZWRpdGFi bGUgb25sb2FkPSJydW4oKSI+PC9ib2R5PgorPC9odG1sPgo= 373861 2019-07-10 13:30:48 -0700 2019-07-10 14:12:54 -0700 Patch for landing bug-199662-20190710133048.patch text/plain 5617 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcwNDUzMmY0MjI4OGJi MTAyNmNmOWE1MTVkODljODNjOWZkZWRjYS4uYzQwYjZlMDg1NDY1OGYyZjQ0NGY0NmNiYzkyNTgz MWQ2MDQzYTUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA3LTA5ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtpT1NdIFJFR1JFU1NJT04o cjI0NDg1MSk6IFJldmVhbGluZyBjYXJldCBzb21ldGltZXMgZmFpbHMgd2hlbiBjb250ZW50IGlu c2V0IGlzIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTY2MgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAg ICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgU2Nyb2xsYWJsZUFyZWE6Om1heGltdW1TY3JvbGxQb3Np dGlvbiB1c2luZyBTY3JvbGxhYmxlQXJlYTo6dmlzaWJsZVNpemUsIHdoaWNoIGRvZXMgbm90Cisg ICAgICAgIHRha2UgdGhlIGNvbnRlbnQgaW5zZXRzIGludG8gYWNjb3VudCBjb3JyZWN0bHksIHJh dGhlciB0aGFuIEZyYW1lVmlldzo6dmlzdWFsVmlld3BvcnRSZWN0RXhwYW5kZWRCeUNvbnRlbnRJ bnNldHMsCisgICAgICAgIHdoaWNoIGRvZXMsIGFuZCBpcyB1c2VkIGZvciAidmlld1JlY3QiIGlu IFJlbmRlckxheWVyOjpzY3JvbGxSZWN0VG9WaXNpYmxlLgorCisgICAgICAgIE92ZXJyaWRlIHRo ZSBtYXhpbXVtIHNjcm9sbCBwb3NpdGlvbiB1c2luZyB2aXN1YWxWaWV3cG9ydFJlY3RFeHBhbmRl ZEJ5Q29udGVudEluc2V0cyBpbiBpT1MgdG8gZml4IHRoZSBpc3N1ZS4KKworICAgICAgICBUZXN0 OiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvYXV0b3Njcm9sbC13aXRoLXRvcC1jb250ZW50LWluc2V0 LTIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyOjpzY3JvbGxSZWN0VG9WaXNpYmxlKTogRml4ZWQgdGhlIGJ1 Zy4KKwogMjAxOS0wNy0wOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBhZnRlciByMjQ3Mjc5CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAxZDNlYjEzNTA3ZWE4OGQ5Mjg1NTAzMzczMWFm Y2E5OTZkODUzZDNlLi4wZjM1OGM4ZmM3YzVkZjRlNDA3YjBjZjI4Nzc0YjNlYzM5YjIwNTVhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTI2NzgsMTAgKzI2 NzgsMTMgQEAgdm9pZCBSZW5kZXJMYXllcjo6c2Nyb2xsUmVjdFRvVmlzaWJsZShjb25zdCBMYXlv dXRSZWN0JiBhYnNvbHV0ZVJlY3QsIGJvb2wgaW5zaWQKICNpZiAhUExBVEZPUk0oSU9TX0ZBTUlM WSkKICAgICAgICAgICAgIExheW91dFJlY3Qgdmlld1JlY3QgPSBmcmFtZVZpZXcudmlzaWJsZUNv bnRlbnRSZWN0KCk7CiAjZWxzZQotICAgICAgICAgICAgLy8gRklYTUU6IENvbnRlbnRJbnNldHMg c2hvdWxkIGJlIHRha2VuIGNhcmUgb2YgaW4gVUkgcHJvY2VzcyBzaWRlLgorICAgICAgICAgICAg Ly8gRklYTUU6IENvbnRlbnRJbnNldHMgc2hvdWxkIGJlIHRha2VuIGNhcmUgb2YgaW4gVUkgcHJv Y2VzcyBzaWRlLiB3ZWJraXQub3JnL2IvMTk5NjgyCiAgICAgICAgICAgICAvLyBUbyBkbyB0aGF0 LCBnZXRSZWN0VG9FeHBvc2UgbmVlZHMgdG8gcmV0dXJuIHRoZSBhZGRpdGlvbmFsIHNjcm9sbGlu ZyB0byBkbyBiZXlvbmQgY29udGVudCByZWN0LgogICAgICAgICAgICAgTGF5b3V0UmVjdCB2aWV3 UmVjdCA9IGZyYW1lVmlldy52aXN1YWxWaWV3cG9ydFJlY3RFeHBhbmRlZEJ5Q29udGVudEluc2V0 cygpOwogCisgICAgICAgICAgICAvLyBGSVhNRTogd2Via2l0Lm9yZy9iLzE5OTY4MyBGcmFtZVZp ZXc6OnZpc2libGVDb250ZW50UmVjdCBpcyB3cm9uZyB3aGVuIGNvbnRlbnQgaW5zZXRzIGFyZSBw cmVzZW50CisgICAgICAgICAgICBtYXhTY3JvbGxQb3NpdGlvbiA9IGZyYW1lVmlldy5zY3JvbGxQ b3NpdGlvbkZyb21PZmZzZXQoU2Nyb2xsUG9zaXRpb24oZnJhbWVWaWV3LnRvdGFsQ29udGVudHNT aXplKCkgLSBmbG9vcmVkSW50U2l6ZSh2aWV3UmVjdC5zaXplKCkpKSk7CisKICAgICAgICAgICAg IGF1dG8gY29udGVudEluc2V0cyA9IHBhZ2UoKS5jb250ZW50SW5zZXRzKCk7CiAgICAgICAgICAg ICBtaW5TY3JvbGxQb3NpdGlvbi5tb3ZlKC1jb250ZW50SW5zZXRzLmxlZnQoKSwgLWNvbnRlbnRJ bnNldHMudG9wKCkpOwogICAgICAgICAgICAgbWF4U2Nyb2xsUG9zaXRpb24ubW92ZShjb250ZW50 SW5zZXRzLnJpZ2h0KCksIGNvbnRlbnRJbnNldHMuYm90dG9tKCkpOwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ2YzE0MWUy YmViOGVlZWI5NTY3YzA1NGQwYzZkMmIyZmY1NjA3ODYuLmJkZmQzY2FmZTczOWQzMzcyMzE2YjI5 M2I1NDk2MDdlZjlkYjk3OWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNy0wOSAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbaU9TXSBSRUdSRVNTSU9O KHIyNDQ4NTEpOiBSZXZlYWxpbmcgY2FyZXQgc29tZXRpbWVzIGZhaWxzIHdoZW4gY29udGVudCBp bnNldCBpcyB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTk2NjIKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAg ICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv bi9pb3MvYXV0b3Njcm9sbC13aXRoLXRvcC1jb250ZW50LWluc2V0LTItZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvYXV0b3Njcm9sbC13aXRoLXRv cC1jb250ZW50LWluc2V0LTIuaHRtbDogQWRkZWQuCisKIDIwMTktMDctMDkgIFJ5YW4gSGFkZGFk ICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRl bmluZywgYWRkcmVzcyBUZXN0RXhwZWN0YXRpb25zIGxpbnRlciB3YXJuaW5nLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2F1dG9zY3JvbGwtd2l0aC10b3At Y29udGVudC1pbnNldC0yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0 aW9uL2lvcy9hdXRvc2Nyb2xsLXdpdGgtdG9wLWNvbnRlbnQtaW5zZXQtMi1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNjZiMjRkMDQxOTY2MDBkY2RkOGQyMDcxZWIzMDc2M2ZlNWZiYzk2NAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9hdXRvc2Ny b2xsLXdpdGgtdG9wLWNvbnRlbnQtaW5zZXQtMi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAor UEFTUyAtIGNhcmV0IGFwcGVhcmVkIHdpdGhpbiB0aGUgdmlzdWFsIHZpZXdwb3J0CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvYXV0b3Njcm9sbC13aXRoLXRv cC1jb250ZW50LWluc2V0LTIuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lv cy9hdXRvc2Nyb2xsLXdpdGgtdG9wLWNvbnRlbnQtaW5zZXQtMi5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIx MGJkNWZhOTRjNThmN2RkZjAxMTNkMTY4NmFkNmMzYTNmMTBjODEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvYXV0b3Njcm9sbC13aXRoLXRvcC1j b250ZW50LWluc2V0LTIuaHRtbApAQCAtMCwwICsxLDQxIEBACis8IURPQ1RZUEUgaHRtbD4gPCEt LSB3ZWJraXQtdGVzdC1ydW5uZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUsIGNvbnRlbnRJ bnNldC50b3A9MTUwIF0gLS0+Cis8aHRtbD4KKzxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50 PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSI+Cis8aGVhZD4KKzxzY3JpcHQg c3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvYmFzaWMtZ2VzdHVyZXMuanMiPjwvc2NyaXB0PgorPHNj cmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy91aS1oZWxwZXIuanMiPjwvc2NyaXB0PgorPHNj cmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci53YWl0VW50 aWxEb25lKCk7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cit9CisKK2FzeW5jIGZ1bmN0 aW9uIHJ1bigpCit7CisgICAgYXdhaXQgVUlIZWxwZXIuc2V0SGFyZHdhcmVLZXlib2FyZEF0dGFj aGVkKGZhbHNlKTsKKyAgICBhd2FpdCBVSUhlbHBlci5hY3RpdmF0ZUFuZFdhaXRGb3JJbnB1dFNl c3Npb25BdCgxMCwgMTApOworCisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxNTA7IGkrKykKKyAg ICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ2luc2VydFBhcmFncmFwaCcpOworCisgICAgd2lu ZG93LnNjcm9sbFRvKDAsIDApOworICAgIGF3YWl0IFVJSGVscGVyLmVuc3VyZVByZXNlbnRhdGlv blVwZGF0ZSgpOworICAgIGF3YWl0IFVJSGVscGVyLmVudGVyVGV4dCgnaGVsbG8nKTsKKworICAg IGNvbnN0IGtleWJvYXJkUmVjdCA9IGF3YWl0IFVJSGVscGVyLmlucHV0Vmlld0JvdW5kcygpOwor ICAgIGNvbnN0IHNjcm9sbFRvcCA9IGRvY3VtZW50LnNjcm9sbGluZ0VsZW1lbnQuc2Nyb2xsVG9w OworICAgIGNvbnN0IHZpZXdwb3J0SGVpZ2h0ID0gdmlzdWFsVmlld3BvcnQuaGVpZ2h0OworICAg IGNvbnN0IGNhcmV0UmVjdCA9IGdldFNlbGVjdGlvbigpLmdldFJhbmdlQXQoMCkuZ2V0Qm91bmRp bmdDbGllbnRSZWN0KCk7CisKKyAgICBkb2N1bWVudC5ib2R5LnRleHRDb250ZW50ID0gY2FyZXRS ZWN0LnkgKyBjYXJldFJlY3QuaGVpZ2h0IDw9IHZpc3VhbFZpZXdwb3J0LmhlaWdodAorICAgICAg ICA/ICdQQVNTIC0gY2FyZXQgYXBwZWFyZWQgd2l0aGluIHRoZSB2aXN1YWwgdmlld3BvcnQnCisg ICAgICAgIDogJ0ZBSUwgLSBjYXJldCBhcHBlYXJlZCBiZWxvdyB0aGUgdmlzdWFsIHZpZXdwb3J0 JzsKKworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3Rp ZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGNvbnRlbnRlZGl0YWJsZSBv bmxvYWQ9InJ1bigpIj48L2JvZHk+Cis8L2h0bWw+Cg==