199656 2019-07-09 20:44:47 -0700 Fix unsafe usage of makeWeakPtr() in CMTimebaseEffectiveRateChangedCallback() 2019-07-10 10:35:17 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 199639 1 cdumez cdumez achristensen commit-queue eric.carlson ggaren jer.noble webkit-bug-importer youennf oldest_to_newest 1551586 0 cdumez 2019-07-09 20:44:47 -0700 Fix unsafe usage of makeWeakPtr() in CMTimebaseEffectiveRateChangedCallback(). 1551587 1 373815 cdumez 2019-07-09 20:49:26 -0700 Created attachment 373815 Patch 1551715 2 373815 eric.carlson 2019-07-10 10:24:47 -0700 Comment on attachment 373815 Patch Thanks Chris! 1551719 3 373815 cdumez 2019-07-10 10:34:25 -0700 Comment on attachment 373815 Patch Clearing flags on attachment: 373815 Committed r247309: <https://trac.webkit.org/changeset/247309> 1551720 4 cdumez 2019-07-10 10:34:26 -0700 All reviewed patches have been landed. Closing bug. 1551722 5 webkit-bug-importer 2019-07-10 10:35:17 -0700 <rdar://problem/52899603> 373815 2019-07-09 20:49:26 -0700 2019-07-10 10:34:25 -0700 Patch bug-199656-20190709204919.patch text/plain 7124 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcwNDUzMmY0MjI4OGJi MTAyNmNmOWE1MTVkODljODNjOWZkZWRjYS4uYTM4MDg1MjQ4MWUxNTkzNzE0Mzk1YmQ1ZjJiMTVl Yjc2NGNhZmQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTA3LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHVuc2FmZSB1c2FnZSBv ZiBtYWtlV2Vha1B0cigpIGluIENNVGltZWJhc2VFZmZlY3RpdmVSYXRlQ2hhbmdlZENhbGxiYWNr KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTY1 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENNVGlt ZWJhc2VFZmZlY3RpdmVSYXRlQ2hhbmdlZENhbGxiYWNrKCkgaXMgZ2V0dGluZyBjYWxsZWQgb24g YSBiYWNrZ3JvdW5kIHRocmVhZCBhbmQgd291bGQgY2FsbAorICAgICAgICBtYWtlV2Vha1B0cigp IG9uIHRoZSBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMgb2JqZWN0LCB3aGlj aCBpcyBub3Qgc2FmZSBiZWNhdXNlCisgICAgICAgIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291 cmNlQVZGT2JqQyBpcyBhIG1haW4gdGhyZWFkIG9iamVjdC4KKworICAgICAgICBUbyBhZGRyZXNz IHRoZSBpc3N1ZSwgbW92ZSB0aGUgbG9naWMgZm9yIGxpc3RlbmluZyB0byBlZmZlY3RpdmUgcmF0 ZSBjaGFuZ2VzIHRvIGl0cyBvd24KKyAgICAgICAgTGlzdGVuZXIgY2xhc3Mgd2hpY2ggaXMgVGhy ZWFkU2FmZVJlZkNvdW50ZWQuIEluc3RlYWQgb2YgdXNpbmcgbWFrZVdlYWtQdHIoKSBvbiB0aGUg YmFja2dyb3VuZAorICAgICAgICB0aHJlYWQsIHdlIG5vdyBtZXJlbHkgcmVmIHRoZSB0aHJlYWQt c2FmZSBsaXN0ZW5lci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5oOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhU291cmNlQVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6OkVmZmVjdGl2ZVJhdGVDaGFu Z2VkTGlzdGVuZXI6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpFZmZlY3RpdmVSYXRlQ2hh bmdlZExpc3RlbmVyOjplZmZlY3RpdmVSYXRlQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpD TVRpbWViYXNlRWZmZWN0aXZlUmF0ZUNoYW5nZWRDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3Jl OjpFZmZlY3RpdmVSYXRlQ2hhbmdlZExpc3RlbmVyOjpzdG9wKToKKyAgICAgICAgKFdlYkNvcmU6 OkVmZmVjdGl2ZVJhdGVDaGFuZ2VkTGlzdGVuZXI6OkVmZmVjdGl2ZVJhdGVDaGFuZ2VkTGlzdGVu ZXIpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZP YmpDOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjp+TWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDKToKKwogMjAxOS0wNy0wOSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBhZnRlciBy MjQ3Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5oCmluZGV4IGJmMzg3MjFlZDk5MWIzZmQ0NTk0 MDc1ZWExZDc1NDczZjIxMDg0MDQuLmQwMjEwYTRlYzkzYjU5Zjk0ZDY5NjYxNmQ4YjQwOWFjNWYy NzhlN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5oCkBAIC00OSw2ICs0OSw3IEBAIHR5cGVk ZWYgc3RydWN0IF9fQ1ZCdWZmZXIgKkNWT3BlbkdMVGV4dHVyZVJlZjsKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogY2xhc3MgQ0RNU2Vzc2lvbk1lZGlhU291cmNlQVZGT2JqQzsKK2NsYXNzIEVmZmVj dGl2ZVJhdGVDaGFuZ2VkTGlzdGVuZXI7CiBjbGFzcyBNZWRpYVNvdXJjZVByaXZhdGVBVkZPYmpD OwogY2xhc3MgUGl4ZWxCdWZmZXJDb25mb3JtZXJDVjsKIGNsYXNzIFBsYXRmb3JtQ2xvY2tDTTsK QEAgLTMyOSw2ICszMzAsOCBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgc3RkOjp1bmlxdWVfcHRy PFZpZGVvRnVsbHNjcmVlbkxheWVyTWFuYWdlck9iakM+IG1fdmlkZW9GdWxsc2NyZWVuTGF5ZXJN YW5hZ2VyOwogCisgICAgUmVmPEVmZmVjdGl2ZVJhdGVDaGFuZ2VkTGlzdGVuZXI+IG1fZWZmZWN0 aXZlUmF0ZUNoYW5nZWRMaXN0ZW5lcjsKKwogI2lmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAg IFJlZjxjb25zdCBMb2dnZXI+IG1fbG9nZ2VyOwogICAgIGNvbnN0IHZvaWQqIG1fbG9nSWRlbnRp ZmllcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQppbmRleCAwZmQ2NzAwMmQwMzlkZmI5N2Yy NjllMDFjNWQwZDFmNzYzODhmNzY0Li5mMTk1MTU2ZDhjZjIyNTZmNjBmOWY1NTMyNDEyOWU4NTIz ZDlkMzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCkBAIC04NSwxNCArODUsNDYgQEAg U3RyaW5nIGNvbnZlcnRFbnVtZXJhdGlvblRvU3RyaW5nKE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlh U291cmNlQVZGT2JqQzo6U2Vla1N0YXQKICNwcmFnbWEgbWFyayAtCiAjcHJhZ21hIG1hcmsgTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDCiAKK2NsYXNzIEVmZmVjdGl2ZVJhdGVD aGFuZ2VkTGlzdGVuZXIgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8RWZmZWN0aXZlUmF0 ZUNoYW5nZWRMaXN0ZW5lcj4geworcHVibGljOgorICAgIHN0YXRpYyBSZWY8RWZmZWN0aXZlUmF0 ZUNoYW5nZWRMaXN0ZW5lcj4gY3JlYXRlKE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZG T2JqQyYgY2xpZW50LCBDTVRpbWViYXNlUmVmIHRpbWViYXNlKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIGFkb3B0UmVmKCpuZXcgRWZmZWN0aXZlUmF0ZUNoYW5nZWRMaXN0ZW5lcihjbGllbnQsIHRp bWViYXNlKSk7CisgICAgfQorCisgICAgdm9pZCBlZmZlY3RpdmVSYXRlQ2hhbmdlZCgpCisgICAg eworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyldIHsKKyAgICAgICAgICAgIGlmIChtX2NsaWVudCkKKyAgICAgICAgICAgICAgICBt X2NsaWVudC0+ZWZmZWN0aXZlUmF0ZUNoYW5nZWQoKTsKKyAgICAgICAgfSk7CisgICAgfQorCisg ICAgdm9pZCBzdG9wKENNVGltZWJhc2VSZWYpOworCitwcml2YXRlOgorICAgIEVmZmVjdGl2ZVJh dGVDaGFuZ2VkTGlzdGVuZXIoTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDJiwg Q01UaW1lYmFzZVJlZik7CisKKyAgICBXZWFrUHRyPE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291 cmNlQVZGT2JqQz4gbV9jbGllbnQ7Cit9OworCiBzdGF0aWMgdm9pZCBDTVRpbWViYXNlRWZmZWN0 aXZlUmF0ZUNoYW5nZWRDYWxsYmFjayhDTU5vdGlmaWNhdGlvbkNlbnRlclJlZiwgY29uc3Qgdm9p ZCAqbGlzdGVuZXIsIENGU3RyaW5nUmVmLCBjb25zdCB2b2lkICosIENGVHlwZVJlZikKIHsKLSAg ICBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMqIHBsYXllciA9IChNZWRpYVBs YXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMqKWNvbnN0X2Nhc3Q8dm9pZCo+KGxpc3RlbmVy KTsKLSAgICBjYWxsT25NYWluVGhyZWFkKFt3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHBsYXllcild IHsKLSAgICAgICAgaWYgKCF3ZWFrVGhpcykKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAg d2Vha1RoaXMtPmVmZmVjdGl2ZVJhdGVDaGFuZ2VkKCk7Ci0gICAgfSk7CisgICAgYXV0byogZWZm ZWN0aXZlUmF0ZUNoYW5nZWRMaXN0ZW5lciA9IChFZmZlY3RpdmVSYXRlQ2hhbmdlZExpc3RlbmVy Kiljb25zdF9jYXN0PHZvaWQqPihsaXN0ZW5lcik7CisgICAgZWZmZWN0aXZlUmF0ZUNoYW5nZWRM aXN0ZW5lci0+ZWZmZWN0aXZlUmF0ZUNoYW5nZWQoKTsKK30KKwordm9pZCBFZmZlY3RpdmVSYXRl Q2hhbmdlZExpc3RlbmVyOjpzdG9wKENNVGltZWJhc2VSZWYgdGltZWJhc2UpCit7CisgICAgQ01O b3RpZmljYXRpb25DZW50ZXJSZWYgbmMgPSBDTU5vdGlmaWNhdGlvbkNlbnRlckdldERlZmF1bHRM b2NhbENlbnRlcigpOworICAgIENNTm90aWZpY2F0aW9uQ2VudGVyUmVtb3ZlTGlzdGVuZXIobmMs IHRoaXMsIENNVGltZWJhc2VFZmZlY3RpdmVSYXRlQ2hhbmdlZENhbGxiYWNrLCBrQ01UaW1lYmFz ZU5vdGlmaWNhdGlvbl9FZmZlY3RpdmVSYXRlQ2hhbmdlZCwgdGltZWJhc2UpOworfQorCitFZmZl Y3RpdmVSYXRlQ2hhbmdlZExpc3RlbmVyOjpFZmZlY3RpdmVSYXRlQ2hhbmdlZExpc3RlbmVyKE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQyYgY2xpZW50LCBDTVRpbWViYXNlUmVm IHRpbWViYXNlKQorICAgIDogbV9jbGllbnQobWFrZVdlYWtQdHIoY2xpZW50KSkKK3sKKyAgICBD TU5vdGlmaWNhdGlvbkNlbnRlclJlZiBuYyA9IENNTm90aWZpY2F0aW9uQ2VudGVyR2V0RGVmYXVs dExvY2FsQ2VudGVyKCk7CisgICAgQ01Ob3RpZmljYXRpb25DZW50ZXJBZGRMaXN0ZW5lcihuYywg dGhpcywgQ01UaW1lYmFzZUVmZmVjdGl2ZVJhdGVDaGFuZ2VkQ2FsbGJhY2ssIGtDTVRpbWViYXNl Tm90aWZpY2F0aW9uX0VmZmVjdGl2ZVJhdGVDaGFuZ2VkLCB0aW1lYmFzZSwgMCk7CiB9CiAKIE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6TWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFTb3VyY2VBVkZPYmpDKE1lZGlhUGxheWVyKiBwbGF5ZXIpCkBAIC0xMDYsMTUgKzEzOCwxMiBA QCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6Ok1lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhU291cmNlQVZGT2JqQyhNZWRpYQogICAgICwgbV9zZWVraW5nKGZhbHNlKQogICAgICwg bV9sb2FkaW5nUHJvZ3Jlc3NlZChmYWxzZSkKICAgICAsIG1fdmlkZW9GdWxsc2NyZWVuTGF5ZXJN YW5hZ2VyKHN0ZDo6bWFrZV91bmlxdWU8VmlkZW9GdWxsc2NyZWVuTGF5ZXJNYW5hZ2VyT2JqQz4o KSkKKyAgICAsIG1fZWZmZWN0aXZlUmF0ZUNoYW5nZWRMaXN0ZW5lcihFZmZlY3RpdmVSYXRlQ2hh bmdlZExpc3RlbmVyOjpjcmVhdGUoKnRoaXMsIFttX3N5bmNocm9uaXplciB0aW1lYmFzZV0pKQog I2lmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAgICwgbV9sb2dnZXIocGxheWVyLT5tZWRpYVBs YXllckxvZ2dlcigpKQogICAgICwgbV9sb2dJZGVudGlmaWVyKHBsYXllci0+bWVkaWFQbGF5ZXJM b2dJZGVudGlmaWVyKCkpCiAjZW5kaWYKIHsKLSAgICBDTVRpbWViYXNlUmVmIHRpbWViYXNlID0g W21fc3luY2hyb25pemVyIHRpbWViYXNlXTsKLSAgICBDTU5vdGlmaWNhdGlvbkNlbnRlclJlZiBu YyA9IENNTm90aWZpY2F0aW9uQ2VudGVyR2V0RGVmYXVsdExvY2FsQ2VudGVyKCk7Ci0gICAgQ01O b3RpZmljYXRpb25DZW50ZXJBZGRMaXN0ZW5lcihuYywgdGhpcywgQ01UaW1lYmFzZUVmZmVjdGl2 ZVJhdGVDaGFuZ2VkQ2FsbGJhY2ssIGtDTVRpbWViYXNlTm90aWZpY2F0aW9uX0VmZmVjdGl2ZVJh dGVDaGFuZ2VkLCB0aW1lYmFzZSwgMCk7Ci0KICAgICBhdXRvIGxvZ1NpdGVJZGVudGlmaWVyID0g TE9HSURFTlRJRklFUjsKICAgICBBTFdBWVNfTE9HKGxvZ1NpdGVJZGVudGlmaWVyKTsKICAgICBV TlVTRURfUEFSQU0obG9nU2l0ZUlkZW50aWZpZXIpOwpAQCAtMTUwLDkgKzE3OSw3IEBAIE1lZGlh UGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6fk1lZGlhUGxheWVyUHJpdmF0ZU1lZGlh U291cmNlQVZGT2JqQygpCiB7CiAgICAgQUxXQVlTX0xPRyhMT0dJREVOVElGSUVSKTsKIAotICAg IENNVGltZWJhc2VSZWYgdGltZWJhc2UgPSBbbV9zeW5jaHJvbml6ZXIgdGltZWJhc2VdOwotICAg IENNTm90aWZpY2F0aW9uQ2VudGVyUmVmIG5jID0gQ01Ob3RpZmljYXRpb25DZW50ZXJHZXREZWZh dWx0TG9jYWxDZW50ZXIoKTsKLSAgICBDTU5vdGlmaWNhdGlvbkNlbnRlclJlbW92ZUxpc3RlbmVy KG5jLCB0aGlzLCBDTVRpbWViYXNlRWZmZWN0aXZlUmF0ZUNoYW5nZWRDYWxsYmFjaywga0NNVGlt ZWJhc2VOb3RpZmljYXRpb25fRWZmZWN0aXZlUmF0ZUNoYW5nZWQsIHRpbWViYXNlKTsKKyAgICBt X2VmZmVjdGl2ZVJhdGVDaGFuZ2VkTGlzdGVuZXItPnN0b3AoW21fc3luY2hyb25pemVyIHRpbWVi YXNlXSk7CiAKICAgICBpZiAobV90aW1lSnVtcGVkT2JzZXJ2ZXIpCiAgICAgICAgIFttX3N5bmNo cm9uaXplciByZW1vdmVUaW1lT2JzZXJ2ZXI6bV90aW1lSnVtcGVkT2JzZXJ2ZXIuZ2V0KCldOwo=