<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>19964</bug_id>
          
          <creation_ts>2008-07-09 11:33:27 -0700</creation_ts>
          <short_desc>divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image</short_desc>
          <delta_ts>2008-09-02 23:23:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Alexander Mohr">amohr</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>85552</commentid>
    <comment_count>0</comment_count>
    <who name="Alexander Mohr">amohr</who>
    <bug_when>2008-07-09 11:33:27 -0700</bug_when>
    <thetext>there&apos;s a divide by zero crash in RenderBox::calculateBackgroundSize when you load a 0,0 bmp as the background image and specify -khtml-background-size

It crashes on:
w = bg-&gt;imageSize(this, style()-&gt;effectiveZoom()).width() * h / bg-&gt;imageSize(this, style()-&gt;effectiveZoom()).height();

since bg-&gt;imageSize returns 0,0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85553</commentid>
    <comment_count>1</comment_count>
      <attachid>22187</attachid>
    <who name="Alexander Mohr">amohr</who>
    <bug_when>2008-07-09 11:35:35 -0700</bug_when>
    <thetext>Created attachment 22187
sample 0,0 bitmap</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85556</commentid>
    <comment_count>2</comment_count>
      <attachid>22188</attachid>
    <who name="Alexander Mohr">amohr</who>
    <bug_when>2008-07-09 11:43:46 -0700</bug_when>
    <thetext>Created attachment 22188
page that links to 0,0 bitmap bugfile that causes crash</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86944</commentid>
    <comment_count>3</comment_count>
    <who name="Chris Brichford">chrisb</who>
    <bug_when>2008-07-25 10:32:30 -0700</bug_when>
    <thetext>I suspect change set 31981 introduced this bug when it removed the following statements from RenderBox::imageChanged:

if (!image || !image-&gt;canRender(style()-&gt;effectiveZoom()) || !parent() || !view()) 
        return;

canRender will return false if the image is zero width or zero height.  If we take the early out in RenderBox::imageChanged we never call calculateBackgroundSize, which assumes that any background images have non-zero height.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86959</commentid>
    <comment_count>4</comment_count>
      <attachid>22479</attachid>
    <who name="Chris Brichford">chrisb</who>
    <bug_when>2008-07-25 13:19:52 -0700</bug_when>
    <thetext>Created attachment 22479
Proposed fix

Proposed fix, including LayoutTest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86984</commentid>
    <comment_count>5</comment_count>
    <who name="Chris Brichford">chrisb</who>
    <bug_when>2008-07-25 18:11:51 -0700</bug_when>
    <thetext>My fix is busted.  Breaks rendering of broken images.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87965</commentid>
    <comment_count>6</comment_count>
      <attachid>22681</attachid>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2008-08-06 08:33:25 -0700</bug_when>
    <thetext>Created attachment 22681
New patch for bug 19964</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89044</commentid>
    <comment_count>7</comment_count>
      <attachid>22681</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-08-21 17:45:20 -0700</bug_when>
    <thetext>Comment on attachment 22681
New patch for bug 19964

+        * ChangeLog:

The ChangeLog itself shouldn&apos;t be listed in the ChangeLog.

We need a ChangeLog for the LayoutTests directory too, not just WebCore.

Otherwise this patch looks good. I&apos;m going to say review+ but having no patch for LayoutTests does add work for whoever commits the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89089</commentid>
    <comment_count>8</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2008-08-22 01:28:53 -0700</bug_when>
    <thetext>Hello,
Can you please explain me what did you mean by having no patch for LayoutTests? The patch i submitted included a test for the problem itself: &quot;LayoutTests/css3/khtml-background-size-0x0-bmp.html&quot; and the needed bitmap for the test.

If more tests are needed for the patch to land in the trunk, please tell me and i will be glad to do it.

Regards,
Mihnea Ovidenie


&gt; (From update of attachment 22681 [edit])
&gt; +        * ChangeLog:
&gt; 
&gt; The ChangeLog itself shouldn&apos;t be listed in the ChangeLog.
&gt; 
&gt; We need a ChangeLog for the LayoutTests directory too, not just WebCore.
&gt; 
&gt; Otherwise this patch looks good. I&apos;m going to say review+ but having no patch
&gt; for LayoutTests does add work for whoever commits the patch.
&gt; 

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89978</commentid>
    <comment_count>9</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2008-09-02 23:23:22 -0700</bug_when>
    <thetext>Landed in r36047.

Mihnea, what Darin meant is that you did not include a ChangeLog entry for your changes inside LayoutTests.  I added one when I landed the change, but in the future you should include one with your patches.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>22187</attachid>
            <date>2008-07-09 11:35:35 -0700</date>
            <delta_ts>2008-07-09 11:35:35 -0700</delta_ts>
            <desc>sample 0,0 bitmap</desc>
            <filename>bikes.bmp</filename>
            <type>image/bmp</type>
            <size>60</size>
            <attacher name="Alexander Mohr">amohr</attacher>
            
              <data encoding="base64">Qk08AAAAAAAAADYAAAAoAAAAAAAAAAAAAAABABgAAAAAAAYAAAASCwAAEgsAAAAAAAAAAAAAfQCD
AAAA
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>22188</attachid>
            <date>2008-07-09 11:43:46 -0700</date>
            <delta_ts>2008-07-09 11:43:46 -0700</delta_ts>
            <desc>page that links to 0,0 bitmap bugfile that causes crash</desc>
            <filename>backgroundSize.html</filename>
            <type>text/html</type>
            <size>205</size>
            <attacher name="Alexander Mohr">amohr</attacher>
            
              <data encoding="base64">PGh0bWw+PGhlYWQ+DQo8c3R5bGU+DQogICAgYm9keSB7DQogICAgICAgIGJhY2tncm91bmQtaW1h
Z2U6dXJsKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTIyMTg3KTsg
DQogICAgICAgIC1raHRtbC1iYWNrZ3JvdW5kLXNpemU6IDEwMCBhdXRvOw0KICAgIH0NCjwvc3R5
bGU+DQo8L2hlYWQ+PGJvZHk+DQo8L2JvZHk+PC9odG1sPg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22479</attachid>
            <date>2008-07-25 13:19:52 -0700</date>
            <delta_ts>2008-07-25 18:12:03 -0700</delta_ts>
            <desc>Proposed fix</desc>
            <filename>cssFixWithTest.patch</filename>
            <type>text/plain</type>
            <size>4981</size>
            <attacher name="Chris Brichford">chrisb</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzNTM1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDctMjUgIENocmlzdG9waGVyIEJyaWNoZm9yZCAgPGNocmlz
YkBhZG9iZS5jb20+CisJRml4IGZvciBCdWcgMTk5NjQ6IGRpdmlkZSBieSB6ZXJvIGNyYXNoIGlu
IFJlbmRlckJveDo6Y2FsY3VsYXRlQmFja2dyb3VuZFNpemUgd2l0aCAwLDAgYm1wIGJhY2tncm91
bmQgaW1hZ2UKKwlBZGRpbmcgY2hlY2sgdG8gUmVuZGVyQm94OjppbWFnZUNoYW5nZWQgdG8gZWFy
bHkgb3V0IGlmIHRoZSBpbWFnZSBjaGFuZ2VzIHRvIGEgc3RhdGUgdGhhdCB3ZSBjYW4gbm90IHJl
bmRlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU
ZXN0OiBjc3MzL2todG1sLWJhY2tncm91bmQtc2l6ZS0weDAtYm1wLmh0bWwKKworICAgICAgICAq
IHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpp
bWFnZUNoYW5nZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guaDoKKwogMjAwOC0w
Ny0yNCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBv
cnQgZm9yIGFuIGFsdGVybmF0ZSBzeW50YXggZm9yIENTUyB2YXJpYWJsZXMuICBUZXN0ZXJzIG9u
IHd3dy1zdHlsZSB3aWxsIGJlIGFibGUgdG8gdHJ5IG91dApJbmRleDogV2ViQ29yZS9yZW5kZXJp
bmcvUmVuZGVyQm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC
b3guY3BwCShyZXZpc2lvbiAzNTMyNikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNiw2ICs1MzYsMTMgQEAgSW50U2l6ZSBSZW5kZXJCb3g6
OmNhbGN1bGF0ZUJhY2tncm91bmRTaQogICAgICAgICByZXR1cm4gYmctPmltYWdlU2l6ZSh0aGlz
LCBzdHlsZSgpLT5lZmZlY3RpdmVab29tKCkpOwogfQogCit2b2lkIFJlbmRlckJveDo6aW1hZ2VD
aGFuZ2VkKENhY2hlZEltYWdlKiBpbWFnZSkKK3sKKyAgICBpZiAoIWltYWdlIHx8ICFpbWFnZS0+
Y2FuUmVuZGVyKHN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKSkpIAorICAgICAgICByZXR1cm47Cisg
ICAgUmVuZGVyT2JqZWN0OjppbWFnZUNoYW5nZWQoaW1hZ2UpOworfQorCiB2b2lkIFJlbmRlckJv
eDo6aW1hZ2VDaGFuZ2VkKFdyYXBwZWRJbWFnZVB0ciBpbWFnZSkKIHsKICAgICBpZiAoaXNJbmxp
bmVGbG93KCkgfHwKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCShyZXZpc2lvbiAzNTMyNikKKysr
IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNiAr
MTU1LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIHBhaW50Qm94RGVjb3JhdGlvbnMo
UGFpbnRJbmZvJiwgaW50IHR4LCBpbnQgdHkpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludE1hc2so
UGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50IHR5KTsKKyAgICB2aXJ0dWFsIHZvaWQg
aW1hZ2VDaGFuZ2VkKENhY2hlZEltYWdlKiBpbWFnZSk7CiAgICAgdmlydHVhbCB2b2lkIGltYWdl
Q2hhbmdlZChXcmFwcGVkSW1hZ2VQdHIpOwogCiAgICAgLy8gQ2FsbGVkIHdoZW4gYSBwb3NpdGlv
bmVkIG9iamVjdCBtb3ZlcyBidXQgZG9lc24ndCBjaGFuZ2Ugc2l6ZS4gIEEgc2ltcGxpZmllZCBs
YXlvdXQgaXMgZG9uZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzUzNTEpCisrKyBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0wNy0yNSAgQ2hy
aXN0b3BoZXIgQnJpY2hmb3JkICA8Y2hyaXNiQGFkb2JlLmNvbT4KKworCUZpeCBmb3IgQnVnIDE5
OTY0OiBkaXZpZGUgYnkgemVybyBjcmFzaCBpbiBSZW5kZXJCb3g6OmNhbGN1bGF0ZUJhY2tncm91
bmRTaXplIHdpdGggMCwwIGJtcCBiYWNrZ3JvdW5kIGltYWdlCisgICAgICAgIEFkZGluZyBjaGVj
ayB0byBSZW5kZXJCb3g6OmltYWdlQ2hhbmdlZCB0byBlYXJseSBvdXQgaWYgdGhlIGltYWdlIGNo
YW5nZXMgdG8gYSBzdGF0ZSB0aGF0IHdlIGNhbiBub3QgcmVuZGVyLgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzMy9raHRtbC1iYWNrZ3JvdW5k
LXNpemUtMHgwLWJtcC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBjc3MzL3N1cHBvcnQ6IEFkZGVk
LgorICAgICAgICAqIGNzczMvc3VwcG9ydC8weDAuYm1wOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0
Zm9ybS9tYWMvY3NzMy9raHRtbC1iYWNrZ3JvdW5kLXNpemUtMHgwLWJtcC1leHBlY3RlZC50eHQ6
IEFkZGVkLgorCiAyMDA4LTA3LTI0ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAog
ICAgICAgICBBZGQgc3VwcG9ydCBmb3IgYW4gYWx0ZXJuYXRlIHByb3Bvc2VkIHN5bnRheCBmb3Ig
Q1NTIHZhcmlhYmxlcy4gIFRoaXMgYWx0ZXJuYXRlIHN5bnRheCB3aWxsIGFsbG93CkluZGV4OiBM
YXlvdXRUZXN0cy9jc3MzL2todG1sLWJhY2tncm91bmQtc2l6ZS0weDAtYm1wLmh0bWwKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gTGF5b3V0VGVzdHMvY3NzMy9raHRtbC1iYWNrZ3JvdW5kLXNpemUtMHgwLWJtcC5o
dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY3NzMy9raHRtbC1iYWNrZ3JvdW5kLXNp
emUtMHgwLWJtcC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACis8aHRtbD48aGVh
ZD4NCis8c3R5bGU+DQorICAgIGJvZHkgew0KKyAgICAgICAgYmFja2dyb3VuZC1pbWFnZTp1cmwo
InN1cHBvcnQvMHgwLmJtcCIpOyANCisgICAgICAgIC1raHRtbC1iYWNrZ3JvdW5kLXNpemU6IDEw
MCBhdXRvOw0KKyAgICB9DQorPC9zdHlsZT4NCis8L2hlYWQ+PGJvZHk+DQorVGhpcyB0ZXN0IGNo
ZWNrcyB0aGF0IHVzaW5nIGEgMHgwIGJtcCBmaWxlIGFzIGEgYmFja2dyb3VuZCBpbWFnZSB3aXRo
IHRoZSBjc3MgYmFja2dyb3VuZCBzaXplIGhlaWdodCBwcm9wZXJ0eSBzZXQgdG8gYXV0bw0KK2Rv
ZXMgbm90IHJlc3VsdCBpbiBhIGRpdmlkZSBieSB6ZXJvLiAgVGhpcyB0ZXN0IHBhc3NlcyBpZiBp
dCBkb2VzIG5vdCBjYXVzZSBhIGNyYXNoLg0KKzwvYm9keT48L2h0bWw+DQpJbmRleDogTGF5b3V0
VGVzdHMvcGxhdGZvcm0vbWFjL2NzczMva2h0bWwtYmFja2dyb3VuZC1zaXplLTB4MC1ibXAtZXhw
ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9jc3MzL2to
dG1sLWJhY2tncm91bmQtc2l6ZS0weDAtYm1wLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr
IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9jc3MzL2todG1sLWJhY2tncm91bmQtc2l6ZS0weDAt
Ym1wLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorbGF5ZXIgYXQg
KDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCits
YXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDAp
IHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4
NAorICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNzYyeDM2CisgICAgICAg
IHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDc2MjogIlRoaXMgdGVzdCBjaGVja3MgdGhhdCB1c2lu
ZyBhIDB4MCBibXAgZmlsZSBhcyBhIGJhY2tncm91bmQgaW1hZ2Ugd2l0aCB0aGUgY3NzIGJhY2tn
cm91bmQgc2l6ZSBoZWlnaHQgcHJvcGVydHkgc2V0IHRvIGF1dG8iCisgICAgICAgIHRleHQgcnVu
IGF0ICgwLDE4KSB3aWR0aCAyMjA6ICJkb2VzIG5vdCByZXN1bHQgaW4gYSBkaXZpZGUgYnkgemVy
by4gIgorICAgICAgICB0ZXh0IHJ1biBhdCAoMjIwLDE4KSB3aWR0aCAyNzA6ICJUaGlzIHRlc3Qg
cGFzc2VzIGlmIGl0IGRvZXMgbm90IGNhdXNlIGEgY3Jhc2guIgorICAgICAgUmVuZGVyVGV4dCB7
I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCkluZGV4OiBMYXlvdXRUZXN0cy9jc3MzL3N1cHBvcnQv
MHgwLmJtcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFy
eSB0eXBlLgpzdm46bWltZS10eXBlID0gYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtCgpQcm9wZXJ0
eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9jc3MzL3N1cHBvcnQvMHgwLmJtcApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
Ck5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyBhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0KCgpRazA4
QUFBQUFBQUFBRFlBQUFBb0FBQUFBQUFBQUFBQUFBQUJBQmdBQUFBQUFBWUFBQUFTQ3dBQUVnc0FB
QUFBQUFBQUFBQUFmUUNECkFBQUEKCg==
</data>
<flag name="review"
          id="9913"
          type_id="1"
          status="-"
          setter="chrisb"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22681</attachid>
            <date>2008-08-06 08:33:25 -0700</date>
            <delta_ts>2008-08-21 17:45:20 -0700</delta_ts>
            <desc>New patch for bug 19964</desc>
            <filename>PatchBug19964.txt</filename>
            <type>text/plain</type>
            <size>3552</size>
            <attacher name="Mihnea Ovidenie">mihnea</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzNTYwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDgtMDYgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9i
ZS5jb20+CisKKwlGaXggZm9yIEJ1ZyAxOTk2NDogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE5OTY0CisJRGl2aWRlIGJ5IHplcm8gY3Jhc2ggaW4gUmVuZGVyQm94Ojpj
YWxjdWxhdGVCYWNrZ3JvdW5kU2l6ZSB3aXRoIDAsMCBibXAgYmFja2dyb3VuZCBpbWFnZQorCUFk
ZGluZyBjaGVjayB0byBSZW5kZXJCb3g6OnJlcGFpbnRMYXllclJlY3RzRm9ySW1hZ2UgdG8gbWFr
ZSBzdXJlIHRoZSBjdXJyZW50IGxheWVyIGltYWdlIGNhbiBiZSByZW5kZXJlZC4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjc3MzL2todG1s
LWJhY2tncm91bmQtc2l6ZS0weDAtYm1wLmh0bWwKKworICAgICAgICAqIENoYW5nZUxvZzoKKyAg
ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl
ckJveDo6cmVwYWludExheWVyUmVjdHNGb3JJbWFnZSk6CisKIDIwMDgtMDgtMDYgIE1hcmNvIEJh
cmlzaW9uZSAgPG1hcmNvLmJhcmlzaW9uZUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2
aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlz
aW9uIDM1NTk0KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29ya2luZyBj
b3B5KQpAQCAtNTU3LDggKzU1Nyw3IEBAIGJvb2wgUmVuZGVyQm94OjpyZXBhaW50TGF5ZXJSZWN0
c0ZvckltYWcKICAgICBSZW5kZXJCb3gqIGxheWVyUmVuZGVyZXIgPSAwOwogCiAgICAgZm9yIChj
b25zdCBGaWxsTGF5ZXIqIGN1ckxheWVyID0gbGF5ZXJzOyBjdXJMYXllcjsgY3VyTGF5ZXIgPSBj
dXJMYXllci0+bmV4dCgpKSB7Ci0gICAgICAgIGlmIChjdXJMYXllci0+aW1hZ2UoKSAmJiBpbWFn
ZSA9PSBjdXJMYXllci0+aW1hZ2UoKS0+ZGF0YSgpKSB7Ci0gICAgICAgIAorICAgICAgICBpZiAo
Y3VyTGF5ZXItPmltYWdlKCkgJiYgaW1hZ2UgPT0gY3VyTGF5ZXItPmltYWdlKCktPmRhdGEoKSAm
JiBjdXJMYXllci0+aW1hZ2UoKS0+Y2FuUmVuZGVyKHN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKSkp
IHsKICAgICAgICAgICAgIC8vIE5vdyB0aGF0IHdlIGtub3cgdGhpcyBpbWFnZSBpcyBiZWluZyB1
c2VkLCBjb21wdXRlIHRoZSByZW5kZXJlciBhbmQgdGhlIHJlY3QKICAgICAgICAgICAgIC8vIGlm
IHdlIGhhdmVuJ3QgYWxyZWFkeQogICAgICAgICAgICAgaWYgKCFsYXllclJlbmRlcmVyKSB7Cklu
ZGV4OiBMYXlvdXRUZXN0cy9jc3MzL2todG1sLWJhY2tncm91bmQtc2l6ZS0weDAtYm1wLWV4cGVj
dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jc3MzL2todG1sLWJhY2tncm91bmQt
c2l6ZS0weDAtYm1wLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Nz
czMva2h0bWwtYmFja2dyb3VuZC1zaXplLTB4MC1ibXAtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw
KQpAQCAtMCwwICsxLDMgQEAKK1Rlc3QgZm9yIEJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk5NjQKKworVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IHVzaW5nIGEgMHgw
IGJtcCBmaWxlIGFzIGEgYmFja2dyb3VuZCBpbWFnZSB3aXRoIHRoZSBjc3MgYmFja2dyb3VuZCBz
aXplIGhlaWdodCBwcm9wZXJ0eSBzZXQgdG8gYXV0byBkb2VzIG5vdCByZXN1bHQgaW4gYSBkaXZp
ZGUgYnkgemVyby4gVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjYXVzZSBhIGNyYXNo
LgpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9raHRtbC1iYWNrZ3JvdW5kLXNpemUtMHgwLWJtcC5o
dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczMva2h0bWwtYmFja2dyb3VuZC1zaXpl
LTB4MC1ibXAuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2NzczMva2h0bWwtYmFj
a2dyb3VuZC1zaXplLTB4MC1ibXAuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMSBAQAor
PGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv
bnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7
Cis8L3NjcmlwdD4KKzxzdHlsZT4KKyAgICBib2R5IHsKKyAgICAgICAgYmFja2dyb3VuZC1pbWFn
ZTp1cmwoInN1cHBvcnQvMHgwLmJtcCIpOyAKKyAgICAgICAgLWtodG1sLWJhY2tncm91bmQtc2l6
ZTogMTAwIGF1dG87CisgICAgfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+CitUZXN0
IGZvciA8aT48YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTk5NjQiPkJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NjQ8
L2E+PC9pPgorPC9wPgorPHA+CitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgdXNpbmcgYSAweDAgYm1w
IGZpbGUgYXMgYSBiYWNrZ3JvdW5kIGltYWdlIHdpdGggdGhlIGNzcyBiYWNrZ3JvdW5kIHNpemUg
aGVpZ2h0IHByb3BlcnR5IHNldCB0byBhdXRvIGRvZXMgbm90IHJlc3VsdCBpbiBhIGRpdmlkZSBi
eSB6ZXJvLiAgVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjYXVzZSBhIGNyYXNoLgor
PC9wPgorPC9ib2R5PjwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2NzczMvc3VwcG9ydC8weDAu
Ym1wCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5
cGUuCnN2bjptaW1lLXR5cGUgPSBhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0KClByb3BlcnR5IGNo
YW5nZXMgb246IExheW91dFRlc3RzL2NzczMvc3VwcG9ydC8weDAuYm1wCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFt
ZTogc3ZuOm1pbWUtdHlwZQogICArIGFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbQoKClFrMDhBQUFB
QUFBQUFEWUFBQUFvQUFBQUFBQUFBQUFBQUFBQkFCZ0FBQUFBQUFZQUFBQVNDd0FBRWdzQUFBQUFB
QUFBQUFBQWZRQ0QKQUFBQQoK
</data>
<flag name="review"
          id="10049"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>