199622 2019-07-09 09:31:06 -0700 Revert conditional WebPageProxy check to grant universal file read sandbox upon correct sandbox creation 2019-07-09 12:56:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198902 InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1551251 0 youennf 2019-07-09 09:31:06 -0700 https://trac.webkit.org/changeset/246694 made it so that WebPageProxy would set m_mayHaveUniversalFileReadSandboxExtension to true only if the sandbox extension to '/' is successfully created. As shown in rdar://problem/52357508, this causes some breakage. 1551252 1 youennf 2019-07-09 09:31:14 -0700 <rdar://problem/52357508> 1551255 2 373724 youennf 2019-07-09 09:38:49 -0700 Created attachment 373724 Patch 1551361 3 373724 commit-queue 2019-07-09 12:56:30 -0700 Comment on attachment 373724 Patch Clearing flags on attachment: 373724 Committed r247272: <https://trac.webkit.org/changeset/247272> 1551362 4 commit-queue 2019-07-09 12:56:32 -0700 All reviewed patches have been landed. Closing bug. 373724 2019-07-09 09:38:49 -0700 2019-07-09 12:56:30 -0700 Patch bug-199622-20190709093849.patch text/plain 2144 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwZDY3YzgxOTgyMjQ2NWFk NjBkODg1NDg0ZjJiYzI2YjAwYThkNzMuLmFhNTBmNDZjYmI4NjliMmFkOTJhMjMxZmRhODA0MDNj MDFmMDAzOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDctMDkgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmVydCBjb25kaXRpb25hbCBX ZWJQYWdlUHJveHkgY2hlY2sgdG8gZ3JhbnQgdW5pdmVyc2FsIGZpbGUgcmVhZCBzYW5kYm94IHVw b24gY29ycmVjdCBzYW5kYm94IGNyZWF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk2MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUyMzU3 NTA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9u IGlPUywgdGhlIHNhbmRib3ggZXh0ZW5zaW9uIHRvICcvJyB3aWxsIHVzdWFsbHkgZmFpbCwgdGh1 cyB0aGUgdW5pdmVyc2FsIGZpbGUgcmVhZCBzYW5kYm94IGlzIG5vdCBncmFudGVkLgorICAgICAg ICBUaGlzIG1ha2VzIFdlYlBhZ2VQcm94eSBjYW5jZWwgc29tZSBmaWxlOi8vIGxvYWRzIHRvIHRo ZSBhcHBsaWNhdGlvbiBvd24gY29udGFpbmVyLgorICAgICAgICBBcyBhIHNob3J0IHRlcm0gZml4 LCBnbyBiYWNrIHRvIHByZXZpb3VzIGJlaGF2aW9yLgorICAgICAgICBDb3ZlcmVkIGJ5IHRlc3Rp bmcgYnJva2VuIGFwcCBpZGVudGlmaWVkIGluIHJkYXI6Ly9wcm9ibGVtLzUyMzU3NTA4LgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6bWF5YmVJbml0aWFsaXplU2FuZGJveEV4dGVuc2lvbkhhbmRsZSk6CisKIDIw MTktMDctMDggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFhI UiBDT1JTIHJlcXVlc3RzIGxvZ2dlZCB0d2ljZSBpbiB0aGUgc2VydmVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBlNDBlNGE4NjdmYWZiZmYxYjQzZjhiMWZm ZjE3YWFlYTI2Yjc1MGRlLi41MWM5YzRiY2I2ZWM0OGI2ZDE0NTRmZWI1NDc3ODE1ZjA1YWMxZWE1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTEwNTgsOCAr MTA1OCw5IEBAIHZvaWQgV2ViUGFnZVByb3h5OjptYXliZUluaXRpYWxpemVTYW5kYm94RXh0ZW5z aW9uSGFuZGxlKFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzCiAgICAgLy8gSW5zcGVjdG9yIHJlc291 cmNlcyBhcmUgaW4gYSBkaXJlY3Rvcnkgd2l0aCBhc3N1bWVkIGFjY2Vzcy4KICAgICBBU1NFUlRf V0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighV2ViS2l0Ojppc0luc3BlY3RvclBhZ2UoKnRoaXMp KTsKIAotICAgIGlmIChTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUoIi8iLCBTYW5kYm94 RXh0ZW5zaW9uOjpUeXBlOjpSZWFkT25seSwgc2FuZGJveEV4dGVuc2lvbkhhbmRsZSkpCi0gICAg ICAgIHdpbGxBY3F1aXJlVW5pdmVyc2FsRmlsZVJlYWRTYW5kYm94RXh0ZW5zaW9uKHByb2Nlc3Mp OworICAgIC8vIEZJWE1FOiB1bml2ZXJzYWwgZmlsZSByZWFkIGFjY2VzcyBzaG91bGQgYmUgc2V0 IGlmIHRoZSBzYW5kYm94IGV4dGVuc2lvbiBpcyBzdWNjZXNzZnVsbHkgY3JlYXRlZDogcmRhcjov L3Byb2JsZW0vNTIzNTc1MDguCisgICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKCIv IiwgU2FuZGJveEV4dGVuc2lvbjo6VHlwZTo6UmVhZE9ubHksIHNhbmRib3hFeHRlbnNpb25IYW5k bGUpOworICAgIHdpbGxBY3F1aXJlVW5pdmVyc2FsRmlsZVJlYWRTYW5kYm94RXh0ZW5zaW9uKHBy b2Nlc3MpOwogfQogCiAjaWYgIVBMQVRGT1JNKENPQ09BKQo=