199602 2019-07-08 17:22:30 -0700 [WHLSL] Implement uint/int div safety and add tests 2020-05-05 00:42:35 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P1 Normal --- 195681 1 saam saam dino fpizlo jonlee justin_fan mmaxfield rmorisset oldest_to_newest 1551056 0 saam 2019-07-08 17:22:30 -0700 e.g ``` program = "uint foo(uint x, uint y) { return x / y; }"; assert_equals(await callUintFunction(program, "foo", [makeUint(7), makeUint(2)]), 3); ``` 1551507 1 saam 2019-07-09 16:30:52 -0700 and ``` program = "int foo(int x, int y) { return x / y; }"; assert_equals(await callIntFunction(program, "foo", [makeInt(7), makeInt(2)]), 3); ``` 1554497 2 saam 2019-07-20 06:35:42 -0700 I shall do this 1554498 3 saam 2019-07-20 06:41:21 -0700 This seems to work now. I'll land tests. 1554499 4 saam 2019-07-20 06:42:06 -0700 (In reply to Saam Barati from comment #3) > This seems to work now. I'll land tests. Though maybe we need to do things to make the div safe 1554503 5 374551 saam 2019-07-20 06:57:40 -0700 Created attachment 374551 WIP 1649050 6 mmaxfield 2020-05-05 00:42:35 -0700 WHLSL is no longer relevant. 374551 2019-07-20 06:57:40 -0700 2019-07-20 06:57:40 -0700 WIP a-backup.diff text/plain 2634 saam SW5kZXg6IExheW91dFRlc3RzL3dlYmdwdS93aGxzbC9kaXZpZGUuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvZGl2aWRlLmh0bWwJKG5vbmV4aXN0ZW50KQorKysg TGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL2RpdmlkZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsNjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8bWV0YSBjaGFyc2V0PXV0Zi04 PgorPG1ldGEgbmFtZT0idGltZW91dCIgY29udGVudD0ibG9uZyI+Cis8dGl0bGU+RW51bXMuPC90 aXRsZT4KKzxzY3JpcHQgc3JjPSJqcy90ZXN0LWhhcm5lc3MuanMiPjwvc2NyaXB0PgorPHNjcmlw dCBzcmM9Ii4uL2pzL3dlYmdwdS1mdW5jdGlvbnMuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ Citjb25zdCB3aGxzbFRlc3RzID0ge307CisKK3dobHNsVGVzdHMuaW50RGl2ID0gYXN5bmMgKCkg PT4geworICAgIGxldCBwcm9ncmFtID0gYAorICAgICAgICBpbnQgZGl2KGludCB4LCBpbnQgeSkg eyByZXR1cm4geCAvIHk7IH0KKyAgICBgOworCisgICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBjYWxs SW50RnVuY3Rpb24ocHJvZ3JhbSwgImRpdiIsIFttYWtlSW50KDIwKSwgbWFrZUludCgxMCldKSwg Mik7CisgICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBjYWxsSW50RnVuY3Rpb24ocHJvZ3JhbSwgImRp diIsIFttYWtlSW50KDIwKSwgbWFrZUludCgxKV0pLCAyMCk7CisgICAgYXNzZXJ0X2VxdWFscyhh d2FpdCBjYWxsSW50RnVuY3Rpb24ocHJvZ3JhbSwgImRpdiIsIFttYWtlSW50KDcpLCBtYWtlSW50 KDIpXSksIDMpOworICAgIGFzc2VydF9lcXVhbHMoYXdhaXQgY2FsbEludEZ1bmN0aW9uKHByb2dy YW0sICJkaXYiLCBbbWFrZUludCgwKSwgbWFrZUludCg0MildKSwgMCk7CisgICAgLy8gT09QUyEK KyAgICAvL2Fzc2VydF9lcXVhbHMoYXdhaXQgY2FsbEludEZ1bmN0aW9uKHByb2dyYW0sICJkaXYi LCBbbWFrZUludCgwKSwgbWFrZUludCgwKV0pLCAuLi4pOworICAgIC8vYXNzZXJ0X2VxdWFscyhh d2FpdCBjYWxsSW50RnVuY3Rpb24ocHJvZ3JhbSwgImRpdiIsIFttYWtlSW50KDEpLCBtYWtlSW50 KDApXSksIC4uLik7CisgICAgLy9hc3NlcnRfZXF1YWxzKGF3YWl0IGNhbGxJbnRGdW5jdGlvbihw cm9ncmFtLCAiZGl2IiwgW21ha2VJbnQoLTIxNDc0ODM2NDgpLCBtYWtlSW50KC0xKV0pLCAuLi4p OworICAgIGFzc2VydF9lcXVhbHMoYXdhaXQgY2FsbEludEZ1bmN0aW9uKHByb2dyYW0sICJkaXYi LCBbbWFrZUludCgyMTQ3NDgzNjQ3KSwgbWFrZUludCgtMSldKSwgLTIxNDc0ODM2NDcpOworfTsK Kword2hsc2xUZXN0cy51aW50RGl2ID0gYXN5bmMgKCkgPT4geworICAgIGxldCBwcm9ncmFtID0g YAorICAgICAgICB1aW50IGRpdih1aW50IHgsIHVpbnQgeSkgeyByZXR1cm4geCAvIHk7IH0KKyAg ICBgOworCisgICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBjYWxsVWludEZ1bmN0aW9uKHByb2dyYW0s ICJkaXYiLCBbbWFrZVVpbnQoMjApLCBtYWtlVWludCgxKV0pLCAyMCk7CisgICAgYXNzZXJ0X2Vx dWFscyhhd2FpdCBjYWxsVWludEZ1bmN0aW9uKHByb2dyYW0sICJkaXYiLCBbbWFrZVVpbnQoMjAp LCBtYWtlVWludCgxMCldKSwgMik7CisgICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBjYWxsVWludEZ1 bmN0aW9uKHByb2dyYW0sICJkaXYiLCBbbWFrZVVpbnQoNyksIG1ha2VVaW50KDIpXSksIDMpOwor ICAgIGFzc2VydF9lcXVhbHMoYXdhaXQgY2FsbFVpbnRGdW5jdGlvbihwcm9ncmFtLCAiZGl2Iiwg W21ha2VVaW50KDApLCBtYWtlVWludCg0MildKSwgMCk7CisgICAgYXNzZXJ0X2VxdWFscyhhd2Fp dCBjYWxsVWludEZ1bmN0aW9uKHByb2dyYW0sICJkaXYiLCBbbWFrZVVpbnQoNDI5NDk2NzI5NSks IG1ha2VVaW50KDIpXSksIDIxNDc0ODM2NDcpOworfTsKKword2hsc2xUZXN0cy5kaXZpZGVFcXVh bHMgPSBhc3luYyAoKSA9PiB7CisgICAgbGV0IHByb2dyYW0gPSBgCisgICAgICAgIGludCBmb28o aW50IHgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHggLz0gNDI7CisgICAgICAgICAgICByZXR1 cm4geDsKKyAgICAgICAgfQorICAgIGA7CisgICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBjYWxsSW50 RnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFttYWtlSW50KDM4NSldKSwgKDM4NSAvIDQyKSB8IDAp OworfQorCit3aGxzbFRlc3RzLmRpdmlkZUVxdWFsc1Jlc3VsdCA9IGFzeW5jICgpID0+IHsKKyAg ICBsZXQgcHJvZ3JhbSA9IGAKKyAgICAgICAgaW50IGZvbyhpbnQgeCkKKyAgICAgICAgeworICAg ICAgICAgICAgcmV0dXJuIHggLz0gNDI7CisgICAgICAgIH0KKyAgICBgOworICAgIGFzc2VydF9l cXVhbHMoYXdhaXQgY2FsbEludEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBbbWFrZUludCgzODUp XSksICgzODUgLyA0MikgfCAwKTsKK30KKworcnVuVGVzdHMod2hsc2xUZXN0cyk7Cis8L3Njcmlw dD4KKzwvaHRtbD4K