199580 2019-07-08 11:18:32 -0700 Prevent null dereferencing in SubresourceLoader::init's lambda 2019-07-08 16:34:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187360 InRadar P2 Normal --- 1 achristensen achristensen beidson cdumez commit-queue dbates ews-watchlist japhet rniwa webkit-bug-importer oldest_to_newest 1550887 0 achristensen 2019-07-08 11:18:32 -0700 Prevent null dereferencing in SubresourceLoader::init's lambda 1550889 1 373646 achristensen 2019-07-08 11:19:21 -0700 Created attachment 373646 Patch 1550968 2 373646 rniwa 2019-07-08 14:32:42 -0700 Comment on attachment 373646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review > Source/WebCore/loader/SubresourceLoader.cpp:168 > + ASSERT_NOT_REACHED(); Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened? 1550977 3 373646 cdumez 2019-07-08 14:41:09 -0700 Comment on attachment 373646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review >> Source/WebCore/loader/SubresourceLoader.cpp:168 >> + ASSERT_NOT_REACHED(); > > Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened? RELEASE_LOG_ERROR(). 1550979 4 373667 achristensen 2019-07-08 14:43:17 -0700 Created attachment 373667 Patch 1551010 5 achristensen 2019-07-08 15:59:23 -0700 http://trac.webkit.org/r247231 1551014 6 webkit-bug-importer 2019-07-08 16:03:23 -0700 <rdar://problem/52802510> 373646 2019-07-08 11:19:21 -0700 2019-07-08 14:43:14 -0700 Patch bug-199580-20190708111921.patch text/plain 1723 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFjMzZlOTEwZTgyYjc0 NDVlNGM2NzlkZGJhOTBmMGE3ZmExZWYwOC4uZGE4YzZjNzJiM2UxNDJkY2IwZTZmODJlMzRhZjhm YmE1MjdmYTViZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTA4ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJldmVu dCBudWxsIGRlcmVmZXJlbmNpbmcgaW4gU3VicmVzb3VyY2VMb2FkZXI6OmluaXQncyBsYW1iZGEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTU4MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGxv Z3MgaW5kaWNhdGUgdGhhdCBzb21ldGltZXMgbV9kb2N1bWVudExvYWRlciBpcyBudWxsLgorICAg ICAgICBUaGlzIGlzIHNpbWlsYXIgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NzM2MAorCisgICAgICAgICogbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjppbml0KToKKwogMjAxOS0wNy0w MyAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRvcHQgc2ltcGxl IHN0cnVjdHVyZWQgYmluZGluZ3MgaW4gbW9yZSBwbGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IGU1MjRkNTcyMGJiZjg0ZjI0YmZiZDI1ZWIx NGNmMTIzMGYxMTI4MzAuLjRlYTAwYTUxZDU0MjlkNjY1MmQzY2VhM2ZmNGFlOGRjMzk3NjI5YTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcApAQCAtMTY0 LDYgKzE2NCwxMCBAQCB2b2lkIFN1YnJlc291cmNlTG9hZGVyOjppbml0KFJlc291cmNlUmVxdWVz dCYmIHJlcXVlc3QsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoYgogICAgIFJlc291cmNlTG9hZGVy Ojppbml0KFdURk1vdmUocmVxdWVzdCksIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigq dGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildIChi b29sIGluaXRpYWxpemVkKSBtdXRhYmxlIHsKICAgICAgICAgaWYgKCFpbml0aWFsaXplZCkKICAg ICAgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcihmYWxzZSk7CisgICAgICAgIGlmICgh bV9kb2N1bWVudExvYWRlcikgeworICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cisg ICAgICAgICAgICByZXR1cm4gY29tcGxldGlvbkhhbmRsZXIoZmFsc2UpOworICAgICAgICB9CiAg ICAgICAgIEFTU0VSVCghcmVhY2hlZFRlcm1pbmFsU3RhdGUoKSk7CiAgICAgICAgIG1fc3RhdGUg PSBJbml0aWFsaXplZDsKICAgICAgICAgbV9kb2N1bWVudExvYWRlci0+YWRkU3VicmVzb3VyY2VM b2FkZXIodGhpcyk7Cg== 373667 2019-07-08 14:43:17 -0700 2019-07-08 15:57:05 -0700 Patch bug-199580-20190708144316.patch text/plain 1928 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFjMzZlOTEwZTgyYjc0 NDVlNGM2NzlkZGJhOTBmMGE3ZmExZWYwOC4uZDU0YWEwM2Y0ZDA0MzAxNmMwMmFjMGNmYjllZTA4 YWNlOWQzNjYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTA4ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJldmVu dCBudWxsIGRlcmVmZXJlbmNpbmcgaW4gU3VicmVzb3VyY2VMb2FkZXI6OmluaXQncyBsYW1iZGEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTU4MAor CisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBDcmFzaCBsb2dz IGluZGljYXRlIHRoYXQgc29tZXRpbWVzIG1fZG9jdW1lbnRMb2FkZXIgaXMgbnVsbC4KKyAgICAg ICAgVGhpcyBpcyBzaW1pbGFyIHRvIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODczNjAKKworICAgICAgICAqIGxvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxvYWRlcjo6aW5pdCk6CisKIDIwMTktMDctMDMg IFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkb3B0IHNpbXBsZSBz dHJ1Y3R1cmVkIGJpbmRpbmdzIGluIG1vcmUgcGxhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L1N1YnJlc291cmNlTG9hZGVyLmNwcAppbmRleCBlNTI0ZDU3MjBiYmY4NGYyNGJmYmQyNWViMTRj ZjEyMzBmMTEyODMwLi5lYTkzNzM3MTc0MjMyNmU3MjgxZTczZGU1NzBiZWE1MjBjODU0OWQwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKQEAgLTE2NCw2 ICsxNjQsMTEgQEAgdm9pZCBTdWJyZXNvdXJjZUxvYWRlcjo6aW5pdChSZXNvdXJjZVJlcXVlc3Qm JiByZXF1ZXN0LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGIKICAgICBSZXNvdXJjZUxvYWRlcjo6 aW5pdChXVEZNb3ZlKHJlcXVlc3QpLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRo aXMpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoYm9v bCBpbml0aWFsaXplZCkgbXV0YWJsZSB7CiAgICAgICAgIGlmICghaW5pdGlhbGl6ZWQpCiAgICAg ICAgICAgICByZXR1cm4gY29tcGxldGlvbkhhbmRsZXIoZmFsc2UpOworICAgICAgICBpZiAoIW1f ZG9jdW1lbnRMb2FkZXIpIHsKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAg ICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiU3VicmVzb3VyY2VMb2FkZXI6OmluaXQ6 IHJlc291cmNlIGxvYWQgY2FuY2VsZWQgYmVjYXVzZSBkb2N1bWVudCBsb2FkZXIgaXMgbnVsbCAo ZnJhbWUgPSAlcCwgZnJhbWVMb2FkZXIgPSAlcCwgcmVzb3VyY2VJRCA9ICVsdSkiLCBmcmFtZSgp LCBmcmFtZUxvYWRlcigpLCBpZGVudGlmaWVyKCkpOworICAgICAgICAgICAgcmV0dXJuIGNvbXBs ZXRpb25IYW5kbGVyKGZhbHNlKTsKKyAgICAgICAgfQogICAgICAgICBBU1NFUlQoIXJlYWNoZWRU ZXJtaW5hbFN0YXRlKCkpOwogICAgICAgICBtX3N0YXRlID0gSW5pdGlhbGl6ZWQ7CiAgICAgICAg IG1fZG9jdW1lbnRMb2FkZXItPmFkZFN1YnJlc291cmNlTG9hZGVyKHRoaXMpOwo=