199523 2019-07-05 11:51:48 -0700 WKObject's minimum object alignment needs to be larger 2019-07-09 14:54:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Mac Other RESOLVED FIXED InRadar P2 Normal --- 179518 1 saagarjha webkit-unassigned achristensen aestes andersca beidson cdumez commit-queue ggaren hysu mitz sam thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1550453 0 saagarjha 2019-07-05 11:51:48 -0700 Got a warning when working on something unrelated: apparently some of the objects we wrap with WKObject require 16-byte alignment on my system (such as WebFrameProxy) but we are running its constructor on an 8-byte aligned address. I believe that changing minimumObjectAlignment to 16 should cover everything that we use, but I have a patch with something that's IMO more portable than a hardcoded number that I'll attach as soon as I can get around to it. 1550564 1 373552 saagarjha 2019-07-05 16:26:37 -0700 Created attachment 373552 Patch 1550994 2 cdumez 2019-07-08 15:24:56 -0700 Looks like Tim Horton did this in Bug 179518. 1551001 3 thorton 2019-07-08 15:32:23 -0700 Oh dear. That was watch bringup, my memory is not great. 1551445 4 373552 commit-queue 2019-07-09 14:49:27 -0700 Comment on attachment 373552 Patch Clearing flags on attachment: 373552 Committed r247281: <https://trac.webkit.org/changeset/247281> 1551446 5 commit-queue 2019-07-09 14:49:29 -0700 All reviewed patches have been landed. Closing bug. 1551447 6 webkit-bug-importer 2019-07-09 14:54:52 -0700 <rdar://problem/52853984> 373552 2019-07-05 16:26:37 -0700 2019-07-09 14:49:27 -0700 Patch bug-199523-20190705162636.patch text/plain 1848 saagarjha U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2NWJmMmMwN2I2ZjJmYzYx YjhkM2FiMTc4YmVlZTAxMmE4NDVjZGEuLjkwM2ZhNGU4M2E1ZTNiMDVmOTk5OTBjMDg4MzhkNWQ1 ZDM4MTFkZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDctMDUgIFNhYWdhciBK aGEgIDxzYWFnYXJqaGFAYXBwbGUuY29tPgorCisgICAgICAgIFdLT2JqZWN0J3MgbWluaW11bSBv YmplY3QgYWxpZ25tZW50IG5lZWRzIHRvIGJlIGxhcmdlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0tPYmplY3QncyB3cmFwcGVkIG9iamVjdHMgYXJl IGN1cnJlbnRseSBjb25zdHJ1Y3RlZCBhdCBhZGRyZXNzZXMgYWxpZ25lZCB0byA4LWJ5dGUgYm91 bmRhcmllcywgYnV0IHNvbWUKKyAgICAgICAgY2xhc3NlcyBoYXZlIG1vcmUgc3RyaW5nZW50IHJl cXVpcmVtZW50cy4gQnkgcXVlcnlpbmcgc3RkOjphbGlnbmVkX3N0b3JhZ2UgZm9yIHRoZSBhbGln bm1lbnQgb2YgYW4gb2JqZWN0CisgICAgICAgIGxhcmdlciB0aGFuIGFueXRoaW5nIHdlIGNhbiBj b25zdHJ1Y3QsIHdlIHNob3VsZCBiZSBhYmxlIHRvIHNhdGlzZnkgYWxpZ25tZW50IGZvciBhbnkg b2YgV2ViS2l0J3MgdHlwZXMuCisKKyAgICAgICAgKiBTaGFyZWQvQ29jb2EvQVBJT2JqZWN0Lm1t OiBVc2Ugc3RkOjphbGlnbmVkX3N0b3JhZ2UgaW4gY29uanVuY3Rpb24gd2l0aCBhbGlnbm9mIHRv IGRldGVybWluZQorICAgICAgICBtaW5pbXVtT2JqZWN0QWxpZ25tZW50LCBpbnN0ZWFkIG9mIGhh cmRjb2RpbmcgOC4KKwogMjAxOS0wNy0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBbaU9TXSBDcmFzaCBpbiBXZWJLaXQ6OldlYlBhZ2U6OnBvc2l0aW9uSW5m b3JtYXRpb24gdmlhIFJhbmdlOjpzdGFydFBvc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9Db2NvYS9BUElPYmplY3QubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2Nv YS9BUElPYmplY3QubW0KaW5kZXggZDAxN2U2Zjc3M2IxYWQ4Nzk0YzVlMmQ2YTRhZWM1ZGU1NzUw ZjEwNy4uNTdjMzJiMmY5YWIyMWE4YmVhMWFmOGEwY2VlOWI3NmJhM2U4ODBlZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvQVBJT2JqZWN0Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL0NvY29hL0FQSU9iamVjdC5tbQpAQCAtOTAsNyArOTAsNyBAQAogI2ltcG9y dCAiX1dLQXBwbGljYXRpb25NYW5pZmVzdEludGVybmFsLmgiCiAjZW5kaWYKIAotc3RhdGljIGNv bnN0IHNpemVfdCBtaW5pbXVtT2JqZWN0QWxpZ25tZW50ID0gODsKK3N0YXRpYyBjb25zdCBzaXpl X3QgbWluaW11bU9iamVjdEFsaWdubWVudCA9IGFsaWdub2Yoc3RkOjphbGlnbmVkX3N0b3JhZ2U8 c3RkOjpudW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKT46OnR5cGUpOwogc3RhdGljX2Fzc2Vy dChtaW5pbXVtT2JqZWN0QWxpZ25tZW50ID49IGFsaWdub2Yodm9pZCopLCAiT2JqZWN0cyBzaG91 bGQgYWx3YXlzIGJlIGF0IGxlYXN0IHBvaW50ZXItYWxpZ25lZC4iKTsKIHN0YXRpYyBjb25zdCBz aXplX3QgbWF4aW11bUV4dHJhU3BhY2VGb3JBbGlnbm1lbnQgPSBtaW5pbXVtT2JqZWN0QWxpZ25t ZW50IC0gYWxpZ25vZih2b2lkKik7CiAK