199510 2019-07-05 01:58:27 -0700 [ATK] Do not use C linkage for functions using C++ features 2019-07-05 04:23:27 -0700 1 1 1 Unclassified WebKit Accessibility Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez aboxhall apinheiro cfleizach cgarcia commit-queue dmazzoni ews-watchlist jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1550312 0 aperez 2019-07-05 01:58:27 -0700 Clang correctly warns about the following: In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-f34946be-9.cpp:1: In file included from ../Source/WebCore/editing/atk/FrameSelectionAtk.cpp:29: ../Source/WebCore/accessibility/atk/WebKitAccessible.h:74:31: warning: 'webkitAccessibleGetAccessibilityObject' has C-linkage specified, but returns user-defined type 'WebCore::AccessibilityObject &' which is incompatible with C [-Wreturn-type-c-linkage] WebCore::AccessibilityObject& webkitAccessibleGetAccessibilityObject(WebKitAccessible*); ^ 1550313 1 webkit-bug-importer 2019-07-05 01:58:43 -0700 <rdar://problem/52674702> 1550315 2 373485 aperez 2019-07-05 02:05:10 -0700 Created attachment 373485 Patch 1550327 3 373485 commit-queue 2019-07-05 04:23:25 -0700 Comment on attachment 373485 Patch Clearing flags on attachment: 373485 Committed r247149: <https://trac.webkit.org/changeset/247149> 1550328 4 commit-queue 2019-07-05 04:23:27 -0700 All reviewed patches have been landed. Closing bug. 373485 2019-07-05 02:05:10 -0700 2019-07-05 04:23:25 -0700 Patch bug-199510-20190705120509.patch text/plain 2227 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlkM2RhMTRkZjI2MjUz OTkyYTVmN2JhNmIxNDRmMTBiMjI1YjJjNS4uNDgwYjNmYWNiNzg3YThkYTc3YWM1YjhkZTliZjA3 NmNlZjkzMGU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTA1ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FUS10g RG8gbm90IHVzZSBDIGxpbmthZ2UgZm9yIGZ1bmN0aW9ucyB1c2luZyBDKysgZmVhdHVyZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTUxMAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTI2NzQ3MDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGUuaDogTW92ZSBmdW5jdGlvbiBhbmQg dHlwZSBkZWNsYXJhdGlvbnMgaW52b2x2aW5nCisgICAgICAgIEMrKyBmZWF0dXJlcyBvdXRzaWRl IG9mIHRoZSBibG9jayBkZWxpbWl0ZWQgYnkgdGhlIEdfQkVHSU5fREVDTFMgYW5kIEdfRU5EX0RF Q0xTIG1hY3JvcywKKyAgICAgICAgd2hpY2ggd2VyZSBzZXR0aW5nIHRoZSBDIGxpbmthZ2UuCisK IDIwMTktMDctMDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb Q29udGVudENoYW5nZU9ic2VydmVyXSBkaWRGaW5pc2hUcmFuc2l0aW9uIHRyaWdnZXJzIGEgbmVz dGVkIHN0eWxlIHJlY2FsYyB2aWEgaXNDb25zaWRlcmVkQ2xpY2thYmxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlLmgKaW5kZXggN2Q1 NjM3YTE1ODMyODI0N2JkNjA4YmQ5NjlkZTAzNDM5NjlkMDJmMS4uMTZlNDQ2MjQ1ZjkyMDg5ODEz MGI0MGVkNWM0NWRhN2IwODJhN2FlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGUuaApAQCAtNTUsNiArNTUsMTQgQEAgc3RydWN0 IF9XZWJLaXRBY2Nlc3NpYmxlQ2xhc3MgewogICAgIEF0a09iamVjdENsYXNzIHBhcmVudENsYXNz OwogfTsKIAorR1R5cGUgd2Via2l0X2FjY2Vzc2libGVfZ2V0X3R5cGUodm9pZCk7CisKK0dfRU5E X0RFQ0xTCisKKy8vIFRoZSBkZWZpbml0aW9ucyBiZWxvdyBhcmUgb25seSB1c2VkIGluIEMrKyBj b2RlLCBhbmQgc29tZSB1c2UgQysrIHR5cGVzLAorLy8gdGhlcmVmb3JlIHRoZXkgc2hvdWxkIGJl IG91dHNpZGUgb2YgdGhlIEdfQkVHSU5fREVDTFMvR19FTkRfREVDTFMgYmxvY2sKKy8vIHRvIG1h a2UgdGhlbSB1c2UgdGhlIEMrKyBBQkkuCisKIGVudW0gQXRrQ2FjaGVkUHJvcGVydHkgewogICAg IEF0a0NhY2hlZEFjY2Vzc2libGVOYW1lLAogICAgIEF0a0NhY2hlZEFjY2Vzc2libGVEZXNjcmlw dGlvbiwKQEAgLTY3LDggKzc1LDYgQEAgZW51bSBBdGtDYWNoZWRQcm9wZXJ0eSB7CiAgICAgQXRr Q2FjaGVkSW1hZ2VEZXNjcmlwdGlvbgogfTsKIAotR1R5cGUgd2Via2l0X2FjY2Vzc2libGVfZ2V0 X3R5cGUodm9pZCk7Ci0KIFdlYktpdEFjY2Vzc2libGUqIHdlYmtpdEFjY2Vzc2libGVOZXcoV2Vi Q29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdCopOwogCiBXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2Jq ZWN0JiB3ZWJraXRBY2Nlc3NpYmxlR2V0QWNjZXNzaWJpbGl0eU9iamVjdChXZWJLaXRBY2Nlc3Np YmxlKik7CkBAIC03OSw2ICs4NSw0IEBAIGJvb2wgd2Via2l0QWNjZXNzaWJsZUlzRGV0YWNoZWQo V2ViS2l0QWNjZXNzaWJsZSopOwogCiBjb25zdCBjaGFyKiB3ZWJraXRBY2Nlc3NpYmxlQ2FjaGVB bmRSZXR1cm5BdGtQcm9wZXJ0eShXZWJLaXRBY2Nlc3NpYmxlKiwgQXRrQ2FjaGVkUHJvcGVydHks IENTdHJpbmcmJik7CiAKLUdfRU5EX0RFQ0xTCi0KICNlbmRpZiAvLyBIQVZFKEFDQ0VTU0lCSUxJ VFkpCg==