199504 2019-07-04 13:50:49 -0700 [iOS] Context Menu - Add to Reading List does nothing 2019-07-05 16:42:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino andersca webkit-bug-importer oldest_to_newest 1550264 0 dino 2019-07-04 13:50:49 -0700 [iOS] Context Menu - Add to Reading List does nothing 1550265 1 dino 2019-07-04 13:51:23 -0700 <rdar://problem/52554137> 1550266 2 373471 dino 2019-07-04 13:53:26 -0700 Created attachment 373471 Patch 1550280 3 373471 andersca 2019-07-04 16:37:19 -0700 Comment on attachment 373471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373471&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:290 > + RELEASE_LOG(ContextMenu, "Executing action for type: %s", elementActionTypeToUIActionIdentifier([elementAction type]).UTF8String); Do you really need to log here? 1550566 4 dino 2019-07-05 16:35:05 -0700 Committed r247185: <https://trac.webkit.org/changeset/247185> 1550574 5 373471 dino 2019-07-05 16:42:55 -0700 Comment on attachment 373471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373471&action=review >> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:290 >> + RELEASE_LOG(ContextMenu, "Executing action for type: %s", elementActionTypeToUIActionIdentifier([elementAction type]).UTF8String); > > Do you really need to log here? No. But it seems we're more happy to release log these days. 373471 2019-07-04 13:53:26 -0700 2019-07-04 16:37:19 -0700 Patch bug-199504-20190705065325.patch text/plain 2724 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVlODE4NjQwNzVjNzQzNDM1 ZDY1OWIyNGM2MTgyOGIzNzY0MDBkMDcuLjU3NTI0NWIxODc5ZTQzMzNlMzlkMWRkYTkwODI3OTUz ZjExZThhMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDctMDQgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIENvbnRleHQgTWVudSAtIEFk ZCB0byBSZWFkaW5nIExpc3QgZG9lcyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk1MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUy NTU0MTM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIHdlcmUgaG9sZGluZyB3ZWFrIHJlZmVyZW5jZXMgdG8gdGhlIF9XS0VsZW1lbnRBY3Rpb24g aW4KKyAgICAgICAgdGhlIGhhbmRsZXIgcHJvdmlkZWQgdG8gVUlBY3Rpb24uIEJ5IHRoZSB0aW1l IHRoZSBoYW5kbGVyIHdhcworICAgICAgICBjYWxsZWQsIHRoZSBvYmplY3QgaGFkIGJlZW4gZGVh bGxvY2F0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rp b24ubW06CisgICAgICAgICgtW19XS0VsZW1lbnRBY3Rpb24gdWlBY3Rpb25Gb3JFbGVtZW50SW5m bzpdKTogVXNlIHN0cm9uZyByZWZlcmVuY2VzIGluIGhhbmRsZXIuCisKIDIwMTktMDYtMjggIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aXNlIFdlYkNv bnRlbnQgc2FuZGJveCBiYXNlZCBvbiBzZWVkIGZlZWRiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCmluZGV4IGY1OGUx NDI1YTdmNTE1ZDdmNjRhMzIzMmYzMGVhMzE3Nzg3YzI1NGMuLjczZGU4MjUyNDgzYWYxMDVmMzhk OGRmODk2NDY5ZjJlYzFlNGY1ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCkBAIC0yOSw2ICsyOSw3IEBACiAjaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkKIAogI2ltcG9ydCAiR2VzdHVyZVR5cGVzLmgiCisjaW1wb3J0 ICJMb2dnaW5nLmgiCiAjaW1wb3J0ICJXS0FjdGlvblNoZWV0QXNzaXN0YW50LmgiCiAjaW1wb3J0 ICJXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaCIKICNpbXBvcnQgIl9XS0FjdGl2YXRlZEVsZW1l bnRJbmZvSW50ZXJuYWwuaCIKQEAgLTI4NCwxNCArMjg1LDEwIEBAIHN0YXRpYyBfV0tFbGVtZW50 QWN0aW9uVHlwZSB1aUFjdGlvbklkZW50aWZpZXJUb0VsZW1lbnRBY3Rpb25UeXBlKFVJQWN0aW9u SWRlbnRpCiAgICAgVUlJbWFnZSAqaW1hZ2UgPSBbX1dLRWxlbWVudEFjdGlvbiBpbWFnZUZvckVs ZW1lbnRBY3Rpb25UeXBlOnNlbGYudHlwZV07CiAgICAgVUlBY3Rpb25JZGVudGlmaWVyIGlkZW50 aWZpZXIgPSBlbGVtZW50QWN0aW9uVHlwZVRvVUlBY3Rpb25JZGVudGlmaWVyKHNlbGYudHlwZSk7 CiAKLSAgICByZXR1cm4gW1VJQWN0aW9uIGFjdGlvbldpdGhUaXRsZTpzZWxmLnRpdGxlIGltYWdl OmltYWdlIGlkZW50aWZpZXI6aWRlbnRpZmllciBoYW5kbGVyOlt3ZWFrU2VsZiA9IFdlYWtPYmpD UHRyPF9XS0VsZW1lbnRBY3Rpb24+KHNlbGYpLCB3ZWFrRWxlbWVudEluZm8gPSBXZWFrT2JqQ1B0 cjxfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbz4oZWxlbWVudEluZm8pXSAoVUlBY3Rpb24gKikgewot ICAgICAgICBhdXRvIHN0cm9uZ1NlbGYgPSB3ZWFrU2VsZi5nZXQoKTsKLSAgICAgICAgaWYgKCFz dHJvbmdTZWxmKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBhdXRvIHN0cm9uZ0VsZW1l bnRJbmZvID0gd2Vha0VsZW1lbnRJbmZvLmdldCgpOwotICAgICAgICBpZiAoIXN0cm9uZ0VsZW1l bnRJbmZvKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBbc3Ryb25nU2VsZiBydW5BY3Rp b25XaXRoRWxlbWVudEluZm86c3Ryb25nRWxlbWVudEluZm8uZ2V0KCldOworICAgIHJldHVybiBb VUlBY3Rpb24gYWN0aW9uV2l0aFRpdGxlOnNlbGYudGl0bGUgaW1hZ2U6aW1hZ2UgaWRlbnRpZmll cjppZGVudGlmaWVyIGhhbmRsZXI6W3JldGFpbmVkU2VsZiA9IHJldGFpblB0cihzZWxmKSwgcmV0 YWluZWRJbmZvID0gcmV0YWluUHRyKGVsZW1lbnRJbmZvKV0gKFVJQWN0aW9uICopIHsKKyAgICAg ICAgYXV0byBlbGVtZW50QWN0aW9uID0gcmV0YWluZWRTZWxmLmdldCgpOworICAgICAgICBSRUxF QVNFX0xPRyhDb250ZXh0TWVudSwgIkV4ZWN1dGluZyBhY3Rpb24gZm9yIHR5cGU6ICVzIiwgZWxl bWVudEFjdGlvblR5cGVUb1VJQWN0aW9uSWRlbnRpZmllcihbZWxlbWVudEFjdGlvbiB0eXBlXSku VVRGOFN0cmluZyk7CisgICAgICAgIFtlbGVtZW50QWN0aW9uIHJ1bkFjdGlvbldpdGhFbGVtZW50 SW5mbzpyZXRhaW5lZEluZm8uZ2V0KCldOwogICAgIH1dOwogfQogI2Vsc2UK