<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199496</bug_id>
          
          <creation_ts>2019-07-04 06:22:09 -0700</creation_ts>
          <short_desc>[GTK] Fix browserperfdash script after r239522</short_desc>
          <delta_ts>2019-07-04 06:54:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>192905</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>dewei_zhu</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1550211</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-07-04 06:22:09 -0700</bug_when>
    <thetext>r239522 Added a new --browser-path argument to run-benchmark.
This argument was made as non-optional on the BenchmarkRunner constructor.

The browserperfdash script needs to be updated accordingly as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550216</commentid>
    <comment_count>1</comment_count>
      <attachid>373462</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-07-04 06:27:42 -0700</bug_when>
    <thetext>Created attachment 373462
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550224</commentid>
    <comment_count>2</comment_count>
      <attachid>373462</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-07-04 06:49:09 -0700</bug_when>
    <thetext>Comment on attachment 373462
Patch

Please investigate the GitHub security warning for this website while you&apos;re at it. I requested many months ago for it to be taken offline because nobody was caring for it, but that never happened.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550227</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-07-04 06:52:55 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #2)
&gt; Comment on attachment 373462 [details]
&gt; Patch
&gt; 
&gt; Please investigate the GitHub security warning for this website while you&apos;re
&gt; at it. I requested many months ago for it to be taken offline because nobody
&gt; was caring for it, but that never happened.

Sure.

I will take care of it</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550228</commentid>
    <comment_count>4</comment_count>
      <attachid>373462</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-07-04 06:53:36 -0700</bug_when>
    <thetext>Comment on attachment 373462
Patch

Clearing flags on attachment: 373462

Committed r247140: &lt;https://trac.webkit.org/changeset/247140&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550229</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-07-04 06:53:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1550230</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-04 06:54:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/52645195&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373462</attachid>
            <date>2019-07-04 06:27:42 -0700</date>
            <delta_ts>2019-07-04 06:53:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199496-20190704152741.patch</filename>
            <type>text/plain</type>
            <size>1974</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM2ZTY4OTdjZTdkNWExODdlY2I4NjgwMmQyOTI1MDdm
YjY1YzRiOC4uOWM0MGUyMmJhODc2NmU4OWIwNjViMWY1MTU2M2E3ZTQwNWIwNzUyOCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDE5LTA3LTA0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs
aWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBicm93c2VycGVyZmRhc2ggc2NyaXB0IGFmdGVy
IHIyMzk1MjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE5OTQ5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogU2NyaXB0cy93ZWJraXRweS9icm93c2VycGVyZmRhc2gvYnJvd3NlcnBlcmZkYXNoX3J1bm5l
ci5weToKKyAgICAgICAgKEJyb3dzZXJQZXJmRGFzaFJ1bm5lci5ydW4pOiBQYXNzIE5vbmUgZm9y
IHRoZSBuZXcgcmVxdWlyZWQgQmVuY2htYXJrUnVubmVyIGNvbnN0cnVjdG9yLgorCiAyMDE5LTA3
LTAyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAg
ICAgICAgIFtHVEtdW1dQRV0gTm90IGxvbmdlciBuZWVkZWQgdG8gYnVpbGQgd29mZjIgb24gdGhl
IEpIQnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnJvd3NlcnBlcmZk
YXNoL2Jyb3dzZXJwZXJmZGFzaF9ydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Jy
b3dzZXJwZXJmZGFzaC9icm93c2VycGVyZmRhc2hfcnVubmVyLnB5CmluZGV4IDkxNjFhYzJmMDgz
YWRlZWJiZjI3NGYxMTdiZTY2ZjZmYjk0YzkzNDkuLjk5NDMxMmQyMWQzNzQyOTUyNDNiNmFiYzFm
MWYwNzlmMzIzNzNiODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnJvd3Nl
cnBlcmZkYXNoL2Jyb3dzZXJwZXJmZGFzaF9ydW5uZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9icm93c2VycGVyZmRhc2gvYnJvd3NlcnBlcmZkYXNoX3J1bm5lci5weQpAQCAtMTY1
LDcgKzE2NSw3IEBAIGNsYXNzIEJyb3dzZXJQZXJmRGFzaFJ1bm5lcihvYmplY3QpOgogICAgICAg
ICAgICAgICAgICMgUnVuIHRlc3QgYW5kIHNhdmUgdGVzdCBpbmZvCiAgICAgICAgICAgICAgICAg
d2l0aCB0ZW1wZmlsZS5OYW1lZFRlbXBvcmFyeUZpbGUoKSBhcyB0ZW1wX3Jlc3VsdF9maWxlOgog
ICAgICAgICAgICAgICAgICAgICBiZW5jaG1hcmtfcnVubmVyX2NsYXNzID0gYmVuY2htYXJrX3J1
bm5lcl9zdWJjbGFzc2VzW3NlbGYuX2FyZ3MuZHJpdmVyXQotICAgICAgICAgICAgICAgICAgICBy
dW5uZXIgPSBiZW5jaG1hcmtfcnVubmVyX2NsYXNzKHBsYW4sIHNlbGYuX2FyZ3MubG9jYWxDb3B5
LCBzZWxmLl9hcmdzLmNvdW50T3ZlcnJpZGUsIHNlbGYuX2FyZ3MuYnVpbGREaXIsIHRlbXBfcmVz
dWx0X2ZpbGUubmFtZSwgc2VsZi5fYXJncy5wbGF0Zm9ybSwgc2VsZi5fYXJncy5icm93c2VyKQor
ICAgICAgICAgICAgICAgICAgICBydW5uZXIgPSBiZW5jaG1hcmtfcnVubmVyX2NsYXNzKHBsYW4s
IHNlbGYuX2FyZ3MubG9jYWxDb3B5LCBzZWxmLl9hcmdzLmNvdW50T3ZlcnJpZGUsIHNlbGYuX2Fy
Z3MuYnVpbGREaXIsIHRlbXBfcmVzdWx0X2ZpbGUubmFtZSwgc2VsZi5fYXJncy5wbGF0Zm9ybSwg
c2VsZi5fYXJncy5icm93c2VyLCBOb25lKQogICAgICAgICAgICAgICAgICAgICBydW5uZXIuZXhl
Y3V0ZSgpCiAgICAgICAgICAgICAgICAgICAgIF9sb2cuaW5mbygnRmluaXNoZWQgYmVuY2htYXJr
IHBsYW46IHtwbGFuX25hbWV9Jy5mb3JtYXQocGxhbl9uYW1lPXBsYW4pKQogICAgICAgICAgICAg
ICAgICAgICAjIEZpbGwgdGVzdCBpbmZvIGZvciB1cGxvYWQK
</data>

          </attachment>
      

    </bug>

</bugzilla>