199493 2019-07-04 05:00:42 -0700 [webkitpy] test-webkitpy is broken on Linux since r246662 2019-07-08 10:31:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez aakash_jain aperez ap bugs-noreply dean_johnson ews-watchlist fujii glenn jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1550204 0 clopez 2019-07-04 05:00:42 -0700 Since r246662 test-webkitpy fails on Linux with: $ Tools/Scripts/test-webkitpy Traceback (most recent call last): File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/test/main.py", line 374, in <module> sys.exit(main()) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/test/main.py", line 72, in main if not _supports_building_and_running_lldb_tests(): File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/test/main.py", line 107, in _supports_building_and_running_lldb_tests return not _host.platform.build_version().startswith('19A') AttributeError: 'NoneType' object has no attribute 'startswith' 1550205 1 373459 clopez 2019-07-04 05:03:41 -0700 Created attachment 373459 Patch 1550217 2 373459 clopez 2019-07-04 06:28:51 -0700 Comment on attachment 373459 Patch Clearing flags on attachment: 373459 Committed r247139: <https://trac.webkit.org/changeset/247139> 1550218 3 clopez 2019-07-04 06:28:55 -0700 All reviewed patches have been landed. Closing bug. 1550219 4 webkit-bug-importer 2019-07-04 06:29:19 -0700 <rdar://problem/52644428> 1550234 5 fujii 2019-07-04 07:01:38 -0700 *** Bug 199428 has been marked as a duplicate of this bug. *** 1550815 6 373459 jbedard 2019-07-08 08:41:00 -0700 Comment on attachment 373459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373459&action=review > Tools/Scripts/webkitpy/test/main.py:109 > + return False Shouldn't this be true? I don't have a Linux build handy at the moment, but I feel like Linux builds should be running lldb tests, no? 1550818 7 373459 mcatanzaro 2019-07-08 08:57:18 -0700 Comment on attachment 373459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373459&action=review >> Tools/Scripts/webkitpy/test/main.py:109 >> + return False > > Shouldn't this be true? > > I don't have a Linux build handy at the moment, but I feel like Linux builds should be running lldb tests, no? Does lldb even work on Linux? Even if it does, lldb is not expected to be installed so the tests shouldn't run automatically. 1550822 8 aperez 2019-07-08 09:02:44 -0700 (In reply to Michael Catanzaro from comment #7) > Comment on attachment 373459 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373459&action=review > > >> Tools/Scripts/webkitpy/test/main.py:109 > >> + return False > > > > Shouldn't this be true? > > > > I don't have a Linux build handy at the moment, but I feel like Linux builds should be running lldb tests, no? > > Does lldb even work on Linux? Well, lldb has worked on Linux for ages, sometimes I use it when GDB is having a bad release that has weird C++ demangling bugs :) > Even if it does, lldb is not expected to be installed so the tests shouldn't > run automatically. I think it's okay that they run if lldb is installed. At any rate, they should be skipped if it is not available, indeed. 1550857 9 clopez 2019-07-08 10:24:03 -0700 (In reply to Jonathan Bedard from comment #6) > Comment on attachment 373459 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373459&action=review > > > Tools/Scripts/webkitpy/test/main.py:109 > > + return False > > Shouldn't this be true? > > I don't have a Linux build handy at the moment, but I feel like Linux builds > should be running lldb tests, no? If lldb tests can run in Linux then a proper check for that can be added, and when the requirements are meet (lldb installed, etc) then return true But this patch just returns False early to avoid calling startswith() over a None value. That is correct IMHO. In any case I just tried quickly changing that to True and trying to run the lldb tests and I get: $ Tools/Scripts/build-lldbwebkittester lldbWebKitTester is currently only supported on Mac. So, it seems that adding support for running WebKit lldb tests on Linux should be done in a new bug. By the way, I'm not familiar with this lldb tests. What is the purpose of them? 1550861 10 jbedard 2019-07-08 10:31:18 -0700 (In reply to Carlos Alberto Lopez Perez from comment #9) > (In reply to Jonathan Bedard from comment #6) > > Comment on attachment 373459 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=373459&action=review > > > > > Tools/Scripts/webkitpy/test/main.py:109 > > > + return False > > > > Shouldn't this be true? > > > > I don't have a Linux build handy at the moment, but I feel like Linux builds > > should be running lldb tests, no? > > If lldb tests can run in Linux then a proper check for that can be added, > and when the requirements are meet (lldb installed, etc) then return true > > But this patch just returns False early to avoid calling startswith() over a > None value. That is correct IMHO. > > In any case I just tried quickly changing that to True and trying to run the > lldb tests and I get: > > $ Tools/Scripts/build-lldbwebkittester > lldbWebKitTester is currently only supported on Mac. > > So, it seems that adding support for running WebKit lldb tests on Linux > should be done in a new bug. > > By the way, I'm not familiar with this lldb tests. What is the purpose of > them? If lldbWebKitTester is currently only supported on Mac, false is correct. My recollection is that the lldb tests were added by Dan Bates some time ago so that WebKit stopped breaking lldb debugging, but it's been awhile, so I'm not 100% certain of the original motivation. 373459 2019-07-04 05:03:41 -0700 2019-07-04 06:28:51 -0700 Patch bug-199493-20190704140340.patch text/plain 1492 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM2ZTY4OTdjZTdkNWExODdlY2I4NjgwMmQyOTI1MDdm YjY1YzRiOC4uMDBjZDAxOWY0ZjkwNTAwM2M2NWU2OTQ5ZTZlNjk1Y2U0YzE2N2FjYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA3LTA0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFt3ZWJraXRweV0gdGVzdC13ZWJraXRweSBpcyBicm9rZW4gb24g TGludXggc2luY2UgcjI0NjY2MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk5NDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weToKKyAgICAgICAgKF9z dXBwb3J0c19idWlsZGluZ19hbmRfcnVubmluZ19sbGRiX3Rlc3RzKTogQWRkIGEgY2hlY2sgZm9y IE5vbmUgYmVmb3JlIGNhbGxpbmcgc3RhcnRzd2l0aCgpLgorCiAyMDE5LTA3LTAyICBDYXJsb3Mg QWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd W1dQRV0gTm90IGxvbmdlciBuZWVkZWQgdG8gYnVpbGQgd29mZjIgb24gdGhlIEpIQnVpbGQKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKaW5kZXggZjNiZjJkYWZlMzkxMDViZTdjNDA5N2U2 ZjI1MDNkZjA1OGExODUxMy4uZDhhZTI3ZmEzOGI2Y2Q1NWQ0NzE1ZjE5ZTcxMzRlNzJkZjBlZDA4 ZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKQEAgLTEwNCw3ICsxMDQsMTAgQEAg ZGVmIG1haW4oKToKIGRlZiBfc3VwcG9ydHNfYnVpbGRpbmdfYW5kX3J1bm5pbmdfbGxkYl90ZXN0 cygpOgogICAgICMgRklYTUU6IFJlbW92ZSB3aGVuIHRlc3QtbGxkYiBpcyBpbiBpdHMgb3duIHNj cmlwdAogICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Nzkx NgotICAgIHJldHVybiBub3QgX2hvc3QucGxhdGZvcm0uYnVpbGRfdmVyc2lvbigpLnN0YXJ0c3dp dGgoJzE5QScpCisgICAgYnVpbGRfdmVyc2lvbiA9IF9ob3N0LnBsYXRmb3JtLmJ1aWxkX3ZlcnNp b24oKQorICAgIGlmIGJ1aWxkX3ZlcnNpb24gaXMgTm9uZToKKyAgICAgICAgcmV0dXJuIEZhbHNl CisgICAgcmV0dXJuIG5vdCBidWlsZF92ZXJzaW9uLnN0YXJ0c3dpdGgoJzE5QScpCiAKIAogZGVm IF9wcmludF9yZXN1bHRzX2FzX2pzb24oc3RyZWFtLCBhbGxfdGVzdF9uYW1lcywgZmFpbHVyZXMs IGVycm9ycyk6Cg==