199473 2019-07-03 15:42:25 -0700 [MSE] Add more debug and error logging 2019-07-04 00:49:13 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ANS0506 commit-queue jer.noble webkit-bug-importer oldest_to_newest 1550052 0 eric.carlson 2019-07-03 15:42:25 -0700 Add error logging. 1550053 1 webkit-bug-importer 2019-07-03 15:42:42 -0700 <rdar://problem/52615882> 1550057 2 373426 eric.carlson 2019-07-03 15:47:12 -0700 Created attachment 373426 Patch 1550173 3 373426 commit-queue 2019-07-03 20:23:45 -0700 Comment on attachment 373426 Patch Clearing flags on attachment: 373426 Committed r247133: <https://trac.webkit.org/changeset/247133> 1550174 4 commit-queue 2019-07-03 20:23:47 -0700 All reviewed patches have been landed. Closing bug. 373426 2019-07-03 15:47:12 -0700 2019-07-03 20:23:45 -0700 Patch bug-199473-20190703154712.patch text/plain 6913 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZiNWE5YzU0Mjk0ZjEy Y2E2M2ViYzI4ZmY2NTM5YTM1OGJiMDM5ZS4uYTQxOTMxMzVmNDQyZjNiZGM3MmRkM2ZkMTAyMzQx NTU4NzhkOWVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA3LTAzICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIEFkZCBt b3JlIGRlYnVnIGFuZCBlcnJvciBsb2dnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0NzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUyNjE1 ODgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U291cmNlQnVmZmVyOjpwcm92aWRlTWVkaWFEYXRhKTogTG9nIGlmIHdlIGRvbid0IGVucXVldWUg ZXZlcnkgYnVmZmVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjpwbGF5SW50ZXJu YWwpOiBMb2cgaWYgd2UgcmV0dXJuCisgICAgICAgIHdpdGhvdXQgc3RhcnRpbmcgcGxheWJhY2su CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VC dWZmZXJQcml2YXRlQVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlclBy aXZhdGVBVkZPYmpDOjplbnF1ZXVlU2FtcGxlKTogTG9nIGlmIAorICAgICAgICBwcmVyb2xsRGVj b2RlV2l0aENvbXBsZXRpb25IYW5kbGVyIGZhaWxzLgorCiAyMDE5LTA3LTAxICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBG aXggR1RLIGJ1aWxkIHdpdGggR1NUUkVBTUVSX0dMIGRpc2FibGVkIGFmdGVyIHIyNDY3MTAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNw cAppbmRleCAwYmZiYjBhYzljYjQ2OTVjMzIzMWUwNWY3NDRmZjk3MWI1ODUzMmZhLi41N2E3OTE2 OWFkYTZmMzI1YTM5OWQwMTNjMmU1OWNhMzljMDQwYjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCkBAIC0yMDE3LDYgKzIw MTcsNyBAQCB2b2lkIFNvdXJjZUJ1ZmZlcjo6cHJvdmlkZU1lZGlhRGF0YShUcmFja0J1ZmZlciYg dHJhY2tCdWZmZXIsIGNvbnN0IEF0b21TdHJpbmcmCiAKICAgICB3aGlsZSAoIXRyYWNrQnVmZmVy LmRlY29kZVF1ZXVlLmVtcHR5KCkpIHsKICAgICAgICAgaWYgKCFtX3ByaXZhdGUtPmlzUmVhZHlG b3JNb3JlU2FtcGxlcyh0cmFja0lEKSkgeworICAgICAgICAgICAgREVCVUdfTE9HKExPR0lERU5U SUZJRVIsICJiYWlsaW5nIGVhcmx5LCB0cmFjayBpZCAiLCB0cmFja0lELCAiIGlzIG5vdCByZWFk eSBmb3IgbW9yZSBkYXRhIik7CiAgICAgICAgICAgICBtX3ByaXZhdGUtPm5vdGlmeUNsaWVudFdo ZW5SZWFkeUZvck1vcmVTYW1wbGVzKHRyYWNrSUQpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIH0KQEAgLTIwMzYsOCArMjAzNywxMSBAQCB2b2lkIFNvdXJjZUJ1ZmZlcjo6cHJvdmlkZU1l ZGlhRGF0YShUcmFja0J1ZmZlciYgdHJhY2tCdWZmZXIsIGNvbnN0IEF0b21TdHJpbmcmCiAgICAg ICAgIE1lZGlhVGltZSBvbmVTZWNvbmQoMSwgMSk7CiAgICAgICAgIGlmICh0cmFja0J1ZmZlci5s YXN0RW5xdWV1ZWREZWNvZGVLZXkuZmlyc3QuaXNWYWxpZCgpCiAgICAgICAgICAgICAmJiB0cmFj a0J1ZmZlci5sYXN0RW5xdWV1ZWREZWNvZGVEdXJhdGlvbi5pc1ZhbGlkKCkKLSAgICAgICAgICAg ICYmIHNhbXBsZS0+ZGVjb2RlVGltZSgpIC0gdHJhY2tCdWZmZXIubGFzdEVucXVldWVkRGVjb2Rl S2V5LmZpcnN0ID4gb25lU2Vjb25kICsgdHJhY2tCdWZmZXIubGFzdEVucXVldWVkRGVjb2RlRHVy YXRpb24pCisgICAgICAgICAgICAmJiBzYW1wbGUtPmRlY29kZVRpbWUoKSAtIHRyYWNrQnVmZmVy Lmxhc3RFbnF1ZXVlZERlY29kZUtleS5maXJzdCA+IG9uZVNlY29uZCArIHRyYWNrQnVmZmVyLmxh c3RFbnF1ZXVlZERlY29kZUR1cmF0aW9uKSB7CisKKyAgICAgICAgREVCVUdfTE9HKExPR0lERU5U SUZJRVIsICJiYWlsaW5nIGVhcmx5IGJlY2F1c2Ugb2YgdW5idWZmZXJlZCBnYXAsIG5ldyBzYW1w bGU6ICIsIHNhbXBsZS0+ZGVjb2RlVGltZSgpLCAiLCBsYXN0IGVucXVldWVkIHNhbXBsZSBlbmRz OiAiLCB0cmFja0J1ZmZlci5sYXN0RW5xdWV1ZWREZWNvZGVLZXkuZmlyc3QgKyB0cmFja0J1ZmZl ci5sYXN0RW5xdWV1ZWREZWNvZGVEdXJhdGlvbik7CiAgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgfQogCiAgICAgICAgIC8vIFJlbW92ZSB0aGUgc2FtcGxlIGZyb20gdGhlIGRlY29kZSBxdWV1 ZSBub3cuCiAgICAgICAgIHRyYWNrQnVmZmVyLmRlY29kZVF1ZXVlLmVyYXNlKHRyYWNrQnVmZmVy LmRlY29kZVF1ZXVlLmJlZ2luKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3Vy Y2VBVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCmluZGV4IDc4 ZTYyNDcyNTFlMzkzOGU3NmVkZDJkZTU1MTVjMTFkMGJhMzkwOGIuLjk0OTE1NGU4ZmUzZGVhNGE5 Y2M0YjUyYzgzYjQ5Y2ViZDhjYzg3MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291 cmNlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KQEAg LTI5Niw4ICsyOTYsMTAgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9i akM6OnBsYXkoKQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6 cGxheUludGVybmFsKCkKIHsKLSAgICBpZiAoY3VycmVudE1lZGlhVGltZSgpID49IG1fbWVkaWFT b3VyY2VQcml2YXRlLT5kdXJhdGlvbigpKQorICAgIGlmIChjdXJyZW50TWVkaWFUaW1lKCkgPj0g bV9tZWRpYVNvdXJjZVByaXZhdGUtPmR1cmF0aW9uKCkpIHsKKyAgICAgICAgQUxXQVlTX0xPRyhM T0dJREVOVElGSUVSLCAiYmFpbGluZywgY3VycmVudCB0aW1lOiAiLCBjdXJyZW50TWVkaWFUaW1l KCksICIgZ3JlYXRlciB0aGFuIGR1cmF0aW9uICIsIG1fbWVkaWFTb3VyY2VQcml2YXRlLT5kdXJh dGlvbigpKTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIEFMV0FZU19MT0coTE9HSURF TlRJRklFUik7CiAgICAgbV9wbGF5aW5nID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZh dGVBVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KaW5kZXggN2Q4MjlmMDIzZWRj MWJjOTA0N2Q5ZTk3Yjg5YTQ5MzA5ZmE1ODdmMS4uN2I1ODUxN2Q2YWNhNWYwNzhiZWU2MjE1Y2Ey YzdjMDI0ODViNzFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNl QnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KQEAgLTEwOTgsMTMgKzEwOTgsMTQgQEAgdm9pZCBTb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6ZW5xdWV1ZVNhbXBsZShSZWY8TWVkaWFTYW1wbGU+JiYg c2FtcGxlLCBjb25zdAogICAgIGlmIChwbGF0Zm9ybVNhbXBsZS50eXBlICE9IFBsYXRmb3JtU2Ft cGxlOjpDTVNhbXBsZUJ1ZmZlclR5cGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIERFQlVHX0xP RyhMT0dJREVOVElGSUVSLCAidHJhY2sgSUQgPSAiLCB0cmFja0lELCAiLCBzYW1wbGUgPSAiLCBz YW1wbGUuZ2V0KCkpOworICAgIGF1dG8gbG9nU2l0ZUlkZW50aWZpZXIgPSBMT0dJREVOVElGSUVS OworICAgIERFQlVHX0xPRyhsb2dTaXRlSWRlbnRpZmllciwgInRyYWNrIElEID0gIiwgdHJhY2tJ RCwgIiwgc2FtcGxlID0gIiwgc2FtcGxlLmdldCgpKTsKIAogICAgIGlmICh0cmFja0lEID09IG1f ZW5hYmxlZFZpZGVvVHJhY2tJRCkgewogICAgICAgICBDTUZvcm1hdERlc2NyaXB0aW9uUmVmIGZv cm1hdERlc2NyaXB0aW9uID0gQ01TYW1wbGVCdWZmZXJHZXRGb3JtYXREZXNjcmlwdGlvbihwbGF0 Zm9ybVNhbXBsZS5zYW1wbGUuY21TYW1wbGVCdWZmZXIpOwogICAgICAgICBGbG9hdFNpemUgZm9y bWF0U2l6ZSA9IEZsb2F0U2l6ZShDTVZpZGVvRm9ybWF0RGVzY3JpcHRpb25HZXRQcmVzZW50YXRp b25EaW1lbnNpb25zKGZvcm1hdERlc2NyaXB0aW9uLCB0cnVlLCB0cnVlKSk7CiAgICAgICAgIGlm ICghbV9jYWNoZWRTaXplIHx8IGZvcm1hdFNpemUgIT0gbV9jYWNoZWRTaXplLnZhbHVlKCkpIHsK LSAgICAgICAgICAgIERFQlVHX0xPRyhMT0dJREVOVElGSUVSLCAic2l6ZSBjaGFuZ2VkIHRvICIs IGZvcm1hdFNpemUpOworICAgICAgICAgICAgREVCVUdfTE9HKGxvZ1NpdGVJZGVudGlmaWVyLCAi c2l6ZSBjaGFuZ2VkIHRvICIsIGZvcm1hdFNpemUpOwogICAgICAgICAgICAgYm9vbCBzaXplV2Fz TnVsbCA9ICFtX2NhY2hlZFNpemU7CiAgICAgICAgICAgICBtX2NhY2hlZFNpemUgPSBmb3JtYXRT aXplOwogICAgICAgICAgICAgaWYgKG1fbWVkaWFTb3VyY2UpIHsKQEAgLTExMjIsNyArMTEyMyw3 IEBAIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OmVucXVldWVTYW1wbGUoUmVmPE1l ZGlhU2FtcGxlPiYmIHNhbXBsZSwgY29uc3QKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAg ICBpZiAobV9tZWRpYVNvdXJjZSAmJiAhbV9tZWRpYVNvdXJjZS0+cGxheWVyKCktPmhhc0F2YWls YWJsZVZpZGVvRnJhbWUoKSAmJiAhc2FtcGxlLT5pc05vbkRpc3BsYXlpbmcoKSkgewotICAgICAg ICAgICAgREVCVUdfTE9HKExPR0lERU5USUZJRVIsICJhZGRpbmcgYnVmZmVyIGF0dGFjaG1lbnQi KTsKKyAgICAgICAgICAgIERFQlVHX0xPRyhsb2dTaXRlSWRlbnRpZmllciwgImFkZGluZyBidWZm ZXIgYXR0YWNobWVudCIpOwogCiAgICAgICAgICAgICBib29sIGhhdmVQcmVyb2xsRGVjb2RlV2l0 aENvbXBsZXRpb25IYW5kbGVyID0gW1BBTDo6Z2V0QVZTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXJD bGFzcygpIGluc3RhbmNlc1Jlc3BvbmRUb1NlbGVjdG9yOkBzZWxlY3RvcihwcmVyb2xsRGVjb2Rl V2l0aENvbXBsZXRpb25IYW5kbGVyOildOwogCkBAIC0xMTM2LDEwICsxMTM3LDE2IEBAIHZvaWQg U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OmVucXVldWVTYW1wbGUoUmVmPE1lZGlhU2FtcGxl PiYmIHNhbXBsZSwgY29uc3QKICAgICAgICAgICAgICAgICBtX21lZGlhU291cmNlLT5wbGF5ZXIo KS0+c2V0SGFzQXZhaWxhYmxlVmlkZW9GcmFtZSh0cnVlKTsKICNlbmRpZgogICAgICAgICAgICAg fSBlbHNlIHsKKwogICAgICAgICAgICAgICAgIFttX2Rpc3BsYXlMYXllciBlbnF1ZXVlU2FtcGxl QnVmZmVyOnBsYXRmb3JtU2FtcGxlLnNhbXBsZS5jbVNhbXBsZUJ1ZmZlcl07Ci0gICAgICAgICAg ICAgICAgW21fZGlzcGxheUxheWVyIHByZXJvbGxEZWNvZGVXaXRoQ29tcGxldGlvbkhhbmRsZXI6 W3dlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXSAoQk9PTCBzdWNjZXNzKSBtdXRhYmxlIHsK LSAgICAgICAgICAgICAgICAgICAgaWYgKCFzdWNjZXNzIHx8ICF3ZWFrVGhpcykKKyAgICAgICAg ICAgICAgICBbbV9kaXNwbGF5TGF5ZXIgcHJlcm9sbERlY29kZVdpdGhDb21wbGV0aW9uSGFuZGxl cjpbdGhpcywgbG9nU2l0ZUlkZW50aWZpZXIsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMp XSAoQk9PTCBzdWNjZXNzKSBtdXRhYmxlIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCF3ZWFr VGhpcykKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgICAg ICAgICBpZiAoIXN1Y2Nlc3MpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEVSUk9SX0xPRyhs b2dTaXRlSWRlbnRpZmllciwgInByZXJvbGxEZWNvZGVXaXRoQ29tcGxldGlvbkhhbmRsZXIgZmFp bGVkIik7CiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAg ICAgIH0KIAogICAgICAgICAgICAgICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt3ZWFrVGhpcyA9 IFdURk1vdmUod2Vha1RoaXMpXSAoKSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICAgICAgICAg IGlmICghd2Vha1RoaXMpCg==