199461 2019-07-03 13:47:04 -0700 Isolate CacheStorage::Engine path when hopping to a background thread 2019-07-03 15:15:17 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez cgarcia commit-queue ews-watchlist webkit-bug-importer oldest_to_newest 1549980 0 youennf 2019-07-03 13:47:04 -0700 Isolate CacheStorage::Engine path when hopping to a background thread 1549984 1 373414 youennf 2019-07-03 13:56:14 -0700 Created attachment 373414 Patch 1549987 2 373414 cdumez 2019-07-03 14:02:56 -0700 Comment on attachment 373414 Patch is the usage on m_rootPath inside Engine::fetchEntries() correct? 1550007 3 youennf 2019-07-03 14:50:22 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 373414 [details] > Patch > > is the usage on m_rootPath inside Engine::fetchEntries() correct? Yes, it is fine. But we should really move the code listing the files of a directory to a background thread. 1550024 4 373414 commit-queue 2019-07-03 15:14:10 -0700 Comment on attachment 373414 Patch Clearing flags on attachment: 373414 Committed r247111: <https://trac.webkit.org/changeset/247111> 1550025 5 commit-queue 2019-07-03 15:14:12 -0700 All reviewed patches have been landed. Closing bug. 1550028 6 webkit-bug-importer 2019-07-03 15:15:17 -0700 <rdar://problem/52614234> 373414 2019-07-03 13:56:14 -0700 2019-07-03 15:14:10 -0700 Patch bug-199461-20190703135613.patch text/plain 1881 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5NzU1OTAzOTNkZTQ0YmZi NDk5OTJkMTE4NzlhZDA3OTBlYzJjZDYuLjU1YWQ0MWU5MzM2MmFmOWI2NWMxOTJkNjE4ZTQxMTZm ZWVhOGFjN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDctMDMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIElzb2xhdGUgQ2FjaGVTdG9yYWdl OjpFbmdpbmUgcGF0aCB3aGVuIGhvcHBpbmcgdG8gYSBiYWNrZ3JvdW5kIHRocmVhZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NDYxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpDYWNoZVN0 b3JhZ2U6OkVuZ2luZTo6aW5pdGlhbGl6ZSk6CisKIDIwMTktMDctMDIgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSB0byBjcm9zcy10aHJlYWQg Y29weSBpbiBTdG9yYWdlTWFuYWdlciB3aGVuIGhvcHBpbmcgYmFjayB0byB0aGUgbWFpbiB0aHJl YWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVT dG9yYWdlRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2Fj aGVTdG9yYWdlRW5naW5lLmNwcAppbmRleCA4MGFhYjY4ZDM2YzQ2OGE0YjBjYjkwOGY2Y2ZmNjUw YzJhZjUzMWE2Li5hYzNjZGI5MzA0NmNiNTc0MzA4MmMwMjE1ODQwZjNlMDE3YjIzMWU1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVu Z2luZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0 b3JhZ2VFbmdpbmUuY3BwCkBAIC0yOTksOSArMjk5LDkgQEAgdm9pZCBFbmdpbmU6OmluaXRpYWxp emUoQ29tcGxldGlvbkNhbGxiYWNrJiYgY2FsbGJhY2spCiAgICAgaWYgKCFzaG91bGRDb21wdXRl U2FsdCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgU3RyaW5nIHNhbHRQYXRoID0gRmlsZVN5c3Rl bTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KG1fcm9vdFBhdGgsICJzYWx0Il9zKTsKLSAgICBt X2lvUXVldWUtPmRpc3BhdGNoKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHRoaXMpLCBz YWx0UGF0aCA9IFdURk1vdmUoc2FsdFBhdGgpXSAoKSBtdXRhYmxlIHsKLSAgICAgICAgRmlsZVN5 c3RlbTo6bWFrZUFsbERpcmVjdG9yaWVzKG1fcm9vdFBhdGgpOworICAgIG1faW9RdWV1ZS0+ZGlz cGF0Y2goW3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIodGhpcyksIHJvb3RQYXRoID0gbV9y b290UGF0aC5pc29sYXRlZENvcHkoKV0gKCkgbXV0YWJsZSB7CisgICAgICAgIEZpbGVTeXN0ZW06 Om1ha2VBbGxEaXJlY3Rvcmllcyhyb290UGF0aCk7CisgICAgICAgIFN0cmluZyBzYWx0UGF0aCA9 IEZpbGVTeXN0ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChyb290UGF0aCwgInNhbHQiX3Mp OwogICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3RoaXMsIHdlYWtUaGlzID0gV1RG TW92ZSh3ZWFrVGhpcyksIHNhbHQgPSByZWFkT3JNYWtlU2FsdChzYWx0UGF0aCldKCkgbXV0YWJs ZSB7CiAgICAgICAgICAgICBpZiAoIXdlYWtUaGlzKQogICAgICAgICAgICAgICAgIHJldHVybjsK