199452 2019-07-03 09:59:39 -0700 WebKit has too many ways to stringify things 2021-02-02 02:44:25 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified ASSIGNED P2 Normal --- 199782 1 darin darin fpizlo mitz mrobinson sam simon.fraser oldest_to_newest 1549901 0 darin 2019-07-03 09:59:39 -0700 WebKit has too many different ways to stringify things. Here are the ones I have found so far: std::ostream WTF::makeString (part of WTF’s StringConcatenate) WTF::ValueToString
 WTF::LogArgument (part of WTF::Logger) WTF::PrintStream dump functions WTF::TextStream I plan to remove WTF::ValueToString first, changing the only client (POD trees) to use TextStream instead. I would welcome other ideas for how to get rid of this redundancy. 1551098 1 darin 2019-07-08 19:03:13 -0700 WTF::StringBuilder 1596623 2 darin 2019-12-07 13:59:56 -0800 Seems like we should remove PrintStream and replace it with TextStream. One way to do it is to make PrintStream use TextStream and then remove it a bit at a time. 1602775 3 darin 2020-01-04 11:52:21 -0800 TextStream has some anomalies in how it serializes floating point numbers, always using fixed position with two decimal places. 1636198 4 darin 2020-03-31 13:02:41 -0700 We’ve made progress on unifying makeString and StringBuilder, by having StringBuilder::append be built on the same underpinnings as makeString! 1636199 5 darin 2020-03-31 13:03:37 -0700 In bug 199782 I deleted ValueToString. One down! 1636200 6 simon.fraser 2020-03-31 13:04:09 -0700 (In reply to Darin Adler from comment #3) > TextStream has some anomalies in how it serializes floating point numbers, > always using fixed position with two decimal places. We can control that with FormattingFlags (which itself should be an OptionSet<>). 1636203 7 darin 2020-03-31 13:06:06 -0700 Yes. I was focusing on the default behavior, not the customizability of it