199431 2019-07-02 20:26:06 -0700 AX: Re-enable accessibility/set-selected-text-range-after-newline.html test. 2019-07-31 07:36:14 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199434 https://bugs.webkit.org/show_bug.cgi?id=199061 InRadar P2 Normal --- 1 andresg_22 webkit-unassigned andresg_22 ap cfleizach commit-queue rniwa webkit-bug-importer oldest_to_newest 1549813 0 andresg_22 2019-07-02 20:26:06 -0700 This test had to be disabled due to bug in CharacterIterator.advance. The workaround implemented in visiblePositionForIndexUsingCharacterIterator had to be rolled out because was causing a hang. This test needs to be re-enable once the CharacterIterator.advance bug is fixed. 1549814 1 webkit-bug-importer 2019-07-02 20:26:18 -0700 <rdar://problem/52563340> 1549915 2 ap 2019-07-03 10:17:06 -0700 > This test had to be disabled due to bug in CharacterIterator.advance. What is the bug? Can you link to other bugs where this happened please? 1550195 3 rniwa 2019-07-04 01:57:40 -0700 (In reply to Alexey Proskuryakov from comment #2) > > This test had to be disabled due to bug in CharacterIterator.advance. > > What is the bug? Can you link to other bugs where this happened please? That would be https://bugs.webkit.org/show_bug.cgi?id=199434. 1550196 4 rniwa 2019-07-04 01:58:20 -0700 Also note: https://bugs.webkit.org/show_bug.cgi?id=199061 1557176 5 375202 andresg_22 2019-07-30 19:33:35 -0700 Created attachment 375202 Patch 1557259 6 375202 commit-queue 2019-07-31 07:36:12 -0700 Comment on attachment 375202 Patch Clearing flags on attachment: 375202 Committed r248037: <https://trac.webkit.org/changeset/248037> 1557260 7 commit-queue 2019-07-31 07:36:14 -0700 All reviewed patches have been landed. Closing bug. 375202 2019-07-30 19:33:35 -0700 2019-07-31 07:36:12 -0700 Patch bug-199431-20190730223334.patch text/plain 6775 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE3OGQyNDE4YjVmYThj YjAzNDIxOTcyZGI5NDZlNTUzZWQ0MTRkZC4uNjM3M2UwOWE1ZGQ5YmI1MGVjYWFjM2NiZWRmYTZj OWNlYzU0NzNmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA3LTMwICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogUmUtZW5h YmxlIGFjY2Vzc2liaWxpdHkvc2V0LXNlbGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3bGluZS5o dG1sIHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTk0MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUyNTYzMzQwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gUmUtZW5hYmxlZCBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L3NldC1zZWxlY3RlZC10ZXh0LXJhbmdlLWFmdGVyLW5ld2xpbmUu aHRtbC4KKyAgICAgICAgLSBQdXQgYmFjayB3b3JrYXJvdW5kIGluIHZpc2libGVQb3NpdGlvbkZv ckluZGV4VXNpbmdDaGFyYWN0ZXJJdGVyYXRvcgorICAgICAgICB0aGF0IGlzIG5lZWRlZCBmb3Ig c2V2ZXJhbCBhY2Nlc3NpYmlsaXR5IGlzc3Vlcy4KKyAgICAgICAgLSBUaGlzIHdvcmthcm91bmQg d2FzIHJvbGxlZCBiYWNrIGJlY2F1c2UgaXQgd2FzIHRob3VnaHQgdGhlIGNhdXNlIG9mOgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NDM0CisgICAg ICAgIEl0IHR1cm5lZCBvdXQgdGhhdCB0aGUgYWN0dWFsIGNhdXNlIG9mIHRoYXQgaGFuZyB3YXMg dW5yZWxhdGVkIGFuZCB3YXMKKyAgICAgICAgZml4ZWQgaW46CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk4NDUKKworICAgICAgICAqIGVkaXRpbmcv RWRpdGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2aXNpYmxlUG9zaXRpb25Gb3JJbmRleFVz aW5nQ2hhcmFjdGVySXRlcmF0b3IpOgorCiAyMDE5LTA3LTI5ICBQaGlsaXBwZSBOb3JtYW5kICA8 cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDMwNTgpOiBbR1N0 cmVhbWVyXSBXZWJLaXRXZWJTcmMncyBpbnRlcm5hbCBxdWV1ZSBjYW4gZXhoYXVzdCB0aGUgV2Vi UHJvY2VzcyBtZW1vcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdGlu Zy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRpbmcuY3BwCmluZGV4IGZiZTU4NjAy MGIxNmNkNGY1MzQ5MDRmYjBhOWY1ZTQ1ZDEwMWFkODAuLmYwZDgyZDU0OWNhNTBhMjU5MTE5OTE0 ZGQxNGVjMTI0ZjI4MjZkYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRp dGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nLmNwcApAQCAtMTEy Miw2ICsxMTIyLDE2IEBAIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlUG9zaXRpb25Gb3JJbmRleFVz aW5nQ2hhcmFjdGVySXRlcmF0b3IoTm9kZSYgbm9kZSwgaW50IGluCiAgICAgQ2hhcmFjdGVySXRl cmF0b3IgaXQocmFuZ2UuZ2V0KCkpOwogICAgIGl0LmFkdmFuY2UoaW5kZXggLSAxKTsKIAorICAg IGlmICghaXQuYXRFbmQoKSAmJiBpdC50ZXh0KClbMF0gPT0gJ1xuJykgeworICAgICAgICAvLyBG SVhNRTogd29ya2Fyb3VuZCBmb3IgY29sbGFwc2VkIHJhbmdlICh3aGVyZSBvbmx5IHN0YXJ0IHBv c2l0aW9uIGlzIGNvcnJlY3QpIGVtaXR0ZWQgZm9yIHNvbWUgZW1pdHRlZCBuZXdsaW5lcy4KKyAg ICAgICAgYXV0byBpdGVyYXRvclJhbmdlID0gaXQucmFuZ2UoKTsKKyAgICAgICAgaWYgKGl0ZXJh dG9yUmFuZ2UtPnN0YXJ0UG9zaXRpb24oKSA9PSBpdGVyYXRvclJhbmdlLT5lbmRQb3NpdGlvbigp KSB7CisgICAgICAgICAgICBpdC5hZHZhbmNlKDEpOworICAgICAgICAgICAgaWYgKCFpdC5hdEVu ZCgpKQorICAgICAgICAgICAgICAgIHJldHVybiBWaXNpYmxlUG9zaXRpb24oaXQucmFuZ2UoKS0+ c3RhcnRQb3NpdGlvbigpKTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIHJldHVybiB7IGl0LmF0 RW5kKCkgPyByYW5nZS0+ZW5kUG9zaXRpb24oKSA6IGl0LnJhbmdlKCktPmVuZFBvc2l0aW9uKCks IFVQU1RSRUFNIH07CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYzUxMTUwZjJkYTVhMGJmMjVlZGFiM2MyOWQzZjNi MzFjYTQ4YzUzLi5kYzYxMTE4NWRkNWJkN2E1ZjQ3MTIzMTNmZjM2MGRiMGM2ODg1M2E1IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDctMzAgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2df MjJAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBSZS1lbmFibGUgYWNjZXNzaWJpbGl0eS9zZXQt c2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXdsaW5lLmh0bWwgdGVzdC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTQzMQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTI1NjMzNDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIGFjY2Vzc2liaWxp dHkvaW9zLXNpbXVsYXRvci9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXdsaW5lLmh0 bWw6IFJlbW92ZWQgYmVjYXVzZSBpdCB3YXMgdGhlIHNhbWUgYXMgdGhlIG9uZSBpbiB0aGUgcGFy ZW50IGFjY2Vzc2liaWxpdHkgZGlyZWN0b3J5LCBzbyBlbmFibGluZyBpdCBmb3IgaU9TIGluIGlv cy13azIvVGVzdEV4cGVjdGF0aW9ucy4KKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtd2syL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTktMDctMjggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVvcmdhbml6ZSBVSVNjcmlwdENvbnRyb2xsZXIgaW50byBw bGF0Zm9ybS1zcGVjaWZpYyBzdWJjbGFzc2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5ZGMzMmNh YTMzNmJkOWMyMmEwOTNhM2FlN2VhMWFkYWYwNzBkNDRmLi4xNTZlZTVhNDFkMWI1N2FhOTU5YmNl MWNkNzMxNzU2OTM1ZTRiODk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIyMDgsNyArMjIwOCw2 IEBAIHdlYmtpdC5vcmcvYi8xNzAxMjIgaHR0cC90ZXN0cy9wcmVsb2FkL3NpbmdsZV9kb3dubG9h ZF9wcmVsb2FkX2hlYWRlcnNfY2hhcnNldC5wCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjCiAjIyMgU1RBUlQgT0YgLWRpc2FibGVkIHRlc3RzCiAKLXdlYmtpdC5vcmcv Yi8xOTk0MzEgYWNjZXNzaWJpbGl0eS9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXds aW5lLmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8yMDg3MSBqcy9nYXJiYWdlLWNvbGxlY3Qt YWZ0ZXItc3RyaW5nLWFwcGVuZHMuaHRtbCBbIFNraXAgXQogd2Via2l0Lm9yZy9iLzU4MzIzIGNv bXBvc2l0aW5nL29iamVjdHMvY29tcG9zaXRlZC1vYmplY3QtYWxpZ25tZW50Lmh0bWwgWyBTa2lw IF0KIHdlYmtpdC5vcmcvYi80ODQ1NCBjb21wb3NpdGluZy90aWxpbmcvaHVnZS1sYXllci1yZXNp emUuaHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9p b3Mtc2ltdWxhdG9yL3NldC1zZWxlY3RlZC10ZXh0LXJhbmdlLWFmdGVyLW5ld2xpbmUuaHRtbCBi L0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvaW9zLXNpbXVsYXRvci9zZXQtc2VsZWN0ZWQtdGV4 dC1yYW5nZS1hZnRlci1uZXdsaW5lLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDhkYjY1NmY1NGZlZDE5YWRjOGVhOTA4YzQ0NzJhZWVjN2UxYTNjNTMuLjAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9pb3Mtc2ltdWxhdG9yL3NldC1zZWxlY3RlZC10ZXh0LXJhbmdlLWFmdGVyLW5ld2xpbmUuaHRt bAorKysgL2Rldi9udWxsCkBAIC0xLDQwICswLDAgQEAKLTxodG1sPgotPGhlYWQ+Ci08c2NyaXB0 IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KLTwvaGVhZD4K LTxib2R5PgotCi08ZGl2IGlkPSJjb250ZW50IiBjb250ZW50ZWRpdGFibGUgdGFiaW5kZXg9IjAi PmhlbGxvd29ybGQ8L2Rpdj4KLQotPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Ci0KLTxzY3JpcHQ+ Ci0gICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewotICAgICAgICB3aW5k b3cuanNUZXN0SXNBc3luYyA9IHRydWU7Ci0KLSAgICAgICAgdmFyIGNvbnRlbnQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiY29udGVudCIpOwotICAgICAgICBjb250ZW50LmZvY3VzKCk7Ci0K LSAgICAgICAgdmFyIHRleHQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVu dDsKLSAgICAgICAgdGV4dC5zZXRTZWxlY3RlZFRleHRSYW5nZSg1LCAwKTsKLSAgICAgICAgc2hv dWxkQmVjb21lRXF1YWwoInRleHQuc2VsZWN0ZWRUZXh0UmFuZ2UiLCAiJ3s1LCAwfSciLCBmdW5j dGlvbigpIHsKLSAgICAgICAgICAgIHRleHQucmVwbGFjZVRleHRJblJhbmdlKCJcbiIsIDUsIDAp OwotCi0gICAgICAgICAgICB2YXIgdCA9IHRleHQuc3RyaW5nRm9yUmFuZ2UoMCwgMTEpOwotICAg ICAgICAgICAgdCA9IHQucmVwbGFjZSgvKD86XHJcbnxccnxcbikvZywgJ1tuZXdsaW5lXScpOwot ICAgICAgICAgICAgZGVidWcoIlRoZXJlIG11c3QgYmUgb25seSBvbmUgW25ld2xpbmVdIGJldHdl ZW4gaGVsbG8gYW5kIHdvcmxkOiAiICsgdCk7Ci0KLSAgICAgICAgICAgIHRleHQuc2V0U2VsZWN0 ZWRUZXh0UmFuZ2UoNiwgMCk7Ci0gICAgICAgICAgICBzaG91bGRCZWNvbWVFcXVhbCgidGV4dC5z ZWxlY3RlZFRleHRSYW5nZSIsICInezYsIDB9JyIsIGZ1bmN0aW9uKCkgewotICAgICAgICAgICAg ICAgIHZhciB0ID0gdGV4dC5zdHJpbmdGb3JSYW5nZSg2LCA1KTsKLSAgICAgICAgICAgICAgICB0 ID0gdC5yZXBsYWNlKC8oPzpcclxufFxyfFxuKS9nLCAnW25ld2xpbmVdJyk7Ci0gICAgICAgICAg ICAgICAgZGVidWcoIlRoZSB0ZXh0IGFmdGVyIHRoZSBuZXdsaW5lIHNob3VsZCBiZSB3b3JsZDog IiArIHQpOwotCi0gICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAgICAgICAgICB9 KTsKLSAgICAgICAgfSk7Ci0gICAgfQotPC9zY3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Ci08L2JvZHk+Ci08L2h0bWw+CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggM2JjYzRm MDQ5ZjliY2MwZTI2M2RjYTkzNGU5NTVhZDg3MTJkNzZiZi4uOTk0Njc4MDRiZmVmZTM3N2JmYzQ3 NTM4YjA5MTI1MmU5OTIwNTljMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9z LXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMjQsNiArMjQsNyBAQCBlZGl0aW5nL2lucHV0L2lvcyBbIFBh c3MgXQogZWRpdGluZy9wYXN0ZWJvYXJkL2lvcyBbIFBhc3MgXQogZWRpdGluZy91bmRvLW1hbmFn ZXIgWyBQYXNzIF0KIAorYWNjZXNzaWJpbGl0eS9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRl ci1uZXdsaW5lLmh0bWwgWyBQYXNzIF0KIGFjY2Vzc2liaWxpdHkvc21hcnQtaW52ZXJ0Lmh0bWwg WyBQYXNzIF0KIGFjY2Vzc2liaWxpdHkvc21hcnQtaW52ZXJ0LXJlZmVyZW5jZS5odG1sIFsgUGFz cyBdCiBmYXN0L21lZGlhL21xLWludmVydGVkLWNvbG9ycy1saXZlLXVwZGF0ZS5odG1sIFsgUGFz cyBdCkBAIC05OTYsNyArOTk3LDYgQEAgZmFzdC9mb3Jtcy9pbmRldGVybWluYXRlLXByb2dyZXNz LWlubGluZS1oZWlnaHQuaHRtbCBbIEZhaWx1cmUgXQogZmFzdC9mb3Jtcy9pbnB1dC1hcHBlYXJh bmNlLXNwaW5idXR0b24uaHRtbCBbIEZhaWx1cmUgXQogZmFzdC9yZXBsYWNlZC9ib3JkZXItcmFk aXVzLWNsaXAuaHRtbCBbIEZhaWx1cmUgXQogYWNjZXNzaWJpbGl0eS9pb3Mtc2ltdWxhdG9yL3By ZXNzLWZpcmVzLXRvdWNoLWV2ZW50cy5odG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTk5NDMx IGFjY2Vzc2liaWxpdHkvaW9zLXNpbXVsYXRvci9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRl ci1uZXdsaW5lLmh0bWwgWyBTa2lwIF0KIAogZmFzdC90ZXh0L2NvbWJpbmluZy1jaGFyYWN0ZXIt c2VxdWVuY2UtdmVydGljYWwuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogZmFzdC90ZXh0L3Zl cnRpY2FsLXF1b3RhdGlvbi1tYXJrcy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCg==