199430 2019-07-02 20:21:51 -0700 REGRESSION (iOS 13): Tapping an element with a click event handler no longer clears the selection 2019-07-03 12:59:10 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1549812 0 wenson_hsieh 2019-07-02 20:21:51 -0700 This makes it nearly impossible to truly dismiss a text selection on a New York Times article, Google search results page, and other big websites. I wrote “truly dismiss” because while it looks like the UIKit selection view disappears upon tapping, the DOM selection remains the same. To reproduce: 1. Go to any New York Times article. 2. Make a text selection. 3. Try to dismiss the text selection by tapping on some other text. Notice that the blue tinted selection view disappears. 4. Open Web Inspector and type “getSelection().toString()”. Expected: Empty string. Observed: The originally selected text. 1549886 1 373390 wenson_hsieh 2019-07-03 08:22:16 -0700 Created attachment 373390 Patch 1549887 2 webkit-bug-importer 2019-07-03 08:23:15 -0700 <rdar://problem/52589498> 1549949 3 373390 thorton 2019-07-03 12:26:50 -0700 Comment on attachment 373390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373390&action=review > Source/WebCore/ChangeLog:8 > + After <trac.webkit.org/r245067>, we no longer immediately clear the text selection when recognizing a single tap Whoops > Source/WebCore/ChangeLog:24 > + breaking the fix in r233311 by matching macOS behavior and not bailing via early return in the case where the Very nice! 1549963 4 373390 commit-queue 2019-07-03 12:59:08 -0700 Comment on attachment 373390 Patch Clearing flags on attachment: 373390 Committed r247100: <https://trac.webkit.org/changeset/247100> 1549964 5 commit-queue 2019-07-03 12:59:10 -0700 All reviewed patches have been landed. Closing bug. 373390 2019-07-03 08:22:16 -0700 2019-07-03 12:59:08 -0700 Patch bug-199430-20190703082216.patch text/plain 14140 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ0NDlkMDYwMDk5ODYy MGMxZWE5Y2Y4YmUzMDA4M2FmNzdkZGRjOC4uNWE5NzU0OWY0NzVhOTI3NTQ1MDc3MjgyMDQ2MmM5 ZGI5NmVjM2RjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE5LTA3LTAzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KGlPUyAxMyk6IFRhcHBpbmcgYW4gZWxlbWVudCB3aXRoIGEgY2xpY2sgZXZlbnQgaGFuZGxlciBu byBsb25nZXIgY2xlYXJzIHRoZSBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTQzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIDx0cmFjLndlYmtpdC5vcmcvcjI0NTA2Nz4sIHdl IG5vIGxvbmdlciBpbW1lZGlhdGVseSBjbGVhciB0aGUgdGV4dCBzZWxlY3Rpb24gd2hlbiByZWNv Z25pemluZyBhIHNpbmdsZSB0YXAKKyAgICAgICAgaW4gV0tDb250ZW50VmlldywgYW5kIGluc3Rl YWQgb25seSBjbGVhciBpdCBvdXQgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIHNpbmdsZSB0YXAgZGlk bid0IHJlc3VsdCBpbiBhIGNsaWNrIGV2ZW50CisgICAgICAgIGluIHRoZSB3ZWIgcHJvY2Vzcy4g VGhpcyBmaXhlZCBhbiBpc3N1ZSB3aGVyZWluIHRoZSB0ZXh0IHNlbGVjdGlvbiB3b3VsZCBiZSBw cmVtYXR1cmVseSBjbGVhcmVkIHdoZW4gdGFwcGluZywKKyAgICAgICAgYnV0IGFsc28gbWFkZSBp dCBzdWNoIHRoYXQgdGFwcGluZyBvbiBhbiBlbGVtZW50IHdpdGggYSBjbGljayBldmVudCBoYW5k bGVyIHdvdWxkIG5vdCBjYXVzZSB0aGUgc2VsZWN0aW9uIHRvCisgICAgICAgIGNoYW5nZSwgZXZl biBpZiBwcmV2ZW50RGVmYXVsdCgpIGlzIG5vdCBjYWxsZWQgb24gbW91c2Vkb3duLiBPbiB3ZWIg cGFnZXMgdGhhdCBhZGQgYSBjbGljayBldmVudCBsaXN0ZW5lciB0bworICAgICAgICBgZG9jdW1l bnQuYm9keWAsIGl0J3MgbmVhcmx5IGltcG9zc2libGUgdG8gZGlzbWlzcyB0ZXh0IHNlbGVjdGlv bnMgYnkgdGFwcGluZyBlbHNld2hlcmUgaW4gdGhlIGJvZHkuCisKKyAgICAgICAgT24gbWFjT1Ms IHRoaXMgd29ya3MgYmVjYXVzZSBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudFNp bmdsZUNsaWNrIGNvbnRhaW5zIGxvZ2ljIHRvIG1vZGlmeSB0aGUKKyAgICAgICAgc2VsZWN0aW9u IHdoZW4gaGFuZGxpbmcgYSBtb3VzZWRvd24sIGFzIGEgcGFydCBvZiBkZWZhdWx0IGJlaGF2aW9y LiBIb3dldmVyLCB0aGVyZSBpcyBwbGF0Zm9ybS1zcGVjaWZpYyBsb2dpYworICAgICAgICBhZGRl ZCBpbiA8dHJhYy53ZWJraXQub3JnL3IyMzMzMTE+IHRoYXQgYXZvaWRzIGNoYW5naW5nIHRoZSBz ZWxlY3Rpb24gd2hlbiBoYW5kbGluZyBhIHN5bnRoZXRpYyBtb3VzZWRvd24gb24KKyAgICAgICAg aU9TOyB0aGlzIGlzIGJlY2F1c2Ugd2UgZGVmZXIgdG8gdGhlIHNpbmdsZSB0YXAgdGV4dCBpbnRl cmFjdGlvbiBnZXN0dXJlIG9uIGlPUywgd2hpY2ggKGFtb25nIG90aGVyIHRoaW5ncykKKyAgICAg ICAgcHJvdmlkZXMgYWRkaXRpb25hbCBzdXBwb3J0IGZvciBtb3ZpbmcgdGhlIHNlbGVjdGlvbiB0 byB3b3JkIGJvdW5kYXJpZXMsIGluc3RlYWQgb2YgdGhlIGVkaXRpbmcgcG9zaXRpb24KKyAgICAg ICAgZGlyZWN0bHkgdW5kZXIgdGhlIGNsaWNrLgorCisgICAgICAgIEhvd2V2ZXIsIG5vIHN1Y2gg cGxhdGZvcm0tc3BlY2lmaWMgdGV4dCBpbnRlcmFjdGlvbiBzaW5nbGUgdGFwIGdlc3R1cmUgZXhp c3RzIGZvciBub24tZWRpdGFibGUgdGV4dCwgc28gdGhlcmUncworICAgICAgICBubyByZWFzb24g d2UgbmVlZCB0byBiYWlsIGluIHRoZSBjYXNlIHdoZXJlIHRoZSByb290IGVkaXRhYmxlIGVsZW1l bnQgaXMgbnVsbC4gV2UgY2FuIGZpeCB0aGlzIGJ1ZyB3aXRob3V0CisgICAgICAgIGJyZWFraW5n IHRoZSBmaXggaW4gcjIzMzMxMSBieSBtYXRjaGluZyBtYWNPUyBiZWhhdmlvciBhbmQgbm90IGJh aWxpbmcgdmlhIGVhcmx5IHJldHVybiBpbiB0aGUgY2FzZSB3aGVyZSB0aGUKKyAgICAgICAgc2lu Z2xlIHRhcCB3b3VsZCBtb3ZlIHNlbGVjdGlvbiBpbnRvIG5vbi1lZGl0YWJsZSB0ZXh0LgorCisg ICAgICAgIFRlc3RzOiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvY2xlYXItc2VsZWN0aW9uLWFmdGVy LXRhcHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNrLWhhbmRsZXIuaHRtbAorICAgICAgICAgICAg ICAgZWRpdGluZy9zZWxlY3Rpb24vaW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmct b24tZWxlbWVudC13aXRoLW1vdXNlZG93bi1oYW5kbGVyLmh0bWwKKworICAgICAgICAqIHBhZ2Uv RXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxl TW91c2VQcmVzc0V2ZW50U2luZ2xlQ2xpY2spOgorCiAyMDE5LTA3LTAxICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgSXQgc2hvdWxkIG5vdCBiZSBwb3NzaWJsZSB0 byB0cmlnZ2VyIGEgbG9hZCB3aGlsZSBpbiB0aGUgbWlkZGxlIG9mIHJlc3RvcmluZyBhIHBhZ2Ug aW4gUGFnZUNhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYTMwYzll OTQzN2U3NWEwYjI1ZWU3ZDg1MzA4NTViMjVhNTRhMDhiZS4uMmI0OGY0YjAyYTU1MThlMDk0NzRj OThjMjAzYWY1MzlkMzU1YjcyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApA QCAtNjkyLDcgKzY5Miw4IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZl bnRTaW5nbGVDbGljayhjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSCiAKICNpZiBQTEFURk9S TShJT1NfRkFNSUxZKQogICAgIC8vIFRoZSB0ZXh0IHNlbGVjdGlvbiBhc3Npc3RhbnQgd2lsbCBo YW5kbGUgc2VsZWN0aW9uIGluIHRoZSBjYXNlIHdoZXJlIHdlIGFyZSBhbHJlYWR5IGVkaXRpbmcg dGhlIG5vZGUKLSAgICBpZiAobmV3U2VsZWN0aW9uLnJvb3RFZGl0YWJsZUVsZW1lbnQoKSA9PSB0 YXJnZXROb2RlLT5yb290RWRpdGFibGVFbGVtZW50KCkpCisgICAgYXV0byogZWRpdGFibGVSb290 ID0gbmV3U2VsZWN0aW9uLnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKKyAgICBpZiAoZWRpdGFibGVS b290ICYmIGVkaXRhYmxlUm9vdCA9PSB0YXJnZXROb2RlLT5yb290RWRpdGFibGVFbGVtZW50KCkp CiAgICAgICAgIHJldHVybiB0cnVlOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1Zjc1ZWRhNWEwOWNiMjc4 MjFlODY3NDgzMWEyZDhlYjk2ZGM5Nzg4Li40Mzk1NTRhMTI0NmE4ZDBjYTRkMjI0NzQyZDdlNWY5 Yzk4ODFiMTdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDctMDMgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoaU9TIDEz KTogVGFwcGluZyBhbiBlbGVtZW50IHdpdGggYSBjbGljayBldmVudCBoYW5kbGVyIG5vIGxvbmdl ciBjbGVhcnMgdGhlIHNlbGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk5NDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGFuZCBhZGp1c3QgbGF5b3V0IHRlc3RzIHRvIHZlcmlmeSB0aGF0 IGNhbGxpbmcgcHJldmVudERlZmF1bHQoKSBvbiBtb3VzZWRvd24gb24gaU9TIGNhdXNlcyBhbiBl eGlzdGluZworICAgICAgICBzZWxlY3Rpb24gdG8gbm90IGJlIGNsZWFyZWQsIGFuZCB0aGF0IHRh cHBpbmcgaW4gYW4gZWxlbWVudCB3aXRoIGEgY2xpY2sgaGFuZGxlciBjbGVhcnMgb3V0IHRoZSBz ZWxlY3Rpb24uCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvY2xlYXItc2VsZWN0 aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNrLWhhbmRsZXItZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvY2xlYXItc2VsZWN0 aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNrLWhhbmRsZXIuaHRtbDogQWRk ZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vaW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFm dGVyLXRhcHBpbmctb24tZWxlbWVudC13aXRoLW1vdXNlZG93bi1oYW5kbGVyLWV4cGVjdGVkLnR4 dDogUmVuYW1lZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxl Y3Rpb24tYWZ0ZXItdGFwcGluZy1vbi1lbGVtZW50LXdpdGgtbW91c2Vkb3duLWhhbmRsZXIuaHRt bDoKKworICAgICAgICBSZW5hbWVkIGZyb20gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24v aW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNr LWhhbmRsZXIuaHRtbCwKKyAgICAgICAgYW5kIGFkanVzdGVkIHRvIGNhbGwgcHJldmVudERlZmF1 bHQoKSBvbiBtb3VzZWRvd24gZXZlbnRzIGluc3RlYWQgb2YgY2xpY2sgZXZlbnRzLiBBbHNvLCBy ZW1vdmUgYSBiaXQgb2YKKyAgICAgICAgdHJhaWxpbmcgd2hpdGVzcGFjZS4KKwogMjAxOS0wNy0w MSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T IDEzXSBlZGl0aW5nL3NlbGVjdGlvbi9pb3MvZGlzcGF0Y2gtbW91c2UtZXZlbnRzLXdoZW4tbW9k aWZ5aW5nLXNlbGVjdGlvbi1xdWlyay5odG1sIGZhaWxzIG9uIHRydW5rCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvY2xlYXItc2VsZWN0aW9uLWFmdGVyLXRh cHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNrLWhhbmRsZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2NsZWFyLXNlbGVjdGlvbi1hZnRlci10YXBwaW5n LW9uLWVsZW1lbnQtd2l0aC1jbGljay1oYW5kbGVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42 NjBhNmFjMmNlYTk5OGEyNzlhZDI3NjJjOGFjOTgzNjEyZTBkMTYyCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2NsZWFyLXNlbGVjdGlvbi1hZnRl ci10YXBwaW5nLW9uLWVsZW1lbnQtd2l0aC1jbGljay1oYW5kbGVyLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDEyIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUgRE9NIHNlbGVjdGlvbiBp cyBkaXNtaXNzZWQgd2hlbiB0YXBwaW5nIG9uIGFuIGVsZW1lbnQgdGhhdCBsaXN0ZW5zIHRvIGNs aWNrIGV2ZW50cy4gVG8gbWFudWFsbHkgdGVzdCwgc2VsZWN0ICdXZWJLaXQnIGFuZCB0YXAgb24g dGhlIHJlZCBzcXVhcmUuIFRoZSBzZWxlY3Rpb24gc2hvdWxkIGJlIGRpc21pc3NlZCwgYW5kIHRo ZSBvdXRwdXQgYXJlYSBzaG91bGQgaW5kaWNhdGUgdGhhdCBubyB0ZXh0IGlzIHNlbGVjdGVkLgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBnZXRTZWxlY3Rpb24oKS50b1N0 cmluZygpIGlzICIiCitQQVNTIGdldFNlbGVjdGlvbigpLnR5cGUgaXMgIkNhcmV0IgorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitXZWJLaXQKK1RoZSBz ZWxlY3RlZCB0ZXh0IGlzOiAiIgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxl Y3Rpb24vaW9zL2NsZWFyLXNlbGVjdGlvbi1hZnRlci10YXBwaW5nLW9uLWVsZW1lbnQtd2l0aC1j bGljay1oYW5kbGVyLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvY2xl YXItc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13aXRoLWNsaWNrLWhhbmRsZXIu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43MzU2MzI5ODUzZTQyYTM3NzAxMGY5MTE2YzdiMTExMWI3YTdkMDM0 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaW9zL2Ns ZWFyLXNlbGVjdGlvbi1hZnRlci10YXBwaW5nLW9uLWVsZW1lbnQtd2l0aC1jbGljay1oYW5kbGVy Lmh0bWwKQEAgLTAsMCArMSw1MyBAQAorPCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3Qt cnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlIF0gLS0+Cis8aHRtbD4KKzxtZXRhIG5h bWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9 MSwgdXNlci1zY2FsYWJsZT1ubyI+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vLi4v cmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c3R5bGU+CisgICAgYm9k eSB7CisgICAgICAgIG1hcmdpbjogMDsKKyAgICB9CisKKyAgICAjdGFyZ2V0IHsKKyAgICAgICAg Zm9udC1zaXplOiAxMDBweDsKKyAgICB9CisKKyAgICAjY2xpY2tUYXJnZXQgeworICAgICAgICB3 aWR0aDogMTAwcHg7CisgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgIGJhY2tncm91bmQt Y29sb3I6IHRvbWF0bzsKKyAgICB9CisgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0PgorICAgIGpz VGVzdElzQXN5bmMgPSB0cnVlOworICAgIHByb2dyZXNzID0gMDsKKworICAgIGZ1bmN0aW9uIGNo ZWNrUHJvZ3Jlc3MoKSB7CisgICAgICAgIGlmICgrK3Byb2dyZXNzICE9IDIpCisgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJnZXRTZWxlY3Rpb24o KS50b1N0cmluZygpIiwgIiIpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImdldFNl bGVjdGlvbigpLnR5cGUiLCAiQ2FyZXQiKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAg fQorCisgICAgZnVuY3Rpb24gcnVuKCkgeworICAgICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 IHZlcmlmaWVzIHRoYXQgdGhlIERPTSBzZWxlY3Rpb24gaXMgZGlzbWlzc2VkIHdoZW4gdGFwcGlu ZyBvbiBhbiBlbGVtZW50IHRoYXQgbGlzdGVucyB0byBjbGljayBldmVudHMuIFRvIG1hbnVhbGx5 IHRlc3QsIHNlbGVjdCAnV2ViS2l0JyBhbmQgdGFwIG9uIHRoZSByZWQgc3F1YXJlLiBUaGUgc2Vs ZWN0aW9uIHNob3VsZCBiZSBkaXNtaXNzZWQsIGFuZCB0aGUgb3V0cHV0IGFyZWEgc2hvdWxkIGlu ZGljYXRlIHRoYXQgbm8gdGV4dCBpcyBzZWxlY3RlZC4iKTsKKworICAgICAgICBkb2N1bWVudC5h ZGRFdmVudExpc3RlbmVyKCJzZWxlY3Rpb25jaGFuZ2UiLCAoKSA9PiBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgicmVzdWx0IikudGV4dENvbnRlbnQgPSBnZXRTZWxlY3Rpb24oKS50b1N0cmluZygp KTsKKyAgICAgICAgY29uc3QgY2xpY2tUYXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi Y2xpY2tUYXJnZXQiKTsKKyAgICAgICAgY2xpY2tUYXJnZXQuYWRkRXZlbnRMaXN0ZW5lcigiY2xp Y2siLCBjaGVja1Byb2dyZXNzKTsKKyAgICAgICAgZ2V0U2VsZWN0aW9uKCkuc2VsZWN0QWxsQ2hp bGRyZW4oZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlbGVjdGlvblRhcmdldCIpKTsKKworICAg ICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICBVSUhlbHBlci5hY3RpdmF0 ZUVsZW1lbnQoY2xpY2tUYXJnZXQpLnRoZW4oY2hlY2tQcm9ncmVzcyk7CisgICAgfQorICAgIDwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW4oKSI+CisgICAgPGRpdiBpZD0ic2Vs ZWN0aW9uVGFyZ2V0Ij5XZWJLaXQ8L2Rpdj4KKyAgICA8ZGl2IGlkPSJjbGlja1RhcmdldCI+PC9k aXY+CisgICAgPHByZT5UaGUgc2VsZWN0ZWQgdGV4dCBpczogIjxzcGFuIGlkPSJyZXN1bHQiPjwv c3Bhbj4iPC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxlY3Rpb24tYWZ0ZXItdGFwcGluZy1vbi1l bGVtZW50LXdpdGgtY2xpY2staGFuZGxlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxlY3Rpb24tYWZ0ZXItdGFwcGluZy1vbi1lbGVt ZW50LXdpdGgtY2xpY2staGFuZGxlci1leHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IGU2ZDk3ZWY0ZmRkODhmMjQxZWJjODYyNzQ4Y2UxZjI5NTQ2YTZhYjkuLjAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvZWRp dGluZy9zZWxlY3Rpb24vaW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmctb24tZWxl bWVudC13aXRoLWNsaWNrLWhhbmRsZXItZXhwZWN0ZWQudHh0CisrKyAvZGV2L251bGwKQEAgLTEs MyArMCwwIEBACi1XZWJLaXQKLVRoZSBzZWxlY3RlZCB0ZXh0IGlzOiAiV2ViS2l0IgotVGhpcyB0 ZXN0IHZlcmlmaWVzIHRoYXQgdGhlIERPTSBzZWxlY3Rpb24gaXMgbm90IGRpc21pc3NlZCB3aGVu IHRhcHBpbmcgb24gYW4gZWxlbWVudCB0aGF0IHByZXZlbnREZWZhdWx0KClzIHRoZSBjbGljayBl dmVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9wZXJz aXN0LXNlbGVjdGlvbi1hZnRlci10YXBwaW5nLW9uLWVsZW1lbnQtd2l0aC1jbGljay1oYW5kbGVy Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxlY3Rp b24tYWZ0ZXItdGFwcGluZy1vbi1lbGVtZW50LXdpdGgtY2xpY2staGFuZGxlci5odG1sCmRlbGV0 ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBlMzhmNGQzMGZjMDRmZjQzMWE3MTNmYmFkNmUxNTJk YzBhNjFlMjUyLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBh L0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9wZXJzaXN0LXNlbGVjdGlvbi1hZnRl ci10YXBwaW5nLW9uLWVsZW1lbnQtd2l0aC1jbGljay1oYW5kbGVyLmh0bWwKKysrIC9kZXYvbnVs bApAQCAtMSw2MCArMCwwIEBACi08IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5u ZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUgXSAtLT4KLTxodG1sPgotPG1ldGEgbmFtZT0i dmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLCB1 c2VyLXNjYWxhYmxlPW5vIj4KLTxoZWFkPgotICAgIDxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNv dXJjZXMvYmFzaWMtZ2VzdHVyZXMuanMiPjwvc2NyaXB0PgotICAgIDxzY3JpcHQgc3JjPSIuLi8u Li8uLi9yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KLSAgICA8c3R5bGU+Ci0gICAg Ym9keSB7Ci0gICAgICAgIG1hcmdpbjogMDsKLSAgICB9Ci0KLSAgICAjdGFyZ2V0IHsKLSAgICAg ICAgZm9udC1zaXplOiAxMDBweDsKLSAgICB9Ci0KLSAgICAjY2xpY2tUYXJnZXQgewotICAgICAg ICB3aWR0aDogMTAwcHg7Ci0gICAgICAgIGhlaWdodDogMTAwcHg7Ci0gICAgICAgIGJhY2tncm91 bmQtY29sb3I6IGdyZWVuOwotICAgIH0KLSAgICA8L3N0eWxlPgotICAgIDxzY3JpcHQ+Ci0gICAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7Ci0gICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OwotICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICB9Ci0KLSAgICBhc3lu YyBmdW5jdGlvbiBydW4oKQotICAgIHsKLSAgICAgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikK LSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICBmdW5jdGlvbiBkaWRDaGFuZ2VTZWxlY3Rp b24oKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXN1bHQudGV4dENvbnRlbnQgPSB3aW5kb3cu Z2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKQotICAgICAgICB9Ci0KLSAgICAgICAgZG9jdW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigic2VsZWN0aW9uY2hhbmdlIiwgZGlkQ2hhbmdlU2VsZWN0aW9uKTsK LQotICAgICAgICB2YXIgY2xpY2tUYXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY2xp Y2tUYXJnZXQiKTsKLQotICAgICAgICBjbGlja1RhcmdldC5hZGRFdmVudExpc3RlbmVyKCJjbGlj ayIsIGV2ZW50ID0+IHsKLSAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0gICAg ICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpLCAwKTsKLSAg ICAgICAgfSk7Ci0KLSAgICAgICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJ0YXJnZXQiKTsgICAgICAgIAotICAgICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0QmFz ZUFuZEV4dGVudCh0YXJnZXQsIDAsIHRhcmdldCwgNik7Ci0KLSAgICAgICAgYXdhaXQgVUlIZWxw ZXIuYWN0aXZhdGVFbGVtZW50KGNsaWNrVGFyZ2V0KTsKLSAgICB9Ci0gICAgPC9zY3JpcHQ+Ci08 L2hlYWQ+Ci08Ym9keSBvbmxvYWQ9InJ1bigpIj4KLSAgICA8ZGl2IGlkPSJ0YXJnZXQiPldlYktp dDwvZGl2PgotICAgIDxkaXYgaWQ9ImNsaWNrVGFyZ2V0Ij48L2Rpdj4KLSAgICA8cHJlPlRoZSBz ZWxlY3RlZCB0ZXh0IGlzOiAiPHNwYW4gaWQ9InJlc3VsdCI+PC9zcGFuPiI8L3ByZT4KLSAgICA8 cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUgRE9NIHNlbGVjdGlvbiBpcyBub3QgZGlzbWlz c2VkIHdoZW4gdGFwcGluZyBvbiBhbiBlbGVtZW50IHRoYXQgcHJldmVudERlZmF1bHQoKXMgdGhl IGNsaWNrIGV2ZW50LjwvcD4KLTwvYm9keT4KLTwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9wZXJzaXN0LXNlbGVjdGlvbi1hZnRlci10YXBwaW5n LW9uLWVsZW1lbnQtd2l0aC1tb3VzZWRvd24taGFuZGxlci1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxlY3Rpb24tYWZ0ZXItdGFwcGlu Zy1vbi1lbGVtZW50LXdpdGgtbW91c2Vkb3duLWhhbmRsZXItZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjYxMWM2OTRhZmZiMjM2YzdhOTU3MTA1YTk2OTg5OTUyMWRiZmFhZDIKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvcGVyc2lzdC1zZWxlY3Rp b24tYWZ0ZXItdGFwcGluZy1vbi1lbGVtZW50LXdpdGgtbW91c2Vkb3duLWhhbmRsZXItZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorV2ViS2l0CitUaGUgc2VsZWN0ZWQgdGV4dCBpczogIldl YktpdCIKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHRoZSBET00gc2VsZWN0aW9uIGlzIG5vdCBk aXNtaXNzZWQgd2hlbiB0YXBwaW5nIG9uIGFuIGVsZW1lbnQgdGhhdCBwcmV2ZW50RGVmYXVsdCgp cyB0aGUgbW91c2Vkb3duIGV2ZW50LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vaW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13 aXRoLW1vdXNlZG93bi1oYW5kbGVyLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9pb3MvcGVyc2lzdC1zZWxlY3Rpb24tYWZ0ZXItdGFwcGluZy1vbi1lbGVtZW50LXdpdGgtbW91 c2Vkb3duLWhhbmRsZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44OWI3NmNkOTI0NTM3MDQ1OWE3YzRlZWIw MDllMDg5MGQ3YWUxM2YyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vaW9zL3BlcnNpc3Qtc2VsZWN0aW9uLWFmdGVyLXRhcHBpbmctb24tZWxlbWVudC13 aXRoLW1vdXNlZG93bi1oYW5kbGVyLmh0bWwKQEAgLTAsMCArMSw2MCBAQAorPCFET0NUWVBFIGh0 bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlIF0g LS0+Cis8aHRtbD4KKzxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Ut d2lkdGgsIGluaXRpYWwtc2NhbGU9MSwgdXNlci1zY2FsYWJsZT1ubyI+Cis8aGVhZD4KKyAgICA8 c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2Jhc2ljLWdlc3R1cmVzLmpzIj48L3Njcmlw dD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9z Y3JpcHQ+CisgICAgPHN0eWxlPgorICAgIGJvZHkgeworICAgICAgICBtYXJnaW46IDA7CisgICAg fQorCisgICAgI3RhcmdldCB7CisgICAgICAgIGZvbnQtc2l6ZTogMTAwcHg7CisgICAgfQorCisg ICAgI2NsaWNrVGFyZ2V0IHsKKyAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICBoZWlnaHQ6 IDEwMHB4OworICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICB9CisgICAgPC9z dHlsZT4KKyAgICA8c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxE b25lKCk7CisgICAgfQorCisgICAgYXN5bmMgZnVuY3Rpb24gcnVuKCkKKyAgICB7CisgICAgICAg IGlmICghd2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAg ZnVuY3Rpb24gZGlkQ2hhbmdlU2VsZWN0aW9uKCkKKyAgICAgICAgeworICAgICAgICAgICAgcmVz dWx0LnRleHRDb250ZW50ID0gd2luZG93LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkKKyAgICAg ICAgfQorCisgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoInNlbGVjdGlvbmNoYW5n ZSIsIGRpZENoYW5nZVNlbGVjdGlvbik7CisKKyAgICAgICAgdmFyIGNsaWNrVGFyZ2V0ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNsaWNrVGFyZ2V0Iik7CisKKyAgICAgICAgY2xpY2tUYXJn ZXQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwgZXZlbnQgPT4geworICAgICAgICAgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAgICAgICAgIHNldFRpbWVvdXQoKCkgPT4gdGVz dFJ1bm5lci5ub3RpZnlEb25lKCksIDApOworICAgICAgICB9KTsKKworICAgICAgICB2YXIgdGFy Z2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpOworICAgICAgICB3aW5kb3cu Z2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudCh0YXJnZXQsIDAsIHRhcmdldCwgNik7CisK KyAgICAgICAgYXdhaXQgVUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50KGNsaWNrVGFyZ2V0KTsKKyAg ICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1bigpIj4KKyAgICA8 ZGl2IGlkPSJ0YXJnZXQiPldlYktpdDwvZGl2PgorICAgIDxkaXYgaWQ9ImNsaWNrVGFyZ2V0Ij48 L2Rpdj4KKyAgICA8cHJlPlRoZSBzZWxlY3RlZCB0ZXh0IGlzOiAiPHNwYW4gaWQ9InJlc3VsdCI+ PC9zcGFuPiI8L3ByZT4KKyAgICA8cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUgRE9NIHNl bGVjdGlvbiBpcyBub3QgZGlzbWlzc2VkIHdoZW4gdGFwcGluZyBvbiBhbiBlbGVtZW50IHRoYXQg cHJldmVudERlZmF1bHQoKXMgdGhlIG1vdXNlZG93biBldmVudC48L3A+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==