199428 2019-07-02 19:15:44 -0700 [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith' 2019-07-04 07:02:33 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 199493 https://bugs.webkit.org/show_bug.cgi?id=199078 P2 Normal --- 1 fujii fujii dean_johnson don.olmstead ews-watchlist glenn jbedard ross.kirsling oldest_to_newest 1549807 0 fujii 2019-07-02 19:15:44 -0700 [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith' AppleWin and WinCairo are failing. https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/2856 https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4417 > Traceback (most recent call last): > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 374, in <module> > sys.exit(main()) > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 72, in main > if not _supports_building_and_running_lldb_tests(): > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 107, in _supports_building_and_running_lldb_tests > return not _host.platform.build_version().startswith('19A') > AttributeError: 'NoneType' object has no attribute 'startswith' Since Bug 199078. 1549809 1 373377 fujii 2019-07-02 19:25:59 -0700 Created attachment 373377 Patch 1549869 2 373377 jbedard 2019-07-03 07:17:00 -0700 Comment on attachment 373377 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review > Tools/Scripts/webkitpy/test/main.py:106 > + return False Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right? 1550155 3 373377 fujii 2019-07-03 18:51:27 -0700 Comment on attachment 373377 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review >> Tools/Scripts/webkitpy/test/main.py:106 >> + return False > > Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right? Yup. build_version is available only for mac. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py?rev=243030#L150 1550233 4 fujii 2019-07-04 07:01:38 -0700 *** This bug has been marked as a duplicate of bug 199493 *** 373377 2019-07-02 19:25:59 -0700 2019-07-04 07:02:33 -0700 Patch bug-199428-20190703112557.patch text/plain 1444 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjQ2ZjZlMzE5MjdlYjliMDIwZDQzYmRmMmFlMjZkMzRh Y2RlZDIxMy4uNTc3OTc2ZGE2ZTc2NzNlMTc1N2RhYjZiNzE5YjNjY2I1MjE1ZTYyNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA3LTAyICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIHRlc3Qtd2Via2l0cHkgaXMgZmFpbGluZyBpbiBfc3VwcG9ydHNf YnVpbGRpbmdfYW5kX3J1bm5pbmdfbGxkYl90ZXN0czogQXR0cmlidXRlRXJyb3I6ICdOb25lVHlw ZScgb2JqZWN0IGhhcyBubyBhdHRyaWJ1dGUgJ3N0YXJ0c3dpdGgnCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0MjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBfaG9zdC5wbGF0Zm9ybS5idWlsZF92ZXJz aW9uKCkgcmV0dXJucyBOb25lIGZvciBhbGwgcGxhdGZvcm0gYnV0IG1hYy4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5OgorICAgICAgICAoX3N1cHBvcnRzX2J1aWxk aW5nX2FuZF9ydW5uaW5nX2xsZGJfdGVzdHMpOiBDaGVjayBpc19tYWMoKS4KKwogMjAxOS0wNy0w MiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1i dWlsZF0gQWRkIGJ1aWxkIHN0ZXBzIHRvIEluc3RhbGwgV3BlIGFuZCBHdGsgZGVwZW5kZW5jaWVz CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CmluZGV4IGYzYmYyZGFmZTM5MTA1YmU3YzQw OTdlNmYyNTAzZGYwNThhMTg1MTMuLjM3YjMwOWRjOTE3Y2EyMTQ4MjZkN2U4ODc2YmYzMDQ2OGM0 OTI2MmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CkBAIC0xMDIsNiArMTAyLDgg QEAgZGVmIG1haW4oKToKIAogCiBkZWYgX3N1cHBvcnRzX2J1aWxkaW5nX2FuZF9ydW5uaW5nX2xs ZGJfdGVzdHMoKToKKyAgICBpZiBub3QgX2hvc3QucGxhdGZvcm0uaXNfbWFjKCk6CisgICAgICAg IHJldHVybiBGYWxzZQogICAgICMgRklYTUU6IFJlbW92ZSB3aGVuIHRlc3QtbGxkYiBpcyBpbiBp dHMgb3duIHNjcmlwdAogICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NzkxNgogICAgIHJldHVybiBub3QgX2hvc3QucGxhdGZvcm0uYnVpbGRfdmVyc2lvbigp LnN0YXJ0c3dpdGgoJzE5QScpCg==